Re: Review Request 47161: Fixed replica log restore tests.

> On Maj 11, 2016, 12:21 rano, Alexander Rukletsov wrote: > > src/tests/log_tests.cpp, lines 450-452 > > > > > > How about this comment for clarity? > > ``` > > // By design only a single process can access

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132572 --- Fix it, then Ship it! I'll touch the comment and the descriptio

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132546 --- Patch looks great! Reviews applied: [47161] Passed command: expo

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos and Kapil Arya. Bu

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132491 --- Fix it, then Ship it! Ship It! src/tests/log_tests.cpp (line

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/ --- (Updated May 10, 2016, 5:37 p.m.) Review request for mesos and Kapil Arya. Bu

Re: Review Request 47161: Fixed replica log restore tests.

> On May 10, 2016, 3:13 p.m., Kapil Arya wrote: > > src/tests/log_tests.cpp, lines 444-446 > > > > > > Move this description before the first scope level? > > > > And maybe, add a comment about this test its

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132445 --- Ran make check locally and it succeeded. src/tests/log_tests.cpp

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132447 --- Ship it! - Neil Conway On May 10, 2016, 9:02 a.m., Tomasz Jan

Re: Review Request 47161: Fixed replica log restore tests.

> On May 10, 2016, 8:02 a.m., Alexander Rukletsov wrote: > > Hey Tomasz, thanks a lot for the patch! Could you please leave a comment in > > test description explaining the necessity for scopes, similar to what you > > write in the description? This will help people understand reasons for > >

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/ --- (Updated May 10, 2016, 9:02 a.m.) Review request for mesos and Kapil Arya. Bu

Re: Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132388 --- Hey Tomasz, thanks a lot for the patch! Could you please leave a c

Review Request 47161: Fixed replica log restore tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-2201 https://issues.ap