Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On Cze 27, 2016, 11:35 po poĊ‚udniu, Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 8 > > > > > > why the change in capitalization of "frameworks"? it is consistent with > > how we capitalized "A

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139697 --- Patch looks great! Reviews applied: [48910] Passed command: expo

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139696 --- Ship it! src/webui/master/static/frameworks.html (line 8)

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- (Updated June 27, 2016, 7:19 p.m.) Review request for mesos, Benjamin Mahler, D

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Vinod Kone
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> On June 27, 2016, 3:49 a.m., Vinod Kone wrote: > > src/webui/master/static/frameworks.html, line 29 > > > > > > should be filtered by `disconnected` boolean. > > > > a framework in master has two tags assoc

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139516 --- Fix it, then Ship it! src/webui/master/static/frameworks.html

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139460 --- Patch looks great! Reviews applied: [48910] Passed command: expo

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-25 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- (Updated June 25, 2016, 3:48 p.m.) Review request for mesos, Benjamin Mahler, D