Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 20, 2016, 4:55 p.m., Jie Yu wrote: > > Can you follow up with some tests on this? Should be similar to > > SlaveRecoveryTest. For example: > > 1) start a slave with cgroups/cpu > > 2) launch a task > > 3) stop the slave and start a new one with cgroups/cpu,cgroups/mem > > 4) make sure

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149676 --- Can you follow up with some tests on this? Should be similar to S

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149669 --- Patch looks great! Reviews applied: [51631] Passed command: expo

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 1:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149647 --- Bad review! Reviews applied: [51631, 51791, 51790, 51789, 51788,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 6:20 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 6:18 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review149609 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 20, 2016, 4:13 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148692 --- Bad review! Reviews applied: [51631, 51791, 51790, 51789, 51788,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 13, 2016, 8:23 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 12, 2016, 3:09 a.m., Qian Zhang wrote: > > I think this patch is mainly for handling the case that agent is restarted > > with more cgroups subsystems enabled, but what if the agent is restarted > > with less cgroups subsystems enabled? In this case, it seems we may miss to > > dest

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148462 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 7:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > prob

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > pro

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 12, 2016, 3:09 a.m., Qian Zhang wrote: > > I think this patch is mainly for handling the case that agent is restarted > > with more cgroups subsystems enabled, but what if the agent is restarted > > with less cgroups subsystems enabled? In this case, it seems we may miss to > > dest

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 12, 2016, 4:57 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > >

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148449 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148440 --- I think this patch is mainly for handling the case that agent is r

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 7:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > > t

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 12, 2016, 2:49 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 5:37 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 7, 2016, 6:08 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 353-358 > > > > > > After moved these code, I think we may not need this method > > `CgroupsIso

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 290-291 > > > > > > I do not think we need this comment because I think if recover fails, > >

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 4:04 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 2:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:22 p.m., Qian Zhang wrote: > > Can you please add a test for this? `MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PERF_RollForward` have covered this. - haosdent --- This is an automatically generated e-mail.

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 6, 2016, 11:38 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 408-411 > > > > > > Why moving these code here? Can you please let me know what is the > > pro

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- (Updated Sept. 11, 2016, 10:31 a.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147977 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147943 --- Can you please add a test for this? - Qian Zhang On Sept. 6, 20

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147806 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147769 --- Patch looks great! Reviews applied: [51031, 51185, 49852, 49853,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review147766 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line

Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/ --- Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. Bugs: MESOS-606