Re: Review Request 51864: Added logs for container state transitions.

2016-09-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 16, 2016, 10:19 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51864: Added logs for container state transitions.

2016-09-16 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 16, 2016, 10:19 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51864: Added logs for container state transitions.

2016-09-16 Thread Alexander Rukletsov
> On Sept. 16, 2016, 8:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > > > > > This is not correct. We dont always provision image for a container. > > > >

Re: Review Request 51864: Added logs for container state transitions.

2016-09-16 Thread Gilbert Song
> On Sept. 16, 2016, 1:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > > > > > This is not correct. We dont always provision image for a container. > > > >

Re: Review Request 51864: Added logs for container state transitions.

2016-09-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review149178 --- src/slave/containerizer/docker.cpp (lines 566 - 567)

Re: Review Request 51864: Added logs for container state transitions.

2016-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review149067 --- Patch looks great! Reviews applied: [51865, 51864] Passed

Re: Review Request 51864: Added logs for container state transitions.

2016-09-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 15, 2016, 1:35 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51864: Added logs for container state transitions.

2016-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review148953 --- Patch looks great! Reviews applied: [51865, 51864] Passed

Re: Review Request 51864: Added logs for container state transitions.

2016-09-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- (Updated Sept. 14, 2016, 11:53 a.m.) Review request for mesos, Gilbert Song

Re: Review Request 51864: Added logs for container state transitions.

2016-09-14 Thread Alexander Rukletsov
> On Sept. 13, 2016, 10:54 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > > > > > We already have such `LOG(INFO)` in provisioner::_provisioner(). > > > >

Re: Review Request 51864: Added logs for container state transitions.

2016-09-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review148797 --- src/slave/containerizer/mesos/containerizer.cpp (lines 903 -

Review Request 51864: Added logs for container state transitions.

2016-09-13 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos