Re: Review Request 51885: Added a basic default executor implementation.

2016-09-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/ --- (Updated Sept. 15, 2016, 6:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-15 Thread Guangya Liu
> On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group > > Vinod Kone wrote: > what anand reads correct

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-15 Thread Anand Mazumdar
> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group > > Vinod Kone wrote: > what anand reads

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Guangya Liu
> On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > How about rename this file as `default_pod_executor.cpp`? > > Vinod Kone wrote: > we are calling it "pod executor" because this executor will be able to > launch pod and non-pods in the future. command executor will be deprecated in >

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Anand Mazumdar
> On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 212 > > > > > > why capture the task group as a member variable when you already have > > `tasks`? > > Anand Mazumdar

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Anand Mazumdar
> On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 212 > > > > > > why capture the task group as a member variable when you already have > > `tasks`? `tasks` are a list

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Vinod Kone
> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > > > > > s/multiple task groups /multiple tasks in task group what anand reads correct to me. - Vinod

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148944 --- Fix it, then Ship it! src/launcher/default_executor.cpp

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Vinod Kone
> On Sept. 14, 2016, 1:08 p.m., Guangya Liu wrote: > > How about rename this file as `default_pod_executor.cpp`? we are calling it "pod executor" because this executor will be able to launch pod and non-pods in the future. command executor will be deprecated in favor of this. - Vinod

Re: Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148886 --- How about rename this file as `default_pod_executor.cpp`?

Review Request 51885: Added a basic default executor implementation.

2016-09-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6077