Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated May 11, 2017, 5:55 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review174593 --- Fix it, then Ship it!

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On May 1, 2017, 5:38 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 327 (original), 344 (patched) > > > > > > What happens if we were in accounting mode but now in

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated May 2, 2017, 5:23 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review173432 --- LGTM! I also verified that setting limits to zero doesn't lead

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On April 24, 2017, 5:48 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 196 (patched) > > > > > > From reading the references it seems that the soft limits and > >

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated April 25, 2017, 10:37 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated April 24, 2017, 6:53 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated April 24, 2017, 6:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On April 23, 2017, 10:48 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > > Lines 65 (patched) > > > > > > We started to move toward `enum class` now. > > James Peach wrote: >

Re: Review Request 55897: Add support for not enforcing XFS quotas.

> On April 24, 2017, 5:48 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > > Lines 65 (patched) > > > > > > We started to move toward `enum class` now. Really? There are only 14

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review172731 --- Partial review for discussion.

Re: Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- (Updated March 17, 2017, 9:57 p.m.) Review request for mesos, Gilbert Song,

Review Request 55897: Add support for not enforcing XFS quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-5116