Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-18 Thread Jan Schlicht
> On April 18, 2017, 1:56 p.m., Jan Schlicht wrote: > > Because I need to implement similar filters for tests in `libprocess`, > > wouldn't it have been better to create a `Filter` abstraction in stout and > > using that here as well as in Mesos instead of copy-pasting the > > implementation o

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review172188 --- Because I need to implement similar filters for tests in `libproce

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review171512 --- Fix it, then Ship it! I can fix the below issues for you, befor

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-10 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- (Updated April 10, 2017, 9:41 p.m.) Review request for mesos, Andrew Schwartzme

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review171378 --- 3rdparty/stout/include/stout/tests/environment.hpp Lines 205-210

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-04-05 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- (Updated April 5, 2017, 7:08 p.m.) Review request for mesos, Andrew Schwartzmey

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review170353 --- 3rdparty/stout/include/stout/tests/environment.hpp Lines 17-18 (p

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- (Updated March 27, 2017, 10:13 p.m.) Review request for mesos, Andrew Schwartzm

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review169918 --- In terms of review formatting, it look good. You can make the revi

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review169664 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-21 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/#review169648 --- I'm still learning how review board works, so please let me know i

Review Request 57824: Filtered stout tests with symlinks when unable to create symlinks.

2017-03-21 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57824/ --- Review request for mesos. Bugs: MESOS-6731 https://issues.apache.org/jira/b