Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review195079 --- Ship it! This patch still looks good to me =). - Gaston

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 9, 2018, 7:02 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review195027 --- PASS: Mesos patch 64932 was successfully built and tested.

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 8, 2018, 10:36 p.m., Gaston Kleiman wrote: > > @gaston: Could you please re-review? I noticed there is a similar cleanup of the example frameworks on its way, https://reviews.apache.org/r/64849/. I simplified this patch for easier backporting to `1.5.x`, but added a cleanup of this

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 9, 2018, 12:09 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 444-447 (patched) > > > > > > Shouldn't this be a flag like in `no_executor_framework.cpp` and in > >

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194983 --- Ship it! - Gaston Kleiman On Jan. 8, 2018, 2:06 a.m.,

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194968 --- PASS: Mesos patch 64932 was successfully built and tested.

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 8, 2018, 11:06 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 399 (patched) > > > > > > Why don't we make this a `string` instead of an `Option`? > > > > That

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 399 (patched) > > > > > > Why don't we make this a `string` instead of an `Option`? > > > > That

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > Should we add this new framework to `src/tests/examples_tests.cpp`? I am not sure the framework would be useful in its current form for such a test; it e.g., has no clear termination criterion. - Benjamin

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 9:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 278 (patched) > > > > > > I'd rephrase this: > > > > ``` > > Check whether the given resources

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 5, 2018, 6:01 a.m., Greg Mann wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 282 (patched) > > > > > > Is it not possible that a single resource provider can offer both > > reserved and

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- (Updated Jan. 5, 2018, 1:37 p.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 12:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 165-184 (patched) > > > > > > This framework will never launch a task, so this is probably not needed. > >

Re: Review Request 64932: Added example framework converting disk resources.

> On Jan. 4, 2018, 8:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 149 (patched) > > > > > > This framework never starts tasks, so should we crash or log something > > saying

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194830 --- Fix it, then Ship it!

Re: Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/#review194780 --- Should we add this new framework to

Review Request 64932: Added example framework converting disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64932/ --- Review request for mesos, Greg Mann and Jie Yu. Repository: mesos