Re: Review Request 65615: Added docker constants and common functions file.

2018-02-22 Thread Andrew Schwartzmeyer
> On Feb. 22, 2018, 3:25 a.m., Alexander Rukletsov wrote: > > src/Makefile.am > > Lines 1276 (patched) > > > > > > What about CMake? Headers are free in CMake. - Andrew -

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review198108 --- To simplify reviewing, in the future please separate refactoring a

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-21 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- (Updated Feb. 22, 2018, 1:47 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-16 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197703 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 16, 2018, 3

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-16 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- (Updated Feb. 16, 2018, 11:30 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-12 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197344 --- src/tests/containerizer/docker_common.hpp Lines 126 (patched)

Re: Review Request 65615: Added docker constants and common functions file.

2018-02-12 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197343 --- src/tests/containerizer/docker_common.hpp Lines 1-18 (patched)

Review Request 65615: Added docker constants and common functions file.

2018-02-12 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/ --- Review request for mesos. Bugs: MESOS-8498 https://issues.apache.org/jira/b