Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-21 Thread Chun-Hung Hsiao
> On Sept. 21, 2018, 9:41 a.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 240 (patched) > > > > > > Ups, that turned out to be a lot. Thanks for doing this. The

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-21 Thread Chun-Hung Hsiao
> On Sept. 21, 2018, 9:41 a.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 244-245 (patched) > > > > > > An alternative to the closure we sometimes use in tests is

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208843 --- Ship it!

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 3:45 a.m.) Review request for mesos, Benjamin

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 3:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- (Updated Sept. 20, 2018, 2:53 a.m.) Review request for mesos, Benjamin

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Chun-Hung Hsiao
> On Sept. 19, 2018, 1:12 p.m., Benjamin Bannier wrote: > > src/tests/agent_resource_provider_config_api_tests.cpp > > Lines 508-511 (patched) > > > > > > We don't seem to explicitly need this here. Is this

***UNCHECKED*** Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208762 --- src/tests/agent_resource_provider_config_api_tests.cpp Lines

Re: Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/#review208749 --- PASS: Mesos patch 68758 was successfully built and tested.

Review Request 68758: Added unit tests for adding/updating invalid resource provider configs.

2018-09-18 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68758/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: