Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215180 --- Bad review! Reviews applied: [70570] Error: 2019-05-10 09:12:39

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-09 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215168 --- Fix it, then Ship it!

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-08 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215154 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-08 Thread Meng Zhu
> On May 6, 2019, 1:50 p.m., Benjamin Mahler wrote: > > Hm.. don't we need to track the amount held back during the quota > > allocation? What are your thoughts on that? We hold back something in the quota allocation loop, then in the second stage, we try to allocate everything (including the

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-08 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/ --- (Updated May 8, 2019, 5:22 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215081 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215071 --- Hm.. don't we need to track the amount held back during the quota

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215038 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review214982 --- src/master/allocator/mesos/hierarchical.cpp Lines 1798-1799

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-04-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review214957 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-04-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review214956 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-04-29 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/ --- (Updated April 29, 2019, 6 p.m.) Review request for mesos and Benjamin Mahler.

Review Request 70570: Logged headroom related info in the allocator.

2019-04-29 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description