---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/
---
(Updated May 28, 2015, 4:13 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33825/#review85616
---
Is anything happening on this one?
it's now been more than three
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85606
---
Ship it!
Ship It!
- Niklas Nielsen
On May 27, 2015, 6:20 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34782/
---
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34782/#review85625
---
Patch looks great!
Reviews applied: [34782]
All tests passed.
-
On May 28, 2015, 12:02 a.m., Niklas Nielsen wrote:
src/master/master.cpp, lines 3469-3470
https://reviews.apache.org/r/34730/diff/1/?file=973034#file973034line3469
Was there some additional math, only to rescind if the estimate is
lower? If not now, should we add a todo?
Now
On May 28, 2015, 11:45 a.m., Benjamin Hindman wrote:
3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 517
https://reviews.apache.org/r/34193/diff/5/?file=972154#file972154line517
This looks like a duplicated test with the 'Usage' test above?
great catch!
modified to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85613
---
src/examples/test_resource_estimator_module.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
---
(Updated May 28, 2015, 9:23 p.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review85627
---
Ship it!
Hey @vinod - I think Alex made all the suggested fixes:
On May 14, 2015, 6:07 a.m., Alexander Rukletsov wrote:
src/master/master.cpp, line 1315
https://reviews.apache.org/r/29507/diff/6/?file=959052#file959052line1315
This looks like a drive-by bug fix, should it be included in this diff?
At least, let's mention it in the description.
On May 27, 2015, 5:24 p.m., Vinod Kone wrote:
src/examples/test_resource_estimator_module.cpp, lines 40-44
https://reviews.apache.org/r/34662/diff/6/?file=973211#file973211line40
I'm confused. 'parameters' are unused and the passed 'flags' are empty?
Niklas Nielsen wrote:
On May 28, 2015, 5:40 p.m., Adam B wrote:
Do you clearly understand why this change is needed? I didn't understand
after just reading the JIRA, and had to ask the reporter(s). Mesosphere is
hosting the Mesos UI(s) underneath the DCOS UI behind a reverse proxy, so
that
On May 26, 2015, 8:57 p.m., Vinod Kone wrote:
src/common/resources.cpp, line 1160
https://reviews.apache.org/r/34676/diff/1/?file=972037#file972037line1160
Lets use something other than *, since we already abuse it to
represent the default role and unreserved resources.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
---
(Updated May 28, 2015, 6:41 p.m.)
Review request for mesos, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34655/#review85571
---
Do you clearly understand why this change is needed? I didn't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34737/#review85586
---
Ship it!
Looks good. Main issue is that this can and should be a
On May 28, 2015, 6:12 p.m., Niklas Nielsen wrote:
This will change the resource estimator patch set too - do you want to make
them dependent on this one?
This patch depents on Resource Estimator modularization. (:
- Bartek
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85585
---
This will change the resource estimator patch set too - do you want
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85601
---
Patch looks great!
Reviews applied: [34662, 34748]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34737/
---
(Updated May 28, 2015, 12:48 p.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34655/#review85592
---
Ship it!
Ship It!
- Marco Massenzio
On May 28, 2015, 7:54 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34736/#review85658
---
Ship it!
Ship It!
- Niklas Nielsen
On May 28, 2015, 5:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34729/#review85659
---
Ship it!
Ship It!
- Niklas Nielsen
On May 28, 2015, 5:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/
---
(Updated May 29, 2015, 1:03 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/
---
(Updated May 29, 2015, 1:10 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34736/#review85661
---
Patch looks great!
Reviews applied: [34729, 34730, 34736]
All
On May 28, 2015, 11:45 a.m., Benjamin Hindman wrote:
src/cli/execute.cpp, line 321
https://reviews.apache.org/r/34195/diff/3/?file=972213#file972213line321
I'm not convinced the 'errorMessage' is more help here. You're
basically saving doing a 'return EXIT_FAILURE;' in each of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34736/
---
(Updated May 29, 2015, 12:31 a.m.)
Review request for mesos, Jie Yu, Joris Van
On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote:
src/common/protobuf_utils.hpp, line 83
https://reviews.apache.org/r/34687/diff/1/?file=972329#file972329line83
Shouldn't parse() go in
https://github.com/apache/mesos/blob/master/src/common/parse.hpp?
Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34729/
---
(Updated May 29, 2015, 12:30 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34193/
---
(Updated May 29, 2015, 12:51 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/#review85671
---
Patch looks great!
Reviews applied: [34193, 34195]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29507/#review85652
---
Patch looks great!
Reviews applied: [29507]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34737/#review85519
---
Patch looks great!
Reviews applied: [34737]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review85528
---
The current code already returns an empty task list, with response
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34724/#review85529
---
Patch looks great!
Reviews applied: [34724]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85533
---
Patch looks great!
Reviews applied: [34662]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/#review85536
---
src/cli/execute.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34655/#review85544
---
Patch looks great!
Reviews applied: [34655]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review85541
---
Patch looks great!
Reviews applied: [34748]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33781/#review85558
---
Ship it!
Ship It!
- Benjamin Hindman
On May 2, 2015, 2:35 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34134/#review85564
---
Ship it!
Ship It!
- Timothy Chen
On May 13, 2015, 12:44 a.m.,
43 matches
Mail list logo
