---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review94036
---
Ship it!
Ship It!
- Alexander Rojas
On Aug. 3, 2015, 4:58 p.m.,
On Aug. 4, 2015, 3:08 a.m., Alexander Rukletsov wrote:
src/master/master.hpp, line 766
https://reviews.apache.org/r/36913/diff/7/?file=1028501#file1028501line766
s/and /
See my previous review. This is correct syntax IMHO.
- Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2880
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review94040
---
3rdparty/libprocess/include/process/http.hpp (line 747)
On Aug. 4, 2015, 10:08 a.m., Alexander Rukletsov wrote:
src/master/master.hpp, line 766
https://reviews.apache.org/r/36913/diff/7/?file=1028501#file1028501line766
s/and /
Bernd Mathiske wrote:
See my previous review. This is correct syntax IMHO.
See Bernds comment below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated Aug. 4, 2015, 10:40 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94041
---
Ship it!
Pending consistency with subsequent RRs in this chain,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94050
---
Patch looks great!
Reviews applied: [37072]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94019
---
Patch looks great!
Reviews applied: [36402]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review94027
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 3, 2015, 11:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37046/#review94028
---
Patch looks great!
Reviews applied: [37046]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94030
---
src/master/master.hpp (line 766)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 4, 2015, 4:13 p.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94058
---
Patch looks great!
Reviews applied: [36913]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/#review94059
---
include/mesos/authorizer/authorizer.hpp (line 83)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review94014
---
Patch looks great!
Reviews applied: [36908]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/#review94001
---
Thanks for this Artem! I applied the patch and it works. Just a
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote:
I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be
placed inside `include/mesos/master/` instead since the authorizer is only
for the master. Does it make sense to do that? If it does, then should we
also move
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote:
I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be
placed inside `include/mesos/master/` instead since the authorizer is only
for the master. Does it make sense to do that? If it does, then should we
also move
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94018
---
Patch looks great!
Reviews applied: [37045]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review93562
---
src/health-check/main.cpp (line 242)
On Aug. 3, 2015, 2:21 p.m., Alexander Rukletsov wrote:
src/master/quota_handler.hpp, lines 26-27
https://reviews.apache.org/r/36913/diff/5/?file=1027610#file1027610line26
I think we should wrap it into `master` namespace as well.
`quota_handler.cpp` still lacks the `master`
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated Aug. 4, 2015, 9:52 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94024
---
src/master/master.hpp (line 916)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review94023
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 3, 2015, 11:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37075/
---
Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/
---
(Updated Aug. 4, 2015, 1:49 p.m.)
Review request for mesos and Till Toenshoff.
On Aug. 3, 2015, 11:36 p.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, line 81
https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81
What's the significance in the order in which these are called? I
would've expected something like:
On Aug. 4, 2015, 2:39 a.m., Alexander Rukletsov wrote:
src/master/master.hpp, line 916
https://reviews.apache.org/r/36913/diff/6/?file=1027735#file1027735line916
I think we don't need this instance any more.
I think so, too.
- Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94033
---
src/master/master.hpp (line 764)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94037
---
src/master/master.hpp (line 766)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/#review94054
---
Re-based the PR
- Chris Heller
On July 29, 2015, 1:41 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review94067
---
Patch looks great!
Reviews applied: [36847]
All tests passed.
-
Hi folks,
Thanks for the great feedback! I addressed almost all of these issues, but
had a few things left to wrap up before uploading a new patch -- I'm
traveling at the moment, but I should have a new patch by tomorrow.
Neil
On Mon, Aug 3, 2015 at 8:45 PM Adam B a...@mesosphere.io wrote:
This
On Aug. 4, 2015, 6:36 a.m., Michael Park wrote:
src/tests/containerizer/memory_test_helper.cpp, line 81
https://reviews.apache.org/r/37065/diff/1/?file=1028301#file1028301line81
What's the significance in the order in which these are called? I
would've expected something like:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94177
---
src/slave/containerizer/isolators/network/port_mapping.cpp (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 4:19 a.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 4:21 a.m.)
Review request for mesos, Kapil Arya and
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94185
---
Patch looks great!
Reviews applied: [36929, 36930, 36954, 36956,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/
---
(Updated Aug. 5, 2015, 5:25 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review94154
---
Ship it!
LGTM overall. Please address the remaining issues and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94191
---
did you forget to rebase?
- Marco Massenzio
On Aug. 5, 2015,
On Aug. 5, 2015, 5:47 a.m., Marco Massenzio wrote:
did you forget to rebase?
Never mind - I was just looking at diff 4 -- 5.
All good.
- Marco
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36783/#review94159
---
3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94165
---
Patch looks great!
Reviews applied: [37081]
All tests passed.
-
On Aug. 4, 2015, 11:03 p.m., Niklas Nielsen wrote:
src/slave/slave.cpp, lines 2720-2721
https://reviews.apache.org/r/37053/diff/2/?file=1028868#file1028868line2720
What do you think about emitting a warning if the executor id is
already set? It could be, that users have been
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review94176
---
configure.ac (line 544)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94156
---
Ship it!
src/linux/perf.cpp (lines 292 - 294)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review94174
---
Patch looks great!
Reviews applied: [36410, 36411, 36412, 36413,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/#review94161
---
3rdparty/libprocess/src/http.cpp
On Aug. 5, 2015, 12:38 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/os.hpp, lines 22-50
https://reviews.apache.org/r/36783/diff/4/?file=1024905#file1024905line22
Why do we have both os.hpp and os/os.hpp? Seems strange to put only the
structs here,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 4, 2015, 10:02 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/
---
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 5, 2015, midnight)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
---
(Updated Aug. 4, 2015, 10 p.m.)
Review request for mesos, Ben Mahler and Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 11:05 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 11:05 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 5, 2015, 12:24 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/
---
(Updated Aug. 4, 2015, 10:43 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37053/#review94143
---
Ship it!
src/slave/slave.cpp (lines 2720 - 2721)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
---
(Updated Aug. 4, 2015, 11:57 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 5, 2015, 12:32 a.m.)
Review request for mesos, Anand Mazumdar,
On Aug. 4, 2015, 9:07 p.m., Ben Mahler wrote:
I'll get the /call validation committed.
Let's follow up to get tests added for each of the error cases in /call.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review94130
---
I'll get the exited changes committed.
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review94133
---
Patch looks great!
Reviews applied: [36913]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/
---
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37091/#review94145
---
Ship it!
Ship It!
- Timothy Chen
On Aug. 4, 2015, 7:01 p.m.,
On Aug. 4, 2015, 11:45 p.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 314-316
https://reviews.apache.org/r/37045/diff/2/?file=1028754#file1028754line314
Any reason you're changing the style of the failure messages? Let's
leave them untouched in this patch, since they look goot
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94148
---
Looks great paul! Just some minor things around style before we can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94152
---
Patch looks great!
Reviews applied: [37045]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/
---
(Updated Aug. 4, 2015, 11:59 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 5:12 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/
---
(Updated Aug. 4, 2015, 5:43 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/
---
(Updated Aug. 4, 2015, 5:42 p.m.)
Review request for mesos, Anand Mazumdar,
On Aug. 3, 2015, 9:38 p.m., Ben Mahler wrote:
Is this ready to review? Mind updating the 'issues' accordingly?
Just did, thanks for comments :)
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/
---
(Updated Aug. 4, 2015, 4:57 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
(Updated Aug. 4, 2015, 5:15 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37053/
---
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-3196
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36956/#review93921
---
Ship it!
src/tests/containerizer/rootfs.hpp (line 66)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/
---
(Updated Aug. 4, 2015, 5:43 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/
---
(Updated Aug. 4, 2015, 6:26 p.m.)
Review request for mesos, Adam B, Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/
---
(Updated Aug. 4, 2015, 6:27 p.m.)
Review request for mesos, Adam B, Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/
---
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 5:33 p.m.)
Review request for mesos, Kapil Arya and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37010/
---
(Updated Aug. 4, 2015, 5:42 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 4, 2015, 4:33 p.m.)
Review request for mesos, Kapil Arya and
On July 29, 2015, 7:12 p.m., Ben Mahler wrote:
src/master/master.cpp, lines 2128-2159
https://reviews.apache.org/r/36720/diff/3/?file=1021871#file1021871line2128
Any reason you're skipping validation (authorization) of the framework?
Looks like we should pull out the pid specific
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/
---
(Updated Aug. 4, 2015, 4:33 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94084
---
Can you please define how did you test that this works in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37091/
---
Review request for mesos, Ben Mahler, Ian Downes, Timothy Chen, and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37075/#review94103
---
Patch looks great!
Reviews applied: [37075]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94112
---
3rdparty/libprocess/src/http.cpp (line 155)
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
Isabel Jimenez wrote:
This will not crash, tokenize will always
On Aug. 4, 2015, 5:17 p.m., Marco Massenzio wrote:
Can you please define how did you test that this works in the 'tests'
section?
I can try this out on Ubuntu 14.04 (and OSX) given the steps to reproduce
the issue, and then applying the patch.
Once we verify that it works on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review94111
---
I'll get the /call validation committed.
src/master/http.cpp
On Aug. 4, 2015, 7:25 p.m., Ben Mahler wrote:
3rdparty/libprocess/src/http.cpp, line 219
https://reviews.apache.org/r/36402/diff/6/?file=1028798#file1028798line219
This will crash the program if tokens is empty!
This will not crash, tokenize will always return a vector of at least
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94104
---
Nice test!
src/tests/oversubscription_tests.cpp (line 864)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/#review94121
---
Patch looks great!
Reviews applied: [36910]
All tests passed.
-
1 - 100 of 114 matches
Mail list logo
