On Aug. 17, 2015, 9:59 p.m., Timothy Chen wrote:
Hi haosdent, thanks for working on this but I think running the healthcheck
outside of the container doesn't make much sense to me.
I think we should try to run it inside of the container (docker exec), but
since docker exec is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37512/#review95712
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 3:08 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37423/
---
(Updated Aug. 18, 2015, 6:10 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/#review95757
---
3rdparty/libprocess/include/process/http.hpp (lines 590 - 601)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37584/#review95754
---
src/launcher/fetcher.cpp (lines 100 - 106)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/
---
(Updated Aug. 18, 2015, 6:36 p.m.)
Review request for mesos, Michael Park and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
---
Review request for mesos.
Bugs: MESOS-3239
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/
---
(Updated Aug. 18, 2015, 6:42 p.m.)
Review request for mesos and Ben Mahler.
On Aug. 18, 2015, 6:34 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, lines 100-106
https://reviews.apache.org/r/37584/diff/1/?file=1043203#file1043203line100
just do
return Error(Skipping fetch with Hadoop client: +
(available.isError() ?
On Aug. 18, 2015, 6:34 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, lines 100-106
https://reviews.apache.org/r/37584/diff/1/?file=1043203#file1043203line100
just do
return Error(Skipping fetch with Hadoop client: +
(available.isError() ?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/
---
Review request for mesos, Michael Park and Vinod Kone.
Bugs: MESOS-3239
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/#review95755
---
Ship it!
Ship It!
- Ben Mahler
On Aug. 18, 2015, 6:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37587/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3290
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
---
(Updated Aug. 18, 2015, 6:32 p.m.)
Review request for mesos, Michael Park and
On Aug. 17, 2015, 6:22 p.m., Ben Mahler wrote:
src/linux/perf.cpp, line 199
https://reviews.apache.org/r/37424/diff/1/?file=1038974#file1038974line199
We may want to update this to become killtree in a separate patch? Or
are we guaranteed that perf will clean up child processes?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37424/
---
(Updated Aug. 18, 2015, 6:40 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/
---
(Updated Aug. 18, 2015, 6:12 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37588/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3290
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/
---
(Updated Aug. 18, 2015, 6:43 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37584/
---
Review request for mesos and Adam B.
Bugs: MESOS-3287
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37424/
---
(Updated Aug. 18, 2015, 6:43 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37588/#review95758
---
Ship it!
It seems like Forbidden should be used for authorization
On Aug. 18, 2015, 6:49 p.m., Ben Mahler wrote:
It seems like Forbidden should be used for authorization issues, can we
just have the non-leaders say they are not available? It seems to make
sense, since they are not elected, they are not available.
changed master to send 503 when it's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37588/
---
(Updated Aug. 18, 2015, 7:10 p.m.)
Review request for mesos, Anand Mazumdar
On Aug. 18, 2015, 6:34 p.m., Vinod Kone wrote:
src/launcher/fetcher.cpp, lines 100-106
https://reviews.apache.org/r/37584/diff/1/?file=1043203#file1043203line100
just do
return Error(Skipping fetch with Hadoop client: +
(available.isError() ?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/
---
(Updated Aug. 18, 2015, 6:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/
---
(Updated Aug. 18, 2015, 6:57 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/
---
(Updated Aug. 18, 2015, 6:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234/
---
(Updated Aug. 18, 2015, 6:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
---
(Updated Aug. 18, 2015, 7:02 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37423/#review95771
---
Ship it!
Will get this committed now, thanks Paul!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/#review95777
---
Paul can you split this change? I personally don't have context on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review95783
---
Ship it!
LGTM except for one little thing:
src/master/master.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/#review95786
---
Ship it!
LGTM.
src/master/master.cpp (line 5745)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37592/
---
Review request for mesos.
Bugs: MESOS-1283
On Aug. 19, 2015, 1:24 a.m., Guangya Liu wrote:
Just curious: If change the 3rd party code directly in mesos source code,
then how to handle the case when mesos want to upgrade the 3rd party
libraries?
because libprocess is maintained in mesos, so we could do it like this here.
For
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37284/#review95815
---
Bad patch!
Reviews applied: [36321, 36571, 37314, 37325, 37358,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95779
---
Just some notes before you rebase.
src/linux/perf.cpp (lines 411
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37170/#review95780
---
Ship it!
LGTM.
src/master/master.cpp (lines 1364 - 1365)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review95782
---
Ship it!
LGTM
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/
---
(Updated Aug. 18, 2015, 11:48 p.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review95810
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:57 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/#review95803
---
src/master/master.cpp (line 4145)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/#review95806
---
Did you still want to use 'Perf' here? If not, I can't tell what
On Aug. 18, 2015, 8:38 p.m., Ben Mahler wrote:
Paul can you split this change? I personally don't have context on why we
would want to change from sampling 'true' to running against the init
process so I'd like Jie or Ian to review that change, but I can help you
make the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review95807
---
Just curious: If change the 3rd party code directly in mesos source
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 18, 2015, 11:24 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37493/
---
(Updated Aug. 19, 2015, 12:33 a.m.)
Review request for mesos, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 19, 2015, 12:57 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95802
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37589/#review95808
---
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:36 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/#review95809
---
src/linux/perf.cpp (lines 384 - 385)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37417/
---
(Updated Aug. 18, 2015, 11:01 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review95805
---
include/mesos/maintenance/maintenance.hpp (line 38)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37424/#review95773
---
Ship it!
Thanks, the summary here is now stale, but I'll update it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review95785
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95788
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:58 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37562/#review95728
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 18, 2015, 5:11 a.m.,
64 matches
Mail list logo
