----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review95783 -----------------------------------------------------------
Ship it! LGTM except for one little thing: src/master/master.hpp (line 478) <https://reviews.apache.org/r/37175/#comment150913> Why is this return type `Nothing`, instead of `void`? - Joseph Wu On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37175/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 11:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > e278139f856888d6c6f538f7c0f664087e97f629 > src/master/http.cpp a73ee17bcef72791b06240a4673f466de582c41b > src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/master_maintenance_tests.cpp PRE-CREATION > src/tests/mesos.hpp 64987f0cc1632eb8b0c2cccd8446a5324127910c > > Diff: https://reviews.apache.org/r/37175/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
