Review Request 37955: Remove hashmap::existsValue since it is never called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37955/ --- Review request for mesos. Bugs: MESOS-3329

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

> On Aug. 27, 2015, 2:22 a.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h, line 38 > > > > > > Need adjust order here? > > Alexander Rukletsov wrote: > Not sure I

Re: Review Request 37955: Remove hashmap::existsValue since it is never called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37955/#review97086 --- Patch looks great! Reviews applied: [37955] All tests passed. -

Re: Review Request 37958: Add an option to only perform batch allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/ --- (Updated Aug. 31, 2015, 4:49 p.m.) Review request for mesos and Ben Mahler.

Review Request 37958: Add an option to only perform batch allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/ --- Review request for mesos. Repository: mesos Description --- Normally,

Re: Review Request 37945: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97088 --- 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp (line

Re: Review Request 37958: Add an option to only perform batch allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97090 --- Patch looks great! Reviews applied: [37958] All tests passed. -

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering

Re: Review Request 37722: Added definitions of container rootfs directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review97094 --- Ship it! Ship It! - Timothy Chen On Aug. 25, 2015, 6:41 p.m.,

Re: Review Request 37873: Add quiesce logic in allocator

> On Aug. 30, 2015, 5:10 p.m., Robert Lacroix wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 909 > > > > > > We need to store the information that a framework is quiescing offers > > in a more memory

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/ --- (Updated Aug. 31, 2015, 6:03 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/ --- (Updated Aug. 31, 2015, 11:11 a.m.) Review request for mesos, Benjamin

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Aug. 31, 2015, 6:20 p.m., Michael Park wrote: > > What do you think of the following API? > > > > ``` > > JSON::Value value = ...; > > auto message = protobuf::parse(value); // message has type Try. > > auto repeated = > > protobuf::parse(value); //

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/#review97110 --- What do you think of the following API? ``` JSON::Value value =

Re: Review Request 37908: Silence oversubscription logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/ --- (Updated Aug. 31, 2015, 11:28 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/#review97119 --- Patch looks great! Reviews applied: [37699] All tests passed. -

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review97108 --- For any future CMake reviews, could you also add Artem (hartem) and

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/#review97113 --- cmake/MesosConfigure.cmake (line 76)

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Aug. 31, 2015, 11:20 a.m., Michael Park wrote: > > What do you think of the following API? > > > > ``` > > JSON::Value value = ...; > > auto message = protobuf::parse(value); // message has type Try. > > auto repeated = > > protobuf::parse(value); //

Re: Review Request 37585: Maintenance primitives: Add a user doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review97128 --- Patch looks great! Reviews applied: [37585] All tests passed. -

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 31, 2015, 7:41 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

> On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: > > Why? Everyone knows kill(2) sends a signal while signal(2) installs a > > signal handler... > > Jie Yu wrote: > IMO, that naming is confusing, and should be 'signal' and 'install'. > > Joerg Schad wrote: > This is actually answering

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review97133 --- include/mesos/mesos.proto (lines 140 - 154)

Re: Review Request 37197: Docker image store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review97095 --- src/slave/containerizer/provisioners/docker/store.cpp (line 131)

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review97135 --- Ship it! Ship It! support/jenkins_build_docker.sh (line 28)

Re: Review Request 37908: Silence oversubscription logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/#review97137 --- Patch looks great! Reviews applied: [37908] All tests passed. -

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Aug. 31, 2015, 6:20 p.m., Michael Park wrote: > > What do you think of the following API? > > > > ``` > > JSON::Value value = ...; > > auto message = protobuf::parse(value); // message has type Try. > > auto repeated = > > protobuf::parse(value); //

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 31, 2015, 1:06 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 140-154 > > > > > > Should this have been: > > > > ``` > > message Interval { > > required TimeInfo start; >

Re: Review Request 36441: Update message when master is sending offer(s)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36441/#review97146 --- This seems too tedious to fix throughout the code base in all of

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/ --- (Updated Aug. 31, 2015, 2:15 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37945: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97149 --- @Guangya: I pointed out the undefined behavior as specified in the

Review Request 37968: Add more comments for why not using const reference for some functions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/ --- Review request for mesos and Michael Park. Bugs: MESOS-3344

Re: Review Request 37945: change const pass-by-value to const reference in stout

> On Aug. 31, 2015, 9:25 p.m., Michael Park wrote: > > @Guangya: I pointed out the undefined behavior as specified in the C++ > > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). > > Also, refer to > > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246)

Re: Review Request 37955: Remove hashmap::existsValue since it is never called

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37955/#review97154 --- Ship it! Ship It! - Guangya Liu On 八月 31, 2015, 3:42 p.m., Jian

Re: Review Request 37945: change const pass-by-value to const reference in stout

> On 八月 31, 2015, 9:25 p.m., Michael Park wrote: > > @Guangya: I pointed out the undefined behavior as specified in the C++ > > Standard in this review: [r25735](https://reviews.apache.org/r/25735/). > > Also, refer to > > [MESOS-3246](https://issues.apache.org/jira/browse/MESOS-3246) which

Re: Review Request 37921: Add Copy backend for provisioners.

> On Aug. 31, 2015, 5:50 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioners/backends/copy.cpp, line 19 > > > > > > Move this below. > > > > ``` > > #include "common/status_utils.hpp" > >

Re: Review Request 37773: Docker: Adding registry client.

> On Aug. 31, 2015, 8:42 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/registry_client.cpp, line 456 > > > > > > is maxSize being used at all? If not we should remove all references of >

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 31, 2015, 10:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 31, 2015, 10:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 31, 2015, 10:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review97170 --- Ship it! Or we can simply make 'prefix' unsigned. - Cong Wang

Re: Review Request 37814: Added documentation for libprocess environment variables

> On Aug. 31, 2015, 9:45 p.m., Michael Park wrote: > > docs/configuration.md, line 1505 > > > > > > Below in the `Some influential environment variables for configure > > script:` section we list environment

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Aug. 31, 2015, 10:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37427: Docker registry: adding TokenManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 31, 2015, 10:39 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37024: Exposes mesos version information in components.

> On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote: > > src/master/http.cpp, lines 526-542 > > > > > > Could you include these fields as well? They capture "version" / > > "build" information. Once you do, perhaps it

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

> On Aug. 31, 2015, 2:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > > > > > Maybe not yet the guarantee on ordering since we don't support > > dependency in

Re: Review Request 37968: Add more comments for why not using const reference for some functions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37968/#review97184 --- Patch looks great! Reviews applied: [37968] All tests passed. -

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

> On Aug. 31, 2015, 10:28 p.m., Cong Wang wrote: > > Or we can simply make 'prefix' unsigned. Thanks for the review! As far as I know, making "prefix" unsigned would not help. The code in question is: "0x << (32 - prefix)". 0x is an unsigned integer literal -- left-shifting a

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

> On Aug. 31, 2015, 10:47 p.m., Vinod Kone wrote: > > Our ASF Docker build that tests unbuntu 14.04 doesn't have this dependency > > explicitly specified! > > https://github.com/apache/mesos/blob/master/support/jenkins_build.sh > > > > Are you sure the CRAM-MD5 module is not automatically

Re: Review Request 37921: Add Copy backend for provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/ --- (Updated Sept. 1, 2015, 12:56 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37921: Add Copy backend for provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/ --- (Updated Sept. 1, 2015, 12:58 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37700/#review97221 --- Patch looks great! Reviews applied: [37700] All tests passed. -

Re: Review Request 37814: Added documentation for libprocess environment variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review97062 --- Ship it! Ship It! - Alexander Rojas On Aug. 29, 2015, 12:25

Review Request 37945: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1805

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review97064 --- src/master/master.cpp (line 4904)

Re: Review Request 37945: change const pass-by-value to const reference in stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37945/#review97071 --- Patch looks great! Reviews applied: [37945] All tests passed. -

Re: Review Request 37958: Add an option to only perform batch allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97227 --- docs/configuration.md (line 288)

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review97073 --- src/master/allocator/mesos/hierarchical.hpp (line 391)

Re: Review Request 37871: SSL tests refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37871/ --- (Updated Aug. 31, 2015, 2:32 p.m.) Review request for mesos, Joris Van