Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101817 --- Ship it! LGTM. Since the 'Summary' and 'Description fields are

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101818 --- Ship it! Ship It! - Jie Yu On Oct. 7, 2015, 9:41 p.m., Neil

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review101811 --- src/tests/script.cpp (line 100)

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

Seems like os::strerror() would be more consistent with our other posix api wrappers. On Wed, Oct 7, 2015 at 9:27 AM, Bernd Mathiske wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39005/ >

Re: Review Request 38910: Added `-v` flag to `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/#review101812 --- Patch looks great! Reviews applied: [38910] All tests passed. -

Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/ --- Review request for mesos, Adam B and Joris Van Remoortere. Bugs: MESOS-3417

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 7, 2015, 9:42 p.m.) Review request for mesos and Joris Van

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101821 --- 3rdparty/libprocess/src/help.cpp (lines 51 - 54)

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101813 --- docs/attributes-resources.md (line 39)

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 2:52 p.m., Adam B wrote: > > LGTM. > > Since the 'Summary' and 'Description fields are used to create the git > > commit message, I'd like to see the 'Description' be more descriptive; or > > just say "See summary", which means "do not include in commit message". > > Neil

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/ --- (Updated Oct. 7, 2015, 9:49 p.m.) Review request for mesos and Joris Van

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 9:52 p.m., Adam B wrote: > > LGTM. > > Since the 'Summary' and 'Description fields are used to create the git > > commit message, I'd like to see the 'Description' be more descriptive; or > > just say "See summary", which means "do not include in commit message". Okay. Just

Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 8, 2015, 1 a.m.) Review request for mesos and Michael Park.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 8, 2015, 2:37 a.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101864 --- 3rdparty/libprocess/src/help.cpp (line 52)

Re: Review Request 39037: Allow description empty in help information.

> On 十月 7, 2015, 10:01 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/help.cpp, lines 60-63 > > > > > > In your last diff you didn't have this change and the one below to > > conditionally add newlines, why did

Re: Review Request 39037: Allow description empty in help information.

- Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review101821 --- On 十月 7, 2015, 3:04 a.m., haosdent huang wrote: > >

Re: Review Request 39060: Create master detector per url & not per framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39060/#review101847 --- Patch looks great! Reviews applied: [39060] All tests passed. -

Review Request 39112: RegistryClient refactor: fixed variable names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39112/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 8, 2015, 2:37 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101849 --- Patch looks great! Reviews applied: [39104] All tests passed. -

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review101850 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 8, 2015, 4:42 a.m.) Review request for mesos, Adam B and Neil

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review101871 --- Ship it! Ship It! - Guangya Liu On 十月 7, 2015, 3:24 p.m., Greg

Review Request 39102: Added documentation for JSON resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote: > > Ship It! LGTM, just might need to get rebase on changes for switch syntax in other patches. - Isabel --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37996/ --- (Updated Oct. 7, 2015, 11:54 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 38910: Added `-v` flag to `docker rm`.

> On 十月 1, 2015, 4:31 a.m., Jojy Varghese wrote: > > src/docker/docker.cpp, line 681 > > > > > > wondering this behavior should be defaulted or not. We might be > > overloading stop with more than what it should be

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/#review101750 --- Patch looks great! Reviews applied: [39019, 39076] All tests

Review Request 39086: Fixed typos in comments and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39086/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 39086: Fixed typos in comments and docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39086/#review101761 --- Bad patch! Reviews applied: [39086] Failed command:

Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/ --- Review request for mesos, Alexander Rojas, Jan Schlicht, and Till Toenshoff.

Re: Review Request 39086: Fixed typos in comments and docs.

> On Oct. 7, 2015, 2:12 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39086] > > > > Failed command: ./support/apply-review.sh -n -r 39086 > > > > Error: > > 2015-10-07 14:12:55 URL:https://reviews.apache.org/r/39086/diff/raw/ > > [5430/5430] -> "39086.patch" [1] > >

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 7, 2015, 3:24 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 7, 2015, 3:44 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 354 > > > > > > What does this mean? In my understanding, the resource falg should > > support both string and json format, why

Re: Review Request 38910: Added `-v` flag to `docker rm`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38910/ --- (Updated Oct. 7, 2015, 5:34 p.m.) Review request for mesos, Gilbert Song, Jojy

Review Request 39091: CMake:[1/3] Prepared stout tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39091/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39092: CMake:[2/3] prepared process library tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review101781 --- Ship it! Once it compiles (when the preceding patch is fixed),

Re: Review Request 39087: Added support for non-ascii chars to apply-review.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39087/#review101773 --- Patch looks great! Reviews applied: [39087] All tests passed. -

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review101779 --- 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp (line

Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/ --- (Updated Oct. 7, 2015, 7:15 p.m.) Review request for mesos and Michael Park.

Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

> On Oct. 6, 2015, 9:53 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/http.cpp, line 76 > > > > > > We avoid static non-POD types due to destruction issues. Can you put > > this on the heap? > > > >

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review101787 --- Patch looks great! Reviews applied: [39088] All tests passed. -

Re: Review Request 39091: CMake:[1/3] Prepared stout tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39091/#review101792 --- Ship it! Ship It! - Joseph Wu On Oct. 7, 2015, 9 a.m., Alex

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/#review101790 --- Applied the chain and ran: ``` cmake .. make make check ``` Only

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review101797 --- Ship it! Ship It! - haosdent huang On Oct. 7, 2015, 3:24 p.m.,

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/#review101785 --- Ship it!

Re: Review Request 39092: CMake:[2/3] prepared process library tests to run with `make check`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39092/#review101793 --- Ship it! Ship It! - Joseph Wu On Oct. 7, 2015, 9 a.m., Alex