Re: Review Request 39837: Passing os environment variables when start docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104655 --- Patch looks great! Reviews applied: [39837] All tests passed. -

Review Request 39837: Passing os environment variables when start docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/ --- Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen. Bugs:

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104656 --- src/master/allocator/mesos/hierarchical.cpp (line 1005)

Review Request 39839: RegistryClient refactor: Changed getManifest interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39839/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39837: Passing os environment variables when start docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104660 --- src/slave/containerizer/docker.cpp

Review Request 39832: RegistryClient refactor: fully qualified name for URL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39832/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review104658 --- Bad patch! Reviews applied: [39838, 39832, 39839, 38579, 39015,

Re: Review Request 39053: RegistryClient refactor: priv method const'ness

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39053/ --- (Updated Nov. 1, 2015, 3:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39112: RegistryClient refactor: fixed variable names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39112/ --- (Updated Nov. 1, 2015, 3:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 1, 2015, 3:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39837: Passing os environment variables when start docker executor.

> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- (Updated Nov. 1, 2015, 3:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39015/ --- (Updated Nov. 1, 2015, 3:29 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39016: RegistryClient refactor: refactored lambdas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39016/ --- (Updated Nov. 1, 2015, 3:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38579: Refactored registry client

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 1, 2015, 3:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39837: Passing os environment variables when start docker executor.

> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There

Re: Review Request 39837: Passing os environment variables when start docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104665 --- How did you test this? Could you please elaborate the test steps?

Review Request 39838: RegistryClient refactor: fixed getManifest test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39838/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Nov. 1, 2015, 3:39 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 1, 2015, 3:38 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Nov. 1, 2015, 3:38 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39837: Passing os environment variables when start docker executor.

> On Nov. 1, 2015, 5:56 p.m., Jojy Varghese wrote: > > How did you test this? Could you please elaborate the test steps? Or even > > better - add a test case? Need add a test case. - haosdent --- This is an automatically generated

Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39841/ --- (Updated Nov. 1, 2015, 5:36 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39841/#review104674 --- Patch looks great! Reviews applied: [39841] All tests passed. -

Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39841/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-3814

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 30, 2015, 2:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, line 190 > > > > > > OK, this is problematic and almost caused us an incident at Twitter. > > > > Mesos is able

Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39843/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3522

Re: Review Request 39837: Passing os environment variables when start docker executor.

> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On 十月 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not include

Re: Review Request 39340: RegistryClient: Added streaming response read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39340/ --- (Updated Nov. 1, 2015, 3:35 p.m.) Review request for mesos and Ben Mahler.

Review Request 39840: RegistryClient refactor: pulled up streaming read

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39840/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review104679 --- src/docker/docker.cpp (line 433)

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > >

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote: > > src/docker/docker.cpp, line 430 > > > > > > Seems we already have this env in > >

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Nov. 2, 2015, 7:22 a.m.) Review request for mesos, Joris Van