Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

2015-11-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39860/ --- (Updated Nov. 2, 2015, 3:19 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39432: Add /master/frameworks to master endpoint

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39432/#review104716 --- Vinod, can you please help check if we can merge this? Thanks! -

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review104710 --- Ship it! src/master/allocator/mesos/allocator.hpp (line 268)

Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39860/#review104720 --- Patch looks great! Reviews applied: [39317, 38218, 39399, 39860]

Review Request 39862: Add documentation for newer metrics

2015-11-02 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39862/ --- Review request for mesos, Adam B and Bernd Mathiske. Bugs: MESOS-3569

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review104703 --- Patch looks great! Reviews applied: [39317, 38218, 39399, 39400,

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 2, 2015, 5:41 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39862: Add documentation for newer metrics

2015-11-02 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39862/ --- (Updated Nov. 2, 2015, 6:18 p.m.) Review request for mesos, Adam B and Bernd

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/ --- (Updated Nov. 2, 2015, 6:52 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 39862: Add documentation for newer metrics

2015-11-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39862/#review104729 --- docs/monitoring.md (line 900)

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/ --- (Updated Nov. 2, 2015, 6:35 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review104753 --- configure.ac (line 758)

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-02 Thread Jojy Varghese
> On Nov. 1, 2015, 5:56 p.m., Jojy Varghese wrote: > > How did you test this? Could you please elaborate the test steps? Or even > > better - add a test case? > > haosdent huang wrote: > Need add a test case. Thanks haosdent. Shout if you need help. - Jojy

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/ --- (Updated Nov. 2, 2015, 6:30 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39634/#review104756 --- configure.ac (lines 612 - 621)

Re: Review Request 39862: Add documentation for newer metrics

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39862/#review104745 --- Ship it! thanks for updating this! docs/monitoring.md (line

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/ --- (Updated Nov. 2, 2015, 6:36 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39889: Windows: Added support for `files/files.hpp`.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/#review104877 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540,

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/#review104739 --- Ship it! LGTM. Note: I didn't actually run the code on

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104771 --- Ship it! Double-checked non-Windows builds. - Joseph Wu On

Re: Review Request 39258: Add filesystem isolator with command executor test.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/#review104781 --- Bad patch! Reviews applied: [39719, 39866, 38900, 39868, 39869,

Re: Review Request 38900: Update command executor to support rootfs.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/ --- (Updated Nov. 2, 2015, 7:02 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 39358: Network monitoring metrics table has common style

2015-11-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39358/#review104769 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 29, 2015,

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/ --- (Updated Nov. 2, 2015, 7:42 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/ --- (Updated Nov. 2, 2015, 7:52 p.m.) Review request for mesos, Adam B and

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann
> On Oct. 24, 2015, 5:12 a.m., haosdent huang wrote: > > docs/getting-started.md, line 61 > > > > > > How about add nss through install. Because install also would update if > > the package installed. Thanks

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/ --- (Updated Nov. 2, 2015, 7:56 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/ --- Review request for mesos, Jie Yu and Jojy Varghese. Repository: mesos

Review Request 39869: Added provisioner TestStore.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39869/ --- Review request for mesos, Jie Yu and Jojy Varghese. Repository: mesos

Re: Review Request 39258: Add filesystem isolator with command executor test.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39258/ --- (Updated Nov. 2, 2015, 7:05 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-02 Thread Vinod Kone
> On Oct. 30, 2015, 9:43 p.m., Ben Mahler wrote: > > Hm.. we're still relying on the update uuid, shouldn't we be trying to move > > off of it onto the status uuid? As mentioned in the comments, we can't yet remove uuid because of old checkpointed updates :( > On Oct. 30, 2015, 9:43 p.m.,

Re: Review Request 39862: Add documentation for newer metrics

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39862/#review104768 --- Patch looks great! Reviews applied: [39862] All tests passed. -

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/ --- (Updated Nov. 2, 2015, 7:32 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review104775 --- Ship it! Double-checked non-Windows builds. - Joseph Wu On

Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-11-02 Thread Kapil Arya
> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote: > > Ship It! > > Joseph Wu wrote: > Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted > from V1 unintentionally? Yes, that was an oversight on my end. Thanks for fixing this, Joseph!! - Kapil

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/#review104778 ---

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-02 Thread Joseph Wu
> On Nov. 2, 2015, 12:38 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > lines 34-71 > > > > > > Can you please explain why we can't just use

Re: Review Request 39597: Add Newbie guide.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review104758 --- Thanks for doing this Diana! Sorry for the delay, we need to

Review Request 39868: Moved ProvisionerProcess to header for testing.

2015-11-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39868/ --- Review request for mesos, Jie Yu and Jojy Varghese. Repository: mesos

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/#review104760 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

2015-11-02 Thread Joseph Wu
> On Oct. 23, 2015, 11:45 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp, > > line 34 > > > > > > `strlen()` might be better/more-readable. > > Alex Clemmer

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39791/ --- (Updated Nov. 2, 2015, 7:31 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/#review104779 --- src/master/master.cpp (lines 6024 - 6028)

Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/ --- Review request for mesos, Ben Mahler and Artem Harutyunyan. Bugs: MESOS-3771

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-02 Thread Timothy Chen
> On Nov. 2, 2015, 8:19 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 605 > > > > > > Wondering if this means that we can use ContainerInfo as a predicate > > for "launch"

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review104784 --- Where's the `Makefile` change?

Re: Review Request 39827: Made slave version required in master.cpp.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39827/ --- (Updated Nov. 2, 2015, 7:34 p.m.) Review request for mesos and Ben Mahler.

Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/#review104773 --- Ship it! Ship It! - Joseph Wu On Oct. 29, 2015, 10:57 p.m.,

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39866/#review104782 --- src/slave/containerizer/mesos/containerizer.cpp (line 578)

Re: Review Request 39719: Fixed marking mounts as slave in ubuntu.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39719/#review104757 --- src/Makefile.am (line 735)

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review104767 --- Ship it! Checked that this doesn't break the non-Windows CMake

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review104770 --- Ship it! Double-checked build on non-Windows. - Joseph Wu On

Re: Review Request 39622: CMake: Pointed Stout test linker flags at correct gtest directory.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39622/#review104774 --- Ship it! Ship It! - Joseph Wu On Oct. 29, 2015, 10:57 p.m.,

Review Request 39890: Slave do not support multiple masters when start up

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39890/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3822

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review104873 --- Ship it! Ship It! docs/getting-started.md (line 57)

Review Request 39889: Windows: Added support for `files/files.hpp`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39889/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39843/ --- (Updated 十一月 2, 2015, 8:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review104683 --- Patch looks great! Reviews applied: [37336] All tests passed. -

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104732 --- Ship it! support/apply-reviews.py (line 45)

Re: Review Request 39285: Added Quota Request Validation.

2015-11-02 Thread Joerg Schad
> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote: > > src/master/master.hpp, line 864 > > > > > > Should we return Bad Request (404) for now, because we did not > > implement it yet. As it is implemented in the

Re: Review Request 39285: Added Quota Request Validation.

2015-11-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review104725 --- Ship it! Looks good! The only thing I'm not sure about is how to

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 2, 2015, 9:50 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
> On Nov. 2, 2015, 8:13 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 6032-6036 > > > > > > The movement around this seems to be the key part of this patch, is it > > possible to isolate the fix in a

Re: Review Request 39866: Added containerInfo support for tasks in mesos containerizer.

2015-11-02 Thread Jojy Varghese
> On Nov. 2, 2015, 8:19 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 605 > > > > > > Wondering if this means that we can use ContainerInfo as a predicate > > for "launch"

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/ --- (Updated Nov. 2, 2015, 8:54 p.m.) Review request for mesos, Adam B and

Re: Review Request 39597: Add Newbie guide.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39597/#review104791 --- docs/NewbieQuickStart.md (line 61)

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Kapil Arya
> On Nov. 2, 2015, 3:52 p.m., Neil Conway wrote: > > How about backward compatibility? Adding a note to docs/upgrades.md seems a > > good idea, at the very least. Are we pretty confident that no one else is > > looking at this data, and/or we're happy to break anyone that is? Good point about

Review Request 39878: Updated code and comments Master::updateTask() that deals with 0.21.0 slaves.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39878/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review104806 ---

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104789 --- How about backward compatibility? Adding a note to

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Joseph Wu
> On Nov. 2, 2015, 12:52 p.m., Neil Conway wrote: > > How about backward compatibility? Adding a note to docs/upgrades.md seems a > > good idea, at the very least. Are we pretty confident that no one else is > > looking at this data, and/or we're happy to break anyone that is? > > Kapil Arya

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39325/#review104801 --- Patch looks great! Reviews applied: [39463, 39325] All tests

Re: Review Request 39868: Moved ProvisionerProcess to header for testing.

2015-11-02 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39868/#review104803 --- Ship it! LGTM. - Gilbert Song On Nov. 2, 2015, 11:04 a.m.,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-02 Thread Alexander Rukletsov
> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not

Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39843/ --- (Updated Nov. 2, 2015, 9:42 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-02 Thread Alexander Rukletsov
> On Oct. 25, 2015, 12:46 p.m., Qian Zhang wrote: > > include/mesos/master/allocator.hpp, line 357 > > > > > > Why do we assume quota for the given role is not set prior to the call? > > I thought we support

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-02 Thread Alexander Rukletsov
> On Nov. 1, 2015, 12:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

2015-11-02 Thread Guangya Liu
> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not

Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39843/#review104684 --- Patch looks great! Reviews applied: [39843] All tests passed. -

Review Request 39845: Add REASON_RESOURCE_OVERSUBSCRIBED to mesos proto

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39845/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2647

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

2015-11-02 Thread Alexander Rukletsov
> On Oct. 25, 2015, 12:10 a.m., Klaus Ma wrote: > > include/mesos/master/allocator.hpp, line 358 > > > > > > It said Mesos master will also validate the quota request in design > > document; should we clarify which

Re: Review Request 38579: Refactored registry client

2015-11-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38579/ --- (Updated Nov. 2, 2015, 10:45 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2015-11-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review104810 --- Partial review. (Haven't looked at the new files yet).

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104828 --- support/apply-reviews.py (line 63)

Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39860/#review104830 --- Ship it! Ship It! - Guangya Liu On 十一月 2, 2015, 3:19 p.m.,

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104829 --- Ship it! Ship It! - Vinod Kone On Oct. 30, 2015, 8:54 a.m.,

Re: Review Request 39873: Fixed master to properly handle status updates when multiple of them are enqueued on the slave.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39873/ --- (Updated Nov. 2, 2015, 10:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39015: RegistryClient refactor: expanded abbreviated names.

2015-11-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39015/ --- (Updated Nov. 2, 2015, 10:46 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39839: RegistryClient refactor: Changed getManifest interface

2015-11-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39839/ --- (Updated Nov. 2, 2015, 10:45 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-02 Thread David Forsythe
> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote: > > configure.ac, lines 612-621 > > > > > > If it's not too much trouble, it would be great to see this logic added > > also the `cmake/CompilationCOnfigure.cmake`.

Re: Review Request 39860: Quota: Replaced "slave" with "agent" in allocator logs.

2015-11-02 Thread Alexander Rukletsov
> On Nov. 2, 2015, 4:11 p.m., Vinod Kone wrote: > > What's the plan for slave to agent rename in the logs? Having just the > > allocator output agent when the rest of the code base outputs slave will be > > confusing IMO. I think we change as we go. I was introducing new log messages and

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39493/#review104813 --- Patch looks great! Reviews applied: [39493] All tests passed. -

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104823 --- Ship it! I think that the upgrade documentshould also be updated

Re: Review Request 39611: Remove binary `data` fields from state endpoints.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39611/#review104824 --- Patch looks great! Reviews applied: [39611] All tests passed. -

Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39850/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

Re: Review Request 39851: Windows: fixed ambiguousity error in `process/owned.hpp`.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39851/ --- (Updated Nov. 2, 2015, 11:02 a.m.) Review request for mesos, Artem

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

2015-11-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Nov. 2, 2015, 11:18 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

2015-11-02 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/ --- Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van

  1   2   >