Re: Review Request 40954: Fix comments in TaskHealthStatus message proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40954/#review108950 --- Patch looks great! Reviews applied: [40954] Passed command:

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/ --- (Updated Dec. 4, 2015, 9:26 a.m.) Review request for mesos, Jie Yu and Jojy

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review108971 --- Patch looks great! Reviews applied: [40961, 40821, 39450] Passed

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Dec. 3, 2015, 7:33 p.m., Ben Mahler wrote: > > src/tests/fetcher_tests.cpp, lines 285-289 > > > > > > This makes spawning and termination asymmetric! :( > > > > Please follow the approach done here: >

Re: Review Request 40797: Filtered non-whitelisted and deactivated agents once per allocation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40797/ --- (Updated Dec. 4, 2015, 9:38 a.m.) Review request for mesos and Joris Van

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Dec. 4, 2015, 9:37 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40945: Made HDFS::copyToLocal asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40945/#review108958 --- src/hdfs/hdfs.cpp (line 302)

Re: Review Request 40806: Made HDFS::exists asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40806/#review108960 --- Ship it! src/hdfs/hdfs.cpp (line 143)

Re: Review Request 40211: Add mesos provisioner doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40211/#review108961 --- Patch looks great! Reviews applied: [40211] Passed command:

Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40964/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/ --- (Updated Dec. 4, 2015, 10:09 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40821: Quota: Ensured the sorter for quota'ed roles does not contain revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40821/ --- (Updated Dec. 4, 2015, 10:09 a.m.) Review request for mesos, Bernd Mathiske,

Review Request 40961: Quota: Properly initialized the sorter for quota'ed roles in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40961/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Re: Review Request 40942: Made HDFS::rm asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40942/#review108964 --- Ship it! src/hdfs/hdfs.cpp (line 234)

Re: Review Request 40943: Made HDFS::copyFromLocal asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40943/#review108963 --- Ship it! src/hdfs/hdfs.cpp (line 270)

Re: Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40964/#review108978 --- Patch looks great! Reviews applied: [40964] Passed command:

Re: Review Request 40348: [4/4] Quota Authorization: Documented quota authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40348/ --- (Updated Dec. 4, 2015, 3:28 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 4, 2015, 3:34 p.m.) Review request for mesos, Alexander

Re: Review Request 39288: Quota: Added authentication of quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/ --- (Updated Dec. 4, 2015, 2:51 p.m.) Review request for mesos, Alexander

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/ --- (Updated Dec. 4, 2015, 2:53 p.m.) Review request for mesos, Alexander

Re: Review Request 40935: Fixed flakiness in MasterMaintenanceTest.InverseOffersFilters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40935/#review109001 --- Ship it! Addressed Joseph's comments, verified with Joseph & Neil

Review Request 40975: Document that libprocess ignores SIGPIPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 40821: Quota: Ensured the sorter for quota'ed roles does not contain revocable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40821/#review109003 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 4, 2015,

Re: Review Request 40961: Quota: Properly initialized the sorter for quota'ed roles in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40961/#review108992 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 4, 2015,

Re: Review Request 40985: Fixed the flaky PersistentVolumeTest.SlaveRecovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40985/#review109024 --- Ship it! src/tests/persistent_volume_tests.cpp (line 680)

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/ --- (Updated Dec. 4, 2015, 2:56 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40964/#review109008 --- Ship it! Fixed in-line src/master/quota_handler.cpp (line 97)

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39450/#review109012 --- Ship it! Touched up some comments before committing.

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > >

Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/ --- Review request for mesos, Adam B and Greg Mann. Repository: mesos

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109021 --- Patch looks great! Reviews applied: [40978] Passed command:

Review Request 40985: Fixed the flaky PersistentVolumeTest.SlaveRecovery test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40985/ --- Review request for mesos, Michael Park and Vinod Kone. Bugs: MESOS-3907

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/#review109027 --- Patch looks great! Reviews applied: [39569, 38874, 38875, 38876,

Re: Review Request 40056: Make hook execution order deterministic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109028 --- Hi Haosdent! I apologize the tardy reply. The patch looks good

Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40345/#review109052 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 4, 2015, 1:53

Review Request 40987: Fix apply-reviews.py to work for first-time contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40987/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Vinod

Re: Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40988/#review109033 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2015, 9:50 p.m., Neil

Review Request 40988: stout: Fixed comments for numify(), cleaned up some test code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40988/ --- Review request for mesos, Jie Yu and Cong Wang. Repository: mesos

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review109053 --- Ship it! include/mesos/authorizer/authorizer.hpp (line 175)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 --- Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and

Re: Review Request 40953: Avoid accepting hex float literals

> On Dec. 4, 2015, 11:13 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 37 > > > > > > Just noticed that this fails to parse negative hex numbers like `-0x2`. > >

Re: Review Request 40953: Avoid accepting hex float literals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40953/#review109018 --- No idea why this suddenly had to be so expedited, but here still

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39782/#review109029 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 40660: Linked against executor PID's to ensure ordered message delivery

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40660/#review109044 --- Ship it! We may also want to link in the recovery path, but the

Re: Review Request 40987: Fix apply-reviews.py to work for first-time contributors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40987/#review109046 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2015, 9:30 p.m.,

Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40118/#review109041 --- Ship it! Ship It! - Jie Yu On Dec. 3, 2015, 11:37 p.m., Greg

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review109042 --- Patch looks great! Reviews applied: [40944] Passed command:

Re: Review Request 37540: Add perf event API

> On Dec. 2, 2015, 6:13 p.m., Niklas Nielsen wrote: > > Ping - Cong, is there anything you need to close the last issues? :) I was blocked at the second to the last issue above and switched to something else, now I can think more about it. Thanks! - Cong

Review Request 41000: Shortened allocation_interval in ReservationTests to avoid flakiness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41000/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4067

Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/ --- Review request for mesos. Repository: mesos Description --- Improved

Re: Review Request 40999: Fixed flakiness in ReservationTest.ACLMultipleOperations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40999/#review109068 --- src/tests/reservation_tests.cpp (lines 1663 - 1664)

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review109062 --- Patch looks great! Reviews applied: [38117] Passed command:

Review Request 40998: Reinstated previously reverted commit around CHECK's for ordered delivery of messages in Command Executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3851

Review Request 40999: Fixed flakiness in ReservationTest.ACLMultipleOperations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40999/ --- Review request for mesos, Jie Yu and Michael Park. Bugs: MESOS-4067

Re: Review Request 40946: Made HDFS::du asynchrounous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/#review109060 --- Ship it! Ship It! - Vinod Kone On Dec. 4, 2015, 1:34 a.m., Jie

Re: Review Request 39848: Validate revocable resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39848/#review109063 --- src/slave/slave.cpp (line 1503)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109057 --- looks great so far! We probably need a few tests to exercise the

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/#review109070 --- Patch looks great! Reviews applied: [40838, 40884] Passed

Re: Review Request 40995: Added test cases for role behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review109077 --- Patch looks great! Reviews applied: [40995] Passed command:

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review109072 --- src/slave/containerizer/mesos/provisioner/docker/message.proto

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > >

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 5, 2015, 3:35 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40998: Reinstated previously reverted commit around CHECK's for ordered delivery of messages in Command Executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40998/#review109079 --- Patch looks great! Reviews applied: [40998] Passed command:

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/#review109081 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109082 --- Patch looks great! Reviews applied: [40951] Passed command:

Re: Review Request 40975: Document that libprocess ignores SIGPIPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40975/#review109007 --- Patch looks great! Reviews applied: [40975] Passed command:

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- (Updated Dec. 4, 2015, 10:44 a.m.) Review request for mesos, Artem

Re: Review Request 40953: Avoid accepting hex float literals

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40953/#review109011 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2015, 5:23 a.m., Cong

Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Artem Harutyunyan.

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Dec. 3, 2015, 7:33 p.m., Ben Mahler wrote: > > src/tests/fetcher_tests.cpp, lines 285-289 > > > > > > This makes spawning and termination asymmetric! :( > > > > Please follow the approach done here: >

Re: Review Request 40954: Fix comments in TaskHealthStatus message proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40954/#review109005 --- Ship it! src/messages/messages.proto (line 666)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 4, 2015, 6:30 p.m.) Review request for mesos. Bugs: MESOS-3843

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review109010 --- src/slave/containerizer/mesos/provisioner/docker/message.proto

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 4, 2015, 7:18 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 38878: Added test for the Subscribe->Subscribed workflow for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38878/ --- (Updated Dec. 4, 2015, 7:02 p.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38117: Export per container SNMP statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Dec. 4, 2015, 7:01 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- (Updated Dec. 4, 2015, 11:01 a.m.) Review request for mesos, Artem