Re: Review Request 41372: Added update for systemd in centos Getting Started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41372/ --- (Updated Dec. 15, 2015, 1:05 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41363: Reworded NOTE in Examples for Getting Started doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41363/ --- (Updated Dec. 15, 2015, 1:06 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41362: Added note in docs for installing wget, tar, git.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41362/ --- (Updated Dec. 15, 2015, 1:07 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41360: Aligned the code blocks in Getting Started better.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41360/ --- (Updated Dec. 15, 2015, 1:08 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41359: Forced horizontal scroll in docs code blocks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41359/ --- (Updated Dec. 15, 2015, 1:08 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41361: Wrote cmd to create WANdiscoSVN file for centos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41361/ --- (Updated Dec. 15, 2015, 1:07 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 41286: Updated Getting Started for Mac OS X El Capitan.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41286/ --- (Updated Dec. 15, 2015, 1:09 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 41243: Updated how we find the .git directory in bootstrap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41243/ --- (Updated Dec. 15, 2015, 1:09 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 41244: Using 'git rev-parse --git-dir' in post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41244/ --- (Updated Dec. 15, 2015, 1:10 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 40806: Made HDFS::exists asynchronous.

> On Dec. 4, 2015, 10:51 a.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.cpp, line 143 > > > > > > Maybe we can get some extra info about what subprocess failed to be > > reaped by capturing some values from above in

Re: Review Request 40941: Added a helper for HDFS client to shell out commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40941/ --- (Updated Dec. 15, 2015, 1:26 a.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 40946: Made HDFS::du asynchrounous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40946/ --- (Updated Dec. 15, 2015, 1:27 a.m.) Review request for mesos, Bernd Mathiske, Be

Review Request 41384: Added tests for HDFS client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41384/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone. Bugs: MES

Review Request 41383: Added ubuntu dependence for libsasl2-modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/ --- Review request for mesos, Bernd Mathiske and Neil Conway. Bugs: MESOS-3305

Re: Review Request 41275: Introduced a field for specifying grace period in Shutdown Event for Executor V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41275/#review110363 --- include/mesos/executor/executor.proto (line 89)

Re: Review Request 41280: Fixed header include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/#review110364 --- Ship it! Ship It! - Joseph Wu On Dec. 11, 2015, 3:51 p.m., Anan

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40062/#review110366 --- Ship it! Ship It! - Adam B On Nov. 9, 2015, 9:16 p.m., Vaibhav

Re: Review Request 40829: Improved authorization documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40829/#review110367 --- Ship it! Ship It! - Adam B On Dec. 1, 2015, 11:10 a.m., Neil Co

Re: Review Request 41280: Fixed header include order.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41280/#review110369 --- Ship it! Ship It! - Guangya Liu On 十二月 11, 2015, 11:51 p.m., An

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110371 --- src/master/http.cpp (line 1578)

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/ --- (Updated Dec. 14, 2015, 6:14 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Review Request 41370: Logger Module: Update DockerContainerizer test helpers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/ --- Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Bugs: MESOS-4

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110374 --- src/master/http.cpp (line 316)

Re: Review Request 41282: Added the interface for the V1 Executor HTTP Library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41282/#review110370 --- include/mesos/v1/executor.hpp (lines 63 - 64)

Re: Review Request 41384: Added tests for HDFS client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41384/#review110373 --- Ship it! I like this approach a lot. Maybe some more comments coul

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 10:47 p.m., Guangya Liu wrote: > > src/master/master.cpp, lines 2829-2845 > > > > > > How does this can resove overcommit issue? I think that the issue is > > still there? Another is that can yo

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo

> On Dec. 14, 2015, 9:53 p.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 511 > > > > > > Seems the executor_rootfs is not a slave configuraiton? I can only set > > launcher_dir, sandbox_dir and switch_u

Re: Review Request 41075: Added support for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41075/#review110381 --- src/master/http.cpp (line 1556)

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/#review110382 --- Thanks for the detailed analysis of the issues! (1) My preference

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/ --- (Updated Dec. 15, 2015, 3:20 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40829: Improved authorization documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40829/#review110383 --- docs/authorization.md (line 24)

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we shoul

Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/ --- Review request for mesos, Adam B and Anand Mazumdar. Bugs: MESOS-4114 https

Review Request 41381: Added unit test cases to test the new vip and instance_port fields

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/ --- Review request for mesos, Adam B and Anand Mazumdar. Repository: mesos Descri

Re: Review Request 40102: Windows: Unified POSIX and Windows implementation of process.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40102/ --- (Updated Dec. 15, 2015, 3:38 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110388 --- src/slave/containerizer/docker.cpp (line 139)

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

> On Dec. 14, 2015, 2:31 p.m., Qian Zhang wrote: > > src/master/master.cpp, line 2830 > > > > > > So if task's resources has no cpu, then we will not add cpu to > > executor's resources, right? But I think we shoul

Re: Review Request 41369: Logger Module: Add ContainerLogger support to the Mesos Docker executor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review110389 --- src/docker/executor.hpp (line 89)

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110385 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review110391 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/#review110393 --- include/mesos/slave/container_logger.hpp (line 111)

Re: Review Request 41002: Logger Module: Introduce the ContainerLogger interface for logging the stdout/stderr of executors and tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/#review110394 --- include/mesos/slave/container_logger.hpp (line 120)

Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110395 --- src/docker/docker.cpp (line 593)

Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review110397 --- Ship it! Ship It! - Timothy Chen On Dec. 15, 2015, 2:14 a.m., J

Re: Review Request 41378: Logger Module: Update tests that use the DockerContainerizer to pass in a ContainerLogger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41378/#review110398 --- src/tests/environment.cpp (line 226)

Re: Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41386/#review110399 --- src/tests/container_logger_tests.cpp (line 158)

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review110392 --- 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review110387 --- LGTM, Just some minor style nits and suggestions. src/tests/slave

Re: Review Request 41383: Added ubuntu dependence for libsasl2-modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41383/#review110409 --- Patch looks great! Reviews applied: [41286, 41359, 41360, 41361, 4

Re: Review Request 40829: Improved authorization documentation.

> On Dec. 14, 2015, 7:25 p.m., Guangya Liu wrote: > > docs/authorization.md, line 24 > > > > > > Not yours, shall we file a JIRA ticket to update shutdown_frameworks to > > teardown_frameworks to make it consistent w

Re: Review Request 40062: MESOS-2315 Deprecate/Remove CommandInfo::ContainerInfo

> On Dec. 14, 2015, 5:47 p.m., Adam B wrote: > > Ship It! Only missing piece is an API change mention in the CHANGELOG. I'll add that. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4

Re: Review Request 40829: Improved authorization documentation.

> On 十二月 15, 2015, 3:25 a.m., Guangya Liu wrote: > > docs/authorization.md, line 24 > > > > > > Not yours, shall we file a JIRA ticket to update shutdown_frameworks to > > teardown_frameworks to make it consistent wi

<    1   2