Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115537 --- src/master/allocator/mesos/hierarchical.cpp (line 1310)

Re: Review Request 41855: Trace pending executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41855/#review115534 --- src/slave/slave.cpp (lines 1384 - 1388)

Re: Review Request 42559: Allocated resources as revocable beyond quota.

> On Jan. 21, 2016, 1:20 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1313 > > > > > > Who will kill this `revocable` resources? So we'll have a patch for > > evicting? > >

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

> On 一月 21, 2016, 6:12 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-21 06:12:19 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > >

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115539 --- There maybe risk if we want to catch up with 0.27.0 for this.

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115547 --- Patch looks great! Reviews applied: [42235, 41961, 42236, 42237,

Re: Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42580/#review115551 --- Bad patch! Reviews applied: [42580] Failed command:

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115565 --- Patch looks great! Reviews applied: [42517] Passed command:

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115538 --- Ship it! Ship It! - Guangya Liu On 一月 20, 2016, 9:57 p.m.,

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 21, 2016, 3:08 a.m.) Review request for mesos, Adam B, Neil

Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Joris Van

Review Request 42590: Removed reserved() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42590/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere,

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/ --- (Updated 一月 21, 2016, 4:12 a.m.) Review request for mesos, Jie Yu and Timothy

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/#review115533 --- Patch looks great! Reviews applied: [42543, 42546] Passed

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

> On 一月 14, 2016, 9:19 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [42288] > > > > Failed command: ./support/apply-review.sh -n -r 42288 > > > > Error: > > 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ > > [612/612] -> "42288.patch" [1] > >

Re: Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/ --- (Updated Jan. 21, 2016, 2:27 p.m.) Review request for mesos, Alexander

Re: Review Request 42535: Made allocator's pause/resume idempotent.

> On Jan. 20, 2016, 3:11 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1048 > > > > > > Suggest to add some tests for this case. > > Alexander Rukletsov wrote: > I totally agree

Re: Review Request 41772: Added helper function to flatten resources.

> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42580/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4386

Re: Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/#review115540 --- Patch looks great! Reviews applied: [42575] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115542 --- src/docker/docker.cpp (line 517)

Re: Review Request 42355: Removed the timeout from the filter.

> On Jan. 20, 2016, 9:49 a.m., Qian Zhang wrote: > > One question: Say allocation interval is 10s, at the time 5s, framework > > sets a filter with 3s, so with this patch, we will expire the filter 10s > > (max(10, 3)) later, i.e., at the time 15s. Then at the time of 10s (the > > next

Re: Review Request 41847: Updated allocation slack when slave was updated.

> On 一月 16, 2016, 2:21 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total =

Re: Review Request 42506: Multiple Disk: Parameterized persistent volume tests on disk source.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42506/ --- (Updated Jan. 21, 2016, 7:41 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On 一月 16, 2016, 2:11 a.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 42503: Multiple Disk: Added Resource arithmetic tests for type 'PATH'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42503/ --- (Updated Jan. 21, 2016, 7:39 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/ --- (Updated Jan. 21, 2016, 7:38 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

> On 一月 20, 2016, 10:54 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 662 > > > > > > Have you considered modifying `Resources::apply` to "create" allocation > > slack upon a

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115586 --- Ship it! Ship It! - Timothy Chen On Jan. 21, 2016, 12:41 a.m.,

Re: Review Request 42355: Removed the timeout from the filter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42355/#review115583 --- Thanks Alex, code change looks great. Feel free to split the fix

Re: Review Request 42589: Added test case for allocator recover with Quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42589/#review115588 --- Patch looks great! Reviews applied: [42535, 42589] Passed

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 21, 2016, 7:39 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/ --- (Updated Jan. 21, 2016, 7:40 a.m.) Review request for mesos, Jie Yu and

Review Request 42593: Multiple Disk: Fixed invalid 'DiskResourcesTest's.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42593/ --- Review request for mesos. Repository: mesos Description --- These were

Re: Review Request 42470: Multiple Disk: Added 'Source' to 'Resource.DiskInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42470/ --- (Updated Jan. 21, 2016, 7:35 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42471: Multiple Disk: Adjusted resource arithmetic for 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42471/ --- (Updated Jan. 21, 2016, 7:36 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42473/ --- (Updated Jan. 21, 2016, 7:37 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/ --- (Updated Jan. 21, 2016, 7:37 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42535: Made allocator's pause/resume idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/#review115589 --- Ship it! I see the test is in the works in a separate review. -

Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42389/#review115530 --- Ship it! Ship It! - Jie Yu On Jan. 19, 2016, 12:10 a.m.,

Re: Review Request 42143: Removed HTTPTest.Auth test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42143/#review115428 --- Ship it! Ship It! - Till Toenshoff On Jan. 13, 2016, 6:13

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review115434 --- Patch looks great! Reviews applied: [41597, 41681] Passed

Re: Review Request 42516: Add support for user-defined networks.

> On Jan. 20, 2016, 7:41 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 539-541 > > > > > > I think that you may also want some test cases to verify port mapping > > plus user defined network. We agree

Re: Review Request 42546: Updated `Master::Http::stateSummary` to use `jsonify`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42546/ --- (Updated Jan. 20, 2016, 6:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115454 --- Patch looks great! Reviews applied: [42517] Passed command:

Re: Review Request 42516: Add support for user-defined networks.

> On 一月 19, 2016, 11:29 p.m., Guangya Liu wrote: > > A unit test also needed, please refer to > > https://github.com/apache/mesos/blob/master/src/tests/containerizer/docker_containerizer_tests.cpp#L297 > > for detail > > Ezra Silvera wrote: > Thanks. I'll have a look. We will probably

Review Request 42557: Moved CachedImage to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42559: Allocated resources as revocable beyond quota.

> On Jan. 20, 2016, 5:20 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1313 > > > > > > Who will kill this `revocable` resources? So we'll have a patch for > > evicting? Someday,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/#review115446 --- Ship it! Ship It! - Gilbert Song On Jan. 18, 2016, 12:14 a.m.,

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 41911: Added a test case for corrupt packets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41911/#review115242 --- src/tests/containerizer/port_mapping_tests.cpp (line 23)

Re: Review Request 42543: Updated `json` to handle integral types comprehensively.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42543/ --- (Updated Jan. 20, 2016, 5:04 p.m.) Review request for mesos and Benjamin

Re: Review Request 42415: Added a roles field to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42415/#review115439 --- Patch looks great! Reviews applied: [42415] Passed command:

Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/ --- Review request for mesos, Bernd Mathiske, Joris Van Remoortere, Joseph Wu, and

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115443 --- src/master/allocator/mesos/hierarchical.cpp (line 1313)

Re: Review Request 42503: Multiple Disk: Added Resource arithmetic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42503/ --- (Updated Jan. 20, 2016, 7:16 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 42557: Moved CachedImage to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42557/#review115465 --- Bad patch! Reviews applied: [41958, 41959, 42156, 42157] Failed

Re: Review Request 42474: Multiple Disk: Updated Slave initialize to create DiskInfo paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42474/#review115472 --- Ship it! src/slave/slave.cpp (lines 369 - 372)

Re: Review Request 42027: Changed HTTP responses from Unauthorized (401) to Forbidden (403).

> On Jan. 20, 2016, 7:37 p.m., Till Toenshoff wrote: > > src/master/http.cpp, lines 549-553 > > > > > > To prosterity; this means that we currently do not support mixed usage > > of old API and HTTP API for

Re: Review Request 42368: Added reservation endpoint test without authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42368/ --- (Updated Jan. 20, 2016, 6:59 p.m.) Review request for mesos, Jie Yu, Michael

Re: Review Request 42027: Changed HTTP responses from Unauthorized (401) to Forbidden (403).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42027/#review115423 --- Ship it! src/master/http.cpp (lines 548 - 551)

Re: Review Request 42472: Multiple Disk: Checkpoint persistent volume based on 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42472/#review115468 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2016, 7:12 p.m., Joris

Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42473/#review115471 --- Ship it!

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/ --- (Updated Jan. 20, 2016, 7:18 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 42068: Porting 3rdparty on ppc64le.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42068/#review115457 --- Bad patch! Reviews applied: [42068] Failed command:

Re: Review Request 42473: Multiple Disk: Updated filesystem isolators to use 'DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42473/ --- (Updated Jan. 20, 2016, 7:15 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 20, 2016, 12:19 p.m.) Review request for mesos, Artem

Re: Review Request 42504: Multiple Disk: Modified 'DiskInfo' stripping logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42504/#review115479 --- src/common/resources.cpp (line 968)

Re: Review Request 42505: Multiple Disk: Adjusted DiskInfo validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42505/#review115482 --- src/master/validation.cpp (lines 206 - 210)

Re: Review Request 42503: Multiple Disk: Added Resource arithmetic tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42503/#review115475 --- Ship it! src/tests/resources_tests.cpp (line 1846)

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 19, 2016, 2:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

> On Jan. 15, 2016, 6:11 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1291-1319 > > > > > > None of this should be necessary: > > > > 1) You should have all the allocation

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/ --- (Updated Jan. 20, 2016, 9:56 p.m.) Review request for mesos, Alexander

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

> On Jan. 14, 2016, 10:33 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 123 > > > > > > The name of this struct is weird considering it is encapsulating two > > connections. > > > >

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review115497 --- src/master/allocator/mesos/hierarchical.cpp (line 662)

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

> On Jan. 19, 2016, 3:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two.

Re: Review Request 41850: Add map to trace evictable executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41850/#review115295 --- src/slave/slave.cpp (line 1599)

Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/ --- Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil

Re: Review Request 42144: Removed deprecated constructor of http::Unauthorized in libprocess.

> On Jan. 11, 2016, 4:53 p.m., Jan Schlicht wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 538 > > > > > > Instead of using `std::vector`, we could also use > > `std::initializer_list` here. Same for

Re: Review Request 42559: Allocated resources as revocable beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42559/#review115504 --- Patch looks great! Reviews applied: [42559] Passed command:

Re: Review Request 41726: Implement os::memory() for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review115510 --- Ship it! Ship It! - Ian Downes On Jan. 7, 2016, 4:52 p.m.,

Re: Review Request 41847: Updated allocation slack when slave was updated.

> On Jan. 15, 2016, 6:21 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 529-535 > > > > > > What if you did this? > > ``` > > slaves[slaveId]total =

Re: Review Request 42255: Updated user documentation around HTTP response codes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42255/#review115494 --- Ship it! Ship It! - Till Toenshoff On Jan. 18, 2016, 11:46

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/ --- (Updated Jan. 20, 2016, 9:57 p.m.) Review request for mesos, Alexander

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/ --- (Updated Jan. 20, 2016, 10:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42575: Removed superfluous word from quota.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42575/#review115528 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 20, 2016,

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

> On Jan. 18, 2016, 11:02 p.m., Timothy Chen wrote: > > src/tests/uri_fetcher_tests.cpp, line 216 > > > > > > Should we create a constant for docker registry server url? We're > > referring to it in multiple places

Re: Review Request 42516: Add support for user-defined networks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review115526 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42517/#review115529 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 20, 2016, 9:57

Re: Review Request 42239: Added tests for the Docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42239/ --- (Updated Jan. 21, 2016, 12:41 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:26 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 11, 2016, 12:12 a.m., Adam B wrote: > > 3rdparty/libprocess/src/http.cpp, lines 1218-1221 > > > > > > Will you add `query` as a parameter only once you've moved `get()` over > > to this? > > > >

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:52 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41789: Expose the http::internal::request function.

> On Jan. 19, 2016, 7:11 p.m., Adam B wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 812-814 > > > > > > Seems like a good candidate for a doxygen-style @param > > Yongqiao Wang wrote: > I

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 20, 2016, 8:09 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 41856: Added helper functions to get allocation slack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41856/ --- (Updated Jan. 20, 2016, 4:23 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 41648: Used initializer list c-tor for brevity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/#review115383 --- Ship it! Ship It! - Bernd Mathiske On Jan. 12, 2016, 1:33

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review115382 --- Ship it! Ship It! - Bernd Mathiske On Jan. 12, 2016, 1:34

  1   2   >