Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/ --- (Updated March 13, 2016, 5:50 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 12, 2016, 2:19 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 228 > > > > > > Can there be a use case where you want multiple NICs to be attached to > >

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123321 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review123316 --- Fix it, then Ship it! src/master/constants.hpp (line 136)

Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123319 --- src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/ --- (Updated March 13, 2016, 6:50 p.m.) Review request for mesos, Adam B and

Review Request 44761: [WIP][PROPOSAL_2]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44761/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4697

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44762/#review123322 --- Bad patch! Reviews applied: [44762] Failed command:

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/ --- (Updated March 13, 2016, 6:54 p.m.) Review request for mesos, Adam B and Greg

Review Request 44764: Made 'framework' endpoint help string consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44764/ --- Review request for mesos, Adam B and Neil Conway. Repository: mesos

Review Request 44765: Added description to endpoint help for frameworks and flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44765/ --- Review request for mesos, Adam B and Neil Conway. Repository: mesos

Re: Review Request 42806: Added the fetcher plugin module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/#review123315 --- Patch looks great! Reviews applied: [42806] Passed command:

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

> On March 13, 2016, 8:26 a.m., Adam B wrote: > > src/tests/master_maintenance_tests.cpp, line 1786 > > > > > > You can't use `badAuthnHeaders` here, because of the content-type? Yes. > On March 13, 2016, 8:26

Re: Review Request 44761: [WIP][PROPOSAL_2]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44761/#review123320 --- Bad patch! Reviews applied: [44761] Failed command:

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123323 --- support/clang-format (line 2)

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/#review123324 --- Patch looks great! Reviews applied: [44286, 44186, 44621, 44711]

Re: Review Request 44761: [WIP][PROPOSAL_2]Add CgroupsIsolator. This is only used for discussion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44761/ --- (Updated March 13, 2016, 6:09 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44765/#review123329 --- Can you also run the support/generate-endpoint-ehlp.py sript to

Re: Review Request 44768: Included weights endpoint in endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44768/#review123332 --- Ship it! Ship It! - Kevin Klues On March 13, 2016, 9:37

Re: Review Request 44767: Added authentication information to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/ --- (Updated March 13, 2016, 10:33 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44768: Included weights endpoint in endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44768/#review123335 --- Patch looks great! Reviews applied: [44768] Passed command:

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/ --- (Updated March 14, 2016, 12:25 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44768: Included weights endpoint in endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44768/#review123340 --- I already have a patch out for this --

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

> On March 6, 2016, 12:51 a.m., Klaus Ma wrote: > > support/install-nvidia-gdk.sh, lines 3-13 > > > > > > Are we going to provide documents about those vars? e.g. which version > > are we going to support? >From

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists. > > Ben Mahler wrote: > Could you update the testing done so that others can tell how you tested > this? Done. >

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44583/#review123341 --- Ship it! Ship It! - Kevin Klues On March 9, 2016, 6:04

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44765/#review123343 --- Patch looks great! Reviews applied: [44286, 44186, 44621, 44711,

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/ --- (Updated March 14, 2016, 1:09 a.m.) Review request for mesos and Michael Park.

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 13, 2016, 6:47 p.m., Benjamin Bannier wrote: > > support/clang-format, line 2 > > > > > > It would be great if you could use this opportunity and explicitly > > expand the values of the `Google` style we

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/ --- (Updated March 14, 2016, 1:12 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

> On March 8, 2016, 7:33 p.m., Ben Mahler wrote: > > configure.ac, lines 957-976 > > > > > > Could we flatten this to make it a bit easier to read? There are alot of examples in configure.ac that still do it this

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

> On March 4, 2016, 7:42 a.m., Benjamin Bannier wrote: > > I think using a `TemporaryDirectoryTest` fixture is the right approach, but > > what I find unfortunate about your approach is that with this patch we'd > > create a temporary directory and incur the overhead for all tests in this > >

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/ --- (Updated March 13, 2016, 10:31 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44765/ --- (Updated March 13, 2016, 9:29 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 44767: Added authentication information to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/#review123348 --- Bad patch! Reviews applied: [44767, 44766, 44768] Failed

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 12, 2016, 2:11 a.m., Greg Mann wrote: > > src/master/http.cpp, line 787 > > > > > > This increment statement occurs after some invalidation logic, and > > directly before the authorization call; is this

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42386/ --- (Updated 三月 14, 2016, 4:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 14, 2016, 4:02 a.m.) Review request for mesos, Adam B,

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 三月 14, 2016, 4:03 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 14, 2016, 4 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/ --- (Updated March 14, 2016, 4:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 14, 2016, 4:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 14, 2016, 4:18 a.m.) Review request for mesos, Adam B,

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 14, 2016, 4:18 a.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 13, 2016, 4:26 p.m., Joerg Schad wrote: > > src/master/constants.hpp, line 136 > > > > > > Should we make it "master HTTP authentication realm."? Good idea; done! - Greg

Re: Review Request 44315: Do not traverse offer list if there is only one offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- (Updated 三月 14, 2016, 4:44 a.m.) Review request for mesos, Anand Mazumdar, Ben

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44758/#review123349 --- Patch looks great! Reviews applied: [44758] Passed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 14, 2016, 5:50 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44620: Documented how to make executors work with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123305 --- Ship it! Looks good, but I'll clean it up a bit before

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review123306 --- Ship it! Ship It! - Adam B On March 11, 2016, 2:04 a.m.,

Re: Review Request 44672: Added normalize method to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44672/#review123307 --- Can you please link

Re: Review Request 44620: Documented how to make executors work with SSL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44620/#review123308 --- Patch looks great! Reviews applied: [44620] Passed command:

Re: Review Request 42806: Added the fetcher plugin module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42806/ --- (Updated March 13, 2016, 1:09 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 13, 2016, 1:29 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 44765: Added description to endpoint help for frameworks and flags.

> On March 13, 2016, 8:40 p.m., Kevin Klues wrote: > > Can you also run the support/generate-endpoint-ehlp.py sript to regenerate > > the mardown files for the endpoints help? Already considered that :-). - Joerg --- This is an

Review Request 44768: Included weights endpoint in endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44768/ --- Review request for mesos, Adam B, Kevin Klues, and Neil Conway. Repository:

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review123309 --- Fix it, then Ship it! Looks great. Fix it, then I'll commit.

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

> On March 13, 2016, 4:31 a.m., Adam B wrote: > > Ship It! Sorry, needs a rebase after https://reviews.apache.org/r/44693/ - Adam --- This is an automatically generated e-mail. To reply, visit:

Review Request 44590: Tests fixup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44590/ --- Review request for mesos. Repository: mesos Description --- Tests

Re: Review Request 44584: Improved docs for dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44584/#review123312 --- Ship it! Ship It! - Adam B On March 10, 2016, 10:40 a.m.,

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44583/#review123311 --- Ship it! Ship It! - Adam B On March 9, 2016, 10:04 a.m.,

Re: Review Request 44621: Added tests for http endpoints with bad authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44621/#review123302 --- Looks good. Just some minor style points to clean up, and then we

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44711/#review123304 --- Slow down, partner. Even after Greg's patch to add authn to basic