Review Request 48310: Removed trailing space from Files documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48310/ --- Review request for mesos, Adam B and Neil Conway. Bugs: MESOS-5153

Review Request 48311: Updated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48311/ --- Review request for mesos, Adam B and Neil Conway. Bugs: MESOS-5153

Re: Review Request 48311: Updated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48311/#review136404 --- Patch looks great! Reviews applied: [48310, 48311] Passed

Re: Review Request 48311: Updated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48311/#review136408 --- docs/endpoints/master/state.md (line 53)

Re: Review Request 47396: Added aufs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review136392 --- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp

Re: Review Request 45905: Added metrics to the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/#review136399 --- Patch looks great! Reviews applied: [46407, 48299, 45604, 46411,

Review Request 48313: Creation and deletion of persistent volumes across agent restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- Review request for mesos. Bugs: MESOS-5448

Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- Review request for mesos. Bugs: MESOS-5448

Review Request 48314: Added os::empty(path) to check if contents in a directory is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48314/ --- Review request for mesos. Bugs: MESOS-5448

Re: Review Request 48310: Removed trailing space from Files documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48310/#review136407 --- Ship it! Ship It! - Adam B On June 6, 2016, 8:41 p.m.,

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136406 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 48311: Updated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48311/ --- (Updated June 7, 2016, 7:52 a.m.) Review request for mesos, Adam B and Neil

Review Request 48264: Added test for optional request.object field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/ --- Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone. Bugs:

Re: Review Request 48269: Removed unused imports from protobuf files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48269/#review136232 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48267/#review136230 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48267/ --- (Updated June 6, 2016, 9:54 a.m.) Review request for mesos, Adam B, Till

Review Request 48271: Used tense consistently in 1.0 Changelog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48271/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 48269: Removed unused imports from protobuf files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48269/ --- Review request for mesos. Repository: mesos Description --- This

Review Request 48272: Added 1.0 changed to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48272/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 48264: Added test for optional request.object field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/#review136229 --- Patch looks great! Reviews applied: [48264] Passed command:

Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5509

Re: Review Request 47396: Added aufs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/#review136393 --- Patch looks great! Reviews applied: [48300, 47396] Passed

Re: Review Request 48275: Updated log messages and doc pages for slave -> agent rename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48275/#review136247 --- Patch looks great! Reviews applied: [48275] Passed command:

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43520/#review136241 --- Ship it! Ship It! - Neil Conway On April 16, 2016, 3:37

Re: Review Request 48272: Added 1.0 changed to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48272/#review136243 --- Patch looks great! Reviews applied: [48264, 48267, 48271, 48272]

Review Request 48275: Updated log messages and doc pages for slave -> agent rename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48275/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review136248 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136250 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 48264: Added test for optional request.object field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/#review136259 --- src/tests/authorization_tests.cpp (line 2106)

Re: Review Request 47396: Added aufs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/ --- (Updated June 6, 2016, 3:08 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 48263: Fixed documentation for MESOS-5405.

> On June 6, 2016, 3:07 p.m., Vinod Kone wrote: > > docs/authorization.md, line 636 > > > > > > Is there a place which lists for each of the actions which fields in > > Object will be set? If not, we should have

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48267/ --- (Updated June 6, 2016, 3:19 p.m.) Review request for mesos, Adam B, Till

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

> On June 6, 2016, 2:49 p.m., Vinod Kone wrote: > > CHANGELOG, line 40 > > > > > > s/these fields/any of these fields/ ? > > > > I don't follow what you mean by "the request should be allowed only for > >

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48267/#review136260 --- CHANGELOG (line 40)

Re: Review Request 48271: Used tense consistently in 1.0 Changelog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48271/#review136261 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 10:45 a.m.,

Re: Review Request 48263: Fixed documentation for MESOS-5405.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48263/#review136266 --- docs/authorization.md (line 635)

Re: Review Request 48264: Added test for optional request.object field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/ --- (Updated June 6, 2016, 3:11 p.m.) Review request for mesos, Adam B, Till

Re: Review Request 48272: Added 1.0 changed to upgraded.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48272/#review136258 --- docs/upgrades.md (line 50)

Re: Review Request 48272: Added 1.0 changed to upgraded.md.

> On June 6, 2016, 2:52 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 173 > > > > > > This section seems like duplicate of what we have in CHANGELOG. What do > > you think about removing this text from here

Re: Review Request 48263: Fixed documentation for MESOS-5405.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48263/#review136227 --- Patch looks great! Reviews applied: [48263] Passed command:

Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48267/ --- Review request for mesos. Repository: mesos Description --- The changed

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/#review136279 --- Ship it! Ship It! - Vinod Kone On June 5, 2016, 5:59 p.m.,

Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5507

Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5506

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we

Re: Review Request 48272: Added 1.0 changed to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48272/#review136313 --- Patch looks great! Reviews applied: [48264, 48267, 48271, 48272]

Re: Review Request 48275: Updated log messages and doc pages for slave -> agent rename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48275/#review136255 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 12:37 p.m.,

Re: Review Request 48263: Fixed documentation for MESOS-5405.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48263/#review136265 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 8:22 a.m.,

Re: Review Request 48272: Added 1.0 changed to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48272/ --- (Updated June 6, 2016, 3:26 p.m.) Review request for mesos and Vinod Kone.

Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/ --- Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/#review136345 --- Ship it! Ship It! - Joseph Wu On June 5, 2016, 10:59 a.m.,

Re: Review Request 46588: Added URI struct to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46588/ --- (Updated June 6, 2016, 11:10 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/#review136339 --- Patch looks great! Reviews applied: [48115, 48116, 48257, 48084,

Re: Review Request 47806: Add docker config auth protobuf to docker spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/#review136340 --- include/mesos/docker/spec.proto (line 44)

Re: Review Request 46686: Allowed to pass lambda in `dispatch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46686/#review136355 --- This is looking good haosdent! As I'm on vacation this week, I'll

Re: Review Request 47808: Added test for parsing docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47808/#review136360 --- src/tests/containerizer/docker_spec_tests.cpp (line 237)

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 9:30 a.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > > > > > why want this function to return `v1::master::Response` instead of > > `http::Response` to be consistent with how we

Re: Review Request 47807: Implemented parsing a docker config to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47807/#review136356 --- src/docker/spec.cpp (line 196)

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136346 --- src/master/http.cpp (line 678)

Re: Review Request 48291: Use varint comparator in replica log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48291/#review136364 --- Patch looks great! Reviews applied: [47324, 48291] Passed

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/#review136372 --- src/tests/api_tests.cpp (lines 265 - 268)

Re: Review Request 45958: Updated protobuf Resource to mark the resource as shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/#review136371 --- Ship it! Ship It! - Jiang Yan Xu On May 22, 2016, 12:05

Re: Review Request 48183: Documented some suggestions for using persistent volume IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48183/#review136379 --- Ship it! Ship It! - Jie Yu On June 2, 2016, 7:09 p.m., Neil

Re: Review Request 45951: Implemented http basic auth to get docker auth token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/#review136361 --- src/uri/fetchers/docker.cpp (line 285)

Re: Review Request 46407: Updated balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46407/ --- (Updated June 6, 2016, 4:48 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 46407: Updated balloon executor.

> On April 21, 2016, 2:02 p.m., Vinod Kone wrote: > > src/examples/balloon_executor.cpp, line 149 > > > > > > I don't quite follow what the bug was previously that you are trying to > > fix here with a separate

Review Request 48299: Updated balloon framework spacing and logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48299/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Review Request 48300: Added fs::aufs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48300/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4672

Re: Review Request 47396: Added aufs provisioning backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47396/ --- (Updated June 6, 2016, 11:57 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/ --- (Updated June 6, 2016, 4:55 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 48300: Added fs::aufs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48300/ --- (Updated June 6, 2016, 11:56 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 46411: Removed private header from the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46411/ --- (Updated June 6, 2016, 4:55 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 48300: Added fs::aufs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48300/#review136388 --- Ship it! Ship It! - Jie Yu On June 6, 2016, 11:56 p.m.,

Review Request 48303: Split the balloon scheduler into a Process to support metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48303/ --- Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod

Re: Review Request 45905: Added metrics to the balloon framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45905/ --- (Updated June 6, 2016, 5:30 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 45905: Added metrics to the balloon framework.

> On April 21, 2016, 2:40 p.m., Vinod Kone wrote: > > src/examples/balloon_framework.cpp, line 389 > > > > > > Why do you need to store this? With the process split, we don't need to store it anymore. > On April

Re: Review Request 48300: Added fs::aufs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48300/#review136391 --- Patch looks great! Reviews applied: [48300] Passed command:

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review136387 --- src/uri/fetchers/docker.cpp (line 281)

Re: Review Request 48240: Added /dev/fd to the list of symlinks created by filesystem/linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48240/#review136226 --- Ship it! Note that this also conforms to:

Review Request 48263: Fixed documentation for MESOS-5405.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48263/ --- Review request for mesos, Till Toenshoff and Vinod Kone. Bugs: MESOS-5405