Re: Review Request 50699: Added new TaskState values and PARTITION_AWARE capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50699/ --- (Updated Aug. 23, 2016, 3:35 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50701: Added registrar operations for marking agents (un-)reachable.

> On Aug. 22, 2016, 7:39 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1907 > > > > > > do you want to get rid of this parameter (in a different review and for > > all operations) because this is no

Re: Review Request 51272: Refactored the agent 'launcher' flag to always have a value.

> On Aug. 22, 2016, 7 p.m., Jie Yu wrote: > > src/local/local.cpp, lines 343-350 > > > > > > I'd suggest we move this logic down below. more readable to me (current > > logic is broken into two pieces). > > ```

Review Request 51343: Refactored the redundant logic in provisioner recover().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review146439 --- Ship it! Will commit with the following edits.

Re: Review Request 51272: Refactored the agent 'launcher' flag to always have a value.

> On Aug. 23, 2016, 2:30 p.m., Qian Zhang wrote: > > src/local/local.cpp, line 345 > > > > > > Do we need to check if `launcher` is already `"posix"` first? Yes! - Benjamin

Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51317/#review146562 --- Fix it, then Ship it! src/master/master.cpp (line 3366)

Re: Review Request 51318: Added a TODO to CHECK resource arithemtic invariant when launching task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51318/#review146564 --- Fix it, then Ship it! src/master/master.cpp (lines 3850 -

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/#review146552 --- Ship it! Ship It! - Zameer Manji On Aug. 23, 2016, 10:34

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/#review146559 --- Fix it, then Ship it! src/master/http.cpp (line 842)

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/ --- (Updated Aug. 23, 2016, 5:55 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51319: Removed a hard CHECK for ExecutorInfo.framework_id.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51319/#review146565 --- Ship it! src/tests/master_validation_tests.cpp (line 696)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146480 --- This can also help

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/ --- (Updated Aug. 23, 2016, 8:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51277: Added an 'ns::enter' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51277/#review146575 --- src/linux/ns.hpp (line 230)

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/#review146566 --- Fix it, then Ship it! Modulo Vinod's comment.

Re: Review Request 51272: Refactored the agent 'launcher' flag to always have a value.

> On Aug. 22, 2016, 7 p.m., Jie Yu wrote: > > src/local/local.cpp, lines 343-350 > > > > > > I'd suggest we move this logic down below. more readable to me (current > > logic is broken into two pieces). > > ```

Review Request 51347: Fixed distcheck build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51347/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Vinod Kone.

Re: Review Request 51278: Refactored LinuxLauncher to be nested container aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51278/#review146532 --- src/slave/containerizer/mesos/linux_launcher.hpp (lines 20 - 22)

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/ --- (Updated Aug. 23, 2016, 8:16 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51347: Fixed distcheck build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51347/#review146567 --- Ship it! Ship It! - Jie Yu On Aug. 23, 2016, 8:21 p.m.,

Re: Review Request 50836: Made add/subtract resource object as private method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50836/ --- (Updated 八月 23, 2016, 10:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

> On 八月 1, 2016, 10:39 p.m., Jiang Yan Xu wrote: > > Can we keep add/subtract private? The fact they were added to save some > > redudant work suggests their `private` nature. Otherwise what if people use > > `add` directly instead of `+=`? > > > > Looks like they were changed to public just

Re: Review Request 51299: Fixed memory leak in master during framework teardown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51299/ --- (Updated Aug. 23, 2016, 3:49 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50836: Made add/subtract resource object as private method.

> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 50836: Made add/subtract resource object as private method.

> On 八月 16, 2016, 11:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146588 --- src/master/allocator/mesos/hierarchical.hpp (line 380)

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 23, 2016, 2:26 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1194-1195 > > > > > > `delay` already contains `dispatch`, so under "synchronously" you > > actually

Re: Review Request 50836: Made add/subtract resource object as private method.

> On Aug. 16, 2016, 4:44 p.m., Jiang Yan Xu wrote: > > include/mesos/resources.hpp, line 59 > > > > > > I think it would still work if you keep the `static` keyword right? > > > > The `friend` keyword

Re: Review Request 51325: Removed unused function `os::dirent_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51325/#review146601 --- Patch looks great! Reviews applied: [51324, 51325] Passed

Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.

> On 八月 23, 2016, 8:45 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 3362 > > > > > > The current logic is that the task with duplicate ID will be ignored > > and will not be launched, so which task

Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.

> On 八月 23, 2016, 8:45 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 3366 > > > > > > I saw that this only occur if the task authorization failed for now, > > shall we highlight this in the comments

Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51293/#review146608 --- Ship it! Ship It! - Qian Zhang On Aug. 23, 2016, 9:58 p.m.,

Re: Review Request 51294: Removed unnecessary statements in `CgroupsIsolatorProcess::_watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51294/#review146609 --- Patch looks great! Reviews applied: [51293, 51294] Passed

Re: Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/#review146615 --- Patch looks great! Reviews applied: [51342] Passed command:

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146591 --- This patch really improved the performance a lot for allocator, I

Re: Review Request 51321: Added a test to ensure the master handles launching task groups.

> On 八月 24, 2016, 12:41 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 548 > > > > > > ASSERT_EQ(runTaskGroupMessage->task_group(), 2); I think that we are always putting the `expected value` as

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146592 --- Patch looks great! Reviews applied: [51009, 51052] Passed

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50523/ --- (Updated Aug. 24, 2016, 12:56 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 51351: Update HttpDockerExecutor with v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51351/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Qian Zhang, and

Review Request 51352: Make docker executor unversioned.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51352/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Qian Zhang, and

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146585 --- Fix it, then Ship it! src/master/master.cpp (line 3257)

Re: Review Request 51321: Added a test to ensure the master handles launching task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51321/#review146597 --- Fix it, then Ship it! src/tests/scheduler_tests.cpp (line

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

> On Aug. 21, 2016, 3 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1021 > > > > > > I'd prefer > > > > ``` > > if (!deviceInspect.isSome()) { > > return Nothing(); > >

Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.

> On Aug. 23, 2016, 8:45 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 3362 > > > > > > The current logic is that the task with duplicate ID will be ignored > > and will not be launched, so which task

Review Request 51342: Printed out the received stream ID in scheduler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51342/ --- Review request for mesos, Anand Mazumdar, Vinod Kone, and Zameer Manji. Bugs:

Re: Review Request 51316: Documented 'Kill' behavior for task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51316/#review146561 --- Fix it, then Ship it! include/mesos/scheduler/scheduler.proto

Review Request 51359: Added unit test for provisioner helper findContainerDir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Review Request 51324: Replaced use of `readdir_r` with `readdir`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51324/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6013

Review Request 51325: Removed unused function `os::dirent_size`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51325/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6013

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146499 --- src/master/allocator/mesos/hierarchical.cpp (lines 275 - 278)

Re: Review Request 51294: Removed unnecessary statements in `CgroupsIsolatorProcess::_watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51294/#review146487 --- Ship it! Ship It! - Qian Zhang On Aug. 23, 2016, 12:11

Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 51317: Documented a bug with the use of `pendingTasks` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51317/#review146492 --- src/master/master.cpp (line 3362)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:32 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51293/#review146486 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:24 a.m.) Review request for . Bugs: MESOS-3157

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Aug. 23, 2016, 8:24 a.m.) Review request for . Bugs: MESOS-3157

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146497 --- You may want to update the `Description` section to make sure

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 18, 2016, 12:38 a.m., Guangya Liu wrote: > > Can you please also clarify some difference with > > https://reviews.apache.org/r/41658/, as here the work is carry from > > https://reviews.apache.org/r/41658/ , I think that this is more simple and > > clear compared with counter in

Review Request 51328: Added some missing includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51328/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 51329: Fixed incorrect html in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51329/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 51329: Fixed incorrect html in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51329/ --- (Updated Aug. 23, 2016, 12:41 p.m.) Review request for mesos and Till

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146501 --- src/master/master.cpp (line 93)

Re: Review Request 51321: Added a test to ensure the master handles launching task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51321/#review146510 --- src/tests/scheduler_tests.cpp (lines 504 - 506)

Review Request 51333: Fixed typos in upgrade doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51333/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 51333: Fixed typos in upgrade doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51333/#review146525 --- Ship it! Ship It! - Till Toenshoff On Aug. 23, 2016, 2:24

Re: Review Request 51272: Refactored the agent 'launcher' flag to always have a value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51272/#review146505 --- src/local/local.cpp (line 345)

Re: Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`.

> On Aug. 23, 2016, 7:54 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 99 > > > > > > I think we are not returning `Nothing`, instead we are returning > >

Re: Review Request 51293: Fixed a typo in the comment of `Subsystem::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51293/ --- (Updated Aug. 23, 2016, 1:58 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51294: Removed unnecessary statements in `CgroupsIsolatorProcess::_watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51294/ --- (Updated Aug. 23, 2016, 1:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51328: Added some missing includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51328/ --- (Updated Aug. 23, 2016, 2:45 p.m.) Review request for mesos and Till

Re: Review Request 51328: Added some missing includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51328/#review146513 --- Ship it! Ship It! - Till Toenshoff On Aug. 23, 2016, 12:45

Re: Review Request 51283: Fixed broken link in multiple disk documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51283/#review146515 --- Ship it! Ship It! - Till Toenshoff On Aug. 22, 2016, 9:22

Re: Review Request 51329: Fixed incorrect html in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51329/#review146514 --- Ship it! Ship It! - Till Toenshoff On Aug. 23, 2016, 12:41

Re: Review Request 51147: Corrected typo in docker_build example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51147/#review146516 --- Ship it! Ship It! - Till Toenshoff On Aug. 16, 2016, 8:25