Re: Review Request 51096: Added the `mesos-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/#review146780 ---

Re: Review Request 50707: Added test for agent removal behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- (Updated Aug. 25, 2016, 2:30 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 2:16 p.m.) Review request for mesos, Alexander

Re: Review Request 51374: Modified registry update protocol on removal / reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Aug. 25, 2016, 2:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51257: Add external process container logger.

> On Aug. 22, 2016, 6:03 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 171 > > > > > > Can you un-remove all these un-related `cpuacct` changes? Weird, my local branch history doesn't show these in it. I

Review Request 51021: Added GC of unreachable agent metadata from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5965

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/#review146781 --- Patch looks great! Reviews applied: [51266, 49555, 50657, 49556,

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 1:26 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 25, 2016, 1:25 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 1:24 p.m.) Review request for mesos, Alexander

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/#review146776 --- src/health-check/health_checker.hpp (line 52)

Re: Review Request 49360: Supported TCP in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review146777 --- src/health-check/health_checker.cpp (line 452)

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51086: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaTCP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51086/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51085: Added `HealthCheckTest.ROOT_DOCKER_DockerHealthyTaskViaHTTP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51085/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51378/ --- (Updated Aug. 25, 2016, 12:35 p.m.) Review request for mesos, Alexander

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 49556: Removed the binary way of HealthCheck in src.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49556/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 49360: Supported TCP in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ --- (Updated Aug. 25, 2016, 12:34 p.m.) Review request for mesos, Alexander

Re: Review Request 50657: Removed the binary way of health check in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50657/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 49555: Updated mesos-docker-executor to use health check via library way.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49555/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 12:33 p.m.) Review request for mesos, Alexander

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review146774 --- Patch looks great! Reviews applied: [51323, 51343, 51358, 51359,

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:28 a.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:26 a.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:22 a.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:19 a.m.) Review request for mesos, Alexander

Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ --- (Updated Aug. 25, 2016, 10:12 a.m.) Review request for mesos, Alexander

Re: Review Request 51411: Added provisioner tests to provision using meta discovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51411/#review146770 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 25, 2016, 9:38 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 51425: Added missed headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51425/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 20-25 > > > > > > What does adding all of these headers have to do with this patch? They > > may be needed, but I don't

Re: Review Request 51379: Entered the appropriate namespaces of the task during health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51379/ --- (Updated Aug. 25, 2016, 9:33 a.m.) Review request for mesos, Alexander

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

> On Aug. 22, 2016, 7:43 p.m., Vinod Kone wrote: > > src/master/metrics.hpp, lines 183-184 > > > > > > can you add this to the CHANGELOG for 1.1 under "Deprecations" section? Done. Note that I haven't yet attempted

Re: Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- (Updated Aug. 25, 2016, 9:09 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51418: Updated a few comments in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51418/#review146767 --- Patch looks great! Reviews applied: [51388, 51389, 51390, 51391,

Re: Review Request 51418: Updated a few comments in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51418/#review146764 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:21

Re: Review Request 51417: Removed a NOTE in MesosContainerizer that no longer applies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51417/#review146763 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:21

Re: Review Request 51415: A few consistency fix on indentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51415/#review146762 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:20

Re: Review Request 51414: Fixed the using statements in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51414/#review146761 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:20

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Aug. 25, 2016, 8:23 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51409: Printed all the isolator cleanup errors during destory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51409/#review146760 --- Fix it, then Ship it!

Review Request 51421: Added provisioner appc unit test for recovering nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Review Request 51420: Added provisioner appc unit test for provisioning nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 25, 2016, 8:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51419: Add offeredResources to Allocator::updateAllocation() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51419/ --- (Updated Aug. 25, 2016, 8:11 a.m.) Review request for mesos. Repository:

Review Request 51419: Add offeredResources to Allocator::updateAllocation() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51419/ --- Review request for mesos. Repository: mesos Description --- This is

Re: Review Request 51401: Removed 'status' in the destroy chain in MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51401/#review146758 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:22

Re: Review Request 51400: Stopped passing messages in MesosContainerizer destroy methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51400/#review146757 --- Ship it! Ship It! - Gilbert Song On Aug. 24, 2016, 10:22

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review146756 --- Patch looks great! Reviews applied: [51412, 45960, 45961, 45962,

<    1   2