Review Request 61544: WIP: Rewrote Mesos CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61544/ --- Review request for mesos, Aaron Wood, Benjamin Bannier, Chun-Hung Hsiao, Jeff

Re: Review Request 61334: Imported `http_parser` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61334/ --- (Updated Aug. 9, 2017, 7:55 p.m.) Review request for mesos. Changes ---

Re: Review Request 61365: Added `get_byproducts()` function to fix Ninja generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61365/ --- (Updated Aug. 9, 2017, 7:53 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61515/ --- (Updated Aug. 9, 2017, 7:53 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 61495: Removed table from markdown and added cross-links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review182549 --- docs/home.md Lines 70 (patched)

Re: Review Request 61511: Improved the readability of some assertions/expectations.

> On Aug. 9, 2017, 3:21 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 1 (original), 1 (patched) > > > > > > Searching with > > > > $ git grep -E

Re: Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/ --- (Updated Aug. 9, 2017, 11:48 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 9, 2017, 11:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/#review182542 --- Ship it! 3rdparty/libprocess/configure.ac Lines 957-959

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/#review182537 --- Ship it! configure.ac Lines 1727-1729 (patched)

Re: Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/ --- (Updated Aug. 9, 2017, 10:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/ --- (Updated Aug. 9, 2017, 10:46 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61535/#review182539 --- Discarding because I included these changes when committing the

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

> On Aug. 9, 2017, 6:04 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 4987-4989 (original), 4987-4989 (patched) > > > > > > Perhaps a note here saying that the master injects the executor for > >

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/ --- (Updated Aug. 9, 2017, 3:24 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 60495: Added network ports isolator listen socket utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60495/ --- (Updated Aug. 9, 2017, 8:19 p.m.) Review request for mesos, Qian Zhang and

Review Request 61538: Used common port range interval code in the port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61538/ --- Review request for mesos, Qian Zhang and Jiang Yan Xu. Bugs: MESOS-7675

Re: Review Request 61517: Refactored OpenSSL library checks in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61517/#review182519 --- Fix it, then Ship it! 3rdparty/libprocess/configure.ac Lines

Re: Review Request 61433: Refactored OpenSSL library checks in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/#review182517 --- Fix it, then Ship it! configure.ac Lines 1967-1968 (patched)

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182516 ---

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

> On Aug. 9, 2017, 11:07 a.m., James Peach wrote: > > We still need to switch to using the `major` and `minor` macros from > > `sys/sysmacros.h` so avoid the deprecation warning. > > [Here's](https://paste.fedoraproject.org/paste/QvCDIi9ZUeLG2MhVIDwhOA) what > > I would recommend. > > > >

Re: Review Request 61531: Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/ --- (Updated Aug. 9, 2017, 12:05 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61535/ --- (Updated Aug. 9, 2017, 6:58 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61535/ --- (Updated Aug. 9, 2017, 6:57 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61534/ --- (Updated Aug. 9, 2017, 6:56 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61534/ --- (Updated Aug. 9, 2017, 6:55 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61535/#review182513 --- Ship it! src/slave/slave.hpp Lines 399-400 (original),

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

> On Aug. 9, 2017, 6:04 p.m., Benjamin Mahler wrote: > > src/slave/slave.cpp > > Lines 4987-4989 (original), 4987-4989 (patched) > > > > > > Perhaps a note here saying that the master injects the executor for > >

Re: Review Request 61534: Added test to verify the fix for a failed agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61534/#review182511 --- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 1825

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/#review182510 --- Ship it! Ship It! - Greg Mann On Aug. 9, 2017, 1:14 p.m.,

Review Request 61535: Updated comments for the agent's 'getExecutorInfo()' helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61535/ --- Review request for mesos, Andrei Budnik and Benjamin Mahler. Bugs: MESOS-7871

Review Request 61534: Added test to verify the fix for a failed agent assertion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61534/ --- Review request for mesos, Andrei Budnik and Benjamin Mahler. Bugs: MESOS-7871

Re: Review Request 61531: [WIP] Fixed the device number proto 'major' and 'minor' to avoid MACROs.

> On Aug. 9, 2017, 6:07 p.m., James Peach wrote: > > We still need to switch to using the `major` and `minor` macros from > > `sys/sysmacros.h` so avoid the deprecation warning. > > [Here's](https://paste.fedoraproject.org/paste/QvCDIi9ZUeLG2MhVIDwhOA) what > > I would recommend. > > > > ```

Re: Review Request 61531: [WIP] Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/#review182503 --- We still need to switch to using the `major` and `minor` macros

Re: Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/#review182502 --- Ship it! Can we also add a test that ensures that getting the

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 9, 2017, 5:54 p.m.) Review request for mesos, Armand Grillet,

Review Request 61531: [WIP] Fixed the device number proto 'major' and 'minor' to avoid MACROs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61531/ --- Review request for mesos, Ilya Pronin, Jie Yu, James Peach, Qian Zhang, and

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182495 --- docs/health-checks.md Line 29 (original), 29 (patched)

Review Request 61530: Enabled retries for `killTasks` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61530/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-6743

Re: Review Request 61458: Added documentation of parallel test execution config flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61458/#review182492 --- Ship it! Ship It! - Till Toenshoff On Aug. 7, 2017, 11:52

Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60646/#review182491 --- Ship it! Ship It! - Till Toenshoff On Aug. 7, 2017, 10:30

Re: Review Request 61495: Removed table from markdown and added cross-links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/ --- (Updated Aug. 9, 2017, 3:41 p.m.) Review request for mesos, Alexander

Re: Review Request 61511: Improved the readability of some assertions/expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61511/#review182488 --- Fix it, then Ship it! Thanks for the cleanup Gaston! Until

Re: Review Request 61434: Updated health-checks.md to include description of generalized checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61434/#review182485 --- Patch looks great! Reviews applied: [61434] Passed command:

Review Request 61524: Moved task validation from `getExecutorInfo` to `runTask` on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61524/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review182479 --- Ship it! Testing done: ``` install tox cd src/python/lib tox

Re: Review Request 61137: Cleaned up style in example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/#review182475 --- Ship it! - Benno Evers On Aug. 7, 2017, 1:53 p.m., Armand