Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/ --- (Updated Nov. 20, 2017, 10:59 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61154: Added safe downcasts for Socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/#review191486 --- 3rdparty/libprocess/include/process/socket.hpp Lines 510-513

Review Request 63959: Optimized resources logging and conversion in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63959/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.

> On Nov. 17, 2017, 5:49 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/composing.cpp > > Lines 389 (patched) > > > > > > Can't you simply pass `ContainerTermination` to `set()`? No, it's not

Re: Review Request 63959: Optimized resources logging and conversion in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63959/#review191516 --- FAIL: Failed to apply the current review. Failed command:

Review Request 63960: Preallocated buffer for resources conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63960/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 63888: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63888/#review191518 --- FAIL: mesos-java failed to build. Reviews applied: `['63887',

Re: Review Request 63960: Preallocated buffer for resources conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63960/#review191528 --- FAIL: mesos-java failed to build. Reviews applied: `['63960']`

Re: Review Request 63959: Optimized resources logging and conversion in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63959/#review191530 --- FAIL: Failed to apply the dependent review: 63638. Failed

Review Request 63963: Windows: Fixed HTTP server build and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63963/ --- Review request for mesos, Benjamin Hindman and Benjamin Mahler. Repository:

Re: Review Request 62635: Added an optional `additional_chars` parameter to `http::encode`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62635/ --- (Updated Nov. 20, 2017, 11:44 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63888: Updated composing containerizer tests.

> On Nov. 17, 2017, 6:09 p.m., Alexander Rukletsov wrote: > > src/tests/containerizer/composing_containerizer_tests.cpp > > Line 184 (original), 203 (patched) > > > > > > Why do you change this condition? I think

Re: Review Request 63963: Windows: Fixed HTTP server build and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63963/#review191542 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Re: Review Request 63963: Windows: Fixed HTTP server build and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63963/#review191543 --- Ship it! Ship It! - Andrew Schwartzmeyer On Nov. 20, 2017,

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review191540 --- Fix it, then Ship it! include/mesos/v1/agent/agent.proto

Review Request 63967: Updated the gRPC client to return both status and payload.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63967/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Review Request 63968: Updated the CSI client to use the new gRPC client interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63968/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 63968: Updated the CSI client to use the new gRPC client interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63968/#review191544 --- FAIL: Failed to apply the dependent review: 63966. Failed

Re: Review Request 63963: Windows: Fixed HTTP server build and tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63963/#review191539 --- 3rdparty/libprocess/src/tests/http_tests.cpp Line 2348

Review Request 63966: Bumped the CSI version to ec29890.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63966/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 63376: Started `LocalResourceProviderDaemon` after obtaining the slave ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63376/ --- (Updated Nov. 20, 2017, 11:15 p.m.) Review request for mesos, Benjamin

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/#review191537 --- Fix it, then Ship it! I will address them for you.

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Nov. 20, 2017, 12:39 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63943: Renamed `TaskStatusEq()` to `TaskStatusTaskIdEq()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63943/#review191534 --- Ship it! Ship It! - Gaston Kleiman On Nov. 19, 2017, 6:44

Re: Review Request 62762: Added `LocalResourceProvider::principal()` for authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62762/ --- (Updated Nov. 21, 2017, 12:07 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 62636: Generated authentication tokens for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62636/ --- (Updated Nov. 21, 2017, 12:10 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 63968: Updated the CSI client to use the new gRPC client interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63968/#review191554 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 20, 2017, 10:42

Review Request 63969: Storage local resource provider is built when gRPC is enabled on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63969/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-8100

Re: Review Request 63967: Updated the gRPC client to return both status and payload.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63967/#review191552 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 20, 2017, 10:42

Re: Review Request 63966: Bumped the CSI version to ec29890.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63966/#review191553 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 20, 2017, 10:41

Re: Review Request 62637: Added an object approver to authorize requests from resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62637/ --- (Updated Nov. 21, 2017, 1:14 a.m.) Review request for mesos, Alexander Rojas,

Review Request 63976: Modified `downgradeResources` to use protobuf reflection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63976/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8221

Review Request 63977: Used the protobuf-reflection-based `downgradeResources` utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63977/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8221

Re: Review Request 63377: Added filesystem layout for CSI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/ --- (Updated Nov. 21, 2017, 5:36 a.m.) Review request for mesos, Jie Yu, Joseph

Re: Review Request 63904: Updated the top-level `CSIPluginInfo` proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63904/ --- (Updated Nov. 21, 2017, 5:32 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63018: Added filesystem layout for local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63018/ --- (Updated Nov. 21, 2017, 5:34 a.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 61154: Added safe downcasts for Socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/#review191505 --- FAIL: Failed to apply the dependent review: 55323. Failed

Re: Review Request 63104: Added a helper to extract resources from storage operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63104/#review188660 --- Fix it, then Ship it! This helper seems generally useful.

Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/#review191493 --- FAIL: mesos-java failed to build. Reviews applied: `['63911',

Review Request 63951: Added noexcept specifier to Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63951/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Re: Review Request 63951: Added noexcept specifier to Option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63951/#review191510 --- FAIL: mesos-java failed to build. Reviews applied: `['63951']`