Re: Review Request 65748: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65748/#review198100 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 65127: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65127/#review198107 --- Fix it, then Ship it! src/checks/checker_process.cpp Lines

Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65748: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65748/ --- (Updated Feb. 22, 2018, 10:20 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/#review198104 --- Just realized this binary is not necessary - it would be simpler

Review Request 65748: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65748/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.

Review Request 65749: Added a new binary to test a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65615: Added docker constants and common functions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review198108 --- To simplify reviewing, in the future please separate refactoring

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review198109 --- src/tests/environment.cpp Line 80 (original), 85-87 (patched)

Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64604/#review198110 --- Fix it, then Ship it! docs/health-checks.md Lines 384-386

Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65758/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8336

Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65758/#review198128 --- PASS: Mesos patch 65758 was successfully built and tested.

Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65758/#review198132 --- Patch looks great! Reviews applied: [65758] Passed command:

Re: Review Request 65615: Added docker constants and common functions file.

> On Feb. 22, 2018, 3:25 a.m., Alexander Rukletsov wrote: > > src/Makefile.am > > Lines 1276 (patched) > > > > > > What about CMake? Headers are free in CMake. - Andrew

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198122 --- Patch looks great! Reviews applied: [65713] Passed command:

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198139 --- PASS: Mesos patch 65759 was successfully built and tested.

Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/#review198144 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/ --- (Updated Feb. 22, 2018, 11:10 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65748: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65748/ --- (Updated Feb. 22, 2018, 11:28 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/#review198149 --- Ship it! Ship It! - Jie Yu On Feb. 20, 2018, 6:43 p.m.,

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/ --- (Updated Feb. 23, 2018, 12:12 a.m.) Review request for mesos, James DeFelice,

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:46 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198145 --- Patch looks great! Reviews applied: [65713, 65759] Passed

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:56 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/ --- (Updated Feb. 22, 2018, 10:57 p.m.) Review request for mesos and Andrei

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 11:28 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- (Updated Feb. 22, 2018, 11:28 p.m.) Review request for mesos, Alexander

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198146 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Feb. 22, 2018, 11:18 p.m.) Review request for mesos, Alexander

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ --- (Updated Feb. 22, 2018, 11:19 p.m.) Review request for mesos, Alexander

Re: Review Request 65749: Added a new binary to test a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65749/ --- (Updated Feb. 22, 2018, 11:24 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198152 --- Bad patch! Reviews applied: [65750, 65751, 65743, 65683] Failed

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198154 --- src/docker/docker.cpp Lines 1314-1315 (patched)

Re: Review Request 65718: Allowed empty resource provider selector in `UriDiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65718/#review198155 --- PASS: Mesos patch 65718 was successfully built and tested.

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198156 --- PASS: Mesos patch 65728 was successfully built and tested.

Re: Review Request 65728: Add test to check quotes in docker executor health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65728/#review198157 --- Patch looks great! Reviews applied: [65393, 65394, 65395, 65396,

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 22, 2018, 10:55 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/ --- (Updated Feb. 23, 2018, 7:58 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 23, 2018, 7:46 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198120 --- PASS: Mesos patch 65713 was successfully built and tested.

Re: Review Request 65307: Cleaned up interface defintion in duration header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65307/ --- (Updated Feb. 22, 2018, 3:14 p.m.) Review request for mesos. Repository:

Review Request 65532: Add jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65532/ --- Review request for mesos. Repository: mesos Description --- Add

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65588/#review198116 --- Ship it! Ship It! - Jan Schlicht On Feb. 15, 2018, 3:54

Re: Review Request 65590: Added helper function to determine provider ID of a conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65590/#review198117 --- Ship it! Ship It! - Jan Schlicht On Feb. 14, 2018, 4:11

Re: Review Request 65673: Added evolve function for mesos UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65673/#review198118 --- Ship it! Ship It! - Jan Schlicht On Feb. 15, 2018, 3:54

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198119 --- Ship it! Ship It! - Jan Schlicht On Feb. 15, 2018, 3:54