Re: Review Request 66256: Removed non minified third party JS library files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66256/#review199924 --- Ship it! Ship It! - Benjamin Mahler On March 23, 2018, 8:11

Re: Review Request 66257: Added licenses for third party JS libraries used by Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66257/#review199923 --- Ship it! Ship It! - Benjamin Mahler On March 23, 2018, 8:13

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review199862 --- src/master/master.cpp Lines 6027 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/#review199858 --- src/slave/slave.cpp Lines 2174 (patched)

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

> On March 23, 2018, 6 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 2406-2407 (patched) > > > > > > Let's use this opportunity to improve this error message. The precise > > reason for denied

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/#review199859 --- src/slave/slave.cpp Lines 2350 (patched)

Re: Review Request 66144: Enforced task launch order on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199857 --- src/slave/slave.hpp Lines 1147-1152 (patched)

Re: Review Request 66123: Temporarily disabled some default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66123/#review199861 --- Patch looks great! Reviews applied: [66123] Passed command:

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199864 --- Ship it! Ship It! - Jan Schlicht On March 21, 2018, 3:58

Re: Review Request 66141: Fixed whitespace in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66141/#review199870 --- Patch looks great! Reviews applied: [63992, 63994, 65300, 64618,

Re: Review Request 66235: Added a reference to MESOS-8557 to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66235/#review199875 --- Patch looks great! Reviews applied: [65692, 65693, 66232, 65694,

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/ --- (Updated March 23, 2018, 7:46 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 66037: Enabled agent resource provider capability by default.

> On March 23, 2018, 6:29 p.m., Gaston Kleiman wrote: > > src/tests/scheduler_tests.cpp > > Lines 1121-1136 (patched) > > > > > > Nit: this might be a matter of taste, but I think that the following is > > easier

Re: Review Request 66248: Re-enabled SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/#review199908 --- Patch looks great! Reviews applied: [66248] Passed command:

Re: Review Request 65695: Made the default executor allow schedulers to retry task kills.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65695/ --- (Updated March 23, 2018, 10:51 a.m.) Review request for mesos, Alexander

Re: Review Request 65855: Added the `stall_timeout` parameter to `net::download()`.

> On March 21, 2018, 10:35 p.m., Gilbert Song wrote: > > 3rdparty/stout/include/stout/net.hpp > > Lines 144 (patched) > > > > > > I think we follow the style that naming parameter as `stallTimeout` The Mesos C++

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199900 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199906 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66256: Removed non minified third party JS library files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66256/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 66257: Added licenses for third party JS libraries used by Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66257/#review199912 --- PASS: Mesos patch 66257 was successfully built and tested.

Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66255/ --- (Updated March 23, 2018, 8:44 p.m.) Review request for mesos, Benno Evers, Jie

Review Request 66257: Added licenses for third party JS libraries used by Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66257/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 66259: Added max_duration support to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66259/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Review Request 66260: Added test for max duration support in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66260/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Review Request 66258: Added max_duration to `TaskInfo` and new reason for kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66258/ --- Review request for mesos, Jason Lai and James Peach. Bugs: MESOS-8725

Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66255/ --- Review request for mesos, Benno Evers, Jie Yu, James Peach, Kapil Arya, and

Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66255/#review199914 --- FAIL: Failed to apply the dependent review: 66210. Failed

Review Request 66248: Re-enabled SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-8711

Re: Review Request 63733: Don't print full usage for invocation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63733/ --- (Updated March 23, 2018, 2:39 p.m.) Review request for mesos. Repository:

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199918 --- Patch looks great! Reviews applied: [66037] Passed command:

Re: Review Request 66260: Added test for max duration support in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66260/#review199916 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 22, 2018, 6:19 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 426 (patched) > > > > > > Document the invariants by adding > > ``` > >

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated March 23, 2018, 4:13 p.m.) Review request for mesos and James Peach.

Re: Review Request 63733: Don't print full usage for invocation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63733/#review199894 --- PASS: Mesos patch 63733 was successfully built and tested.

Re: Review Request 66248: Re-enabled SlaveTest.ChangeDomain.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66248/#review199889 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 63733: Don't print full usage for invocation errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63733/#review199890 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 66037: Enabled agent resource provider capability by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66037/#review199898 --- I only looked at https://reviews.apache.org/r/66037/diff/3-4/,

Re: Review Request 66232: Removed unnecessary/invalid checks from the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66232/ --- (Updated March 23, 2018, 10:49 a.m.) Review request for mesos, Alexander

Re: Review Request 66255: Temporarily disabled CSI proto compilation when gRPC is disabled.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66255/#review199925 --- Patch looks great! Reviews applied: [66210, 66255] Passed