----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66144/#review199857 -----------------------------------------------------------
src/slave/slave.hpp Lines 1147-1152 (patched) <https://reviews.apache.org/r/66144/#comment280335> Nice comment :) src/slave/slave.cpp Lines 2220-2222 (patched) <https://reviews.apache.org/r/66144/#comment280343> See my comment in a prevous review regarding implicit capture of the framework pointer. src/slave/slave.cpp Lines 2231-2235 (patched) <https://reviews.apache.org/r/66144/#comment280339> These comments are quite good! src/slave/slave.cpp Lines 2237 (patched) <https://reviews.apache.org/r/66144/#comment280340> s/direct/directing/ src/slave/slave.cpp Lines 2477 (patched) <https://reviews.apache.org/r/66144/#comment280341> s/exist/exists/ src/slave/slave.cpp Lines 2510 (patched) <https://reviews.apache.org/r/66144/#comment280350> We already know that framework is not nullptr here, and below. src/slave/slave.cpp Lines 2906-2910 (patched) <https://reviews.apache.org/r/66144/#comment280342> In this case, the executor struct exists - do we really want to erase the sequence here? - Greg Mann On March 22, 2018, 7:07 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66144/ > ----------------------------------------------------------- > > (Updated March 22, 2018, 7:07 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8617 and MESOS-8624 > https://issues.apache.org/jira/browse/MESOS-8617 > https://issues.apache.org/jira/browse/MESOS-8624 > > > Repository: mesos > > > Description > ------- > > Up until now, Mesos does not guarantee in-order > task launch on the agent. There are two asynchronous > steps (unschedule GC and task authorization) in the > agent task launch path. Depending on the CPU scheduling > order, a later task launch may finish these two steps earlier > than its predecessors and get to the launch executor stage > earlier, resulting in out-of-order task delivery. > > This patch enforces the task delivery order by sequencing > task launch after the two asynchronous steps, specifically > right before entering `__run()`. > > > Diffs > ----- > > src/slave/slave.hpp 37f0361251524e63d02d251e8a03901812b8affb > src/slave/slave.cpp e76daabad0d2d68aa42d1da809d4a23459eaaacb > > > Diff: https://reviews.apache.org/r/66144/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
