Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 6:32 a.m., Zhitao Li wrote: > > src/slave/slave.cpp > > Lines 8053-8059 (patched) > > > > > > Sorry I'm not following this comment. > > > > From what I can read, the sequence here is:

Re: Review Request 66234: Fixed variable shadowing in the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66234/ --- (Updated March 27, 2018, 9:43 a.m.) Review request for mesos and Alexander

Re: Review Request 66219: Added helper functions to create grow and shrink volume in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66219/ --- (Updated March 26, 2018, 11:38 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 22, 2018, 3:43 p.m., Chun-Hung Hsiao wrote: > > src/common/resources_utils.cpp > > Lines 199-261 (patched) > > > > > > We should not speculatively carve out the conversion here. Let's wait > > for the

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66218/ --- (Updated March 26, 2018, 11:36 p.m.) Review request for mesos, Chun-Hung

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review199818 --- src/master/validation.cpp Lines 2393 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 22, 2018, 3:43 p.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2354 (patched) > > > > > > Let's do the following in order. > > > > First, general validations: > > -

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200078 --- Patch looks great! Reviews applied: [66314] Passed command:

Re: Review Request 66143: Refactored agent task launch for better composition [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66143/ --- (Updated March 27, 2018, 6:07 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200081 --- Patch looks great! Reviews applied: [66318] Passed command:

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review200086 --- src/master/master.cpp Lines 11881-11887 (original), 11885-11890

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

> On March 28, 2018, 2:36 a.m., James DeFelice wrote: > > include/mesos/agent/agent.proto > > Line 327 (original), 331 (patched) > > > > > > "Note that only..." > > > > I don't think this statement is true.

Re: Review Request 66326: Added tests for agent resource provider API idempotency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66326/#review200093 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Re: Review Request 66327: WIP: Added the `LIST_RESOURCE_PROVIDER_CONFIGS` agent API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66327/#review200095 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66322: Fixed a potential race in `Sequence`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66322/#review200092 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200089 --- include/mesos/agent/agent.proto Line 321 (original), 325

Re: Review Request 66218: Ensured that agent does not delete volume upon grow or shrink.

> On March 27, 2018, 12:14 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 4169-4184 (patched) > > > > > > This is not a `set` operation but a `hashset` operation, so the > > comments are incorrect.

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66051/#review200051 --- src/master/http.cpp Lines 1525-1526 (patched)

Re: Review Request 66126: Refactored agent task launch for better composition [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66126/ --- (Updated March 27, 2018, 6:05 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

> On March 28, 2018, 1:58 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 11881-11887 (original), 11885-11890 (patched) > > > > > > Currently, it looks like `Slave::usedResources` is the same as the >

Re: Review Request 66322: Fixed a potential race in `Sequence`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66322/#review200090 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/ --- (Updated March 28, 2018, 3:22 a.m.) Review request for mesos, Benjamin

Review Request 66322: Fixed a potential race in `Sequence`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66322/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. Bugs:

Review Request 66326: Added tests for agent resource provider API idempotency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66326/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Review Request 66325: Implemented idempotency for agent resource provider config API calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66325/ --- Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu. Bugs:

Re: Review Request 66318: Made agent resource provider config API calls idempotent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66318/#review200080 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66308: Delayed construction of the agent's resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66308/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735

Review Request 66311: Implement recovery of resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66311/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735

Review Request 66307: Added implicit conversion from nullptr to Owned and Shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66307/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.

Review Request 66310: Passed on registrar when constructing resource provider manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66310/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735

Review Request 66309: Externalize creation of resource provider manager backing storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66309/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8735

Re: Review Request 66052: Added new operator API to grow and shrink persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66052/#review200052 --- include/mesos/master/master.proto Lines 187 (patched)

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review25 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 30

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review200053 --- include/mesos/mesos.proto Lines 1970 (patched)

Review Request 66313: Fixed an oversubscription test for agent registration backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66313/ --- Review request for mesos, Alexander Rukletsov and Till Toenshoff. Bugs:

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200057 --- Running the test, I get this failure: ```

Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- Review request for mesos. Bugs: MESOS-4176

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review200055 --- src/common/resources_utils.cpp Lines 203-205 (patched)

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

> On March 27, 2018, 7:14 p.m., Greg Mann wrote: > > src/common/resources_utils.cpp > > Lines 203-205 (patched) > > > > > > This is already done in the validation code - do we need to do it again > > here? Ditto

Re: Review Request 66313: Fixed an oversubscription test for agent registration backoff.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66313/#review200068 --- Patch looks great! Reviews applied: [66313] Passed command:

Re: Review Request 66292: Validated that all tasks in the same group have same max_duration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66292/#review200070 --- What's the rationale for this? A common use of task groups is to

Re: Review Request 66307: Added implicit conversion from nullptr to Owned and Shared.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66307/#review200074 --- Ship it! Ship It! - Alexander Rukletsov On March 27, 2018,

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200073 --- FAIL: Some of the unit tests failed. Please check the relevant