Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review203734 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 11:23

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203732 --- Patch looks great! Reviews applied: [67247, 67099, 67059]

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 24, 2018, 4:24 p.m., Qian Zhang wrote: > > Ship It! A minor comment, since we fixed a tech debt (memory leak) in `ComposingContainerizerProcess::__recover()` in this patch, can you please mention it in the commit message? - Qian

Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66670/#review203736 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 11:23

Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65505/#review203739 --- Ship it! Ship It! - Qian Zhang On April 27, 2018, 1 a.m.,

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203744 --- Patch looks great! Reviews applied: [67137] Passed command:

Re: Review Request 66671: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66671/#review203738 --- Ship it! Ship It! - Qian Zhang On April 17, 2018, 11:23

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

> On May 24, 2018, 12:39 a.m., Jie Yu wrote: > > src/common/validation.hpp > > Lines 57 (patched) > > > > > > I wonder if we should just chagne `Resources::validate` given that we > > already check if

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/ --- (Updated May 24, 2018, 11:09 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review203745 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/ --- (Updated May 24, 2018, 1:13 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 67270: Fixed compilation error in libprocess example.

> On May 23, 2018, 6:39 p.m., Benjamin Bannier wrote: > > Could you follow this up with a patch which compiles the example at least > > as part of `check`? > > > > For cmake we could e.g., add a `CMakeLists.txt` to the `example/` directory > > with just > > > > add_executable(example

Re: Review Request 67280: Added libprocess example code to build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67280/#review203765 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67247/ --- (Updated mai 24, 2018, 12:56 après-midi) Review request for mesos and Andrew

Re: Review Request 67247: Added support script to check if Python >= 3.6 is available.

> On mai 23, 2018, 7:47 après-midi, Andrew Schwartzmeyer wrote: > > support/check-python3.py > > Lines 34-37 (patched) > > > > > > While `which` isn't on Windows, I'm not opening an issue as I think > > this is

Re: Review Request 67270: Fixed various issues in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/ --- (Updated May 24, 2018, 12:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203760 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67270: Fixed compilation issues in libprocess example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67270/ --- (Updated May 24, 2018, 1:33 p.m.) Review request for mesos and Benjamin

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/ --- (Updated May 24, 2018, 2:45 p.m.) Review request for mesos, Andrew

Re: Review Request 67285: Moved JWT test keys into the tests source file.

> On May 24, 2018, 4:15 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/jwt_tests.cpp > > Line 26 (original) > > > > > > I think this file is also listed in a Makefile somewhere and that > >

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/#review203774 --- Ship it! Ship It! - James Peach On May 23, 2018, 6:42 p.m.,

Re: Review Request 67059: Ported all support scripts to Python 3.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67059/#review203775 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67282: Added python3 to list of Pylint excluded files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/#review203770 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203773 --- Bad patch! Reviews applied: [67241] Failed command: python

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review203778 --- Ship it! Ship It! - Greg Mann On April 17, 2018, 3:23 p.m.,

Re: Review Request 67285: Moved JWT test keys into the tests source file.

> On May 24, 2018, 9:15 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/jwt_tests.cpp > > Line 26 (original) > > > > > > I think this file is also listed in a Makefile somewhere and that > >

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203768 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 66822,

Re: Review Request 67285: Moved JWT test keys into the tests source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67285/#review203776 --- Fix it, then Ship it! Oh it was `make dist` that was failing

Re: Review Request 67285: Moved JWT test keys into the tests source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67285/#review203786 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67282: Added python3 to list of Pylint excluded files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/#review203784 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 24, 2018,

Review Request 67289: Introduced an overload for os::environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67289/ --- Review request for mesos, Andrew Schwartzmeyer and James Peach. Repository:

Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/ --- Review request for mesos, Andrew Schwartzmeyer and James Peach. Repository:

Review Request 67290: Removed an unneeded test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67290/ --- Review request for mesos and James Peach. Repository: mesos Description

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/#review203789 --- src/tests/slave_tests.cpp Lines 1041-1049 (original), 1037-1045

Review Request 67285: Moved JWT test keys into the tests source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67285/ --- Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. Repository:

Re: Review Request 67130: Updated comments related to `wait`, `destroy` containerizer methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67130/#review203780 --- Ship it! Ship It! - Greg Mann On May 15, 2018, 1:50 p.m.,

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203792 --- we need to update `configure.md` correspondingly. - Gilbert Song

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/#review203791 --- Fix it, then Ship it! usually we start the commit msg with a

Review Request 67292: Added warning to Python version checker script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67292/ --- Review request for mesos and Armand Grillet. Repository: mesos Description

Re: Review Request 67274: Rejected non-zero scalar resource values which be represented as zero.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review203797 --- Patch looks great! Reviews applied: [67274] Passed command:

Re: Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/#review203795 --- 3rdparty/stout/include/stout/internal/windows/inherit.hpp Lines

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/ --- (Updated May 24, 2018, 6:43 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/#review203793 --- It seems to me that most of the modified tests work just fine

Re: Review Request 67292: Added warning to Python version checker script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67292/#review203801 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8926

Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/ --- Review request for mesos, Akash Gupta and Andrew Schwartzmeyer. Bugs:

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/#review203794 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67287/#review203800 --- Please fix up the commit message. - Andrew Schwartzmeyer On

Re: Review Request 67291: Adjusted the tests that use nobody.

> On May 24, 2018, 7:29 p.m., Chun-Hung Hsiao wrote: > > It seems to me that most of the modified tests work just fine with > > `nobody`. For example, the `FetcherTest` and `CapabilitiesTest` don't need > > an unpriviledged user that can access test launcher's home. Are we > > advocating a

Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/ --- (Updated May 24, 2018, 6:43 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67286: White list fds that child processes can inherit in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67286/ --- (Updated May 24, 2018, 6:44 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67291: Adjusted the tests that use nobody.

> On May 24, 2018, 7:29 p.m., Chun-Hung Hsiao wrote: > > src/tests/environment.cpp > > Lines 871 (patched) > > > > > > Should we also test that `$SUDO_USER` is not `root`? Yes! good catch! - Jie

Re: Review Request 67285: Moved JWT test keys into the tests source file.

> On May 24, 2018, 9:59 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67285']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67271: Renamed an ambiguous variable in network port isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 24, 2018, 6:17 p.m.) Review request for mesos and James Peach.

Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/#review203798 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67291: Adjusted the tests that use nobody.

> On May 24, 2018, 7:29 p.m., Chun-Hung Hsiao wrote: > > src/tests/environment.cpp > > Lines 885 (patched) > > > > > > Not a real issue here, but I'm thinking if just `UNPRIVILEDGED_` is > > clear enough.

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/ --- (Updated May 24, 2018, 12:48 p.m.) Review request for mesos, Jason Lai and Jie

Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/ --- Review request for mesos, Akash Gupta and Andrew Schwartzmeyer. Bugs:

Re: Review Request 67290: Removed an unneeded test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67290/ --- (Updated May 24, 2018, 5:49 p.m.) Review request for mesos and James Peach.

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/ --- (Updated May 24, 2018, 5:49 p.m.) Review request for mesos, Andrew

Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/#review203799 --- Please fix up the commit summary message.

Re: Review Request 67292: Added warning to Python version checker script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67292/ --- (Updated May 24, 2018, 11:58 a.m.) Review request for mesos and Armand

Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC.

> On May 24, 2018, 10:36 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1820 (patched) > > > > > > Shouldn't we also close the parent's copy of the read end of the

Re: Review Request 67256: Added a unit test for CSI plugin RPC metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67256/ --- (Updated May 25, 2018, 12:24 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67288: White list fds that child processes can inherit in mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67288/#review203832 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/ --- (Updated May 25, 2018, 1:05 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. Repository:

Re: Review Request 65112: Added documentation about standalone containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65112/#review203834 --- docs/home.md Lines 56 (patched)

Review Request 67304: Added missing calls to the scheduler API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67304/ --- Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, Gilbert Song, and

Review Request 67305: Moved the "Resource Provider" section to `resource-provider.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67305/ --- Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. Repository:

Review Request 67282: Added python3 to list of Pylint excluded files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8770

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/ --- (Updated May 24, 2018, 8:19 p.m.) Review request for mesos, Andrew

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review203811 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67137: Avoided leaking file descriptors in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67137/#review203810 --- Patch looks great! Reviews applied: [67137] Passed command:

Review Request 67298: Fixed a performance issue in collect/await.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67298/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos

Re: Review Request 67298: Fixed a performance issue in collect/await.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67298/#review203819 --- Ship it! Ship It! - Gilbert Song On May 24, 2018, 2:22

Re: Review Request 67271: Renamed an ambiguous variable in network port isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 24, 2018, 9:57 p.m.) Review request for mesos and James Peach.

Re: Review Request 67255: Added per-CSI-call RPC metrics for SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67255/ --- (Updated May 24, 2018, 8:20 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67291: Adjusted the tests that use nobody.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67291/#review203808 --- Fix it, then Ship it!

Re: Review Request 67290: Removed an unneeded test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67290/#review203809 --- Ship it! Ship It! - Chun-Hung Hsiao On May 24, 2018, 5:49

Re: Review Request 67292: Added warning to Python version checker script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67292/#review203812 --- Ship it! Ship It! - Armand Grillet On May 24, 2018, 6:58

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 24, 2018, 5:58 p.m., Gilbert Song wrote: > > we need to update `configure.md` correspondingly. Updated configuration/agent.md - Xudong --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 24, 2018, 8:30 p.m., James Peach wrote: > > Commit subject should be "Added ..." subject changed - Xudong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203805

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203805 --- Fix it, then Ship it! Commit subject should be "Added ..."

Re: Review Request 67292: Added warning to Python version checker script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67292/#review203816 --- support/check-python3.py Lines 37 (patched)

Re: Review Request 67195: Added enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 24, 2018, 9:56 p.m.) Review request for mesos, James Peach and

Re: Review Request 67303: Added documentation for resource provider and CSI plugin metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67303/#review203837 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67118/ --- (Updated May 25, 2018, 2:08 a.m.) Review request for mesos, Akash Gupta,

Review Request 67308: Documented how to setup and use cquery with Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67308/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler,

Re: Review Request 67304: Added missing calls to the scheduler API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67304/#review203841 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 67309: Updated Future::select to take any iterable type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67309/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos

Re: Review Request 67305: Moved the "Resource Provider" section to `resource-provider.md`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67305/#review203842 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/#review203844 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 25, 2018, 2:09 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 25, 2018, 2:13 a.m.) Review request for mesos, Akash Gupta,

Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203843 --- Ship it! Brilliant find. First question that came to my mind

Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203846 --- PASS: Mesos patch 67313 was successfully built and tested.

Re: Review Request 67264: Unmounted any dangling persistent volume in gc paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67264/#review203838 --- Patch looks great! Reviews applied: [67264] Passed command:

Review Request 67312: Updated mesos to use vector instead of list where possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67312/ --- Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos

  1   2   >