Re: Review Request 67998: Improved cmake missing files check script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67998/#review206374 --- Ship it! Ship It! - Alexander Rukletsov On July 20, 2018,

Re: Review Request 67965: Optimized ranges subtraction operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/#review206373 --- PASS: Mesos patch 67965 was successfully built and tested.

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

> On July 24, 2018, 7:05 p.m., James Peach wrote: > > 3rdparty/libprocess/src/mpsc_linked_queue.hpp > > Lines 27 (patched) > > > > > > Chatted with @bbannier, and he pointed out that we can replace > > `__COUNTER__`

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67936/#review206406 --- Ship it! Ship It! - Jie Yu On July 17, 2018, 8:12 p.m.,

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68001/ --- (Updated July 24, 2018, 6:05 p.m.) Review request for Benjamin Bannier and

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68001/ --- (Updated July 24, 2018, 6:06 p.m.) Review request for Benjamin Bannier and

Re: Review Request 67988: Improved performance of jsonify by integrating with rapidjson.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67988/#review206407 --- Fix it, then Ship it!

Re: Review Request 67991: Adjusted Mesos to compile against jsonify rapidjson changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67991/#review206409 --- Ship it! Ship It! - Alexander Rukletsov On July 20, 2018,

Re: Review Request 68033: Fixed flaky test `DefaultExecutorTest.TaskWithFileURI`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68033/#review206412 --- PASS: Mesos patch 68033 was successfully built and tested.

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/#review206413 --- Ship it! Ship It! - James Peach On July 24, 2018, 6:19

Re: Review Request 67987: Added rapidjson to the mesos build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67987/#review206400 --- Fix it, then Ship it! Please also add an entry to

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

> On July 24, 2018, 5:05 p.m., James Peach wrote: > > 3rdparty/libprocess/src/mpsc_linked_queue.hpp > > Lines 27 (patched) > > > > > > Chatted with @bbannier, and he pointed out that we can replace > > `__COUNTER__`

Re: Review Request 68029: Updated XFS disk isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/#review206405 --- Ship it! Ship It! - James Peach On July 24, 2018, 5:36

Re: Review Request 67992: Avoid performance cost of ostringstream in http::OK json constructors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67992/#review206415 --- Ship it! Ship It! - Alexander Rukletsov On July 20, 2018,

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/ --- (Updated July 24, 2018, 12:58 p.m.) Review request for mesos and Benjamin

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68001/#review206418 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68029: Updated XFS disk isolator docs.

> On July 24, 2018, 10:11 a.m., James Peach wrote: > > docs/isolators/disk-xfs.md > > Lines 46 (patched) > > > > > > Make this a link: > > > > ``` > >

Re: Review Request 68029: Updated XFS disk isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/ --- (Updated July 24, 2018, 10:36 a.m.) Review request for mesos and James Peach.

Re: Review Request 67812: Added per-framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/ --- (Updated July 24, 2018, 6:01 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/ --- (Updated July 24, 2018, 12:50 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

> On July 23, 2018, 4:09 p.m., Benjamin Mahler wrote: > > Can you clarify why this commit doesn't touch the shared resources logic in > > the allocation loop? > > https://github.com/apache/mesos/blob/1.6.0/src/master/allocator/mesos/hierarchical.cpp#L2070-L2079 > > > > Does this patch pass the

Re: Review Request 67809: Added per-framework metrics for scheduler events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67809/ --- (Updated July 24, 2018, 5:57 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67914: Updated XFS disk isolator to reclaim project IDs after disk GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67914/ --- (Updated July 24, 2018, 11:19 a.m.) Review request for mesos and James Peach.

Re: Review Request 67990: Fixed libprocess tests against rapidjson.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67990/#review206408 --- Ship it! Can you please call out this change in the changelog?

Re: Review Request 67993: Avoid resource copying while serving state json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67993/#review206411 --- Ship it! Ship It! - Alexander Rukletsov On July 20, 2018,

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

> On July 23, 2018, 4:19 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 685 (patched) > > > > > > const Resources& per comment below Done. > On July 23, 2018, 4:19 p.m.,

Re: Review Request 67878: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 24, 2018, 8:03 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68029: Updated XFS disk isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/#review206420 --- PASS: Mesos patch 68029 was successfully built and tested.

Re: Review Request 67924: Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67924/#review206380 --- Ship it! Ship It! - Alexander Rukletsov On July 16, 2018,

Review Request 68030: Fixed a linking issue with gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68030/ --- Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao. Bugs:

Re: Review Request 67905: Added missing anchor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67905/#review206378 --- Ship it! Ship It! - Alexander Rukletsov On July 13, 2018,

Re: Review Request 67925: Fixed image link in docker volume isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67925/#review206379 --- Ship it! Ship It! - Alexander Rukletsov On July 16, 2018,

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/#review206381 --- Ship it! Ship It! - Armand Grillet On July 19, 2018, 3:48

Re: Review Request 67965: Optimized ranges subtraction operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/#review206414 --- src/common/values.cpp Line 231 (original), 231 (patched)

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/#review206422 --- PASS: Mesos patch 67827 was successfully built and tested.

Re: Review Request 68030: Fixed a linking issue with gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68030/#review206424 --- Patch looks great! Reviews applied: [68030] Passed command:

Re: Review Request 67987: Added rapidjson to the mesos build.

> On July 24, 2018, 5:41 p.m., Alexander Rukletsov wrote: > > 3rdparty/Makefile.am > > Lines 327 (patched) > > > > > > s/radidjson/rapidjson/ > > > > Also, I don't see you using `rapidjsondir`, can you

Re: Review Request 67936: Fixed ephemeral ports deallocation in network/port_mapping isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67936/#review206436 --- Patch looks great! Reviews applied: [67936] Passed command:

Re: Review Request 67965: Optimized ranges subtraction operation.

> On July 24, 2018, 2:06 p.m., Vinod Kone wrote: > > src/common/values.cpp > > Lines 290-311 (patched) > > > > > > This part is a bit hard to follow. Can you break it down into 4 cases > > > > 1) left is

Re: Review Request 67965: Optimized ranges subtraction operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/ --- (Updated July 24, 2018, 5:23 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 67990: Fixed libprocess tests against rapidjson.

> On July 24, 2018, 6:43 p.m., Alexander Rukletsov wrote: > > Can you please call out this change in the changelog? It is unfortunate we > > do such a change without notifying people on the user and dev lists with > > enough time buffer, maybe you can do it right after the chain lands so that

Re: Review Request 68030: Fixed a linking issue with gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68030/#review206434 --- Fix it, then Ship it!

Re: Review Request 67965: Optimized ranges subtraction operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67965/#review206435 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68001/#review206390 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67903: Fixed breadcrumb links in site templates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67903/#review206377 --- Ship it! Ship It! - Alexander Rukletsov On July 13, 2018,

Re: Review Request 67904: Fixed documentation links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67904/#review206376 --- Ship it! Ship It! - Alexander Rukletsov On July 13, 2018,

Re: Review Request 67983: Enabled `TimeTest.Now` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67983/#review206384 --- Patch looks great! Reviews applied: [67951, 67952, 67976, 67977,

Re: Review Request 68030: Fixed a linking issue with gRPC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68030/#review206385 --- PASS: Mesos patch 68030 was successfully built and tested.

Re: Review Request 67878: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67878/ --- (Updated July 24, 2018, 3:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68029: Updated XFS disk isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/#review206387 --- Patch looks great! Reviews applied: [67915, 67914, 68029]

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/ --- (Updated July 24, 2018, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68001/ --- (Updated July 24, 2018, 2:59 p.m.) Review request for Benjamin Bannier and

Re: Review Request 67985: Added rapidjson to the stout build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67985/#review206394 --- Fix it, then Ship it! 3rdparty/stout/3rdparty/Makefile.am

Re: Review Request 68029: Updated XFS disk isolator docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68029/#review206396 --- docs/isolators/disk-xfs.md Lines 46 (patched)

Re: Review Request 67986: Added rapidjson to the libprocess build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67986/#review206397 --- Ship it! Ship It! - Alexander Rukletsov On July 20, 2018,

Review Request 68033: Fixed flaky test `DefaultExecutorTest.TaskWithFileURI`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68033/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-9108

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66856/ --- (Updated July 24, 2018, 5:30 p.m.) Review request for mesos, Benjamin Mahler,