Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68167/#review206817 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68167/#review206806 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2018, 4:30 p.m., Greg

Review Request 68167: Avoided hostname lookups in the CNI port mapper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68167/ --- Review request for mesos and Jie Yu. Bugs: MESOS-9129

Review Request 68174: Support for `wstring` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68174/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.

Review Request 68176: Fixed gRPC release build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68149/ --- (Updated Aug. 2, 2018, 9:43 p.m.) Review request for James Peach.

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68149/ --- (Updated Aug. 2, 2018, 9:44 p.m.) Review request for James Peach.

Re: Review Request 68074: Always build gRPC in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68074/ --- (Updated Aug. 2, 2018, 9:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/ --- (Updated Aug. 2, 2018, 7:17 p.m.) Review request for mesos, Avinash sridharan,

Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68175/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu.

Re: Review Request 68176: Fixed gRPC release build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68176/#review206831 --- PASS: Mesos patch 68176 was successfully built and tested.

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68149/#review206830 --- PASS: Mesos patch 68149 was successfully built and tested.

Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68175/#review206832 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68174: Support for `wstring` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68174/#review206828 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68166: Moved around some functions definitions between files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68166/#review206801 --- PASS: Mesos patch 68166 was successfully built and tested.

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206785 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68161: Granted container user permissions for shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68161/ --- (Updated Aug. 2, 2018, 5:31 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206788 --- src/master/master.hpp Lines 2981-2983 (original)

Re: Review Request 68154: Fixed gRPC compilation for standalone libprocess build with Clang.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68154/#review206787 --- Ship it! Ship It! - Benjamin Bannier On Aug. 1, 2018, 11:53

Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68162/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 10:18 a.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 10:26 a.m.) Review request for mesos and Alexander

Review Request 68161: Granted container user permissions for shared persistent volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68161/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68163/ --- Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.

Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68162/ --- (Updated Aug. 2, 2018, 5:38 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review206789 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68166: Moved around some functions definitions between files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68166/ --- (Updated Aug. 2, 2018, 1:23 p.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 1:23 p.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206799 --- src/Makefile.am Lines 1021 (patched)

Re: Review Request 68166: Moved around some functions definitions between files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68166/#review206796 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2018,

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206797 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 2, 2018,

Re: Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68163/#review206790 --- FAIL: Failed to apply the dependent review: 66811. Failed

Re: Review Request 67894: Migrated mesos python package to python3.6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67894/#review206792 --- Fix it, then Ship it! src/python/lib/tox.ini Line 7

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/#review206794 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68166: Moved around some functions definitions between files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68166/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68141: Moved Framework implementation into separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68141/ --- (Updated Aug. 2, 2018, 12:17 p.m.) Review request for mesos and Alexander

Re: Review Request 68141: Moved Framework implementation into separate file.

> On Aug. 2, 2018, 10:33 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp > > Lines 2981-2983 (original) > > > > > > I think these qualify to stay in ".hpp". Letting functions stay in header files can of