Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/#review209697 --- Ship it! Ship It! - James Peach On Oct. 17, 2018, 8 a.m.,

Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/#review209699 --- Ship it! Ship It! - Andrei Budnik On Oct. 17, 2018, 8 a.m.,

Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68586/#review209706 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 31, 2018, 9:47

Review Request 69064: WIP: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- Review request for mesos. Repository: mesos Description --- This commit

Re: Review Request 68991: Added a test `FsTest.Lsof`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209700 --- 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 833 (patched)

Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209707 --- Ship it! Ship It! - Benjamin Mahler On Oct. 16, 2018, 10:23

Review Request 68795: Added deduplication for read-only master requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209695 --- Patch looks great! Reviews applied: [69041, 69042] Passed

Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68587/#review209704 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp

Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review209698 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69041/#review209708 --- Fix it, then Ship it!

Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68586/#review209710 --- include/mesos/type_utils.hpp Lines 532 (patched)

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 17, 2018, 9:52 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/fsync.hpp > > Lines 53-55 (patched) > > > > > > Related to the discussion from > >

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209733 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 17, 2018, 8:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209716 --- Ship it! LGTM. I filed

Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/#review209731 --- PASS: Mesos patch 69068 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209730 --- Bad patch! Reviews applied: [68957, 68956, 68953] Failed

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209720 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 68953: Refactor allocator configuration into a struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 17, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 17, 2018, 10:18 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 17, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review209721 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/#review209727 --- include/mesos/mesos.proto Lines 2003 (patched)

Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/ --- (Updated Oct. 17, 2018, 6:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69068: Cached whether agents have gpus to improve allocator performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/#review209728 --- Patch looks great! Reviews applied: [68507, 69068] Passed

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 18, 2018, 2:01 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/#review209724 --- Ship it! "Flag" may mislead the reader to think this is a

Re: Review Request 68586: Add the output file to the hash on CommandInfo::URI.

> On Oct. 17, 2018, 6:10 p.m., Jiang Yan Xu wrote: > > include/mesos/type_utils.hpp > > Lines 532 (patched) > > > > > > So `cache` is counted here. Does it mean that if I specify two > > duplicate URIs with

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 4:21 p.m., Benjamin Bannier wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > I agree with James here. It seems totally fine to me to _always `sync`_ > > here.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209715 --- Patch looks great! Reviews applied: [69009, 69010] Passed

Re: Review Request 69036: WIP: Updated the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/ --- (Updated Oct. 17, 2018, 11:21 p.m.) Review request for mesos, Benjamin

Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/ --- Review request for mesos, Benjamin Mahler and Gastón Kleiman. Repository:

Re: Review Request 69068: Added `hasGpu` flag in the allocator `Slave` struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/#review209725 --- PASS: Mesos patch 69068 was successfully built and tested.

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

> On Oct. 15, 2018, 8:23 p.m., Greg Mann wrote: > > src/master/flags.cpp > > Lines 686-689 (patched) > > > > > > This flag name doesn't quite fit with existing flags. For other > > similar flags which

Re: Review Request 68587: Fixed fetcher deadlock with duplicate URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68587/ --- (Updated Oct. 17, 2018, 10:21 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

> On Oct. 17, 2018, 9:52 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 128-130 (original), 139-141 (patched) > > > > > > This comment is still incorrect, especially with

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/ --- (Updated Oct. 17, 2018, 8:29 p.m.) Review request for mesos, Andrew

Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/ --- (Updated Oct. 17, 2018, 2:27 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/#review209687 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69041: Relaxed `Promise` constructor and assignment operator requirements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69041/#review209688 --- Ship it! 3rdparty/libprocess/include/process/future.hpp Line

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209689 --- 3rdparty/stout/include/stout/os/posix/fsync.hpp Lines 53-55

Re: Review Request 68644: Closed all file descriptors except `whitelist_fds` in posix/subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68644/ --- (Updated Oct. 17, 2018, 2:43 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68991: Added a test `FsTest.Lsof`.

> On Oct. 13, 2018, 1:40 a.m., James Peach wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Lines 830 (patched) > > > > > > Maybe also add: > > ``` > > EXPECT_FALSE(std::find(fds->begin(),

Re: Review Request 68991: Added a test `FsTest.Lsof`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/ --- (Updated Oct. 17, 2018, 2:41 p.m.) Review request for mesos, Gilbert Song and

Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/ --- Review request for mesos, Andrei Budnik, Chun-Hung Hsiao, Jie Yu, James Peach,

Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209686 --- Ship it! Ship It! - Jan Schlicht On Oct. 16, 2018, 12:23

Re: Review Request 69059: Fixed the FreeBSD MACRO as '__FreeBSD__' in posix/pipe.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69059/#review209684 --- Ship it! Ship It! - Qian Zhang On Oct. 17, 2018, 4 p.m.,

Re: Review Request 68507: Pulled out nested `Framework` and `Slave` classes in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68507/ --- (Updated Oct. 17, 2018, 4:34 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209723 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 69007: Added `get_container_id` to util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69007/#review209692 --- Ship it! Ship It! - Kevin Klues On Okt. 13, 2018, 9:08

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209691 --- Fix it, then Ship it!

Re: Review Request 69023: Added `retry` argument to `request()` method in Python library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69023/#review209693 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 11:05

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 18, 2018, 12:29 a.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8195 (patched) > > > > > > Let's validate that there is no task using the resources provided by > > this RP before doing the

Re: Review Request 69043: Disabled warnings-as-errors for cares build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69043/#review209694 --- Ship it! - Benjamin Bannier On Oct. 17, 2018, 11:27 a.m.,