Re: Review Request 69237: Simplified newline handling in 'test_exec()' test for new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69237/#review210303 --- Ship it! Ship It! - Kevin Klues On Nov. 1, 2018, 10:28

Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210299 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 12:23

Re: Review Request 69161: Renamed a function argument to not reuse member name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69161/#review210301 --- Fix it, then Ship it! Thanks for cleaning this up!

Re: Review Request 69097: Added an allocator benchmark for quota performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69097/#review210291 --- Fix it, then Ship it!

Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69207/#review210295 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/#review210294 --- Hm.. why is this one not just extending the one you added in the

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/ --- (Updated Nov. 2, 2018, 10:22 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69207/#review210302 --- Ship it! I reworked this commit slightly before pushing it in

Re: Review Request 69208: Updated new CLI task attach/exec exit strategy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69208/#review210307 --- PASS: Mesos patch 69208 was successfully built and tested.

Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69242/#review210310 --- Patch looks great! Reviews applied: [69242] Passed command:

Re: Review Request 69243: Used a `switch` statement to match enum values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69243/#review210293 --- PASS: Mesos patch 69243 was successfully built and tested.

Re: Review Request 69208: Updated new CLI task attach/exec exit strategy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69208/#review210308 --- Ship it! Ship It! - Kevin Klues On Okt. 30, 2018, 12:55

Re: Review Request 69243: Used a `switch` statement to match enum values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69243/#review210311 --- Patch looks great! Reviews applied: [69243] Passed command:

Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69207/#review210300 --- src/python/cli_new/lib/cli/tests/base.py Lines 507 (patched)

Re: Review Request 69237: Simplified newline handling in 'test_exec()' test for new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69237/#review210306 --- PASS: Mesos patch 69237 was successfully built and tested.

Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210304 --- PASS: Mesos patch 69116 was successfully built and tested.

Re: Review Request 69206: Updated new CLI commands for new CLI to return proper exit status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69206/#review210305 --- Ship it! Ship It! - Kevin Klues On Okt. 30, 2018, 12:51

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review210309 --- PASS: Mesos patch 69211 was successfully built and tested.

Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69242/#review210292 --- PASS: Mesos patch 69242 was successfully built and tested.

Re: Review Request 69242: Saved some disk space in mesos-tidy Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69242/#review210296 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 2, 2018, 8:50

Re: Review Request 69243: Used a `switch` statement to match enum values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69243/#review210297 --- Ship it! Ship It! - Chun-Hung Hsiao On Nov. 2, 2018, 8:51

Re: Review Request 68706: Added master failover reregistration progress metrics.

> On Oct. 18, 2018, 11:14 a.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 1874-1875 (patched) > > > > > > If we use equality operator and only set the timer when such a number > > of reregistered

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review210145 --- There were changes added for a test but it's gone in the latest

Review Request 69242: Saved some disk space in mesos-tidy Docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69242/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Review Request 69243: Used a `switch` statement to match enum values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69243/ --- Review request for mesos and Chun-Hung Hsiao. Repository: mesos Description

Re: Review Request 69234: Made debug container runs as its parent container's user by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69234/#review210281 --- src/slave/http.cpp Line 2516 (original), 2519 (patched)

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69092/#review210287 --- Ship it! - Benjamin Mahler On Oct. 20, 2018, 1:27 a.m., Meng

Re: Review Request 69092: Added default arguments to `FrameworkProfile` in allocator benchmark.

> On Oct. 25, 2018, 12:18 a.m., Benjamin Mahler wrote: > > Hm.. I don't understand what this is doing. Is this setting default > > framework behavior if someone writing a benchmark doesn't want to have to > > pass the arguments? > > Meng Zhu wrote: > That is correct. Ok, could you update

Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.

> On Oct. 25, 2018, 12:20 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_benchmarks.cpp > > Line 234 (original), 234 (patched) > > > > > > Hm.. how were you able to change this while it remained

Re: Review Request 69093: Removed `used` argument in `AgentProfile` in the allocator benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69093/#review210289 --- Ship it! Ship It! - Benjamin Mahler On Oct. 20, 2018, 1:27

Re: Review Request 69096: Moved a few allocator test helpers to `tests/allocator.hpp`.

> On Oct. 25, 2018, 12:22 a.m., Benjamin Mahler wrote: > > src/tests/allocator.hpp > > Lines 40-45 (patched) > > > > > > I think we some other create helpers lying around, e.g. createTask. Is > > this where these