Re: Review Request 33241: docs: Add documentation on observability metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review83706 --- Ship it! Ship It! - Joe Smith On May 12, 2015, 1:43 p.m., Ricard

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83700 --- Ship it! src/slave/resource_estimator.hpp

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/#review83696 --- Per the offline discussion, how about we create a master/framework.h

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83691 --- Patch looks great! Reviews applied: [33918, 33919] All tests passe

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/ --- (Updated May 14, 2015, 12:07 a.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/ --- (Updated May 13, 2015, 11:28 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33058: Updated test-frameworks to support principal only credential.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33058/#review83683 --- src/examples/java/TestFramework.java

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83682 --- Patch looks great! Reviews applied: [33918, 33919] All tests passe

Re: Review Request 32982: [WIP] Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83678 --- docs/reservation.md

Re: Review Request 31667: Piped hashmap from allocator through to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review83669 --- Ship it! Looks good, just some minor notes below. Went over these w

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/ --- (Updated May 13, 2015, 10:36 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 13, 2015, 10:35 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33919: Integrated resources estimator with the slave.

> On May 13, 2015, 5:24 p.m., Niklas Nielsen wrote: > > src/slave/flags.cpp, line 443 > > > > > > Don't we usually use an empty string instead of a placeholder? See for > > example hadoop_home Changed it to Option in

Re: Review Request 32982: [WIP] Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83674 --- Ship it! This looks really good - it's great to have documentation!

Re: Review Request 32982: Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated May 13, 2015, 10:15 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32982: [WIP] Added reservation user guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated May 13, 2015, 10:15 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 13, 2015, 3:07 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

> On April 29, 2015, 3:41 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/fetcher.cpp, lines 408-417 > > > > > > For the future: > > > > auto futures = filter(entries, [](const auto& entry) { return

Re: Review Request 29947: Fixed a race condition in hook tests for remove-executor hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29947/ --- (Updated May 13, 2015, 4:36 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/ --- (Updated May 13, 2015, 8:12 p.m.) Review request for mesos and Joris Van Remoor

Review Request 34176: Removed allocator namespace

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34176/ --- Review request for mesos. Summary (updated) - Removed allocato

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83651 --- Ship it! Thanks! Looks like the title of this review is no longer a

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/ --- (Updated May 13, 2015, 6:36 p.m.) Review request for mesos and Ben Mahler. Ch

Re: Review Request 33154: Added reason metrics for slave removals.

> On May 13, 2015, 6:20 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4791 > > > > > > do you still need the copy here? Yes: https://issues.apache.org/jira/browse/MESOS-2716 - Ben

Re: Review Request 33154: Added reason metrics for slave removals.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33154/#review83647 --- Ship it! src/master/master.cpp

Re: Review Request 33155: Added tests for slave removal metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33155/#review83648 --- Ship it! Ship It! - Vinod Kone On May 12, 2015, 11:32 p.m., Ben

Re: Review Request 32398: Persisted the reservation state on the slave.

> On May 13, 2015, 6:04 p.m., Jie Yu wrote: > > I fixed a few style issues for you. Make sure the comments are wrapped at > > 70 chars (set tw=70). > > > > Also, this is how I used to find snake case variable names: > > `/[a-z]*_[a-z]*\ ` > I fixed a few style issues for you. Thank you... and

Re: Review Request 33876: Added usages() to resource monitor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33876/#review83645 --- Ship it! Ship It! - Jie Yu On May 12, 2015, 8:55 p.m., Niklas Ni

Re: Review Request 32398: Persisted the reservation state on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review83638 --- Ship it! I fixed a few style issues for you. Make sure the comments

Re: Review Request 34152: Master flag validation now supports zookeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152/#review83639 --- src/cli/execute.cpp

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

> On May 11, 2015, 10:19 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 155 > > > > > > unique_ptr is not a POD, so this will still try to run the destructor > > of the function during exit of the program. > >

Re: Review Request 33919: Integrated resources estimator with the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33919/#review83630 --- src/slave/flags.cpp

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

> On May 11, 2015, 10:19 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 155 > > > > > > unique_ptr is not a POD, so this will still try to run the destructor > > of the function during exit of the program. > >

Re: Review Request 34048: Fixed disappearing search bar: MESOS-2479

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34048/#review83611 --- Ship it! Someone finally fixed one of my more embarassing bugs. :th

Re: Review Request 32398: Persisted the reservation state on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review83609 --- Ship it! Ship It! - Alexander Rukletsov On May 12, 2015, 6:44 p.

Re: Review Request 32398: Persisted the reservation state on the slave.

> On April 24, 2015, 8:18 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 442-445 > > > > > > Let's use this function where we already check for this condition, like > > in `master/validation.cpp`

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83593 --- Patch looks great! Reviews applied: [34016] All tests passed. - M

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/ --- (Updated May 13, 2015, 10:49 a.m.) Review request for mesos and Ben Mahler. R

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review83122 --- Question about completed tasks/frameworks, and some minor nits. sr