Re: Review Request 36908: Added QuotaInfo Protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review97972 --- Ship it! Ship It! - Qian Zhang On Sept. 2, 2015, 9:38 p.m., Joer

Review Request 38172: Stout: Simplified hashset implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217 https://issues.

Review Request 38171: Stout: Refactored set to use initializer list for variadic constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38171/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217 https://issues.

Review Request 38173: Stout: Simplified hashmap implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38173/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217 https://issues.

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 8, 2015, 6:16 a.m.) Review request for mesos, Alexander Rukletsov a

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97969 --- Patch looks great! Reviews applied: [37993] All tests passed. - M

Re: Review Request 38168: Replace hard-coded reap interval with a constant for 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38168/#review97960 --- Patch looks great! Reviews applied: [38168] All tests passed. - M

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 8, 2015, 3:18 a.m.) Review request for mesos, Adam B, Alexander Ruk

Re: Review Request 38046: Replace hard-coded reap interval with a constant

> On 九月 7, 2015, 4:22 p.m., Alexander Rukletsov wrote: > > I would encourage you to check the reaping concept in > > `libprocess/reap.{hpp|cpp}`. Comments in those files should be sufficient > > to understand what's reaping and how we use it in Mesos. Though some of the > > changes you've made

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 8, 2015, 2:41 a.m.) Review request for mesos, Alexander Rukletsov a

Review Request 38168: Replace hard-coded reap interval with a constant for 3rdparty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38168/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Bugs: MESOS-1935

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97950 --- src/docker/docker.cpp (line 414)

Re: Review Request 38141: Refactor shared paths in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/#review97949 --- Patch looks great! Reviews applied: [38141] All tests passed. - M

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 7, 2015, 11:31 p.m.) Review request for mesos, Jojy Varghese, Ti

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97947 --- Ship it! Ship It! - Guangya Liu On 九月 7, 2015, 6:47 p.m., Wojcie

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review97945 --- Hi Marco, Sorry for the delay in looking at your review. I was able

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review97944 --- Bad patch! Reviews applied: [38141, 38137] Failed command: ./suppo

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 7, 2015, 9:58 p.m.) Review request for mesos, Jojy Varghese, Til

Re: Review Request 38137: Added Docker provisioner and local store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 7, 2015, 9:32 p.m.) Review request for mesos, Jojy Varghese, Til

Re: Review Request 38141: Refactor shared paths in provisioners.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/ --- (Updated Sept. 7, 2015, 9:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review97937 --- I would suggest to write a summarizing comment about how coalescing

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97942 --- Patch looks great! Reviews applied: [38165] All tests passed. - M

Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38164/#review97941 --- Patch looks great! Reviews applied: [38164] All tests passed. - M

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

> On Sept. 7, 2015, 3:49 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioners/docker.cpp, line 280 > > > > > > One space indentation too many :) Also no longer valid :) > On Sept. 7, 2015, 3:49 p.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

> On Sept. 7, 2015, 3:48 p.m., Till Toenshoff wrote: > > src/slave/containerizer/provisioner.cpp, line 45 > > > > > > This should fit into 80 chars without a linebreak. Also no longer valid :) - Timothy

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review97938 --- src/slave/containerizer/provisioners/docker.hpp (lines 19 - 20)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review97936 --- Patch looks great! Reviews applied: [38158] All tests passed. - M

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 7, 2015, 6:47 p.m.) Review request for mesos. Bugs: MESOS-3377

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 7, 2015, 6:46 p.m.) Review request for mesos. Changes ---

Review Request 38165: MOS-3377 - Adding CONTAINER_NAME as additional env variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- Review request for mesos. Bugs: MOS-3377 https://issues.apache.org/jira/bro

Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38164/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-3379 https://i

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review97935 --- Thanks till these will be fixed and pushed in my big review! - Timo

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 7, 2015, 6:04 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 38158: Refactored Value::Ranges coalesce().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 7, 2015, 4:57 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review97928 --- Patch looks great! Reviews applied: [38161, 38160] All tests passe

Re: Review Request 38046: Replace hard-coded reap interval with a constant

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97924 --- I would encourage you to check the reaping concept in `libprocess/r

Review Request 38160: Documented how to expedite event firing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos De

Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 37496: Move docker provisioner local store into dedicated folders.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37496/#review97922 --- src/Makefile.am (lines 758 - 760)

Re: Review Request 37495: Docker provisioner local store unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37495/#review97921 --- src/tests/containerizer/docker_provisioner_tests.cpp (line 66)

Re: Review Request 37247: Added Docker image reference store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review97914 --- I did not realize that we had a combined RR for this chain - please

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review97910 --- I did not realize that we had a combined RR for this chain - please

Re: Review Request 37198: Add Docker image provisioner and copy backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review97908 --- I did not realize that we had a combined RR for this chain - please

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/#review97920 --- Ship it! Ship It! - haosdent huang On Sept. 7, 2015, 9:12 a.m.,

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/#review97905 --- src/tests/reservation_endpoints_tests.cpp (lines 78 - 101)

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/#review97915 --- Patch looks great! Reviews applied: [37826, 37827, 37830, 38154] A

Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/ --- Review request for mesos and Michael Park. Bugs: MESOS-3312 https://issues.

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/#review97909 --- src/master/http.cpp (lines 1909 - 1914)

Re: Review Request 37830: Added a test for converting JSON arrays to Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37830/ --- (Updated Sept. 7, 2015, 9:12 a.m.) Review request for mesos, Joseph Wu and Mich

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37827/ --- (Updated Sept. 7, 2015, 9:12 a.m.) Review request for mesos, haosdent huang, Jo

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37826/ --- (Updated Sept. 7, 2015, 9:12 a.m.) Review request for mesos, Joseph Wu and Mich

Re: Review Request 37827: Added a test for converting JSON arrays to repeated protobufs.

> On Sept. 3, 2015, 9:29 p.m., Michael Park wrote: > > Perhaps a dumb question, but may I ask why you needed to introduce > > `SimpleMessage`? I would like to compare protobuf messages with `EXPECT_EQ`, therefore I need an equality operator, which will be too long for the existing `Message` pr

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Sept. 3, 2015, 11:32 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 594 > > > > > > Do we want to support the following? > > > > ```cpp > > using g

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

> On Sept. 3, 2015, 8:37 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 593 > > > > > > The `Parse` above uses `value`, rather than `json`. Can we > > consolidate t