Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/#review132124
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 0, 39474, 36383]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 7, 2016, 2:59 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36383/
> ---
> 
> (Updated May 7, 2016, 2:59 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker volume test case by adding checkpoint verify logic.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 
> 
> Diff: https://reviews.apache.org/r/36383/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47082/#review132122
---



Patch looks great!

Reviews applied: [47082]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 7, 2016, 2:27 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47082/
> ---
> 
> (Updated May 7, 2016, 2:27 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5143
> https://issues.apache.org/jira/browse/MESOS-5143
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a slave is removed, master sends a LostSlaveMessage to affected
> frameworks only (instead of all registered frameworks). An affected
> framework is a framework which satisfied one or more conditions of
> the following:
> 
> 1. There are running tasks on this slave belonging to the framework.
> 2. Reserved resources on the slave have a matching role with the
>role of the framework.
> 3. There are pending offers from this slave for the framework.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
>   src/tests/master_authorization_tests.cpp 
> 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/47082/diff/
> 
> 
> Testing
> ---
> 
> All existing and modified tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 47080: Agent should backoff when establishing a socket.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47080/#review132119
---



Patch looks great!

Reviews applied: [47080]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 10:51 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47080/
> ---
> 
> (Updated May 6, 2016, 10:51 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent should backoff when establishing a socket.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47080/diff/
> 
> 
> Testing
> ---
> 
> make tests
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/
---

(Updated 五月 7, 2016, 2:59 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Updated docker volume test case by adding checkpoint verify logic.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 

Diff: https://reviews.apache.org/r/36383/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/
---

(Updated 五月 7, 2016, 2:44 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Updated docker volume test case by adding checkpoint verify logic.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 

Diff: https://reviews.apache.org/r/36383/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Qian Zhang]

> On May 7, 2016, 1:34 a.m., Jie Yu wrote:
> > src/tests/containerizer/cni_isolator_tests.cpp, line 42
> > 
> >
> > Instead of using a script here, can we use code to get ip network and 
> > name server information?
> > 
> > You can take a look at `links()` and `IPNetwork::fromLinkDevice(..)` in 
> > stout.
> > 
> > I would suggest that we define a test fixture for the isolator tests 
> > and get the ip network and nameserver address in the SetUp function. We can 
> > also put the helpers to create plugin/config in the test fixture.

I see `link::eth0()` and `IPNetwork::fromLinkDevice(..)` can be used to get the 
IP of host public interface which is good, but how can we use code to get name 
server? It seems we do not have existing method to do so.

What about I put creating plugin/config in `static void SetUpTestCase()` but 
still use script to get IP and name server?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review132084
---


On May 6, 2016, 10:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> ---
> 
> (Updated May 6, 2016, 10:06 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount 
> --help=false --operation=make-rslave --path=/
> + grep+  -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/.+ 
> /proc/self/mountinfo
> + grepcut -v -d  -f5
>  d06b117d-518b-41e2-b8e0-62a12083773c
> + xargs --no-run-if-empty umount -l
> + mount -n --rbind 
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/provisioner/containers/d06b117d-518b-41e2-b8e0-62a12083773c/backends/copy/rootfses/7ea27011-cd3a-43b0-8301-b0b94d9f9b47
>  
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/slaves/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0/frameworks/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-/executors/60e6d35d-6d33-47ae-9c23-d2e5c913c892/runs/d06b117d-518b-41e2-b8e0-62a12083773c/.rootfs
> I0420 22:26:00.924844  9305 exec.cpp:150] Version: 0.29.0
> I0420 22:26:00.942319  9375 exec.cpp:225] Executor registered on agent 
> 18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0
> Registered executor on mesos
> Starting task 60e6d35d-6d33-47ae-9c23-d2e5c913c892
> Forked command at 9382
> sh -c 'ls /'
> bin  dev  etc  home lib  linuxrc  mediamnt  proc  
>root run  sbin sys  tmp  usr  var
> Command exited with status 0 (pid: 9382)
> I0420 22:26:01.098331  9380 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_LaunchCommandTask (42603 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47082/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5143
https://issues.apache.org/jira/browse/MESOS-5143


Repository: mesos


Description
---

When a slave is removed, master sends a LostSlaveMessage to affected
frameworks only (instead of all registered frameworks). An affected
framework is a framework which satisfied one or more conditions of
the following:

1. There are running tasks on this slave belonging to the framework.
2. Reserved resources on the slave have a matching role with the
   role of the framework.
3. There are pending offers from this slave for the framework.


Diffs
-

  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
  src/tests/master_authorization_tests.cpp 
804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
  src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 

Diff: https://reviews.apache.org/r/47082/diff/


Testing
---

All existing and modified tests passed.


Thanks,

Anindya Sinha

Re: Review Request 45562: Edited `--work_dir` configuration docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45562/
---

(Updated May 7, 2016, 1:29 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Some users have encountered difficulty when running the Mesos agent
with the `work_dir` located in a subdirectory of `/tmp`. This patch
adds language to the `work_dir` help strings and configuration docs
advising users to avoid the use of this location in production.


Diffs (updated)
-

  docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 

Diff: https://reviews.apache.org/r/45562/diff/


Testing
---

Viewed with the Mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 46004: Updated master '--work_dir' help string.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46004/
---

(Updated May 7, 2016, 1:29 a.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Adds language to the master's `--work_dir` help string which advises
users to avoid locations in '/tmp' when setting the work directory.


Diffs (updated)
-

  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/46004/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 46005: Updated references to agent work_dir to Option type.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46005/
---

(Updated May 7, 2016, 1:29 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Updated references to `flags.work_dir` in the agent code to use `.get()`
now that the work directory is an `Option`. We enforce that
`flags.work_dir.isSome()` in the agent initialization code and in
'src/slave/main.cpp', so we don't have to perform this check elsewhere
in the agent code.


Diffs
-

  src/slave/containerizer/containerizer.cpp 
d0cae79834e451594d7675f00c5f7d2d2cd3a264 
  src/slave/containerizer/docker.cpp 9c24227171c88ee89b567ebc5200a9563dfff5be 
  src/slave/containerizer/external_containerizer.cpp 
cf4384cce44172a028c890f52f71ceb8ae109383 
  src/slave/containerizer/mesos/containerizer.cpp 
c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
9fc7c48f99155750fd3c18c7c102507e2726362b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
8a4938ebe4e00779e88e7c538445e9ffd51202e2 
  src/slave/http.cpp a684ff504535e2b9b2064f8048f5e03a0efcb059 
  src/slave/slave.cpp f090c853b8affc4be5eecb4f616ec881fc2b60c3 
  src/slave/status_update_manager.cpp d616fd4e4f140666bb691752cc93f0bc6fcd6e6e 
  src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
  src/tests/containerizer/docker_containerizer_tests.cpp 
7accd32fba5eed196a82b1a171cb16d37b9e0539 
  src/tests/containerizer/external_containerizer_test.cpp 
226eac56725e908040abda306a2e5e3c96bce9d7 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
51e60c2e8c6c8b76b51de0e7761ecbb0ca9c3304 
  src/tests/containerizer/isolator_tests.cpp 
7b4d47bd9e99b71269093d7c11559f3b74a3e22b 
  src/tests/containerizer/port_mapping_tests.cpp 
21ad1e1c53316a3bb6d914aa228ccf3658acdfbf 
  src/tests/containerizer/provisioner_appc_tests.cpp 
84fe52b6937c3b7d7628b17a2f045eec2f386b4d 
  src/tests/fetcher_cache_tests.cpp 9ffcd2375f1203bd3d7c5d0cc898e955d5cb124e 
  src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
  src/tests/master_contender_detector_tests.cpp 
1426a173b1f458d67b748016aee311ac008b054a 
  src/tests/persistent_volume_tests.cpp 
d246f35046fff469b847c908de2b305ae629212f 
  src/tests/reservation_tests.cpp 2d7fb21e2fe153c2b62dfd60bbaccb350a157391 
  src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 
  src/tests/status_update_manager_tests.cpp 
f5313a124c59eba3da86a173817d0c2a6a943e17 

Diff: https://reviews.apache.org/r/46005/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 46003: Removed the default value for agent work_dir.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46003/
---

(Updated May 7, 2016, 1:28 a.m.)


Review request for mesos, Michael Park and Vinod Kone.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

The default value for the agent's `--work_dir` flag was removed, the
type of the parameter was changed to `Option`, and code was
added to explicitly set the work directory when necessary.


Diffs (updated)
-

  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46003/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann

Re: Review Request 47078: Added checking for required flags to FlagsBase.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47078/
---

(Updated May 7, 2016, 1:27 a.m.)


Review request for mesos and Michael Park.


Changes
---

Changed template parameter from Option to pointer


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Added checking for required flags to FlagsBase.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/47078/diff/


Testing (updated)
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46882: Added a LoggingTest with authorization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46882/#review132117
---



Patch looks great!

Reviews applied: [46866, 46867, 46883, 46869, 46870, 46876, 46881, 46882]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 9:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46882/
> ---
> 
> (Updated May 6, 2016, 9:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A new test, `LoggingTest.ToggleAuthorizationEnabled`,
> was added which checks that the '/logging/toggle'
> endpoint correctly rejects unauthorized requests.
> 
> 
> Diffs
> -
> 
>   src/tests/logging_tests.cpp 541274460f7d623eedca4d5c4780015e1bd4f961 
> 
> Diff: https://reviews.apache.org/r/46882/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47062/#review132114
---



Bad patch!

Reviews applied: [47062, 47061]

Failed command: ./support/apply-review.sh -n -r 47062

Error:
2016-05-06 23:57:23 URL:https://reviews.apache.org/r/47062/diff/raw/ 
[1646/1646] -> "47062.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12923/console

- Mesos ReviewBot


On May 6, 2016, 9:16 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47062/
> ---
> 
> (Updated May 6, 2016, 9:16 p.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5316
> https://issues.apache.org/jira/browse/MESOS-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Testcase SlaveTest.HTTPEndpointsBadAuthentication is updated to use 
> authentication when hitting '/containers' endpoint as well as when bad 
> credentials are provided.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 
> 
> Diff: https://reviews.apache.org/r/47062/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j2 check 
> On Ubuntu 16.04
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47071/#review132113
---



Patch looks great!

Reviews applied: [46613, 47068, 47069, 47070, 47071]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 8:35 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47071/
> ---
> 
> (Updated May 6, 2016, 8:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The /state and /task endpoints output framework and task level data.
> Hence we need to authorize both frameworks and tasks.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> e59c11269670a7ed72b780913971b421ee17f33f 
>   src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
> 
> Diff: https://reviews.apache.org/r/47071/diff/
> 
> 
> Testing
> ---
> 
> make check (osx)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 47080: Agent should backoff when establishing a socket.

[Cong Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47080/#review132111
---


Ship it!




Ship It!

- Cong Wang


On May 6, 2016, 10:51 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47080/
> ---
> 
> (Updated May 6, 2016, 10:51 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
> 
> 
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent should backoff when establishing a socket.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
> 
> Diff: https://reviews.apache.org/r/47080/diff/
> 
> 
> Testing
> ---
> 
> make tests
> make check
> 
> Also started a master and agent and captured a tcpdump to verify the 
> connection is only established _after_ the registration backoff.
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 47080: Agent should backoff when establishing a socket.

[David Robinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47080/
---

(Updated May 6, 2016, 10:51 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.


Bugs: MESOS-5330
https://issues.apache.org/jira/browse/MESOS-5330


Repository: mesos


Description
---

Agent should backoff when establishing a socket.


Diffs
-

  src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 

Diff: https://reviews.apache.org/r/47080/diff/


Testing (updated)
---

make tests
make check

Also started a master and agent and captured a tcpdump to verify the connection 
is only established _after_ the registration backoff.


Thanks,

David Robinson

Review Request 47080: Agent should backoff when establishing a socket.

[David Robinson]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47080/
---

Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.


Bugs: MESOS-5330
https://issues.apache.org/jira/browse/MESOS-5330


Repository: mesos


Description
---

Agent should backoff when establishing a socket.


Diffs
-

  src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 

Diff: https://reviews.apache.org/r/47080/diff/


Testing
---

make tests

Also started a master and agent and captured a tcpdump to verify the connection 
is only established _after_ the registration backoff.


Thanks,

David Robinson

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review132106
---



Bad patch!

Reviews applied: [46799, 46798, 46371, 46370, 46369]

Failed command: ./support/apply-review.sh -n -r 46371

Error:
2016-05-06 21:48:11 URL:https://reviews.apache.org/r/46371/diff/raw/ 
[18318/18318] -> "46371.patch" [1]
error: patch failed: src/Makefile.am:2045
error: src/Makefile.am: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12921/console

- Mesos ReviewBot


On May 6, 2016, 5:06 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> ---
> 
> (Updated May 6, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two flags: `user` and `capabilities`.
> 
>user:  used to specify the user name for the command.
>capabilities: comma separated list of capabilities the task
>  requires.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
> 
> Diff: https://reviews.apache.org/r/46799/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 47078: Added checking for required flags to FlagsBase.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47078/
---

(Updated May 6, 2016, 9:48 p.m.)


Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Added checking for required flags to FlagsBase.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/47078/diff/


Testing (updated)
---


Thanks,

Greg Mann

Review Request 47078: Added checking for required flags to FlagsBase.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47078/
---

Review request for mesos and Michael Park.


Bugs: MESOS-5064
https://issues.apache.org/jira/browse/MESOS-5064


Repository: mesos


Description
---

Added checking for required flags to FlagsBase.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 

Diff: https://reviews.apache.org/r/47078/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46990/
---

(Updated May 6, 2016, 9:21 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The previous commit added authorization handling
to `ProcessBase::visit`, so the authorization
handlers in the endpoint code can be removed.


Diffs
-

  3rdparty/libprocess/include/process/logging.hpp 
651cb3736705124bec9e4366c0e7adc5d5b488f0 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46990/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/
---

(Updated May 6, 2016, 9:20 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds the handling of authorization calls
for libprocess-level HTTP endpoints into the
`ProcessBase::visit` method. The authorization results
are sequenced to assure that operations are execute in
the same order in which they are received.


Diffs
-

  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46989/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

[Greg Mann]

> On May 6, 2016, 6:01 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 3346-3355
> > 
> >
> > Can we simplify the logic a bit here and add some explanation?

This review was merged into https://reviews.apache.org/r/46866/


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/#review132085
---


On May 5, 2016, 8:15 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46989/
> ---
> 
> (Updated May 5, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the handling of authorization calls
> for libprocess-level HTTP endpoints into the
> `ProcessBase::visit` method. The authorization results
> are sequenced to assure that operations are execute in
> the same order in which they are received.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46989/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46882: Added a LoggingTest with authorization.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46882/
---

(Updated May 6, 2016, 9:18 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

A new test, `LoggingTest.ToggleAuthorizationEnabled`,
was added which checks that the '/logging/toggle'
endpoint correctly rejects unauthorized requests.


Diffs (updated)
-

  src/tests/logging_tests.cpp 541274460f7d623eedca4d5c4780015e1bd4f961 

Diff: https://reviews.apache.org/r/46882/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/
---

(Updated May 6, 2016, 9:17 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds an authorization callback to the
generating function `CreateAuthorizationCallbacks`
for the '/logging/toggle' endpoint.


Diffs (updated)
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46881/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46880: Added authorization to '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46880/
---

(Updated May 6, 2016, 9:17 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

Authorization is added to the '/logging/toggle' endpoint,
enabling it to call an authorization callback which has
been correctly installed in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/logging.hpp 
651cb3736705124bec9e4366c0e7adc5d5b488f0 
  3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 

Diff: https://reviews.apache.org/r/46880/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46870: Added MetricsTests with authorization.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46870/
---

(Updated May 6, 2016, 9:16 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

New tests were added: `MetricsTest.AgentAuthorizationEnabled`
and `MetricsTest.MasterAuthorizationEnabled`. They verify
that unauthorized requests to the '/metrics/snapshot'
endpoints are rejected.


Diffs (updated)
-

  src/tests/metrics_tests.cpp 2ff6bb5b9ff6040009cb58730f09d6727fb9627c 

Diff: https://reviews.apache.org/r/46870/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46869/
---

(Updated May 6, 2016, 9:16 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The test cluster initialization code was altered
to enable authorization of libprocess-level HTTP
endpoints when a master or agent is launched
with authorization enabled.


Diffs (updated)
-

  src/tests/cluster.cpp db7262868164b1966a9824b8aa53dbe9c5af7c2f 

Diff: https://reviews.apache.org/r/46869/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46876/
---

(Updated May 6, 2016, 9:17 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

Some tests hit the '/metrics/snapshot' endpoint and
must be updated to accomodate authorization. In
particular, an authorizer had to be explicitly
instantiated and used to initialize the master/agent
in some tests so that they share the same authorizer.


Diffs (updated)
-

  src/tests/master_authorization_tests.cpp 
804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 
  src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2 
  src/tests/mesos.cpp 036c589f5aafc8c804b0fb4e5ad62df70e471e88 
  src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1 
  src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 

Diff: https://reviews.apache.org/r/46876/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46883/
---

(Updated May 6, 2016, 9:16 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Rebase, change dependency.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds a callback to the generating
function `CreateAuthorizationCallbacks` for the
'/metrics/snapshot' endpoint.


Diffs (updated)
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46883/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 47062: Modified testcase for authentication on '/containers' endpoint.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47062/
---

(Updated May 6, 2016, 9:16 p.m.)


Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Summary (updated)
-

Modified testcase for authentication on '/containers' endpoint.


Bugs: MESOS-5316
https://issues.apache.org/jira/browse/MESOS-5316


Repository: mesos


Description
---

Testcase SlaveTest.HTTPEndpointsBadAuthentication is updated to use 
authentication when hitting '/containers' endpoint as well as when bad 
credentials are provided.


Diffs (updated)
-

  src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 

Diff: https://reviews.apache.org/r/47062/diff/


Testing
---

sudo make -j2 check 
On Ubuntu 16.04


Thanks,

Abhishek Dasgupta

Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46868/
---

(Updated May 6, 2016, 9:15 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The '/metrics/snapshot' handler is updated to
authorize requests via an authorization callback
installed in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46868/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46867/
---

(Updated May 6, 2016, 9:14 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Rebase.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

Code is added to the common headers and the
master/agent executables which sets authorization
callbacks for libprocess-level HTTP endpoints.
This allows these endpoints to be authorized.


Diffs (updated)
-

  src/common/http.hpp 6c6f2840bbf49d198b1db876cdf4af5ef49b0e27 
  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/46867/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46866/
---

(Updated May 6, 2016, 9:13 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Addressed comments.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch enables libprocess to store and execute
authorization callbacks provided by a client
application.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
8f4eabcbb71ead1f5c28e1d8a2dd40db7af1f297 
  3rdparty/libprocess/src/process.cpp dcaa64633d1eea330649c563635642928164d73c 

Diff: https://reviews.apache.org/r/46866/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46438/#review132100
---



Patch looks great!

Reviews applied: [46096, 46097, 46435, 46436, 46438]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 2:09 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46438/
> ---
> 
> (Updated May 6, 2016, 2:09 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_SlaveRecovery".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46438/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_SlaveRecovery
> I0420 22:36:44.632558 10440 exec.cpp:150] Version: 0.29.0
> I0420 22:36:44.655817 10456 exec.cpp:225] Executor registered on agent 
> 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> Registered executor on mesos
> Starting task 190bb5f3-c917-4848-820b-bf76d9251cf6
> sh -c 'sleep 5'
> Forked command at 10463
> I0420 22:36:44.856591 10455 exec.cpp:271] Received reconnect request from 
> agent 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> I0420 22:36:44.859297 10455 exec.cpp:248] Executor re-registered on agent 
> 444d7f44-a320-42e4-874e-efa06378dc0f-S0
> Re-registered executor on mesos
> Command exited with status 0 (pid: 10463)
> I0420 22:36:49.796159 10456 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_SlaveRecovery (6436 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 46730: Cleanup syscalls logic.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review132098
---


Ship it!




Ship It!

- Ben Mahler


On April 29, 2016, 1:03 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46730/
> ---
> 
> (Updated April 29, 2016, 1:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-5263
> https://issues.apache.org/jira/browse/MESOS-5263
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `` and removed uncessary condition complie.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 
> 
> Diff: https://reviews.apache.org/r/46730/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47071/
---

Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

The /state and /task endpoints output framework and task level data.
Hence we need to authorize both frameworks and tasks.


Diffs
-

  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 
  src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 

Diff: https://reviews.apache.org/r/47071/diff/


Testing
---

make check (osx)


Thanks,

Joerg Schad

Review Request 47070: Added framework filtering to /state-summary endoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47070/
---

Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

As the /state-summary endpoint only outputs the frameworks
(but not tasks) it is sufficient to filter unauthorized frameworks
for this endpoint.


Diffs
-

  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 
  src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 
  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 

Diff: https://reviews.apache.org/r/47070/diff/


Testing
---

make check (osx)


Thanks,

Joerg Schad

Review Request 47069: Added `user` field to `Task` protobuf message.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47069/
---

Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

As the LocalAuthorizer will use the OS `user` for
authorization of tasks we add it to the `Task` protobug
message. Note that the master stores `Task` (as opposed
to `TaskInfo`) for running and completed tasks.


Diffs
-

  src/common/protobuf_utils.cpp 4f4711d54c471922f1a103310d4d360e41a99870 
  src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c 

Diff: https://reviews.apache.org/r/47069/diff/


Testing
---

tested entire check.


Thanks,

Joerg Schad

Review Request 47068: Added fine-grained filtering master flag.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47068/
---

Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Repository: mesos


Description
---

Added a master flag enabling the fine-grained
authorization based filtering of HTTP endpoints.
The default for this setting is `false` as the filtering incurs
a performance penalty.


Diffs
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a 
  src/master/flags.hpp e4cac1f8d688319c804e608b7229f458f779364a 
  src/master/flags.cpp c0c9e924e876175b75a174e375a4c993d97e18ee 

Diff: https://reviews.apache.org/r/47068/diff/


Testing
---

tested entire chain.


Thanks,

Joerg Schad

Re: Review Request 46613: Introduced filtering relevant actions and acls.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/
---

(Updated May 6, 2016, 8:28 p.m.)


Review request for mesos, Adam B, Alexander Rojas, and Michael Park.


Summary (updated)
-

Introduced filtering relevant actions and acls.


Bugs: MESOS-5169
https://issues.apache.org/jira/browse/MESOS-5169


Repository: mesos


Description (updated)
---

In order to allow for framework and task level filtering we introduce
the following authorizer actions:
* VIEW_FRAMEWORK_WITH_INFO
* VIEW_TASK_WITH_EXECUTOR_INFO = 13;
* VIEW_TASK_WITH_COMMAND_INFO = 14;
* VIEW_TASK_WITH_TASK = 15;

Note that we need different actions for authorizing a tasks
based on the object being authorized.

We also introduce the following acls for the local authorizer:
* ViewFrameworks  (giving access to frameworks running in
a given role)
* ViewTasks view_tasks (giving access to Tasks run under a
specific OS user)


Diffs (updated)
-

  docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
  include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
  include/mesos/authorizer/authorizer.proto 
32492a59ad95df3bb673ec42321518f86c11af59 
  src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f 

Diff: https://reviews.apache.org/r/46613/diff/


Testing
---

make check (OSX)


Thanks,

Joerg Schad

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/#review132096
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 0, 39474, 36383]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 12:40 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36383/
> ---
> 
> (Updated May 6, 2016, 12:40 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker volume test case by adding checkpoint verify logic.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> ae58775a0afe083c56165002040c952805ad0c2e 
> 
> Diff: https://reviews.apache.org/r/36383/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review132086
---




include/mesos/mesos.proto (line 1737)


I would call it `LinuxInfo` instead.

ProcessConfig sounds weird to me, even in the OCI spec. I understand things 
like capability, rlimit are process specific, but the only process we have 
control is the init process (i.e., the executor process in our case). I would 
rather simply that. All configurations are container level, if things like 
rlimit, capability are process specific, it'll be applied to the init process.



include/mesos/mesos.proto (line 1739)


Can you move this to the top level (i.e., not nested in LinuxInfo).



include/mesos/mesos.proto (line 1741)


Having an enum value being 0 is bad. See BenM's email about enumeration 
type semantics in protobuf. Basically, an unknown enum value will be mapped to 
0. For instance, if in the future, linux adds a new capability. If we simply 
extend this list, the old master/agent (using the old protobuf) will map that 
to 0 (CHOWN), which is not expected.

I understand that you want the value to be the same as that defined in 
`linux/capability.h`. But I don't think that's strictly necessary, right? I 
would suggest that you start the first enum at `1000` (i.e., `CHOWN = 1000`) so 
that you still have a systematic way to do the conversion. Also, we should set 
`UNKNOWN = 0`.


- Jie Yu


On May 6, 2016, 5:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated May 6, 2016, 5:02 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 46923: Added framework failover timeout validation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review132092
---



Patch looks great!

Reviews applied: [46923]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 12:09 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 6, 2016, 12:09 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 46920: Added validation hook inside Slave::runTask.

[Kapil Arya]

> On May 6, 2016, 3:37 a.m., Adam B wrote:
> > Please create a JIRA with motivation for this hook. I don't want a new hook 
> > to slip into a release without a JIRA in the changelog to document it.

Good point. I meant to add it to the RR, but it slipped :-).


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46920/#review131997
---


On May 5, 2016, 12:01 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46920/
> ---
> 
> (Updated May 5, 2016, 12:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to 
> inspect the contents of a task and potentially reject the task with a 
> `TASK_ERROR`.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca 
>   src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 
>   src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 
>   src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
>   src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 
> 
> Diff: https://reviews.apache.org/r/46920/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46989/#review132085
---




3rdparty/libprocess/src/process.cpp (lines 3299 - 3308)


Can we simplify the logic a bit here and add some explanation?



3rdparty/libprocess/src/process.cpp (lines 3315 - 3318)


Simplify this too so that callback_path is set iff there is a callback for 
the requested URL.


- Kapil Arya


On May 5, 2016, 4:15 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46989/
> ---
> 
> (Updated May 5, 2016, 4:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds the handling of authorization calls
> for libprocess-level HTTP endpoints into the
> `ProcessBase::visit` method. The authorization results
> are sequenced to assure that operations are execute in
> the same order in which they are received.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> dcaa64633d1eea330649c563635642928164d73c 
> 
> Diff: https://reviews.apache.org/r/46989/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review132084
---




src/tests/containerizer/cni_isolator_tests.cpp (line 42)


Instead of using a script here, can we use code to get ip network and name 
server information?

You can take a look at `links()` and `IPNetwork::fromLinkDevice(..)` in 
stout.

I would suggest that we define a test fixture for the isolator tests and 
get the ip network and nameserver address in the SetUp function. We can also 
put the helpers to create plugin/config in the test fixture.


- Jie Yu


On May 6, 2016, 2:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46097/
> ---
> 
> (Updated May 6, 2016, 2:06 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5167
> https://issues.apache.org/jira/browse/MESOS-5167
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
>   src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46097/diff/
> 
> 
> Testing
> ---
> 
> [ RUN  ] CniIsolatorTest.ROOT_LaunchCommandTask
> + /home/stack/workspace/mesos/build/src/mesos-containerizer mount 
> --help=false --operation=make-rslave --path=/
> + grep+  -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/.+ 
> /proc/self/mountinfo
> + grepcut -v -d  -f5
>  d06b117d-518b-41e2-b8e0-62a12083773c
> + xargs --no-run-if-empty umount -l
> + mount -n --rbind 
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/provisioner/containers/d06b117d-518b-41e2-b8e0-62a12083773c/backends/copy/rootfses/7ea27011-cd3a-43b0-8301-b0b94d9f9b47
>  
> /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/slaves/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0/frameworks/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-/executors/60e6d35d-6d33-47ae-9c23-d2e5c913c892/runs/d06b117d-518b-41e2-b8e0-62a12083773c/.rootfs
> I0420 22:26:00.924844  9305 exec.cpp:150] Version: 0.29.0
> I0420 22:26:00.942319  9375 exec.cpp:225] Executor registered on agent 
> 18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0
> Registered executor on mesos
> Starting task 60e6d35d-6d33-47ae-9c23-d2e5c913c892
> Forked command at 9382
> sh -c 'ls /'
> bin  dev  etc  home lib  linuxrc  mediamnt  proc  
>root run  sbin sys  tmp  usr  var
> Command exited with status 0 (pid: 9382)
> I0420 22:26:01.098331  9380 exec.cpp:399] Executor asked to shutdown
> [   OK ] CniIsolatorTest.ROOT_LaunchCommandTask (42603 ms)
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 39474: Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review132075
---


Fix it, then Ship it!





src/tests/containerizer/docker_volume_isolator_tests.cpp (line 814)


I don't think we need that. it's the default.


- Jie Yu


On May 6, 2016, 4:27 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 6, 2016, 4:27 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> ae58775a0afe083c56165002040c952805ad0c2e 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes"
>  --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47062: Modified testcase for testing authentication on '/containers' endpoint.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47062/#review132074
---



Bad patch!

Reviews applied: [47062, 47061]

Failed command: ./support/apply-review.sh -n -r 47062

Error:
2016-05-06 17:14:37 URL:https://reviews.apache.org/r/47062/diff/raw/ 
[1646/1646] -> "47062.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/12917/console

- Mesos ReviewBot


On May 6, 2016, 9:57 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47062/
> ---
> 
> (Updated May 6, 2016, 9:57 a.m.)
> 
> 
> Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5316
> https://issues.apache.org/jira/browse/MESOS-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Testcase SlaveTest.HTTPEndpointsBadAuthentication is updated to use 
> authentication when hitting '/containers' endpoint as well as when bad 
> credentials are provided.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 
> 
> Diff: https://reviews.apache.org/r/47062/diff/
> 
> 
> Testing
> ---
> 
> sudo make -j2 check 
> On Ubuntu 16.04
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Jojy Varghese]

> On April 29, 2016, 12:19 a.m., Qian Zhang wrote:
> > src/cli/execute.cpp, lines 172-175
> > 
> >
> > Can we only add this flag in Linux? Then user will not see this flag at 
> > all when running `mesos-execute` in other platorms.
> 
> Jojy Varghese wrote:
> I avoided that logic as it would mean spreading `ifdef` all over the file.
> 
> Qian Zhang wrote:
> Right, but I think that is the common way to handle the platform-specific 
> logic, you can take a look at: 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp,
>  in this file, we use `#ifdef __linux__` for all the isolators which can be 
> only enabled on Linux.

I have looked at the platform speific ifdefs in the code and I am not sure if 
that is the right way to do platform specific code. Linux kernel is a good 
example of how it actually should be done. But I am changing the code in cli 
for now for uniformity.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/#review131021
---


On May 6, 2016, 5:06 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46799/
> ---
> 
> (Updated May 6, 2016, 5:06 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces two flags: `user` and `capabilities`.
> 
>user:  used to specify the user name for the command.
>capabilities: comma separated list of capabilities the task
>  requires.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
> 
> Diff: https://reviews.apache.org/r/46799/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 46799: Added capabilities support to mesos-execute.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46799/
---

(Updated May 6, 2016, 5:06 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change introduces two flags: `user` and `capabilities`.

   user:  used to specify the user name for the command.
   capabilities: comma separated list of capabilities the task
 requires.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 

Diff: https://reviews.apache.org/r/46799/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46798/
---

(Updated May 6, 2016, 5:05 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change introduces linux capability based security for unified
containerizer. A new agent flag `allowed_capabilities` has been
introduced to override the default capabilities of the user or the
capabilities requested by the user.

This feature is only available on linux.


Diffs (updated)
-

  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/slave/containerizer/mesos/containerizer.hpp 
13399f014dcd85defbff79f3b5aa4e7e75d41fd1 
  src/slave/containerizer/mesos/containerizer.cpp 
8d538954d6e1f13e833d75c2eaa37e700278ee0c 
  src/slave/containerizer/mesos/launch.hpp 
c716e0396736d1f2f60ec31540f12f4f7597d081 
  src/slave/containerizer/mesos/launch.cpp 
e22106b014c871e2184a15c2ab154a0674874e47 
  src/slave/flags.hpp 4fa3213545d4bd3525d85c3f71749f00f08dc998 
  src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14 
  src/tests/container_logger_tests.cpp efadceafca5721bce4dbffadb35f54fd5365abb0 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
29d313051865761306029f331eb36684c3252ffb 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46798/diff/


Testing
---

make check; used mesos cli to test end to end functionality.


Thanks,

Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46370/
---

(Updated May 6, 2016, 5:03 p.m.)


Review request for mesos, Jie Yu and Kevin Klues.


Bugs: MESOS-5051
https://issues.apache.org/jira/browse/MESOS-5051


Repository: mesos


Description
---

This change introduces basic API for linux capabilities. This is not a
comprehensive API but is strictly limited to the need for securing Mesos
containers using linux capabilities.


Diffs (updated)
-

  src/CMakeLists.txt f991743f1a467f24a786e925983390a411792327 
  src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 
  src/linux/capabilities.hpp PRE-CREATION 
  src/linux/capabilities.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46370/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/
---

(Updated May 6, 2016, 5:02 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5232
https://issues.apache.org/jira/browse/MESOS-5232


Repository: mesos


Description
---

Added capabilities support in ContanerInfo protobuf.


Diffs (updated)
-

  include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
  include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 

Diff: https://reviews.apache.org/r/46369/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46874/#review132069
---



Patch looks great!

Reviews applied: [46874]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 5:59 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46874/
> ---
> 
> (Updated May 6, 2016, 5:59 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The mesos-containerizer will help prepare the rootfs, mount and
> network conf for a container when launch with some flags, it
> would be helpful to print out all of the mesos-containerizer launch
> flags for trouble shooting.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 75e5a32a3e70ec60a6800e21a621673184ea0956 
> 
> Diff: https://reviews.apache.org/r/46874/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Enhanced log message:
> I0501 14:12:17.910006  5991 containerizer.cpp:1175] Launching 
> 'mesos-containerizer' with flags 
> '--command="{"shell":true,"value":"\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-executor"}"
>  --commands="{"commands":[{"shell":true,"value":"#!\/bin\/sh\nset -x 
> -e\n\/root\/src\/mesos\/m1\/mesos\/build\/src\/mesos-containerizer mount 
> --help=\"false\" --operation=\"make-rslave\" --path=\"\/\"\ngrep -E 
> '\/tmp\/mesos\/.+' \/proc\/self\/mountinfo | grep -v 
> 'a2cc264f-72eb-416c-b876-e4a98484a0ab' | cut -d' ' -f5 | xargs 
> --no-run-if-empty umount -l || true \n"}]}" --help="false" --pipe_read="8" 
> --pipe_write="9" 
> --sandbox="/tmp/mesos/slaves/5763efb9-8e12-4bfc-b06b-2a324881608d-S0/frameworks/425afd24-796d-42dd-98c0-593f1d71e246-/executors/test/runs/a2cc264f-72eb-416c-b876-e4a98484a0ab"
>  --user="root"'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review132065
---


Ship it!




Ship It!

- haosdent huang


On May 6, 2016, 3:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 6, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47056/#review132064
---


Ship it!




Ship It!

- haosdent huang


On May 6, 2016, 6:26 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47056/
> ---
> 
> (Updated May 6, 2016, 6:26 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5287
> https://issues.apache.org/jira/browse/MESOS-5287
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove python-boto since 'mesos-ec2' has been removed.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/47056/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

[haosdent huang]

> On May 6, 2016, 4:29 p.m., haosdent huang wrote:
> > support/docker_build.sh, line 60
> > 
> >
> > I think need update the `docs/getting-started.md`.

Oh, you have already updated it in https://reviews.apache.org/r/46958/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47056/#review132061
---


On May 6, 2016, 6:26 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47056/
> ---
> 
> (Updated May 6, 2016, 6:26 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5287
> https://issues.apache.org/jira/browse/MESOS-5287
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove python-boto since 'mesos-ec2' has been removed.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/47056/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47056/#review132061
---




support/docker_build.sh (line 60)


I think need update the `docs/getting-started.md`.


- haosdent huang


On May 6, 2016, 6:26 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47056/
> ---
> 
> (Updated May 6, 2016, 6:26 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5287
> https://issues.apache.org/jira/browse/MESOS-5287
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove python-boto since 'mesos-ec2' has been removed.
> 
> 
> Diffs
> -
> 
>   configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe 
>   support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 
> 
> Diff: https://reviews.apache.org/r/47056/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 47058: Fix accessibility of table in web GUI.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/#review132055
---



Do you forgot to update `src/webui/master/static/browse.html` in this patch?


src/webui/master/static/slave_executor.html (line 169)


Remove the extra space. ``


- haosdent huang


On May 6, 2016, 8:57 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47058/
> ---
> 
> (Updated May 6, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix accessibility of table in web GUI.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/offers.html 
> ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 
> 99b23ed9e85011a66bad780fb2d3076e946821a6 
>   src/webui/master/static/slave_framework.html 
> 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
>   src/webui/master/static/slaves.html 
> 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/47058/diff/
> 
> 
> Testing
> ---
> 
> We should use the scope attribute to associate header cells and data cells in 
> data tables.
> 
> It can make screen readers to find a header of date cell in table.
> 
> for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46975: Add title and heading in Mesos Log Page.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46975/#review132051
---


Fix it, then Ship it!




Ship It!


src/webui/master/static/pailer.html (line 5)


Seems use `Mesos Log Pailer` would be better here.


- haosdent huang


On May 6, 2016, 1:30 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46975/
> ---
> 
> (Updated May 6, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add title and heading in Mesos Log Page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/pailer.html 
> 19e0981143bd7e8372b49f4f036867e9dd05727a 
> 
> Diff: https://reviews.apache.org/r/46975/diff/
> 
> 
> Testing
> ---
> 
> Mesos log page should have a title. for details: 
> https://www.w3.org/TR/WCAG20-TECHS/H25
> 
> And Should give a heading to tell screen reader that the content in the page 
> is "Mesos log"
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46966: Added associated labels to form in webui

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46966/#review132050
---


Fix it, then Ship it!




Ship It!


src/webui/master/static/directives/tableHeader.html (line 10)


I think need to change it like
```


Find

```
Because it should be the content of `input-group-addon`, not the content of 
glyphicon.


- haosdent huang


On May 6, 2016, 1:29 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46966/
> ---
> 
> (Updated May 6, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Form controls must have associated labels.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/directives/tableHeader.html 
> 448f67ef20c279fdd542890158fb9f96a10ebebc 
> 
> Diff: https://reviews.apache.org/r/46966/diff/
> 
> 
> Testing
> ---
> 
> Using aria-label "search" to make screen reader to identify that the text 
> form is for search.
> 
> and use content to replace placeholder to make the "Find"text more visible.
> 
> Use of the placeholder attribute as a replacement for a programmatically 
> associated visible label can reduce the accessibility and usability of the 
> control for a range of users including older users and users with cognitive, 
> mobility.
> 
> refer to 
> https://www.paciellogroup.com/blog/2011/02/html5-accessibility-chops-the-placeholder-attribute/
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> > src/webui/master/static/index.html, line 22
> > 
> >
> > +1 For use `banner` :-)

Use `banner` is more boostrap style.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

> On May 6, 2016, 3:24 p.m., haosdent huang wrote:
> >

I think also need

1. Update the bug field to jira ticket
2. Description should be limited in 72 characters.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46965/#review132041
---




src/webui/master/static/css/mesos.css (line 5)


I think need to use `.navbar-header h1` as selector here, because I think 
we don't want to overwrite the margin of `h1` globally.



src/webui/master/static/index.html (line 21)


Actualy I think here is not the main.

```

```

should be the main.

Contains `banner` in `main` looks wired as well.

Or we could delegate this to templates. Because we have two major layout 
styles, one is a left `dashboard` + a `main`. The other one is `main`.



src/webui/master/static/index.html (line 22)


+1 For use `banner` :-)



src/webui/master/static/index.html (line 32)


Fix the incorrent indent here.
```

  Mesos

```


- haosdent huang


On May 5, 2016, 5:03 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46965/
> ---
> 
> (Updated May 5, 2016, 5:03 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using ARIA landmarks to identify regions of a page and Providing heading 
> elements at the beginning of each section of content.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
> 
> Diff: https://reviews.apache.org/r/46965/diff/
> 
> 
> Testing
> ---
> 
> we should Using ARIA landmarks to identify regions of a page.
> 
> 1.Should add "main" role to main content page and use "banner" role for header
> refer to https://www.w3.org/TR/WCAG20-TECHS/ARIA11
> 
> 2. Providing heading elements at the beginning of each section of content. So 
> for the header section we need provide a h1
> refer to https://www.w3.org/TR/WCAG20-TECHS/H69.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46373/#review132042
---



Patch looks great!

Reviews applied: [46373]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 5:08 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46373/
> ---
> 
> (Updated May 6, 2016, 5:08 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Greg Mann.
> 
> 
> Bugs: mesos-5060
> https://issues.apache.org/jira/browse/mesos-5060
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> [MESOS-5060]
> The patch did the following changes:
> 1. Fix the length logic in files.cpp.
> 2. Add some tests to test the /files/read.json endponit with
> negative length.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp 4e916101b378b0e9032a08a3f6c73e195b2a08a1 
>   src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd 
> 
> Diff: https://reviews.apache.org/r/46373/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> request 'files/read.json' endpoint with negative offset or length argument
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46964: Using the summary attribute of the table element.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/#review132032
---



Hi, @lichenn. Thanks a lot for your patch! Here are some my comments for this, 
free feel to drop them if you think them don't make sense.

1. Seems missing update tables in browse.html
2. Because we prefer keep the length of code in 80 characters, I suggest to 
start summary attribute in a new line.
For example,
```

```

3. I guest to use Mesos instead of mesos in summary because `Mesos` looks more 
popular in this case.

```
$ cd docs
grep -cr 'Mesos' .|cut -d':' -f2|paste -sd+ - | bc
792
$ grep -cr 'mesos' .|cut -d':' -f2|paste -sd+ - | bc
370 # Most of them are comes from code like `from mesos.native import 
MesosExecutorDrive`


src/webui/master/static/framework.html (line 95)


Should be completed tasks here?



src/webui/master/static/frameworks.html (line 62)


Should be completed frameworks or terminated frameworks here?



src/webui/master/static/home.html (line 144)


Do we need update these table elements?

```
Slaves
  
  
Tasks
  

Resources
   
``



src/webui/master/static/slave.html (line 48)


Do we need update here?



src/webui/master/static/slave.html (line 86)


Do we need update here?



src/webui/master/static/slave.html (line 126)


Should be `have running tasks`?



src/webui/master/static/slave_executor.html (line 55)


Do we need update here?



src/webui/master/static/slave_executor.html (line 126)


Actually here only show `running tasks`.



src/webui/master/static/slave_framework.html (line 34)


Do we need update here?



src/webui/master/static/slave_framework.html (line 80)


s/the current running/the running/g


- haosdent huang


On May 6, 2016, 8:56 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46964/
> ---
> 
> (Updated May 6, 2016, 8:56 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Using the summary attribute of the table element.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/framework.html 
> 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/frameworks.html 
> f172e022e18df5b6aa3d232e610c3c732e20aa09 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/offers.html 
> ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 
> 99b23ed9e85011a66bad780fb2d3076e946821a6 
>   src/webui/master/static/slave_framework.html 
> 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
>   src/webui/master/static/slaves.html 
> 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/46964/diff/
> 
> 
> Testing
> ---
> 
> Have checked with the patch by firebug, each table should have summary 
> attribute.
> 
> For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46438/
---

(Updated May 6, 2016, 10:09 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_SlaveRecovery".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46438/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_SlaveRecovery
I0420 22:36:44.632558 10440 exec.cpp:150] Version: 0.29.0
I0420 22:36:44.655817 10456 exec.cpp:225] Executor registered on agent 
444d7f44-a320-42e4-874e-efa06378dc0f-S0
Registered executor on mesos
Starting task 190bb5f3-c917-4848-820b-bf76d9251cf6
sh -c 'sleep 5'
Forked command at 10463
I0420 22:36:44.856591 10455 exec.cpp:271] Received reconnect request from agent 
444d7f44-a320-42e4-874e-efa06378dc0f-S0
I0420 22:36:44.859297 10455 exec.cpp:248] Executor re-registered on agent 
444d7f44-a320-42e4-874e-efa06378dc0f-S0
Re-registered executor on mesos
Command exited with status 0 (pid: 10463)
I0420 22:36:49.796159 10456 exec.cpp:399] Executor asked to shutdown
[   OK ] CniIsolatorTest.ROOT_SlaveRecovery (6436 ms)


Thanks,

Qian Zhang

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46436/
---

(Updated May 6, 2016, 10:08 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_FailedPlugin".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46436/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_FailedPlugin
[   OK ] CniIsolatorTest.ROOT_FailedPlugin (917 ms)


Thanks,

Qian Zhang

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46435/
---

(Updated May 6, 2016, 10:07 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".


Diffs (updated)
-

  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46435/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo
I0420 22:34:55.747752 10309 exec.cpp:150] Version: 0.29.0
I0420 22:34:55.768620 10328 exec.cpp:225] Executor registered on agent 
e5403695-ee6e-435c-a273-b9523adf7051-S0
Registered executor on mesos
Starting task 51bf9caa-9305-4533-8ba5-1d7982d807b7
sh -c 'sleep 1000'
Forked command at 10332
Received killTask for task 51bf9caa-9305-4533-8ba5-1d7982d807b7
Sending SIGTERM to process tree at pid 10332
Sent SIGTERM to the following process trees:
[ 
-+- 10332 sh -c sleep 1000 
 --- 10333 sleep 1000 
]
Command terminated with signal Terminated (pid: 10332)
[   OK ] CniIsolatorTest.ROOT_VerifyCheckpointedInfo (3090 ms)


Thanks,

Qian Zhang

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Qian Zhang]

> On May 6, 2016, 5:29 a.m., Jie Yu wrote:
> > This test failed on my machine:
> > 
> > ```
> > E0505 14:28:48.309273 42478 slave.cpp:3995] Container 
> > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor 
> > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- failed to start: Collect failed: 
> > Unable to parse the IP address  for the container: Unexpected number of '/' 
> > detected: 1
> > I0505 14:28:48.309643 42514 containerizer.cpp:1495] Destroying container 
> > '33dc5d83-125f-4da2-8c69-cba76d95955b'
> > I0505 14:28:48.315160 42487 cgroups.cpp:2676] Freezing cgroup 
> > /sys/fs/cgroup/freezer/mesos/33dc5d83-125f-4da2-8c69-cba76d95955b
> > Failed to synchronize with agent (it's probably exited)
> > I0505 14:28:48.406708 42472 containerizer.cpp:1731] Executor for container 
> > '33dc5d83-125f-4da2-8c69-cba76d95955b' has exited
> > I0505 14:28:48.422672 42505 cgroups.cpp:1409] Successfully froze cgroup 
> > /sys/fs/cgroup/freezer/mesos/33dc5d83-125f-4da2-8c69-cba76d95955b after 
> > 107.395072ms
> > I0505 14:28:48.426668 42507 cgroups.cpp:2694] Thawing cgroup 
> > /sys/fs/cgroup/freezer/mesos/33dc5d83-125f-4da2-8c69-cba76d95955b
> > I0505 14:28:48.431022 42510 cgroups.cpp:1438] Successfully thawed cgroup 
> > /sys/fs/cgroup/freezer/mesos/33dc5d83-125f-4da2-8c69-cba76d95955b after 
> > 4.254208ms
> > I0505 14:28:48.509074 42484 cni.cpp:1131] Unmounted the network namespace 
> > handle 
> > '/run/mesos/isolators/network/cni/33dc5d83-125f-4da2-8c69-cba76d95955b/ns' 
> > for container 33dc5d83-125f-4da2-8c69-cba76d95955b
> > I0505 14:28:48.509239 42484 cni.cpp:1142] Removed the container directory 
> > '/run/mesos/isolators/network/cni/33dc5d83-125f-4da2-8c69-cba76d95955b'
> > I0505 14:28:48.512855 42499 provisioner.cpp:338] Destroying container 
> > rootfs at 
> > '/tmp/CniIsolatorTest_ROOT_INTERNET_CURL_LaunchCommandTask_6wrXpg/provisioner/containers/33dc5d83-125f-4da2-8c69-cba76d95955b/backends/copy/rootfses/5bf9ed6f-0918-46d8-94f9-d20e8a03da9f'
> >  for container 33dc5d83-125f-4da2-8c69-cba76d95955b
> > I0505 14:28:48.610003 42474 slave.cpp:4108] Executor 
> > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- exited with status 1
> > I0505 14:28:48.613152 42474 slave.cpp:3221] Handling status update 
> > TASK_FAILED (UUID: 07b0c1ee-ef56-41e2-be69-2365427e370a) for task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- from @0.0.0.0:0
> > W0505 14:28:48.615442 42490 containerizer.cpp:1337] Ignoring update for 
> > unknown container: 33dc5d83-125f-4da2-8c69-cba76d95955b
> > I0505 14:28:48.616350 42510 status_update_manager.cpp:320] Received status 
> > update TASK_FAILED (UUID: 07b0c1ee-ef56-41e2-be69-2365427e370a) for task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92-
> > I0505 14:28:48.617668 42504 slave.cpp:3619] Forwarding the update 
> > TASK_FAILED (UUID: 07b0c1ee-ef56-41e2-be69-2365427e370a) for task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- to master@10.0.49.2:39069
> > I0505 14:28:48.618381 42470 master.cpp:5094] Status update TASK_FAILED 
> > (UUID: 07b0c1ee-ef56-41e2-be69-2365427e370a) for task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- from agent 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92-S0 at slave(1)@10.0.49.2:39069 
> > (core-dev)
> > I0505 14:28:48.618508 42470 master.cpp:5142] Forwarding status update 
> > TASK_FAILED (UUID: 07b0c1ee-ef56-41e2-be69-2365427e370a) for task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92-
> > I0505 14:28:48.618823 42470 master.cpp:6750] Updating the state of task 
> > 0e6076e9-9cc3-4319-aacd-6b6bb8651e9b of framework 
> > 9ecf5fd8-ad54-4973-9688-bcc6a8092c92- (latest state: TASK_FAILED, 
> > status update state: TASK_FAILED)
> > ../../../../mesos/src/tests/containerizer/cni_isolator_tests.cpp:164: 
> > Failure
> > Value of: statusRunning->state()
> >   Actual: TASK_FAILED
> > Expected: TASK_RUNNING
> > ```
> 
> Jie Yu wrote:
> `[jie@core-dev build]$ hostname -i
> fe80::ec4:7aff:fe6d:1f02%enp6s0f0 fe80::42:62ff:fe3e:8ea1%docker0 
> fe80::ec50:6eff:fe55:5124%vethf850a68 10.0.49.2 172.17.0.1`
> 
> Qian Zhang wrote:
> Can you please show the output of `ip addr` in your machine?

I updated the patch, can you please try it again in your machine?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/#review131937
---


On May 6, 2016, 10:06 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apa

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46097/
---

(Updated May 6, 2016, 10:06 p.m.)


Review request for mesos, Avinash sridharan and Jie Yu.


Bugs: MESOS-5167
https://issues.apache.org/jira/browse/MESOS-5167


Repository: mesos


Description
---

Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".


Diffs (updated)
-

  src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
  src/tests/containerizer/cni_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/46097/diff/


Testing
---

[ RUN  ] CniIsolatorTest.ROOT_LaunchCommandTask
+ /home/stack/workspace/mesos/build/src/mesos-containerizer mount --help=false 
--operation=make-rslave --path=/
+ grep+  -E /tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/.+ 
/proc/self/mountinfo
+ grepcut -v -d  -f5
 d06b117d-518b-41e2-b8e0-62a12083773c
+ xargs --no-run-if-empty umount -l
+ mount -n --rbind 
/tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/provisioner/containers/d06b117d-518b-41e2-b8e0-62a12083773c/backends/copy/rootfses/7ea27011-cd3a-43b0-8301-b0b94d9f9b47
 
/tmp/CniIsolatorTest_ROOT_LaunchCommandTask_HRK4Dz/slaves/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0/frameworks/18dea042-5bb5-4336-8bc8-358ed1fbf6dd-/executors/60e6d35d-6d33-47ae-9c23-d2e5c913c892/runs/d06b117d-518b-41e2-b8e0-62a12083773c/.rootfs
I0420 22:26:00.924844  9305 exec.cpp:150] Version: 0.29.0
I0420 22:26:00.942319  9375 exec.cpp:225] Executor registered on agent 
18dea042-5bb5-4336-8bc8-358ed1fbf6dd-S0
Registered executor on mesos
Starting task 60e6d35d-6d33-47ae-9c23-d2e5c913c892
Forked command at 9382
sh -c 'ls /'
bin  dev  etc  home lib  linuxrc  mediamnt  proc
 root run  sbin sys  tmp  usr  var
Command exited with status 0 (pid: 9382)
I0420 22:26:01.098331  9380 exec.cpp:399] Executor asked to shutdown
[   OK ] CniIsolatorTest.ROOT_LaunchCommandTask (42603 ms)


Thanks,

Qian Zhang

Re: Review Request 46761: Slave/Agent Rename Phase I - Update terms in WebUI.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46761/#review132024
---



Patch looks great!

Reviews applied: [46761]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 4:59 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46761/
> ---
> 
> (Updated May 6, 2016, 4:59 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Kevin Klues, Maxim Khutornenko, and 
> Vinod Kone.
> 
> 
> Bugs: mesos-3779
> https://issues.apache.org/jira/browse/mesos-3779
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch did the following changes in WebUI:
> 1. Slave/Agent Rename on web page
> 2. Slave/Agent Rename in web url
> 3. Slave/Agent Rename in JS class/method/attribute
> 4. Slave/Agent Rename in comments
> 
> For the JSON data returned from server that contains
> term 'slave', the change is not included.
> 
> 
> Diffs
> -
> 
>   CHANGELOG f4b21be457edc0ae4c2b0bec42079b5d99f85118 
>   src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd 
>   src/webui/master/static/browse.html 
> 04a4600f0c762a2412ddee078ba2c173d595aa8d 
>   src/webui/master/static/framework.html 
> 041513b0e005e8b54ca9723741b21b136ff61ca6 
>   src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
>   src/webui/master/static/index.html ec2f5792d21bf7efb479e87be3812b06bfbe98dc 
>   src/webui/master/static/js/app.js 543fe9efb9618b311c7f21b7771a251738b01a91 
>   src/webui/master/static/js/controllers.js 
> 8d9021cc89e54ae3a4151ff7f399733f5a7376dd 
>   src/webui/master/static/js/services.js 
> fa5cc35c1ef0e8ec149ed88852837058ec6ab13c 
>   src/webui/master/static/offers.html 
> ec32a649239da48270a1ad1d5bf195326c31ff9d 
>   src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
>   src/webui/master/static/slave_executor.html 
> 99b23ed9e85011a66bad780fb2d3076e946821a6 
>   src/webui/master/static/slave_framework.html 
> 176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
>   src/webui/master/static/slaves.html 
> 063031771cef8b9f45723869198bad3460591936 
> 
> Diff: https://reviews.apache.org/r/46761/diff/
> 
> 
> Testing
> ---
> 
> cd mesos
> ./bootstrap
> mkdir build
> cd build
> ../configure --prefix=${HOME}/install/mesos
> make
> make check
> make install
> 
> start mesos master/agent and run a sample framework, then open browser and 
> goto : to check all the strings on web page and url
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/#review132022
---


Ship it!




Ship It!

- Neil Conway


On May 6, 2016, 8:57 a.m., Chen Nan Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46954/
> ---
> 
> (Updated May 6, 2016, 8:57 a.m.)
> 
> 
> Review request for mesos, Zhiwei Chen and haosdent huang.
> 
> 
> Bugs: MESOS-5201
> https://issues.apache.org/jira/browse/MESOS-5201
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensuring that id attributes are unique on a Web page.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/directives/tableHeader.html 
> 448f67ef20c279fdd542890158fb9f96a10ebebc 
> 
> Diff: https://reviews.apache.org/r/46954/diff/
> 
> 
> Testing
> ---
> 
> Have checked with the patch by firebug, the ID of each table header is 
> different with each other.
> 
> For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93
> 
> 
> Thanks,
> 
> Chen Nan Li
> 
>

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/
---

(Updated 五月 6, 2016, 12:40 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Updated docker volume test case by adding checkpoint verify logic.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
ae58775a0afe083c56165002040c952805ad0c2e 

Diff: https://reviews.apache.org/r/36383/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36383/
---

Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Updated docker volume test case by adding checkpoint verify logic.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Updated docker volume test case by adding checkpoint verify logic.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
ae58775a0afe083c56165002040c952805ad0c2e 

Diff: https://reviews.apache.org/r/36383/diff/


Testing (updated)
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 46923: Added framework failover timeout validation.

[Jose Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/
---

(Updated May 6, 2016, 12:09 p.m.)


Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
Kone.


Bugs: MESOS-1575
https://issues.apache.org/jira/browse/MESOS-1575


Repository: mesos


Description
---

Frameworks were allowed to subscribe themselves with invalid failover
timeout. For this reason, a validation has been made in the master to
deny framework subscription if it set a invalid value for the failover
timeout. MESOS-1575


Diffs (updated)
-

  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
  src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 

Diff: https://reviews.apache.org/r/46923/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 46923: Added framework failover timeout validation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review132017
---




src/master/master.cpp (line 1387)


Comments should be terminated with a period.



src/tests/master_tests.cpp (line 4484)


Comments should be terminated with a period.


- Neil Conway


On May 6, 2016, 12:03 p.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 6, 2016, 12:03 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 46923: Added framework failover timeout validation.

[Jose Guilherme Vanz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/
---

(Updated May 6, 2016, 12:03 p.m.)


Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
Kone.


Bugs: MESOS-1575
https://issues.apache.org/jira/browse/MESOS-1575


Repository: mesos


Description
---

Frameworks were allowed to subscribe themselves with invalid failover
timeout. For this reason, a validation has been made in the master to
deny framework subscription if it set a invalid value for the failover
timeout. MESOS-1575


Diffs (updated)
-

  src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
  src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
  src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 

Diff: https://reviews.apache.org/r/46923/diff/


Testing
---


Thanks,

Jose Guilherme Vanz

Re: Review Request 39474: Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review132011
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 0, 39474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 4:27 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 6, 2016, 4:27 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> ae58775a0afe083c56165002040c952805ad0c2e 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_INTERNET_CURL_CommandTaskRootfsWithVolumes"
>  --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46613/#review132008
---




include/mesos/authorizer/acls.proto (line 168)


s/of which users/for executors run as the given users/



include/mesos/authorizer/acls.proto (line 173)


This isn't accurate either. Remember this is the RunAs user: the linux user 
that the agent launches the container as, and the filesystem owner of the 
sandbox on disk.
This is unrelated to a task's "owner", or the HTTP user that created a task 
in Marathon or other framework UIs



include/mesos/authorizer/acls.proto (lines 177 - 182)


Ditto



include/mesos/authorizer/authorizer.proto (lines 62 - 63)


What about VIEW_EXECUTOR_WITH_INFO?


- Adam B


On May 4, 2016, 5:57 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46613/
> ---
> 
> (Updated May 4, 2016, 5:57 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-5169
> https://issues.apache.org/jira/browse/MESOS-5169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced VIEW_(FRAMEWORK,TASK}_WITH_INFO actions to authorizer.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
>   include/mesos/authorizer/acls.proto 
> 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d 
>   include/mesos/authorizer/authorizer.proto 
> 32492a59ad95df3bb673ec42321518f86c11af59 
>   src/authorizer/local/authorizer.cpp 
> e59c11269670a7ed72b780913971b421ee17f33f 
> 
> Diff: https://reviews.apache.org/r/46613/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 47062: Modified testcase for testing authentication on '/containers' endpoint.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47062/
---

Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Bugs: MESOS-5316
https://issues.apache.org/jira/browse/MESOS-5316


Repository: mesos


Description
---

Testcase SlaveTest.HTTPEndpointsBadAuthentication is updated to use 
authentication when hitting '/containers' endpoint as well as when bad 
credentials are provided.


Diffs
-

  src/tests/slave_tests.cpp 3f653354869987dce3f5fbc4513b6f3466a718cb 

Diff: https://reviews.apache.org/r/47062/diff/


Testing
---

sudo make -j2 check 
On Ubuntu 16.04


Thanks,

Abhishek Dasgupta

Review Request 47061: Authenticated the agent's '/containers' endpoint.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47061/
---

Review request for mesos, Adam B, Greg Mann, and Till Toenshoff.


Bugs: MESOS-5316
https://issues.apache.org/jira/browse/MESOS-5316


Repository: mesos


Description
---

This patch adds HTTP Authentication to '/containers' endpoint.


Diffs
-

  src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5 
  src/slave/slave.hpp b72438033708de473046d321c493d9fbcd7a9b43 
  src/slave/slave.cpp 5aa1530a3f6b2fdb7196fc65b133ab6afaaa6a53 

Diff: https://reviews.apache.org/r/47061/diff/


Testing
---

Testing is done when testcases are modified in the next patch 
https://reviews.apache.org/r/47062/ .


Thanks,

Abhishek Dasgupta

Re: Review Request 47054: Windows: Removed `Zookeeper's` NTDDI_VERSION.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47054/#review132007
---



Patch looks great!

Reviews applied: [47052, 47053, 47054]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 4:17 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47054/
> ---
> 
> (Updated May 6, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Removed `Zookeeper's` NTDDI_VERSION.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 
> 
> Diff: https://reviews.apache.org/r/47054/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: msbuild
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47055: Make the proper contrast ratio in web page for accessibility.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47055/
---

(Updated 五月 6, 2016, 8:58 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5204
https://issues.apache.org/jira/browse/MESOS-5204


Repository: mesos


Description
---

Make the proper contrast ratio in web page for accessibility.


Diffs
-

  src/webui/master/static/css/mesos.css 
5b1227e9d64757f9fc106e497f7fa3ed72112c10 

Diff: https://reviews.apache.org/r/47055/diff/


Testing
---

Ensuring that a contrast ratio of at least 4.5:1 exists between text (and 
images of text) and background behind the text.

refer to https://www.w3.org/TR/WCAG20-TECHS/G18.html


Thanks,

Chen Nan Li

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46954/
---

(Updated 五月 6, 2016, 8:57 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Ensuring that id attributes are unique on a Web page.


Diffs
-

  src/webui/master/static/directives/tableHeader.html 
448f67ef20c279fdd542890158fb9f96a10ebebc 

Diff: https://reviews.apache.org/r/46954/diff/


Testing
---

Have checked with the patch by firebug, the ID of each table header is 
different with each other.

For details refer to https://www.w3.org/TR/2014/NOTE-WCAG20-TECHS-20140311/H93


Thanks,

Chen Nan Li

Re: Review Request 47058: Fix accessibility of table in web GUI.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/
---

(Updated 五月 6, 2016, 8:57 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Fix accessibility of table in web GUI.


Diffs
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/47058/diff/


Testing
---

We should use the scope attribute to associate header cells and data cells in 
data tables.

It can make screen readers to find a header of date cell in table.

for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html


Thanks,

Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/
---

(Updated 五月 6, 2016, 8:56 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

fix some clerical errors


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using the summary attribute of the table element.


Diffs (updated)
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46964/diff/


Testing
---

Have checked with the patch by firebug, each table should have summary 
attribute.

For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html


Thanks,

Chen Nan Li

Re: Review Request 46964: Using the summary attribute of the table element.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46964/
---

(Updated 五月 6, 2016, 8:52 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Using the summary attribute of the table element.


Diffs (updated)
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/46964/diff/


Testing
---

Have checked with the patch by firebug, each table should have summary 
attribute.

For details refer to https://www.w3.org/TR/WCAG20-TECHS/H73.html


Thanks,

Chen Nan Li

Re: Review Request 46923: Added framework failover timeout validation.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46923/#review132003
---


Fix it, then Ship it!





src/master/master.cpp (line 1386)


I think we should add a comment that says we can safely assume that the 
`failover_timeout` is valid because we registration with an invalid 
`failover_timeout` is refused.


Otherwise, LGTM!

- Neil Conway


On May 6, 2016, 3:18 a.m., Jose Guilherme Vanz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46923/
> ---
> 
> (Updated May 6, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Kevin Sweeney, Neil Conway, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-1575
> https://issues.apache.org/jira/browse/MESOS-1575
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Frameworks were allowed to subscribe themselves with invalid failover
> timeout. For this reason, a validation has been made in the master to
> deny framework subscription if it set a invalid value for the failover
> timeout. MESOS-1575
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 
>   src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e 
>   src/tests/master_tests.cpp 8e00753fcbcd0cae1d08aad387b08aa17c7f63ad 
> 
> Diff: https://reviews.apache.org/r/46923/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jose Guilherme Vanz
> 
>

Re: Review Request 47058: Fix accessibility of table in web GUI.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/
---

(Updated 五月 6, 2016, 8:12 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Changes
---

fix some clerical error


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Fix accessibility of table in web GUI.


Diffs (updated)
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/47058/diff/


Testing
---

We should use the scope attribute to associate header cells and data cells in 
data tables.

It can make screen readers to find a header of date cell in table.

for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html


Thanks,

Chen Nan Li

Re: Review Request 47058: Fix accessibility of table in web GUI.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/
---

(Updated 五月 6, 2016, 8:07 a.m.)


Review request for mesos, Zhiwei Chen and haosdent huang.


Bugs: MESOS-5201
https://issues.apache.org/jira/browse/MESOS-5201


Repository: mesos


Description
---

Fix accessibility of table in web GUI.


Diffs
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/47058/diff/


Testing
---

We should use the scope attribute to associate header cells and data cells in 
data tables.

It can make screen readers to find a header of date cell in table.

for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html


Thanks,

Chen Nan Li

Review Request 47058: Fix accessibility of table in web GUI.

[Chen Nan Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47058/
---

Review request for mesos.


Repository: mesos


Description
---

Fix accessibility of table in web GUI.


Diffs
-

  src/webui/master/static/framework.html 
041513b0e005e8b54ca9723741b21b136ff61ca6 
  src/webui/master/static/frameworks.html 
f172e022e18df5b6aa3d232e610c3c732e20aa09 
  src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa 
  src/webui/master/static/offers.html ec32a649239da48270a1ad1d5bf195326c31ff9d 
  src/webui/master/static/slave.html c908511df85141128599ad5edc40d4b567437822 
  src/webui/master/static/slave_executor.html 
99b23ed9e85011a66bad780fb2d3076e946821a6 
  src/webui/master/static/slave_framework.html 
176e7e9fa7878f31268bd5aa06dfc8789f3e7edd 
  src/webui/master/static/slaves.html 063031771cef8b9f45723869198bad3460591936 

Diff: https://reviews.apache.org/r/47058/diff/


Testing
---

We should use the scope attribute to associate header cells and data cells in 
data tables.

It can make screen readers to find a header of date cell in table.

for details refer to https://www.w3.org/TR/WCAG20-TECHS/H63.html


Thanks,

Chen Nan Li

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/
---

(Updated 五月 6, 2016, 8:04 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.


Bugs: MESOS-4801
https://issues.apache.org/jira/browse/MESOS-4801


Repository: mesos


Description
---

Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
53a759ce0ebea87cc564a22cb2d34e54870f782b 

Diff: https://reviews.apache.org/r/42386/diff/


Testing
---

make
make tests
GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 42386: Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42386/#review132000
---



Patch looks great!

Reviews applied: [42386]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 3:35 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42386/
> ---
> 
> (Updated May 6, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4801
> https://issues.apache.org/jira/browse/MESOS-4801
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `createFrameworkInfo` for hierarchical_allocator_tests.cpp.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 53a759ce0ebea87cc564a22cb2d34e54870f782b 
> 
> Diff: https://reviews.apache.org/r/42386/diff/
> 
> 
> Testing
> ---
> 
> make
> make tests
> GLOG_v=2 ./bin/mesos-tests.sh  --gtest_filter="HierarchicalAllocatorTest.*" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 46920: Added validation hook inside Slave::runTask.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46920/#review131997
---



Please create a JIRA with motivation for this hook. I don't want a new hook to 
slip into a release without a JIRA in the changelog to document it.


include/mesos/hook.hpp (lines 51 - 55)


Why wouldn't you do this validation at the master? What would a slave know 
about validation that the master wouldn't?
Would different slaves validate differently? If so, why isn't that 
attribute surfaced in the offer rather than failing on task launch?
Fail early.


- Adam B


On May 5, 2016, 9:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46920/
> ---
> 
> (Updated May 5, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a new hook `slaveRunTaskValidatorHook`, which allows a module to 
> inspect the contents of a task and potentially reject the task with a 
> `TASK_ERROR`.
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 210ffba09f5acae34ca49b888a781f683777f9ca 
>   src/examples/test_hook_module.cpp 4b97f84204934d0e678786fd6cde38b89a6f8f48 
>   src/hook/manager.hpp 528674e36639fe78137ba0a4bb004c99730e7a22 
>   src/hook/manager.cpp 381807d582998043d73e9b8c9d3c1fddbcf73cf1 
>   src/slave/slave.cpp 116ea59b72950db4a7cd721b7ba5bfbb2e1c1454 
>   src/tests/hook_tests.cpp 60d52c5849ba555f6f3070883d87aadf105f05b0 
> 
> Diff: https://reviews.apache.org/r/46920/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>