Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/
---

(Updated June 17, 2016, 5:47 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

rebase


Bugs: MESOS-5493
https://issues.apache.org/jira/browse/MESOS-5493


Repository: mesos


Description
---

Implement v1::master::Call::GET_TASKS.


Diffs (updated)
-

  include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 
  src/internal/evolve.hpp 5f3e267fa3a0420fcbed7be6f13ee76bf85cb182 
  src/internal/evolve.cpp 93719127e75b4ba299f8d0a7fdeb4681818d30db 
  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48046/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

Jay Guo

Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48401/
---

(Updated June 17, 2016, 5:47 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

rebase


Bugs: MESOS-5493
https://issues.apache.org/jira/browse/MESOS-5493


Repository: mesos


Description
---

This protobuf message should be int32 instead of string.
Default value is set to TASK_LIMIT (100).


Diffs (updated)
-

  include/mesos/master/master.proto 3b85b8130f1a292f3574214fcf7761c891f57f22 
  include/mesos/v1/master/master.proto 5a6bbeb0f9b57d03803e366df32e04e9598e00ed 

Diff: https://reviews.apache.org/r/48401/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

Jay Guo

Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48838/#review138161
---


Ship it!




- Kapil Arya


On June 17, 2016, 1:44 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48838/
> ---
> 
> (Updated June 17, 2016, 1:44 a.m.)
> 
> 
> Review request for mesos and Kapil Arya.
> 
> 
> Bugs: 5400
> https://issues.apache.org/jira/browse/5400
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Without this, files that #included `stout/elf.hpp` would fail with a
> `make distcheck` because this file was not being installed properly
> from a `make install`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 
> 
> Diff: https://reviews.apache.org/r/48838/diff/
> 
> 
> Testing
> ---
> 
> $ make install (in 3rdparty)
> Verified that it installed the elf.hpp file
> 
> $ ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' CONFIGURATION="--enable-libevent 
> --enable-ssl" COMPILER=gcc BUILDTOOL=autotools OS=centos:7 
> support/docker_build.sh
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48838/
---

(Updated June 17, 2016, 5:44 a.m.)


Review request for mesos and Kapil Arya.


Changes
---

Added Test info


Bugs: 5400
https://issues.apache.org/jira/browse/5400


Repository: mesos


Description
---

Without this, files that #included `stout/elf.hpp` would fail with a
`make distcheck` because this file was not being installed properly
from a `make install`.


Diffs
-

  3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 

Diff: https://reviews.apache.org/r/48838/diff/


Testing (updated)
---

$ make install (in 3rdparty)
Verified that it installed the elf.hpp file

$ ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1' CONFIGURATION="--enable-libevent 
--enable-ssl" COMPILER=gcc BUILDTOOL=autotools OS=centos:7 
support/docker_build.sh


Thanks,

Kevin Klues

Review Request 48838: Added missing `stout/elf.hpp` file to `nobase_include_HEADERS`.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48838/
---

Review request for mesos and Kapil Arya.


Bugs: 5400
https://issues.apache.org/jira/browse/5400


Repository: mesos


Description
---

Without this, files that #included `stout/elf.hpp` would fail with a
`make distcheck` because this file was not being installed properly
from a `make install`.


Diffs
-

  3rdparty/stout/include/Makefile.am 7f31582c176e653873402bd3f19b0c0195503d45 

Diff: https://reviews.apache.org/r/48838/diff/


Testing
---


Thanks,

Kevin Klues

Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/#review138156
---



Patch looks great!

Reviews applied: [48836]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 3:34 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48836/
> ---
> 
> (Updated June 17, 2016, 3:34 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed variable shadowing in `launchTaskPosix`.
> 
> 
> Diffs
> -
> 
>   src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 
> 
> Diff: https://reviews.apache.org/r/48836/diff/
> 
> 
> Testing
> ---
> 
> ```
> pid_t launchTaskPosix(
> const mesos::v1::TaskInfo& task,
> const mesos::v1::CommandInfo& command,
> const Option& user, <--- shadown with `Result user = 
> os::user();` below.
> char** argv,
> Option& override,
> Option& rootfs,
> Option& sandboxDirectory,
> Option& workingDirectory)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48835: Remove duplicate return in getHealth method.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48835/#review138150
---



Patch looks great!

Reviews applied: [48835]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 2:40 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48835/
> ---
> 
> (Updated June 17, 2016, 2:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> removed the duplicate return clause.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
> 
> Diff: https://reviews.apache.org/r/48835/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Re: Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/
---

(Updated June 17, 2016, 3:34 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

Fixed variable shadowing in `launchTaskPosix`.


Diffs
-

  src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 

Diff: https://reviews.apache.org/r/48836/diff/


Testing (updated)
---

```
pid_t launchTaskPosix(
const mesos::v1::TaskInfo& task,
const mesos::v1::CommandInfo& command,
const Option& user, <--- shadown with `Result user = 
os::user();` below.
char** argv,
Option& override,
Option& rootfs,
Option& sandboxDirectory,
Option& workingDirectory)
```


Thanks,

haosdent huang

Review Request 48836: Fixed variable shadowing in `launchTaskPosix`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/
---

Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

Fixed variable shadowing in `launchTaskPosix`.


Diffs
-

  src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 

Diff: https://reviews.apache.org/r/48836/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48835: Remove duplicate return in getHealth method.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48835/#review138149
---


Ship it!




Thank you for fix my bug. My bad that don't remove this return when rebasing.

- haosdent huang


On June 17, 2016, 2:40 a.m., zhou xing wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48835/
> ---
> 
> (Updated June 17, 2016, 2:40 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> removed the duplicate return clause.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
> 
> Diff: https://reviews.apache.org/r/48835/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> zhou xing
> 
>

Review Request 48835: Remove duplicate return in getHealth method.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48835/
---

Review request for mesos, haosdent huang and Vinod Kone.


Repository: mesos


Description
---

removed the duplicate return clause.


Diffs
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 

Diff: https://reviews.apache.org/r/48835/diff/


Testing
---

make


Thanks,

zhou xing

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/#review138148
---



Patch looks great!

Reviews applied: [48115, 48116, 48257, 48084, 48259, 48260, 48285, 48286, 48580]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 17, 2016, 1:28 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48580/
> ---
> 
> (Updated June 17, 2016, 1:28 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
> https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test case `MasterAPITest.StartAndStopMaintenance`.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 
> 
> Diff: https://reviews.apache.org/r/48580/diff/
> 
> 
> Testing
> ---
> 
> Test by
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="*APITest*"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48824: Updated the documentation regarding quota authorization.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48824/#review138143
---



Bad patch!

Reviews applied: [48824, 48040, 48038, 48039, 48037, 47977, 47736, 47704, 
47559, 48052, 47558, 46093]

Failed command: ./support/apply-review.sh -n -r 48038

Error:
2016-06-17 01:30:52 URL:https://reviews.apache.org/r/48038/diff/raw/ 
[9233/9233] -> "48038.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/13830/console

- Mesos ReviewBot


On June 16, 2016, 11:09 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48824/
> ---
> 
> (Updated June 16, 2016, 11:09 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5628
> https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 0df0d4ccd76379ede6492e595999711e5462f79b 
>   docs/upgrades.md afc76f7a0e74042bd095b925f8119bfa5daa489c 
> 
> Diff: https://reviews.apache.org/r/48824/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48580/
---

(Updated June 17, 2016, 1:28 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5507
https://issues.apache.org/jira/browse/MESOS-5507


Repository: mesos


Description
---

Added test case `MasterAPITest.StartAndStopMaintenance`.


Diffs (updated)
-

  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48580/diff/


Testing
---

Test by

```
./bin/mesos-tests.sh --gtest_filter="*APITest*"
```


Thanks,

haosdent huang

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48285/
---

(Updated June 17, 2016, 1:28 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5506
https://issues.apache.org/jira/browse/MESOS-5506


Repository: mesos


Description
---

Implemented START_MAINTENANCE Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 

Diff: https://reviews.apache.org/r/48285/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48286/
---

(Updated June 17, 2016, 1:28 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5507
https://issues.apache.org/jira/browse/MESOS-5507


Repository: mesos


Description
---

Implemented STOP_MAINTENANCE Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 

Diff: https://reviews.apache.org/r/48286/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48084: Implemented GET_MAINTENANCE_STATUS Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48084/
---

(Updated June 17, 2016, 1:27 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Summary (updated)
-

Implemented GET_MAINTENANCE_STATUS Call in v1 master API.


Bugs: MESOS-5503
https://issues.apache.org/jira/browse/MESOS-5503


Repository: mesos


Description (updated)
---

Implemented GET_MAINTENANCE_STATUS Call in v1 master API.


Diffs (updated)
-

  src/internal/evolve.hpp 5f3e267fa3a0420fcbed7be6f13ee76bf85cb182 
  src/internal/evolve.cpp 93719127e75b4ba299f8d0a7fdeb4681818d30db 
  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 

Diff: https://reviews.apache.org/r/48084/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48260/
---

(Updated June 17, 2016, 1:27 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5503
https://issues.apache.org/jira/browse/MESOS-5503


Repository: mesos


Description
---

Added test case `MasterAPITest.GetMaintenanceStatus`.


Diffs (updated)
-

  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48260/diff/


Testing
---

Test in CentOS 7.2

```
./bin/mesos-tests.sh --gtest_filter="*MasterAPITest*"
```


Thanks,

haosdent huang

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48259/
---

(Updated June 17, 2016, 1:27 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5504
https://issues.apache.org/jira/browse/MESOS-5504


Repository: mesos


Description
---

Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.


Diffs (updated)
-

  src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 

Diff: https://reviews.apache.org/r/48259/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48116/
---

(Updated June 17, 2016, 1:27 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5505
https://issues.apache.org/jira/browse/MESOS-5505


Repository: mesos


Description
---

Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.


Diffs (updated)
-

  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 

Diff: https://reviews.apache.org/r/48116/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48257/
---

(Updated June 17, 2016, 1:27 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
---

Rebase.


Bugs: MESOS-5504
https://issues.apache.org/jira/browse/MESOS-5504


Repository: mesos


Description
---

Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.


Diffs (updated)
-

  src/internal/evolve.hpp 5f3e267fa3a0420fcbed7be6f13ee76bf85cb182 
  src/internal/evolve.cpp 93719127e75b4ba299f8d0a7fdeb4681818d30db 
  src/master/http.cpp 1b74211acafc15cc0bcb24545ca4c2bacd79cb2d 
  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 

Diff: https://reviews.apache.org/r/48257/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48115: Added maintenance V1 header.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48115/
---

(Updated June 17, 2016, 1:26 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-5505
https://issues.apache.org/jira/browse/MESOS-5505


Repository: mesos


Description
---

Added maintenance V1 header.


Diffs (updated)
-

  include/mesos/v1/maintenance/maintenance.hpp PRE-CREATION 
  src/Makefile.am 7a578c642309560d53466249b2ccca1df5f070b1 

Diff: https://reviews.apache.org/r/48115/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 48815: Made all Entities required in acls.proto.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48815/#review138142
---



Patch looks great!

Reviews applied: [48781, 48815]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 8:47 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48815/
> ---
> 
> (Updated June 16, 2016, 8:47 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: Mesos-5588
> https://issues.apache.org/jira/browse/Mesos-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made all Entities required in acls.proto.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> cc0b8ea870a3e626ad90efb1691934bb28051435 
> 
> Diff: https://reviews.apache.org/r/48815/diff/
> 
> 
> Testing
> ---
> 
> (sudo) make check on various systems.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review138138
---




src/master/master.hpp (line 1317)


After the recent change, this should take unversioned master::Call.


- Vinod Kone


On June 9, 2016, 11:17 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> ---
> 
> (Updated June 9, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implement v1::master::Call::GET_TASKS.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48046/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48450: Add unit test for master /tasks endpoint.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review138139
---


Ship it!




Ship It!

- Vinod Kone


On June 9, 2016, 11:13 p.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> ---
> 
> (Updated June 9, 2016, 11:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> ---
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/#review138137
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 10:47 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48040/
> ---
> 
> (Updated June 16, 2016, 10:47 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5628
> https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 
> 
> Diff: https://reviews.apache.org/r/48040/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48401: Change GetTask.limit type to int32 with default value 100.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48401/#review138136
---




include/mesos/v1/master.proto (line 111)


can you also update the unversioned master.proto (that we recently added) 
with these changes?


- Vinod Kone


On June 9, 2016, 12:01 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48401/
> ---
> 
> (Updated June 9, 2016, 12:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This protobuf message should be int32 instead of string.
> Default value is set to TASK_LIMIT (100).
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48401/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review138135
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 11:03 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 11:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5628
> https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
> updated to send only one authorization request per action.
> 
> In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
> Note that `QuotaHandler` encodes the type of the request (set or remove)
> by setting the `value` field of `Object` to `"SetQuota"` or
> `"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
> `ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 558f332b3a5382cee64fb1dcf57b110e481b1efc 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

[Dan Osborne]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48527/
---

(Updated June 17, 2016, 12:31 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-5592
https://issues.apache.org/jira/browse/MESOS-5592


Repository: mesos


Description
---

Review: https://reviews.apache.org/r/48527

Fixes.

Review: https://reviews.apache.org/r/48754

Code review fixes.


Checkpointed mutated networkinfo.


Added error message if args is specified.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
09890cedf2e7a1846bd1cb250e117be1680a1b80 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
106ff35320f37b2e75ed60381de1406459e6d515 
  src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
8af50c11b00240ac1d24605b119acbd96aaa50be 
  src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 
b3fb0a32e3e74ca859ca58085efed5a87e4e626b 

Diff: https://reviews.apache.org/r/48527/diff/


Testing
---


Thanks,

Dan Osborne

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

[Jie Yu]

> On June 15, 2016, 6:08 a.m., Avinash sridharan wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 987
> > 
> >
> > Is there a guarantee that the plugin would be waiting for the isolator 
> > to `write` into the PIPE ?
> > Also, this can potentially block the `network/cni` isolator if the 
> > plugin is not fast enough in reading the pipe.
> > 
> > Can we follow the existing idiom of writing mutated JSON into a temp 
> > file? Probably checkpoint the JSON into the containers checkpoint DIR and 
> > set the stdinof the plugin to the checkpointed JSON config. This would also 
> > serve the dual purpose of checkpointing the mutated JSON to be used when 
> > deleteing the container.

See my comments below. I won't be too worried about the the pipe full issue as 
network config is typically pretty small and the kernel buffer for a pipe is 
usually 64K. Also, the spec says that the plugin will read the stdin for config.

If you're really worried about the blocking issue, use async process::io::write 
should solve the issue.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48527/#review137667
---


On June 15, 2016, 10:23 p.m., Dan Osborne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48527/
> ---
> 
> (Updated June 15, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/48527
> 
> Fixes.
> 
> Review: https://reviews.apache.org/r/48754
> 
> Code review fixes.
> 
> 
> Checkpointed mutated networkinfo.
> 
> 
> Added error message if args is specified.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 09890cedf2e7a1846bd1cb250e117be1680a1b80 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 106ff35320f37b2e75ed60381de1406459e6d515 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 8af50c11b00240ac1d24605b119acbd96aaa50be 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 
> b3fb0a32e3e74ca859ca58085efed5a87e4e626b 
> 
> Diff: https://reviews.apache.org/r/48527/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Osborne
> 
>

Re: Review Request 48527: Add NetworkInfo.labels to CNI Network before passing to CNI plugin.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48527/#review138128
---




src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (line 92)


Why 'taskId' here? If it's a command task, that's clear what taskId is. But 
what if this is a custom executor with multiple tasks, what is this id for?



src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 968 - 971)


I would prefer the following for the `args` json:
```
{
  ...
  "args" : {
"mesos" : {
  "network_info" : {
... // JSON rep. of NetworkInfo.
  }
}
  }
}
```



src/slave/containerizer/mesos/isolators/network/cni/paths.cpp (lines 126 - 135)


I would prefer not introducing a new checkpointed file which we will 
deprecate soon. In the future, we need to checkpoint the network config json 
anyway because technically, when we call `plugin DEL`, we need to provide an 
identical network config as we provide to `plugin ADD`.

I think the previous way of using a PIPE for stdin sounds fine to me.


- Jie Yu


On June 15, 2016, 10:23 p.m., Dan Osborne wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48527/
> ---
> 
> (Updated June 15, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/48527
> 
> Fixes.
> 
> Review: https://reviews.apache.org/r/48754
> 
> Code review fixes.
> 
> 
> Checkpointed mutated networkinfo.
> 
> 
> Added error message if args is specified.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 
> 09890cedf2e7a1846bd1cb250e117be1680a1b80 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 106ff35320f37b2e75ed60381de1406459e6d515 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.hpp 
> 8af50c11b00240ac1d24605b119acbd96aaa50be 
>   src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 
> b3fb0a32e3e74ca859ca58085efed5a87e4e626b 
> 
> Diff: https://reviews.apache.org/r/48527/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dan Osborne
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review138131
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 10:48 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated June 16, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-5628
> https://issues.apache.org/jira/browse/MESOS-5628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As described in MESOS-5628, this patch makes `QuotaHandler` only
> send one authorization request per action.
> 
> During the deprecation cycle of `ACL::SetQuota` and `ACL::RemoveQuota`,
> the `LocalAuthorizer` for example still needs to know whether the action
> is a set or remove. We remedy this situation by encoding type (set or
> remove) by setting the `value` field in the `Object` with the string
> `"SetQuota"` or `"RemoveQuota"`. With this approach, we can simply stop
> setting the `value` field at the end of the deprecation cycle as opposed
> to changing the public API.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48684: Revised documentation for task reconciliation.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48684/#review138126
---


Ship it!




Ship It!

- Till Toenshoff


On June 14, 2016, 12:03 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48684/
> ---
> 
> (Updated June 14, 2016, 12:03 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In particular, add a note that the `TaskStatus` messages
> produced by reconciliation can be identified by looking at
> the `reason` field, and that these messages won't have
> other fields like `labels` and `data` set. Also, add
> recommendations for the how to do reconciliation and edit
> some of the previous text for tone and brevity.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 2605f68c983403d4fe0cbb5d76b31a9244681d43 
>   docs/reconciliation.md ce8435587e93e8e07dc9b0637fad7f900fbe65bb 
> 
> Diff: https://reviews.apache.org/r/48684/diff/
> 
> 
> Testing
> ---
> 
> previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48745: Removed JNI major version check.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48745/#review138125
---



Patch looks great!

Reviews applied: [48745]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 15, 2016, 7:48 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48745/
> ---
> 
> (Updated June 15, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5571
> https://issues.apache.org/jira/browse/MESOS-5571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The major version check makes upgrading frameworks unnecessarily hard
> because you would have to deploy Mesos and frameworks in lockstep.
> 
> Dependency management should be done outside of the code but through
> package metadata.
> 
> 
> Diffs
> -
> 
>   src/java/jni/convert.cpp 5c48ca89c376ea904e5dc37234495450b8d2255d 
> 
> Diff: https://reviews.apache.org/r/48745/diff/
> 
> 
> Testing
> ---
> 
> make check passed, particularly Java related ones.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 48825: Added documentation about replicated log metrics.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48825/
---

(Updated June 16, 2016, 11:47 p.m.)


Review request for mesos and Joseph Wu.


Changes
---

Addressed review comments.


Repository: mesos


Description
---

Added documentation about replicated log metrics.


Diffs (updated)
-

  docs/monitoring.md 3cfdaf5de149c5a1a7b3d64ba2870887a092ffc6 

Diff: https://reviews.apache.org/r/48825/diff/


Testing
---

Preview:
https://github.com/jieyu/mesos/blob/metrics_replicated_log/docs/monitoring.md#registrar


Thanks,

Jie Yu

Re: Review Request 48635: Fixed various typos and grammar nits in upgrade notes.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48635/#review138123
---


Ship it!




Ship It!

- Till Toenshoff


On June 13, 2016, 1:16 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48635/
> ---
> 
> (Updated June 13, 2016, 1:16 p.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed various typos and grammar nits in upgrade notes.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md afc76f7a0e74042bd095b925f8119bfa5daa489c 
> 
> Diff: https://reviews.apache.org/r/48635/diff/
> 
> 
> Testing
> ---
> 
> Previewed in site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 48825: Added documentation about replicated log metrics.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48825/#review138122
---


Fix it, then Ship it!





docs/monitoring.md (line 273)


Might want to note that the in-memory version (i.e. for testing via 
`--registry=in_memory`) will not have this metric.  

Probably not a general use case though :)



docs/monitoring.md (line 275)


Suggestion:

s/recovered/caught up with the other masters in the cluster.  A cluster is 
operational as long as a quorum of "recovered" masters is available in the 
cluster./

Also note that a "recovered" registrar will never go from 1 -> 0 without 
out-right aborting/crashing.


- Joseph Wu


On June 16, 2016, 4:22 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48825/
> ---
> 
> (Updated June 16, 2016, 4:22 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation about replicated log metrics.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 3cfdaf5de149c5a1a7b3d64ba2870887a092ffc6 
> 
> Diff: https://reviews.apache.org/r/48825/diff/
> 
> 
> Testing
> ---
> 
> Preview:
> https://github.com/jieyu/mesos/blob/metrics_replicated_log/docs/monitoring.md#registrar
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48367: Added test to verify that GPU auto-discovery works.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48367/#review138110
---


Ship it!




Thanks for the tests! Here is the diff I applied before committing:

```
diff --git a/src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
b/src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
index ffe1f57..e06d107 100644
--- a/src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
+++ b/src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
@@ -228,36 +228,46 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_FractionalResources)
 }
 
 
-// Test proper enumeration of available GPU devices.
-TEST_F(NvidiaGpuTest, ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
+// Ensures that GPUs can be auto-discovered.
+TEST_F(NvidiaGpuTest, ROOT_CGROUPS_NVIDIA_GPU_Discovery)
 {
   ASSERT_TRUE(nvml::isAvailable());
   ASSERT_SOME(nvml::initialize());
 
-  // Get the number of GPUs actually on this machine using NVML.
   Try gpus = nvml::deviceGetCount();
   ASSERT_SOME(gpus);
 
-  // Set the `gpus` resource flag to 0.
   slave::Flags flags = CreateSlaveFlags();
-  flags.resources = "gpus:0";
+  flags.resources = "cpus:1"; // To override the default with gpus:0.
 
   Try resources = Containerizer::resources(flags);
 
   ASSERT_SOME(resources);
-  ASSERT_NONE(resources->gpus());
+  ASSERT_SOME(resources->gpus());
+  ASSERT_EQ(gpus.get(), resources->gpus().get());
+}
 
-  // Don't set either `nvidia_gpu_devices` or the `gpus` resource flag.
-  flags = CreateSlaveFlags();
-  flags.resources = "cpus:1"; // To override the default with gpus:0.
 
-  resources = Containerizer::resources(flags);
+// Ensures that the --resources and --nvidia_gpu_devices
+// flags are correctly validated.
+TEST_F(NvidiaGpuTest, ROOT_CGROUPS_NVIDIA_GPU_FlagValidation)
+{
+  ASSERT_TRUE(nvml::isAvailable());
+  ASSERT_SOME(nvml::initialize());
+
+  Try gpus = nvml::deviceGetCount();
+  ASSERT_SOME(gpus);
+
+  // Setting the GPUs to 0 should not trigger auto-discovery!
+  slave::Flags flags = CreateSlaveFlags();
+  flags.resources = "gpus:0";
+
+  Try resources = Containerizer::resources(flags);
 
   ASSERT_SOME(resources);
-  ASSERT_SOME(resources->gpus());
-  ASSERT_EQ(gpus.get(), resources->gpus().get());
+  ASSERT_NONE(resources->gpus());
 
-  // Set both the `nvidia_gpu_devices` and `gpus` resource flags.
+  // --nvidia_gpu_devices and --resources agree on the number of GPUs.
   flags = CreateSlaveFlags();
   flags.nvidia_gpu_devices = vector({0u});
   flags.resources = "gpus:1";
@@ -268,7 +278,7 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
   ASSERT_SOME(resources->gpus());
   ASSERT_EQ(1u, resources->gpus().get());
 
-  // Set `nvidia_gpu_devices` but don't set the `gpus` resource flag.
+  // Both --resources and --nvidia_gpu_devices must be specified!
   flags = CreateSlaveFlags();
   flags.nvidia_gpu_devices = vector({0u});
   flags.resources = "cpus:1"; // To override the default with gpus:0.
@@ -277,7 +287,6 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
 
   ASSERT_ERROR(resources);
 
-  // Don't set `nvidia_gpu_devices` but do set the `gpus` resource flag.
   flags = CreateSlaveFlags();
   flags.resources = "gpus:" + stringify(gpus.get());
 
@@ -285,8 +294,7 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
 
   ASSERT_ERROR(resources);
 
-  // Set `nvidia_gpu_devices` and the `gpus`
-  // resource flags to conflicting values.
+  // --nvidia_gpu_devices and --resources do not match!
   flags = CreateSlaveFlags();
   flags.nvidia_gpu_devices = vector({0u});
   flags.resources = "gpus:2";
@@ -295,7 +303,6 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
 
   ASSERT_ERROR(resources);
 
-  // Set `nvidia_gpu_devices` when the `gpus` resource is 0.
   flags = CreateSlaveFlags();
   flags.nvidia_gpu_devices = vector({0u});
   flags.resources = "gpus:0";
@@ -304,18 +311,23 @@ TEST_F(NvidiaGpuTest, 
ROOT_CGROUPS_NVIDIA_GPU_VerifyResources)
 
   ASSERT_ERROR(resources);
 
-  // Set the `gpus` resource flag to 100.
+  // More than available on the machine!
   flags = CreateSlaveFlags();
-  flags.resources = "gpus:100";
+  flags.resources = "gpus:" + stringify(2 * gpus.get());
+  flags.nvidia_gpu_devices = vector();
+
+  for (size_t i = 0; i < 2 * gpus.get(); ++i) {
+flags.nvidia_gpu_devices->push_back(i);
+  }
 
   resources = Containerizer::resources(flags);
 
   ASSERT_ERROR(resources);
 
-  // Set `nvidia_gpu_devices` to contain repeated values.
+  // Set `nvidia_gpu_devices` to contains duplicates.
   flags = CreateSlaveFlags();
   flags.nvidia_gpu_devices = vector({0u, 0u});
-  flags.resources = "cpus:1"; // To override the default with gpus:0.
+  flags.resources = "cpus:1;gpus:1";
 
   resources = Containerizer::resources(flags);
```


src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 231 - 232)

Re: Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48366/#review138106
---


Fix it, then Ship it!





src/slave/containerizer/containerizer.cpp (lines 114 - 121)


We should add context to these error messages.



src/slave/containerizer/containerizer.cpp (lines 125 - 126)


No backticks in the output that we print out to the user (error messages, 
log messages, etc).



src/slave/containerizer/containerizer.cpp (line 140)


s/unsigned/non-negative/?


- Benjamin Mahler


On June 11, 2016, 3:07 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48366/
> ---
> 
> (Updated June 11, 2016, 3:07 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5257
> https://issues.apache.org/jira/browse/MESOS-5257
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit also includes updates to the tests that would start
> failing once GPU autodiscovery was turned on. Since GPUs are now a
> first class resource, we have to explicilty list them in resource
> vectors that attempt to set resources for the whole machine and then
> verify that they get the same vector back in an offer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 
>   src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp 
> d7557a0c338e8c0e51461b2326600c03f89c2e8b 
>   src/tests/master_allocator_tests.cpp 
> 34e3add78d0dec8fb55d7b35710694bea3c58d6f 
>   src/tests/master_quota_tests.cpp 62aaafe7b11a7df1ca7bc1f2f29af4cb626fc35d 
>   src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
>   src/tests/mesos.hpp e9361a65eb31cced99e9ed32fd18a65d1bda26e3 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 70b7626c8e87d1de59b13f9fd88fe9abb5f6b6a5 
>   src/tests/slave_tests.cpp 7ba03e8c06b8aaac1e57124c257660acd8c1d78a 
> 
> Diff: https://reviews.apache.org/r/48366/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 48825: Added documentation about replicated log metrics.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48825/
---

Review request for mesos and Joseph Wu.


Repository: mesos


Description
---

Added documentation about replicated log metrics.


Diffs
-

  docs/monitoring.md 3cfdaf5de149c5a1a7b3d64ba2870887a092ffc6 

Diff: https://reviews.apache.org/r/48825/diff/


Testing
---

Preview:
https://github.com/jieyu/mesos/blob/metrics_replicated_log/docs/monitoring.md#registrar


Thanks,

Jie Yu

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36440/
---

(Updated 六月 16, 2016, 11:23 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5341
https://issues.apache.org/jira/browse/MESOS-5341


Repository: mesos


Description
---

Enabled docker volume support for DockerContainerizer.


Diffs (updated)
-

  include/mesos/mesos.proto d3cfdd0a583bbd0f5ec11c87ea29e649a97450c5 
  include/mesos/v1/mesos.proto dca0c2c8a468345cb18b4ced889fc3db0324ca1d 
  src/docker/docker.cpp a6dcbe788abb8802baa2c70ec2fced1da75c7210 

Diff: https://reviews.apache.org/r/36440/diff/


Testing
---

make
make check

1) Start convoy
2) Create a volume named as c1
root@kvm-002605:~# convoy list
{
"f3459d44-bbed-4e01-a7f6-6c6aa4b70cad": {
"UUID": "f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
"Name": "c1",
"Driver": "devicemapper",
"MountPoint": "",
"CreatedTime": "Mon May 09 09:38:52 +0800 2016",
"DriverInfo": {
"DevID": "1",
"Device": 
"/dev/mapper/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
"Driver": "devicemapper",
"MountPoint": "",
"Size": "107374182400"
},
"Snapshots": {}
}
}
3) Update  mesos-execte to set up volume
index 4711e80..6c712a2 100644
--- a/src/cli/execute.cpp
+++ b/src/cli/execute.cpp
@@ -72,6 +72,8 @@ using mesos::v1::TaskID;
 using mesos::v1::TaskInfo;
 using mesos::v1::TaskState;
 using mesos::v1::TaskStatus;
+using mesos::v1::Volume;
+using mesos::v1::Parameters;
 
 using mesos::v1::scheduler::Call;
 using mesos::v1::scheduler::Event;
@@ -581,6 +583,18 @@ private:
 
   containerInfo.set_type(ContainerInfo::DOCKER);
   containerInfo.mutable_docker()->set_image(dockerImage.get());
+  //containerInfo.mutable_docker()->set_volume_driver("convoy");
+
+  Volume* volume1 = containerInfo.add_volumes();
+  //volume1->set_host_path("c1");
+  volume1->set_container_path("/tmp");
+  volume1->mutable_source()->set_type(Volume::Source::DOCKER_VOLUME);
+  volume1->mutable_source()->mutable_docker_volume()->set_driver(
+  "convoy");
+  volume1->mutable_source()->mutable_docker_volume()->set_name(
+  "c1");
+  volume1->set_mode(Volume::RW);
+  cout << "Add Voume 1" << endl;
 
   if (networks.isSome() && !networks->empty()) {
 vector tokens = strings::tokenize(networks.get(), ",");
4) Start master
./bin/mesos-master.sh --work_dir=/tmp/mesos/master
5) Start agent
GLOG_v=1 ./bin/mesos-slave.sh --master=10.0.0.65:5050 
--isolation=filesystem/linux,docker/runtime --containerizers=docker 
--work_dir=/tmp/mesos --image_providers=docker
5) Start mesos-execute
src/mesos-execute --master=10.0.0.65:5050 --name=test --command="sleep 1" 
--docker_image=ubuntu:14.04 --containerizer=docker
I0509 13:14:56.118808  8320 scheduler.cpp:177] Version: 0.29.0
I0509 13:14:56.120827  8346 scheduler.cpp:479] New master detected at 
master@10.0.0.65:5050
Subscribed with ID 'acff7546-e8bf-4fad-a651-307c73297db0-'
Add Voume 1
Submitted task 'test' to agent '5454a953-83d0-42a4-b7fe-0825a6667f8c-S0'
Received status update TASK_RUNNING for task 'test'
  source: SOURCE_EXECUTOR
Received status update TASK_LOST for task 'test'

6) Inspect container
docker inspect 
...
{
"Name": "c1",
"Source": 
"/var/lib/convoy/devicemapper/mounts/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
"Destination": "/tmp",
"Driver": "convoy",
"Mode": "rw",
"RW": true,
"Propagation": "rprivate"
}
...
7) Check sandbox executer log
I0509 13:14:56.313102  8361 logging.cpp:195] Logging to STDERR
I0509 13:14:56.315385  8361 process.cpp:999] libprocess is initialized on 
10.0.0.65:52853 with 16 worker threads
I0509 13:14:56.316789  8361 exec.cpp:150] Version: 0.29.0
I0509 13:14:56.321717  8387 exec.cpp:200] Executor started at: 
executor(1)@10.0.0.65:52853 with pid 8361
I0509 13:14:56.325158  8388 exec.cpp:225] Executor registered on agent 
5454a953-83d0-42a4-b7fe-0825a6667f8c-S0
I0509 13:14:56.326740  8388 exec.cpp:237] Executor::registered took 325332ns
I0509 13:14:56.327030  8388 exec.cpp:312] Executor asked to run task 'test'
I0509 13:14:56.327163  8388 exec.cpp:321] Executor::launchTask took 98803ns
I0509 13:14:56.327437  8386 docker.cpp:707] Running docker -H 
unix:///var/run/docker.sock run --cpu-shares 1024 --memory 134217728 -e 
MESOS_SANDBOX=/mnt/mesos/sandbox -e 
MESOS_CONTAINER_NAME=mesos-5454a953-83d0-42a4-b7fe-0825a6667f8c-S0.d2fb7a57-d364-41b8-a671-30b95c5cebb4
 --volume-driver=convoy -v c1:/tmp:rw -v 

Re: Review Request 48764: Refactored sandbox authorization logic to use ObjectAuthorizer.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48764/#review138119
---


Ship it!




Ship It!

- Till Toenshoff


On June 16, 2016, 5:34 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48764/
> ---
> 
> (Updated June 16, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-5615
> https://issues.apache.org/jira/browse/MESOS-5615
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously the sandbox authorization used the Request object based
> authorization interface. Additionally this review fixes some issues
> with sandbox authorization object handling  in the LocalAuthorizer.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 2186f0e027946862783e739ece4acbc17dff7d6f 
>   src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 
> 
> Diff: https://reviews.apache.org/r/48764/diff/
> 
> 
> Testing
> ---
> 
> make check (OsX/macOs)
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 48824: Updated the documentation regarding quota authorization.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48824/
---

Review request for mesos, Alexander Rukletsov, Vinod Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  CHANGELOG 0df0d4ccd76379ede6492e595999711e5462f79b 
  docs/upgrades.md afc76f7a0e74042bd095b925f8119bfa5daa489c 

Diff: https://reviews.apache.org/r/48824/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 11:03 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:48 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in MESOS-5628, this patch makes `QuotaHandler` only
send one authorization request per action.

During the deprecation cycle of `ACL::SetQuota` and `ACL::RemoveQuota`,
the `LocalAuthorizer` for example still needs to know whether the action
is a set or remove. We remedy this situation by encoding type (set or
remove) by setting the `value` field in the `Object` with the string
`"SetQuota"` or `"RemoveQuota"`. With this approach, we can simply stop
setting the `value` field at the end of the deprecation cycle as opposed
to changing the public API.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48037/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5627
https://issues.apache.org/jira/browse/MESOS-5627


Repository: mesos


Description
---

Quota-related actions `SET_QUOTA_WITH_ROLE` and
`DESTROY_QUOTA_WITH_PRINCIPAL` were "deprecated" in
https://reviews.apache.org/r/47399/. However, these authorization
actions are new and therefore can be removed instead.

Similar to the transition from `RUN_TASK_WITH_USER`, to `RUN_TASK` in
https://reviews.apache.org/r/48113, `UPDATE_QUOTA_WITH_ROLE` should
become `UPDATE_QUOTA` and be accompanied with `QuotaInfo`.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad 
  include/mesos/authorizer/authorizer.proto 
ffbe4d0f2900601427398e3b1fb8ee478343f034 

Diff: https://reviews.apache.org/r/48037/diff/


Testing (updated)
---

`make check`


Thanks,

Michael Park

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 

Diff: https://reviews.apache.org/r/48040/diff/


Testing (updated)
---

`make check`


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

As described in the JIRA ticket, this patch makes `QuotaHandler` only
send one authorization request per action.

During the deprecation cycle of `ACL::SetQuota` and `ACL::RemoveQuota`,
the `LocalAuthorizer` for example still needs to know whether the action
is a set or remove. We remedy this situation by encoding type (set or
remove) by setting the `value` field in the `Object` with the string
`"SetQuota"` or `"RemoveQuota"`. With this approach, we can simply stop
setting the `value` field at the end of the deprecation cycle as opposed
to changing the public API.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing (updated)
---

`make check`


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing (updated)
---

`make check`


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:47 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in https://reviews.apache.org/r/48039/, `QuotaHandler` is
updated to send only one authorization request per action.

In this patch, we update the `LocalAuthorizer` to handle `UPDATE_QUOTA`.
Note that `QuotaHandler` encodes the type of the request (set or remove)
by setting the `value` field of `Object` to `"SetQuota"` or
`"RemoveQuota"`. The `LocalAuthorizer` uses this information to support
`ACL::SetQuota` and `ACL::RemoveQuota` throughout the deprecation cycle.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48806: Added Berlin usergroup to community page.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48806/#review138108
---



Patch looks great!

Reviews applied: [48806]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48806/
> ---
> 
> (Updated June 16, 2016, 6 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Berlin usergroup to community page.
> 
> 
> Diffs
> -
> 
>   site/source/community/user-groups.html.md 
> fdfe659b4c0742044031a725a30b989c4777c2e0 
> 
> Diff: https://reviews.apache.org/r/48806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:39 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description (updated)
---

As described in the JIRA ticket, this patch makes `QuotaHandler` only
send one authorization request per action.

During the deprecation cycle of `ACL::SetQuota` and `ACL::RemoveQuota`,
the `LocalAuthorizer` for example still needs to know whether the action
is a set or remove. We remedy this situation by encoding type (set or
remove) by setting the `value` field in the `Object` with the string
`"SetQuota"` or `"RemoveQuota"`. With this approach, we can simply stop
setting the `value` field at the end of the deprecation cycle as opposed
to changing the public API.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/
---

(Updated June 16, 2016, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5628
https://issues.apache.org/jira/browse/MESOS-5628


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 

Diff: https://reviews.apache.org/r/48040/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48037/
---

(Updated June 16, 2016, 10:22 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5627
https://issues.apache.org/jira/browse/MESOS-5627


Repository: mesos


Description (updated)
---

Quota-related actions `SET_QUOTA_WITH_ROLE` and
`DESTROY_QUOTA_WITH_PRINCIPAL` were "deprecated" in
https://reviews.apache.org/r/47399/. However, these authorization
actions are new and therefore can be removed instead.

Similar to the transition from `RUN_TASK_WITH_USER`, to `RUN_TASK` in
https://reviews.apache.org/r/48113, `UPDATE_QUOTA_WITH_ROLE` should
become `UPDATE_QUOTA` and be accompanied with `QuotaInfo`.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad 
  include/mesos/authorizer/authorizer.proto 
ffbe4d0f2900601427398e3b1fb8ee478343f034 

Diff: https://reviews.apache.org/r/48037/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/
---

(Updated June 16, 2016, 10:20 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 

Diff: https://reviews.apache.org/r/48040/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:20 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:20 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/
---

(Updated June 16, 2016, 10:10 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 

Diff: https://reviews.apache.org/r/48040/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to send one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 10:09 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Summary (updated)
-

Updated `QuotaHandler` to send one authorization request per action.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 10:10 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48037/
---

(Updated June 16, 2016, 10:10 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Bugs: MESOS-5627
https://issues.apache.org/jira/browse/MESOS-5627


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  include/mesos/authorizer/authorizer.hpp 
02d0d043bd3bf3956709b7c90db8cc4eeb0525ad 
  include/mesos/authorizer/authorizer.proto 
ffbe4d0f2900601427398e3b1fb8ee478343f034 

Diff: https://reviews.apache.org/r/48037/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

[Michael Park]

> On May 30, 2016, 1:22 p.m., Till Toenshoff wrote:
> > src/master/quota_handler.cpp, lines 575-580
> > 
> >
> > Is there a JIRA around introducing LocalAuthorizer specific deprecation 
> > cycles - I would like to understand why we are not pushing this request out 
> > to any authorizer (module).
> 
> Alexander Rukletsov wrote:
> There is no JIRA afaik. In short, the reason why local authorizer is 
> "special" is because the authorizer interface has been refactored in 0.29 and 
> hence we can simply avoid introducing enum values corresponding to the quota 
> authz actions being deprecated in 0.29. However, we still must support 
> related ACLs, which are relevant only to local authorizer. In one sentence: 
> any authorizer (module) is revamped in 0.29 hence no deprecation is needed, 
> while LocalAuthorizer should go through deprecation.

@Till: We've removed this check and decided to always set the `value` field. 
Note that this is still an internal hack, thus we do not claim to set the 
`value` field at the public API level.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135510
---


On June 16, 2016, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated June 16, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `QuotaHandler` to only one authorization request per action.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48803: Added a test for replicated log metrics.

[Jie Yu]

> On June 16, 2016, 9:47 p.m., Joseph Wu wrote:
> > src/tests/log_tests.cpp, lines 2088-2089
> > 
> >
> > Add a "not-recovered" check here.
> > 
> > ```
> > ASSERT_EQ(1u, snapshot.values.count("prefix/log/recovered"));
> > EXPECT_EQ(0, snapshot.values["prefix/log/recovered"]);
> > ```

Added a TODO. Because of the bug mentioned in MESOS-5626, the destruction of 
the log will hang.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48803/#review138075
---


On June 16, 2016, 5:29 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48803/
> ---
> 
> (Updated June 16, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test for replicated log metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 
> 
> Diff: https://reviews.apache.org/r/48803/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48781: Marked some optional fields in state.json as required.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48781/#review138102
---



What exactly is the connection with "state.json"?

- Till Toenshoff


On June 16, 2016, 10:06 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48781/
> ---
> 
> (Updated June 16, 2016, 10:06 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Bugs: MESOS-5588
> https://issues.apache.org/jira/browse/MESOS-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The messages `GetEndpoints`, `ViewFramework`, `ViewTask`, `ViewExecutor`
> and `AccessSandbox` all have optional authorization objects as a result
> of copy and pasting previous message, but their semantics were those
> of an required field, which led to some unexpected behavior when a user
> misstyped any entry there.
> 
> This patch sets the fields to their actual expected values.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 2ffcaa29deaccba5e099a81706432035fe318d98 
> 
> Diff: https://reviews.apache.org/r/48781/diff/
> 
> 
> Testing
> ---
> 
> Ran variations of this script for both master and agent:
> 
> ```sh
> cat < /tmp/credentials.txt
> foo bar
> baz bar
> EOF
> 
> cat < /tmp/acls.json
> {
>   "permissive": false,
>   "access_mesos_logs" : [
> {
>   "principals" : { "values" : ["foo"] },
>   "logs" : { "type" : "ANY" }
> }
>   ],
>   "view_frameworks": [
> {
>   "principals": { "type": "ANY" },
>   "user": { "type": "NONE" }
> }
>   ]
> }
> EOF
> 
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
>   --authenticate_http \
>   --credentials=file:///tmp/credentials.txt \
>   --acls=file:///tmp/acls.json \
>   --log_dir=/tmp/mesos/logs/master 
> ```
> 
> with valid and invalid ACLs
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 48802: Added a metrics prefix for registrar replicated log.

[Jie Yu]

> On June 16, 2016, 9:19 p.m., Joseph Wu wrote:
> > src/master/main.cpp, line 416
> > 
> >
> > With this, the metric name becomes `registrarlog/recovered`.  Maybe use 
> > `registrar/` instead?

Thanks! Good catch!


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48802/#review138087
---


On June 16, 2016, 5:29 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48802/
> ---
> 
> (Updated June 16, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a metrics prefix for registrar replicated log.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 8f84b54505ad07d60c9bebc15b7d2fe1f9ab080a 
>   src/master/main.cpp 91632051b1148f1a9c7e6fc29fe73fcbd019618a 
> 
> Diff: https://reviews.apache.org/r/48802/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48801: Added a metric to replicated log.

[Jie Yu]

> On June 16, 2016, 9:13 p.m., Joseph Wu wrote:
> > src/log/log.hpp, line 111
> > 
> >
> > It might make sense for this to be a `Counter`, since the `recovered` 
> > promise should only ever go from not-ready to ready; not vice-versa.

yeah, but it's slightly more difficult to implement:)


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48801/#review138086
---


On June 16, 2016, 5:28 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48801/
> ---
> 
> (Updated June 16, 2016, 5:28 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a gauge indicating if the replicated log has recovered or not.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 9c8634987181b1345005619e6d16d738903c49fc 
>   src/log/log.hpp 6e7577342d1ba93833e3445daf0f1e67ccc21a09 
>   src/log/log.cpp c0f1cb32a8447f457a4799f7c425a13343292889 
> 
> Diff: https://reviews.apache.org/r/48801/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48806: Added Berlin usergroup to community page.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48806/#review138099
---


Ship it!




Ship It!

- Till Toenshoff


On June 16, 2016, 6 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48806/
> ---
> 
> (Updated June 16, 2016, 6 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Berlin usergroup to community page.
> 
> 
> Diffs
> -
> 
>   site/source/community/user-groups.html.md 
> fdfe659b4c0742044031a725a30b989c4777c2e0 
> 
> Diff: https://reviews.apache.org/r/48806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

[Michael Park]

> On May 30, 2016, 9:39 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 40
> > 
> >
> > Let's add a todo here that this dependency is temporary.

I've removed the `dynamic_cast` to `LocalAuthorizer` and therefore also removed 
this dependency.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/#review135549
---


On June 16, 2016, 9:45 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48039/
> ---
> 
> (Updated June 16, 2016, 9:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `QuotaHandler` to only one authorization request per action.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
>   src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 
> 
> Diff: https://reviews.apache.org/r/48039/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48803: Added a test for replicated log metrics.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48803/#review138075
---


Fix it, then Ship it!





src/tests/log_tests.cpp (line 2086)


Can you add an `ASSERT_SOME` here?  Presumably, you want to make sure the 
replica is in a `VOTING` state.

I added the same assert for the existing tests here: 
https://reviews.apache.org/r/48571/



src/tests/log_tests.cpp (lines 2088 - 2089)


Add a "not-recovered" check here.

```
ASSERT_EQ(1u, snapshot.values.count("prefix/log/recovered"));
EXPECT_EQ(0, snapshot.values["prefix/log/recovered"]);
```


- Joseph Wu


On June 16, 2016, 10:29 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48803/
> ---
> 
> (Updated June 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test for replicated log metrics.
> 
> 
> Diffs
> -
> 
>   src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 
> 
> Diff: https://reviews.apache.org/r/48803/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/
---

(Updated June 16, 2016, 9:46 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated quota authorization tests to satisfy the new requirements.


Diffs (updated)
-

  src/tests/authorization_tests.cpp c133f522743bc255c5d891dd8f5f04d5f209bba2 

Diff: https://reviews.apache.org/r/48040/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48039: Updated `QuotaHandler` to only one authorization request per action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48039/
---

(Updated June 16, 2016, 9:45 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `QuotaHandler` to only one authorization request per action.


Diffs (updated)
-

  src/master/master.hpp 72c60ef74ce57119a97cf8305182340a13c58c42 
  src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 

Diff: https://reviews.apache.org/r/48039/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 9:45 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48376: Changed semantics for granting access to /dev/nvidiactl, etc.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48376/#review138097
---


Ship it!




- Benjamin Mahler


On June 11, 2016, 3:05 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48376/
> ---
> 
> (Updated June 11, 2016, 3:05 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-
> https://issues.apache.org/jira/browse/MESOS-
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, access to `/dev/nvidiactl` and `/dev/nvidia-uvm` was
> only granted to / revoked from a container as GPUs were added and
> removed from them. On some level, this makes sense because most jobs
> don't need access to these devices unless they are also using a GPU.
> However, there are cases when access to these files is appropriate,
> even when not making use of a GPU. Running `nvidia-smi` to control the
> global state of the underlying nvidia driver, for example.
> 
> This commit adds `/dev/nvidiactl` and `/dev/nvidia-uvm` to the default
> whitelist of devices to include in every container when the
> `gpu/nvidia` isolator is enabled. This allows a container to run
> standard nvidia driver tools (such as `nvidia-smi`) without failing
> with abnormal errors when no GPUs have been granted to it. As such,
> these tools will now report that no GPUs are installed instead of
> failing abnormally.
> 
> NOTE: Once we allow GPUs to be granted to containers with filesystem
> isolation turned on, other criteria will be used to determine when /
> if to grant access to these control devices.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
> d7557a0c338e8c0e51461b2326600c03f89c2e8b 
> 
> Diff: https://reviews.apache.org/r/48376/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 48781: Marked some optional fields in state.json as required.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48781/#review138092
---




include/mesos/authorizer/acls.proto (line 169)


required?



include/mesos/authorizer/acls.proto (line 178)


required?


- Adam B


On June 16, 2016, 3:06 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48781/
> ---
> 
> (Updated June 16, 2016, 3:06 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Bugs: MESOS-5588
> https://issues.apache.org/jira/browse/MESOS-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The messages `GetEndpoints`, `ViewFramework`, `ViewTask`, `ViewExecutor`
> and `AccessSandbox` all have optional authorization objects as a result
> of copy and pasting previous message, but their semantics were those
> of an required field, which led to some unexpected behavior when a user
> misstyped any entry there.
> 
> This patch sets the fields to their actual expected values.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 2ffcaa29deaccba5e099a81706432035fe318d98 
> 
> Diff: https://reviews.apache.org/r/48781/diff/
> 
> 
> Testing
> ---
> 
> Ran variations of this script for both master and agent:
> 
> ```sh
> cat < /tmp/credentials.txt
> foo bar
> baz bar
> EOF
> 
> cat < /tmp/acls.json
> {
>   "permissive": false,
>   "access_mesos_logs" : [
> {
>   "principals" : { "values" : ["foo"] },
>   "logs" : { "type" : "ANY" }
> }
>   ],
>   "view_frameworks": [
> {
>   "principals": { "type": "ANY" },
>   "user": { "type": "NONE" }
> }
>   ]
> }
> EOF
> 
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
>   --authenticate_http \
>   --credentials=file:///tmp/credentials.txt \
>   --acls=file:///tmp/acls.json \
>   --log_dir=/tmp/mesos/logs/master 
> ```
> 
> with valid and invalid ACLs
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 48040: Updated quota authorization tests to satisfy the new requirements.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48040/#review138090
---



Bad patch!

Reviews applied: [48040, 48039, 48038, 48037, 47977, 47736, 47704, 47559, 
48052, 47558, 46093]

Failed command: ./support/apply-review.sh -n -r 48038

Error:
2016-06-16 21:20:14 URL:https://reviews.apache.org/r/48038/diff/raw/ 
[9171/9171] -> "48038.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/13826/console

- Mesos ReviewBot


On June 16, 2016, 6 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48040/
> ---
> 
> (Updated June 16, 2016, 6 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated quota authorization tests to satisfy the new requirements.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp ef49ec633351c5a586554916e53d6845fbe8 
> 
> Diff: https://reviews.apache.org/r/48040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48802: Added a metrics prefix for registrar replicated log.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48802/#review138087
---


Fix it, then Ship it!




Can you add a patch to update the monitoring doc with the new metric?

This seems like a good spot:
https://github.com/apache/mesos/blame/2a02d8bfcbf50778b7180fe0aaa22bbdfcdb4097/docs/monitoring.md#L246-L259


src/master/main.cpp (line 416)


With this, the metric name becomes `registrarlog/recovered`.  Maybe use 
`registrar/` instead?


- Joseph Wu


On June 16, 2016, 10:29 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48802/
> ---
> 
> (Updated June 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a metrics prefix for registrar replicated log.
> 
> 
> Diffs
> -
> 
>   src/local/local.cpp 8f84b54505ad07d60c9bebc15b7d2fe1f9ab080a 
>   src/master/main.cpp 91632051b1148f1a9c7e6fc29fe73fcbd019618a 
> 
> Diff: https://reviews.apache.org/r/48802/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48801: Added a metric to replicated log.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48801/#review138086
---


Ship it!





src/log/log.hpp (line 111)


It might make sense for this to be a `Counter`, since the `recovered` 
promise should only ever go from not-ready to ready; not vice-versa.


- Joseph Wu


On June 16, 2016, 10:28 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48801/
> ---
> 
> (Updated June 16, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is a gauge indicating if the replicated log has recovered or not.
> 
> 
> Diffs
> -
> 
>   include/mesos/log/log.hpp 9c8634987181b1345005619e6d16d738903c49fc 
>   src/log/log.hpp 6e7577342d1ba93833e3445daf0f1e67ccc21a09 
>   src/log/log.cpp c0f1cb32a8447f457a4799f7c425a13343292889 
> 
> Diff: https://reviews.apache.org/r/48801/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 9:02 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 558f332b3a5382cee64fb1dcf57b110e481b1efc 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48781: Marked some optional fields in state.json as required.

[Joerg Schad]

> On June 16, 2016, 4:31 p.m., Joerg Schad wrote:
> > include/mesos/authorizer/acls.proto, line 241
> > 
> >
> > Why is this one still optional?

FYI: I added another review adding the other ones (just to run it through out 
internal ci): https://reviews.apache.org/r/48815/


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48781/#review138010
---


On June 16, 2016, 10:06 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48781/
> ---
> 
> (Updated June 16, 2016, 10:06 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Bugs: MESOS-5588
> https://issues.apache.org/jira/browse/MESOS-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The messages `GetEndpoints`, `ViewFramework`, `ViewTask`, `ViewExecutor`
> and `AccessSandbox` all have optional authorization objects as a result
> of copy and pasting previous message, but their semantics were those
> of an required field, which led to some unexpected behavior when a user
> misstyped any entry there.
> 
> This patch sets the fields to their actual expected values.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 2ffcaa29deaccba5e099a81706432035fe318d98 
> 
> Diff: https://reviews.apache.org/r/48781/diff/
> 
> 
> Testing
> ---
> 
> Ran variations of this script for both master and agent:
> 
> ```sh
> cat < /tmp/credentials.txt
> foo bar
> baz bar
> EOF
> 
> cat < /tmp/acls.json
> {
>   "permissive": false,
>   "access_mesos_logs" : [
> {
>   "principals" : { "values" : ["foo"] },
>   "logs" : { "type" : "ANY" }
> }
>   ],
>   "view_frameworks": [
> {
>   "principals": { "type": "ANY" },
>   "user": { "type": "NONE" }
> }
>   ]
> }
> EOF
> 
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
>   --authenticate_http \
>   --credentials=file:///tmp/credentials.txt \
>   --acls=file:///tmp/acls.json \
>   --log_dir=/tmp/mesos/logs/master 
> ```
> 
> with valid and invalid ACLs
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 48790: Added note about generation of `ExecutorInfo` for `CommandInfo`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48790/#review138078
---



Bad patch!

Reviews applied: [48790, 48789, 48765, 48764, 48733]

Failed command: ./support/apply-review.sh -n -r 48764

Error:
2016-06-16 20:49:38 URL:https://reviews.apache.org/r/48764/diff/raw/ 
[3413/3413] -> "48764.patch" [1]
error: patch failed: src/authorizer/local/authorizer.cpp:238
error: src/authorizer/local/authorizer.cpp: patch does not apply
error: patch failed: src/slave/slave.cpp:5421
error: src/slave/slave.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13825/console

- Mesos ReviewBot


On June 16, 2016, 1:01 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48790/
> ---
> 
> (Updated June 16, 2016, 1:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Bugs: MESOS-5615
> https://issues.apache.org/jira/browse/MESOS-5615
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In case of a task specifies a `CommandInfo` the agent will implictly
> generate an `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> 78d8f3637a9d9dae88f1dd6c37908165ab084615 
> 
> Diff: https://reviews.apache.org/r/48790/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 48815: Made all Entities required in acls.proto.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48815/
---

Review request for mesos and Till Toenshoff.


Bugs: Mesos-5588
https://issues.apache.org/jira/browse/Mesos-5588


Repository: mesos


Description
---

Made all Entities required in acls.proto.


Diffs
-

  include/mesos/authorizer/acls.proto cc0b8ea870a3e626ad90efb1691934bb28051435 

Diff: https://reviews.apache.org/r/48815/diff/


Testing
---

(sudo) make check on various systems.


Thanks,

Joerg Schad

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/
---

(Updated June 16, 2016, 8:43 p.m.)


Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
Kone, and Zhitao Li.


Repository: mesos


Description
---

Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp 3c0fe048635abb3a9bea8399050e2ca2d823262d 

Diff: https://reviews.apache.org/r/48038/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 48804: Added a TODO about a bug in RecoverProtocolProcess discard logic.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48804/#review138074
---


Fix it, then Ship it!





src/log/recover.cpp (line 125)


Typo: terminats


- Joseph Wu


On June 16, 2016, 10:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48804/
> ---
> 
> (Updated June 16, 2016, 10:30 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
> https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a TODO about a bug in RecoverProtocolProcess discard logic.
> 
> 
> Diffs
> -
> 
>   src/log/recover.cpp 826e5cd3f7d6cc0a11a6b6b57ab9ba189ac91baf 
> 
> Diff: https://reviews.apache.org/r/48804/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/#review138065
---


Ship it!




This is coming together very nicely!

Now we can build it without external depedencies and we'll pick up the 
dependency at runtime. Are you planning to flip the configure default to have 
the nvidia code enabled by default? That would be great!


configure.ac (line 341)


Weird whitespace here?


- Benjamin Mahler


On June 11, 2016, 3:37 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48365/
> ---
> 
> (Updated June 11, 2016, 3:37 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5552
> https://issues.apache.org/jira/browse/MESOS-5552
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Bundled NVML headers for Nvidia GPU support.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 3622602 
>   3rdparty/Makefile.am fb4a37d 
>   3rdparty/cmake/Versions.cmake 86c51ed 
>   3rdparty/nvml-352.79.tar.gz PRE-CREATION 
>   3rdparty/versions.am 7dcd6bf 
>   configure.ac e344c56 
>   src/Makefile.am b656702 
>   support/install-nvidia-gdk.sh fcb075f 
> 
> Diff: https://reviews.apache.org/r/48365/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36440/#review138072
---



Can you rebase. The patch does not apply.

- Jie Yu


On June 15, 2016, 11:02 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36440/
> ---
> 
> (Updated June 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5341
> https://issues.apache.org/jira/browse/MESOS-5341
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled docker volume support for DockerContainerizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dbffb16f4317df786ee38999a49e4e89733ff9ff 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
>   src/docker/docker.cpp a6dcbe788abb8802baa2c70ec2fced1da75c7210 
> 
> Diff: https://reviews.apache.org/r/36440/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 1) Start convoy
> 2) Create a volume named as c1
> root@kvm-002605:~# convoy list
> {
> "f3459d44-bbed-4e01-a7f6-6c6aa4b70cad": {
> "UUID": "f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Name": "c1",
> "Driver": "devicemapper",
> "MountPoint": "",
> "CreatedTime": "Mon May 09 09:38:52 +0800 2016",
> "DriverInfo": {
> "DevID": "1",
> "Device": 
> "/dev/mapper/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Driver": "devicemapper",
> "MountPoint": "",
> "Size": "107374182400"
> },
> "Snapshots": {}
> }
> }
> 3) Update  mesos-execte to set up volume
> index 4711e80..6c712a2 100644
> --- a/src/cli/execute.cpp
> +++ b/src/cli/execute.cpp
> @@ -72,6 +72,8 @@ using mesos::v1::TaskID;
>  using mesos::v1::TaskInfo;
>  using mesos::v1::TaskState;
>  using mesos::v1::TaskStatus;
> +using mesos::v1::Volume;
> +using mesos::v1::Parameters;
>  
>  using mesos::v1::scheduler::Call;
>  using mesos::v1::scheduler::Event;
> @@ -581,6 +583,18 @@ private:
>  
>containerInfo.set_type(ContainerInfo::DOCKER);
>containerInfo.mutable_docker()->set_image(dockerImage.get());
> +  //containerInfo.mutable_docker()->set_volume_driver("convoy");
> +
> +  Volume* volume1 = containerInfo.add_volumes();
> +  //volume1->set_host_path("c1");
> +  volume1->set_container_path("/tmp");
> +  volume1->mutable_source()->set_type(Volume::Source::DOCKER_VOLUME);
> +  volume1->mutable_source()->mutable_docker_volume()->set_driver(
> +  "convoy");
> +  volume1->mutable_source()->mutable_docker_volume()->set_name(
> +  "c1");
> +  volume1->set_mode(Volume::RW);
> +  cout << "Add Voume 1" << endl;
>  
>if (networks.isSome() && !networks->empty()) {
>  vector tokens = strings::tokenize(networks.get(), ",");
> 4) Start master
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master
> 5) Start agent
> GLOG_v=1 ./bin/mesos-slave.sh --master=10.0.0.65:5050 
> --isolation=filesystem/linux,docker/runtime --containerizers=docker 
> --work_dir=/tmp/mesos --image_providers=docker
> 5) Start mesos-execute
> src/mesos-execute --master=10.0.0.65:5050 --name=test --command="sleep 1" 
> --docker_image=ubuntu:14.04 --containerizer=docker
> I0509 13:14:56.118808  8320 scheduler.cpp:177] Version: 0.29.0
> I0509 13:14:56.120827  8346 scheduler.cpp:479] New master detected at 
> master@10.0.0.65:5050
> Subscribed with ID 'acff7546-e8bf-4fad-a651-307c73297db0-'
> Add Voume 1
> Submitted task 'test' to agent '5454a953-83d0-42a4-b7fe-0825a6667f8c-S0'
> Received status update TASK_RUNNING for task 'test'
>   source: SOURCE_EXECUTOR
> Received status update TASK_LOST for task 'test'
> 
> 6) Inspect container
> docker inspect 
> ...
> {
> "Name": "c1",
> "Source": 
> "/var/lib/convoy/devicemapper/mounts/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Destination": "/tmp",
> "Driver": "convoy",
> "Mode": "rw",
> "RW": true,
> "Propagation": "rprivate"
> }
> ...
> 7) Check sandbox executer log
> I0509 13:14:56.313102  8361 logging.cpp:195] Logging to STDERR
> I0509 13:14:56.315385  8361 process.cpp:999] libprocess is initialized on 
> 10.0.0.65:52853 with 16 worker threads
> I0509 13:14:56.316789  8361 exec.cpp:150] Version: 0.29.0
> I0509 13:14:56.321717  8387 exec.cpp:200] Executor started at: 
> executor(1)@10.0.0.65:52853 with pid 8361
> I0509 13:14:56.325158  8388 exec.cpp:225] Executor registered on agent 
> 5454a953-83d0-42a4-b7fe-0825a6667f8c-S0
> I0509 13:14:56.326740  8388 exec.cpp:237] Executor::registered took 

Re: Review Request 48038: Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.

[Michael Park]

> On May 30, 2016, 4:17 p.m., Joerg Schad wrote:
> > src/authorizer/local/authorizer.cpp, line 59
> > 
> >
> > Just curious: will we keep this around after the deprecation cycle?

Left a comment to point out that this class can be removed after the 
deprecation cycle.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48038/#review135524
---


On June 16, 2016, 5:59 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48038/
> ---
> 
> (Updated June 16, 2016, 5:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `LocalAuthorizer` to consolidate to the `UPDATE_QUOTA` action.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 3c0fe048635abb3a9bea8399050e2ca2d823262d 
> 
> Diff: https://reviews.apache.org/r/48038/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 48781: Marked some optional fields in state.json as required.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48781/#review138069
---




include/mesos/authorizer/acls.proto (line 182)


why optional fields in state.json???

should be acls.proto or?


- Joerg Schad


On June 16, 2016, 10:06 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48781/
> ---
> 
> (Updated June 16, 2016, 10:06 a.m.)
> 
> 
> Review request for mesos, Joerg Schad and Till Toenshoff.
> 
> 
> Bugs: MESOS-5588
> https://issues.apache.org/jira/browse/MESOS-5588
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The messages `GetEndpoints`, `ViewFramework`, `ViewTask`, `ViewExecutor`
> and `AccessSandbox` all have optional authorization objects as a result
> of copy and pasting previous message, but their semantics were those
> of an required field, which led to some unexpected behavior when a user
> misstyped any entry there.
> 
> This patch sets the fields to their actual expected values.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/acls.proto 
> 2ffcaa29deaccba5e099a81706432035fe318d98 
> 
> Diff: https://reviews.apache.org/r/48781/diff/
> 
> 
> Testing
> ---
> 
> Ran variations of this script for both master and agent:
> 
> ```sh
> cat < /tmp/credentials.txt
> foo bar
> baz bar
> EOF
> 
> cat < /tmp/acls.json
> {
>   "permissive": false,
>   "access_mesos_logs" : [
> {
>   "principals" : { "values" : ["foo"] },
>   "logs" : { "type" : "ANY" }
> }
>   ],
>   "view_frameworks": [
> {
>   "principals": { "type": "ANY" },
>   "user": { "type": "NONE" }
> }
>   ]
> }
> EOF
> 
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master \
>   --authenticate_http \
>   --credentials=file:///tmp/credentials.txt \
>   --acls=file:///tmp/acls.json \
>   --log_dir=/tmp/mesos/logs/master 
> ```
> 
> with valid and invalid ACLs
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 48745: Removed JNI major version check.

[Joris Van Remoortere]

> On June 15, 2016, 8:30 p.m., Vinod Kone wrote:
> > Ship It!
> 
> Jiang Yan Xu wrote:
> Thanks, will wait for reviewbot to get to it and then commit it.

I just used this patch to be able to test marathon. +1


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48745/#review137833
---


On June 15, 2016, 7:48 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48745/
> ---
> 
> (Updated June 15, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5571
> https://issues.apache.org/jira/browse/MESOS-5571
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The major version check makes upgrading frameworks unnecessarily hard
> because you would have to deploy Mesos and frameworks in lockstep.
> 
> Dependency management should be done outside of the code but through
> package metadata.
> 
> 
> Diffs
> -
> 
>   src/java/jni/convert.cpp 5c48ca89c376ea904e5dc37234495450b8d2255d 
> 
> Diff: https://reviews.apache.org/r/48745/diff/
> 
> 
> Testing
> ---
> 
> make check passed, particularly Java related ones.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review138064
---



Patch looks great!

Reviews applied: [48583, 48584, 48585, 48799, 48587, 48588, 48800, 48595, 
48737, 48596, 48597, 48600, 48601, 48602, 48603]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 5:26 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> ---
> 
> (Updated June 16, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48601/#review138063
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:58 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48601/
> ---
> 
> (Updated June 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed metrics information via `process::metrics::snapshot`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> 25e8fcaeb9c71eaa43096165745e79c8198c139a 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> be03406c58439b7ab7c1ba12c19dd9f30aff109e 
> 
> Diff: https://reviews.apache.org/r/48601/diff/
> 
> 
> Testing
> ---
> 
> ## Performance test:
> 
> I start a master and three agents in my test server. Use 
> 
> ```
> $ time for i in {1..200}; do curl 'http://localhost:5050/metrics/snapshot' -o 
> /dev/null 2>/dev/null; done
> ```
> 
> to collect the performance data.
> 
> Before apply this patch
> ```
> real1m39.684s
> user0m0.622s
> sys 0m0.776s
> ```
> 
> After apply this patch
> ```
> real1m39.674s
> user0m0.586s
> sys 0m0.817s
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

[Vinod Kone]

> On June 16, 2016, 12:59 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/src/metrics/metrics.cpp, line 262
> > 
> >
> > hmm. you are still copying all the metrics into a hashmap and returning 
> > it, incuring an extra copy, which is not the same as what we were doing 
> > before. is there a way to refactor this without incurring extra copies for 
> > the /metrics/snapshot handler?
> 
> Vinod Kone wrote:
> actually it's not probably that bad because we are already doing a copy 
> in `snapshot()`
> 
> haosdent huang wrote:
> Got it, let me post a performance comparision about `/metrics/snapshot` 
> if apply this patch.
> 
> haosdent huang wrote:
> @vinodkone, I describe my test about performance above. It looks like not 
> big different after apply this patch.

great. thanks for adding the benchmark results.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48601/#review137863
---


On June 16, 2016, 5:58 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48601/
> ---
> 
> (Updated June 16, 2016, 5:58 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, Michael Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Exposed metrics information via `process::metrics::snapshot`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> 25e8fcaeb9c71eaa43096165745e79c8198c139a 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> be03406c58439b7ab7c1ba12c19dd9f30aff109e 
> 
> Diff: https://reviews.apache.org/r/48601/diff/
> 
> 
> Testing
> ---
> 
> ## Performance test:
> 
> I start a master and three agents in my test server. Use 
> 
> ```
> $ time for i in {1..200}; do curl 'http://localhost:5050/metrics/snapshot' -o 
> /dev/null 2>/dev/null; done
> ```
> 
> to collect the performance data.
> 
> Before apply this patch
> ```
> real1m39.684s
> user0m0.622s
> sys 0m0.776s
> ```
> 
> After apply this patch
> ```
> real1m39.674s
> user0m0.586s
> sys 0m0.817s
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36440/#review138062
---


Ship it!




Ship It!

- Jie Yu


On June 15, 2016, 11:02 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36440/
> ---
> 
> (Updated June 15, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5341
> https://issues.apache.org/jira/browse/MESOS-5341
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled docker volume support for DockerContainerizer.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dbffb16f4317df786ee38999a49e4e89733ff9ff 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
>   src/docker/docker.cpp a6dcbe788abb8802baa2c70ec2fced1da75c7210 
> 
> Diff: https://reviews.apache.org/r/36440/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 1) Start convoy
> 2) Create a volume named as c1
> root@kvm-002605:~# convoy list
> {
> "f3459d44-bbed-4e01-a7f6-6c6aa4b70cad": {
> "UUID": "f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Name": "c1",
> "Driver": "devicemapper",
> "MountPoint": "",
> "CreatedTime": "Mon May 09 09:38:52 +0800 2016",
> "DriverInfo": {
> "DevID": "1",
> "Device": 
> "/dev/mapper/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Driver": "devicemapper",
> "MountPoint": "",
> "Size": "107374182400"
> },
> "Snapshots": {}
> }
> }
> 3) Update  mesos-execte to set up volume
> index 4711e80..6c712a2 100644
> --- a/src/cli/execute.cpp
> +++ b/src/cli/execute.cpp
> @@ -72,6 +72,8 @@ using mesos::v1::TaskID;
>  using mesos::v1::TaskInfo;
>  using mesos::v1::TaskState;
>  using mesos::v1::TaskStatus;
> +using mesos::v1::Volume;
> +using mesos::v1::Parameters;
>  
>  using mesos::v1::scheduler::Call;
>  using mesos::v1::scheduler::Event;
> @@ -581,6 +583,18 @@ private:
>  
>containerInfo.set_type(ContainerInfo::DOCKER);
>containerInfo.mutable_docker()->set_image(dockerImage.get());
> +  //containerInfo.mutable_docker()->set_volume_driver("convoy");
> +
> +  Volume* volume1 = containerInfo.add_volumes();
> +  //volume1->set_host_path("c1");
> +  volume1->set_container_path("/tmp");
> +  volume1->mutable_source()->set_type(Volume::Source::DOCKER_VOLUME);
> +  volume1->mutable_source()->mutable_docker_volume()->set_driver(
> +  "convoy");
> +  volume1->mutable_source()->mutable_docker_volume()->set_name(
> +  "c1");
> +  volume1->set_mode(Volume::RW);
> +  cout << "Add Voume 1" << endl;
>  
>if (networks.isSome() && !networks->empty()) {
>  vector tokens = strings::tokenize(networks.get(), ",");
> 4) Start master
> ./bin/mesos-master.sh --work_dir=/tmp/mesos/master
> 5) Start agent
> GLOG_v=1 ./bin/mesos-slave.sh --master=10.0.0.65:5050 
> --isolation=filesystem/linux,docker/runtime --containerizers=docker 
> --work_dir=/tmp/mesos --image_providers=docker
> 5) Start mesos-execute
> src/mesos-execute --master=10.0.0.65:5050 --name=test --command="sleep 1" 
> --docker_image=ubuntu:14.04 --containerizer=docker
> I0509 13:14:56.118808  8320 scheduler.cpp:177] Version: 0.29.0
> I0509 13:14:56.120827  8346 scheduler.cpp:479] New master detected at 
> master@10.0.0.65:5050
> Subscribed with ID 'acff7546-e8bf-4fad-a651-307c73297db0-'
> Add Voume 1
> Submitted task 'test' to agent '5454a953-83d0-42a4-b7fe-0825a6667f8c-S0'
> Received status update TASK_RUNNING for task 'test'
>   source: SOURCE_EXECUTOR
> Received status update TASK_LOST for task 'test'
> 
> 6) Inspect container
> docker inspect 
> ...
> {
> "Name": "c1",
> "Source": 
> "/var/lib/convoy/devicemapper/mounts/f3459d44-bbed-4e01-a7f6-6c6aa4b70cad",
> "Destination": "/tmp",
> "Driver": "convoy",
> "Mode": "rw",
> "RW": true,
> "Propagation": "rprivate"
> }
> ...
> 7) Check sandbox executer log
> I0509 13:14:56.313102  8361 logging.cpp:195] Logging to STDERR
> I0509 13:14:56.315385  8361 process.cpp:999] libprocess is initialized on 
> 10.0.0.65:52853 with 16 worker threads
> I0509 13:14:56.316789  8361 exec.cpp:150] Version: 0.29.0
> I0509 13:14:56.321717  8387 exec.cpp:200] Executor started at: 
> executor(1)@10.0.0.65:52853 with pid 8361
> I0509 13:14:56.325158  8388 exec.cpp:225] Executor registered on agent 
> 5454a953-83d0-42a4-b7fe-0825a6667f8c-S0
> I0509 13:14:56.326740  8388 exec.cpp:237] Executor::registered took 325332ns
> I0509 

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48600/#review138059
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:25 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48600/
> ---
> 
> (Updated June 16, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5484
> https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto PRE-CREATION 
>   include/mesos/master/master.proto PRE-CREATION 
>   include/mesos/v1/agent/agent.proto b9b1680afec4e73c31a9e0aeb74153d129c54ee6 
>   include/mesos/v1/master/master.proto 
> 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48600/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48597/#review138058
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:25 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48597/
> ---
> 
> (Updated June 16, 2016, 5:25 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay 
> Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5513
> https://issues.apache.org/jira/browse/MESOS-5513
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::agent::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp 3ed026e4b7e886ae738567369ee5750591ef97d9 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48597/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48596/#review138057
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48596/
> ---
> 
> (Updated June 16, 2016, 5:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
> https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented v1::master::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48596/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48800: Moved `v1/agent.proto` to `v1/agent/agent.proto`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48800/#review138055
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:15 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48800/
> ---
> 
> (Updated June 16, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved `v1/agent.proto` to `v1/agent/agent.proto`.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/agent.hpp 629e85226241fa49cfa321e2a68e2b8917491948 
>   include/mesos/v1/agent.proto  
>   src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
> 
> Diff: https://reviews.apache.org/r/48800/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48799: Moved `v1/master.proto` to `v1/master/master.proto`.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48799/#review138054
---


Ship it!




Ship It!

- Vinod Kone


On June 16, 2016, 5:12 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48799/
> ---
> 
> (Updated June 16, 2016, 5:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
> https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved `v1/master.proto` to `v1/master/master.proto`.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/master.hpp b5bffa27e53ec84e25cd5f8046a581564076ebe8 
>   include/mesos/v1/master.proto  
>   src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 
>   src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48799/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48037: Removed `SET_QUOTA_WITH_ROLE` and `REMOVE_QUOTA_WITH_PRINCIPAL` actions.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48037/#review138050
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 16, 2016, 6:28 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48037/
> ---
> 
> (Updated June 16, 2016, 6:28 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, Vinod 
> Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Renamed `UPDATE_QUOTA_WITH_ROLE` to `UPDATE_QUOTA`.
> 
> 
> Diffs
> -
> 
>   include/mesos/authorizer/authorizer.hpp 
> 02d0d043bd3bf3956709b7c90db8cc4eeb0525ad 
>   include/mesos/authorizer/authorizer.proto 
> ffbe4d0f2900601427398e3b1fb8ee478343f034 
> 
> Diff: https://reviews.apache.org/r/48037/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>