Re: Review Request 48921: Added a check of namespaces in Posix launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48921/#review138446 --- Ship it! Ship It! - haosdent huang On June 19, 2016, 5:10 a.

Re: Review Request 48917: Fixed docker fetcher redirect errors by header attached.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48917/#review138445 --- Patch looks great! Reviews applied: [48917] Passed command: expo

Review Request 48921: Added a check of namespaces in Posix launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48921/ --- Review request for mesos, Avinash sridharan, Gilbert Song, haosdent huang, and K

Re: Review Request 48915: Added an example framework for consuming GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/#review138444 --- Patch looks great! Reviews applied: [48912, 48913, 48914, 48915]

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138434 --- Fix it, then Ship it! Thanks for the patience Abhishek. I would

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach` h

Re: Review Request 47973: Updated gc to prevent early exit in case of error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/ --- (Updated June 19, 2016, 3:51 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- (Updated June 19, 2016, 3:50 a.m.) Review request for mesos, Alex Clemmer, Jori

Re: Review Request 47972: Updated rmdir to continue deletion on error.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/ --- (Updated June 19, 2016, 3:49 a.m.) Review request for mesos, Alex Clemmer, Jori

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On 六月 19, 2016, 2:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1274 > > > > > > s/slaves/agents > > Kevin Klues wrote: > I thought about this as I was writing it, but I le

Review Request 48919: Updated HTTPProxy to return a failure message in the HTTP result.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48919/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Benjamin

Review Request 48918: Removed explicit authorization results in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48918/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Benjamin

Review Request 48920: Updated the HTTP result returned by failures of authn/authz.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48920/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Benjamin

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 19, 2016, 2:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1274 > > > > > > s/slaves/agents I thought about this as I was writing it, but I left it as slave because all

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138441 --- Patch looks great! Reviews applied: [48613, 48901, 48614] Passed

Re: Review Request 38934: Show framework role in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38934/#review138440 --- Ship it! Ship It! - haosdent huang On Oct. 1, 2015, 6:31 p.m

Re: Review Request 38934: Show framework role in webui.

> On June 18, 2016, 5:58 p.m., Tomasz Janiszewski wrote: > > Could be closed. Solved by https://reviews.apache.org/r/47702/ My bad, let me discard it. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 48911: Show orphan tasks in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138436 --- Ship it! Ship It! - haosdent huang On June 18, 2016, 8:22 p.

Re: Review Request 48910: Highlight disconnected frameworks in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138435 --- Ship it! Nice patch! - haosdent huang On June 18, 2016, 7:16

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48914/#review138432 --- src/master/allocator/mesos/hierarchical.cpp (lines 261 - 263)

Re: Review Request 48911: Show orphan tasks in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138431 --- Patch looks great! Reviews applied: [48911] Passed command: expo

Re: Review Request 48917: Fixed docker fetcher redirect errors by header attached.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48917/ --- (Updated June 18, 2016, 5:19 p.m.) Review request for mesos, Artem Harutyunyan,

Review Request 48917: Fixed docker fetcher redirect errors by header attached.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48917/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME

Re: Review Request 48910: Highlight disconnected frameworks in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138430 --- Patch looks great! Reviews applied: [48910] Passed command: expo

Review Request 48915: Added an example framework for consuming GPUs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48915/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5649 https://issu

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138427 --- Patch looks great! Reviews applied: [48094] Passed command: expo

Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48914/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5634 https://issu

Review Request 48912: Changed all global variable declarations in nvml.cpp to static.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48912/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5550 https://issu

Review Request 48913: Added a `nvml::makeDiscoverable()` call to Nvidia's NVML abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48913/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5550 https://issu

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 9:16 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48901: Fixed all source files affected by the `fromBytes()` change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48901/ --- (Updated June 18, 2016, 9:04 p.m.) Review request for mesos and Vinod Kone. C

Review Request 48911: Show orphan tasks in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and Vinod

Re: Review Request 48909: Replace all tests which require 'perf' with the prefix 'PERF_'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48909/#review138423 --- Patch looks great! Reviews applied: [48909] Passed command: expo

Review Request 48910: Highlight disconnected frameworks in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross All

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5 p.m., haosdent huang wrote: > > src/master/http.cpp, lines 1465-1473 > > > > > > Same here, I think could > > ``` > > Role* role = master->activeRoles[name]; > > > >

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review138420 --- Patch looks great! Reviews applied: [48835, 48841, 48438] Passed

Re: Review Request 38934: Show framework role in webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38934/#review138419 --- Could be closed. Solved by https://reviews.apache.org/r/47702/ -

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5:33 p.m., Abhishek Dasgupta wrote: > > src/tests/api_tests.cpp, lines 459-475 > > > > > > v1Response->get_roles().roles() returns a protobuf repeated pointer > > field. Would it not be a little

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, lines 459-475 > > > > > > I suggest change this to > > ``` > > v1::Resources expectedResources = > > v1::Resources::par

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138416 --- src/tests/api_tests.cpp (lines 459 - 475)

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

> On June 17, 2016, 6:36 a.m., haosdent huang wrote: > > src/internal/devolve.hpp, line 28 > > > > > > Put this above > > ``` > > #include > > ``` I think the alphabectial should be `opq rst`. So ``` #i

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

> On June 17, 2016, 6:36 a.m., haosdent huang wrote: > > src/Makefile.am, line 693 > > > > > > I think you want put > > ``` > > $(top_srcdir)/include/mesos/v1/quota/quota.hpp > > \

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138413 --- Ship it! LGTM if besides some isssues mentioned above. - haosd

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138412 --- src/master/http.cpp (lines 1456 - 1460)

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

> On June 17, 2016, 6:36 a.m., haosdent huang wrote: > > src/Makefile.am, line 693 > > > > > > I think you want put > > ``` > > $(top_srcdir)/include/mesos/v1/quota/quota.hpp > > \

Review Request 48909: Replace all tests which require 'perf' with the prefix 'PERF_'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48909/ --- Review request for mesos, Isabel Jimenez, Jie Yu, Vinod Kone, and Jiang Yan Xu.

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 18, 2016, 4:21 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48908: Added test case for scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/#review138410 --- Patch looks great! Reviews applied: [48906, 48895, 48904, 48907,

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach` h

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach` h

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/ --- (Updated June 18, 2016, 2:53 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138405 --- src/master/http.cpp (line 1456)

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/ --- (Updated 六月 18, 2016, 2:02 p.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48841: Add Agent protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/ --- (Updated 六月 18, 2016, 1:59 p.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48905: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48905/#review138404 --- Patch looks great! Reviews applied: [48905] Passed command: expo

Re: Review Request 48879: Added logic for subscribing to task added/updated events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48879/#review138403 --- src/master/http.cpp (line 689)

Re: Review Request 48880: Added test for task added/update event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48880/#review138402 --- Ship it! Ship It! - haosdent huang On June 18, 2016, 12:22 a

Review Request 48904: Updated allocator initialize().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48904/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5620 https://issu

Review Request 48906: Added helper function to get non-scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48906/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5621 https://issu

Review Request 48908: Added test case for scarce resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48908/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5623 https://issu

Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48895/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5620 https://issu

Review Request 48907: Updated allocator to filter out scarce resources from sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48907/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5622 https://issu

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138401 --- Patch looks great! Reviews applied: [48094] Passed command: expo

Re: Review Request 48878: Added protobuf helpers for creating task added/updated events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48878/#review138400 --- Ship it! Ship It! - haosdent huang On June 17, 2016, 8:17 p.

Re: Review Request 48877: Added evolve logic for `master::Event` -> `v1::master::Event`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48877/#review138399 --- Ship it! Ship It! - haosdent huang On June 17, 2016, 8:17 p.

Re: Review Request 48875: Fixed a couple of minor style typos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48875/#review138398 --- Ship it! Ship It! - haosdent huang On June 17, 2016, 8:17 p.

Re: Review Request 48873: Added `Task` to `v1/mesos.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48873/#review138397 --- Ship it! Ship It! - haosdent huang On June 17, 2016, 8:17 p.

Re: Review Request 48905: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48905/ --- (Updated June 18, 2016, 11:53 a.m.) Review request for mesos, Abhishek Dasgupta

Review Request 48905: Added missing comments for operator API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48905/ --- Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, and Vino

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 18, 2016, 11:23 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 46875: Some cleanup in weights_handler.cpp.

> On 六月 17, 2016, 1 p.m., Alexander Rukletsov wrote: > > I beleive `request.body` is supposed to be the contents, and not the file, > > right? Just FYI, Alex, I have fixed this issue in https://reviews.apache.org/r/48680/ and it was merged today. - Guangya -

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138395 --- include/mesos/v1/maintenance/maintenance.proto (line 18)

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138394 --- Bad patch! Reviews applied: [48614, 48901, 48613] Failed command

Re: Review Request 48902: Move v1/master/allocator.proto to its own package.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138393 --- Patch looks great! Reviews applied: [48902] Passed command: expo

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 8:21 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 8:20 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 7:58 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48613: Added validation logic for UUID's.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48613/ --- (Updated June 18, 2016, 7:58 a.m.) Review request for mesos and Vinod Kone. C

Review Request 48901: Fixed all source files affected by the `fromBytes()` change.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48901/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5224 https://issues.ap

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

> On June 13, 2016, 7:41 a.m., Neil Conway wrote: > > src/tests/scheduler_http_api_tests.cpp, line 974 > > > > > > Why are we fetching the stream ID? > > Vinod Kone wrote: > looks like you forgot to set the stre

Re: Review Request 48387: Delay before initiating a connection with master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48387/#review138391 --- Patch looks great! Reviews applied: [48387] Passed command: expo