Re: Review Request 49616: Add suppression benchmark.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141253
---



Another nit is that in `Testing Done` section, it is better add some testing 
command and test data but not only `make check`.

Such as following:

GLOG_v=1 ./bin/mesos-tests.sh --benchmark 
--gtest_filter="SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2"
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN  ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2
Using 1000 agents and 100 frameworks
allocate() took 905223us to make 1000 offers with 20 out of 100 frameworks 
suppressing offers
allocate() took 899943us to make 1000 offers with 40 out of 100 frameworks 
suppressing offers
allocate() took 943203us to make 1000 offers with 60 out of 100 frameworks 
suppressing offers
allocate() took 918019us to make 1000 offers with 80 out of 100 frameworks 
suppressing offers
allocate() took 92340us to make 0 offers with 100 out of 100 frameworks 
suppressing offers
[   OK ] 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/2 
(7279 ms)
[--] 1 test from 
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (7279 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (7288 ms total)
[  PASSED  ] 1 test.

- Guangya Liu


On 七月 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated 七月 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49616: Add suppression benchmark.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141251
---




src/tests/hierarchical_allocator_tests.cpp (lines 3607 - 3608)


I think that you still need the following to reserve some spaces for those 
two vectors to avoid allocate/reallocate memory when call push_back to put in 
slaveInfo/FrameworkInfo.

slaves.reserve(slaveCount);
frameworks.reserve(frameworkCount);



src/tests/hierarchical_allocator_tests.cpp (line 3640)


I think that the reason you want to use `batch` is because you want to 
speed up the test by decrease the whole loop here, if so, can you please update 
the comments a bit for why you want to use `batch` here? 

Such as following:

// TODO(jjanco): Parameterize the test by batch size, not an arbitrary 
number. This can help reduce the total loop of benchmark test and speed up this 
unit test.



src/tests/hierarchical_allocator_tests.cpp (lines 3641 - 3642)


new line here



src/tests/hierarchical_allocator_tests.cpp (lines 3648 - 3649)


new line here



src/tests/hierarchical_allocator_tests.cpp (lines 3654 - 3655)


new line here


- Guangya Liu


On 七月 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated 七月 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49616: Add suppression benchmark.

[Jiang Yan Xu]

> On July 6, 2016, 4:19 p.m., Jiang Yan Xu wrote:
> >
> 
> Guangya Liu wrote:
> @Jiang Yan, just FYI, I filed a JIRA here 
> https://issues.apache.org/jira/browse/MESOS-5800 to trace the comments you 
> mentioned here for other benchmark test.

Thanks!


> On July 6, 2016, 4:19 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3609-3616
> > 
> >
> > We can simply:
> > 
> > ```
> > cout << "Using " << slaveCount << " agents and "
> >  << frameworkCount << " frameworks" << endl;
> > 
> > vector slaves(slaveCount);
> > vector frameworks(frameworkCount);
> > ```
> 
> Guangya Liu wrote:
> I think that you did not address this comment but still using 
> `vector frameworks;`. We cannot use `vector 
> frameworks(frameworkCount);` here, as the `vector 
> frameworks(frameworkCount);` will create some empty frameworks and when 
> allocator add frameworks, we will get segment fault as `F0707 22:26:05.169266 
> 25663 hierarchical.cpp:242] Check failed: 
> !frameworkSorters[role]->contains(frameworkId.value())`.

Hey Guangya, thanks for pointing this out. It's my fault for suggesting 
`vector slaves(slaveCount)` which is actually a "fill constructor". 
We still have to use `reserve()`.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
---


On July 7, 2016, 8:48 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated July 7, 2016, 8:48 p.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49780/#review141249
---


Ship it!




Ship It!

- Jay Guo


On July 8, 2016, 2:12 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49780/
> ---
> 
> (Updated July 8, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, zhou xing, Jay Guo, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were waiting on `__recover()` to be invoked which does
> _not_ mean that the function has completed. This can lead to
> some flakiness i.e. a `503 xx` when the `post()` happens before
> the agent has finished recovery e.g., due to a context switch.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49780/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=1000)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 49616: Add suppression benchmark.

[Guangya Liu]

> On 七月 6, 2016, 11:19 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3609-3616
> > 
> >
> > We can simply:
> > 
> > ```
> > cout << "Using " << slaveCount << " agents and "
> >  << frameworkCount << " frameworks" << endl;
> > 
> > vector slaves(slaveCount);
> > vector frameworks(frameworkCount);
> > ```

I think that you did not address this comment but still using 
`vector frameworks;`. We cannot use `vector 
frameworks(frameworkCount);` here, as the `vector 
frameworks(frameworkCount);` will create some empty frameworks and when 
allocator add frameworks, we will get segment fault as `F0707 22:26:05.169266 
25663 hierarchical.cpp:242] Check failed: 
!frameworkSorters[role]->contains(frameworkId.value())`.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
---


On 七月 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated 七月 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Review Request 49788: Used MESOS_VERSION instead of fixed mesos version string.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49788/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Fixed the hard coded version string in GetAgents test in
api_tests.


Diffs
-

  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49788/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49785: MESOS-5808 - Elasticsearch misspelled on homepage

[Keith Chambers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49785/
---

(Updated July 8, 2016, 4:23 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-5808
https://issues.apache.org/jira/browse/MESOS-5808


Repository: mesos


Description
---

MESOS-5808 - Elasticsearch misspelled on homepage


Diffs
-

  site/source/index.html.erb 5beaeae6a600185b1f4b890f81cb4be0cec3c5ae 

Diff: https://reviews.apache.org/r/49785/diff/


Testing
---

Documentation change. No testing done.


Thanks,

Keith Chambers

Review Request 49785: MESOS-5808 - Elasticsearch misspelled on homepage

[Keith Chambers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49785/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5805
https://issues.apache.org/jira/browse/MESOS-5805


Repository: mesos


Description
---

MESOS-5808 - Elasticsearch misspelled on homepage


Diffs
-

  site/source/index.html.erb 5beaeae6a600185b1f4b890f81cb4be0cec3c5ae 

Diff: https://reviews.apache.org/r/49785/diff/


Testing
---

Documentation change. No testing done.


Thanks,

Keith Chambers

Review Request 49784: Increase framework numbers to allocator benchmarks.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49784/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5780 and MESOS-5781
https://issues.apache.org/jira/browse/MESOS-5780
https://issues.apache.org/jira/browse/MESOS-5781


Repository: mesos


Description
---

- Our clusters have very high numbers of frameworks,
  and we would like to increase the allocator benchmark
  parameters to reflect this.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49784/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49616: Add suppression benchmark.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/
---

(Updated July 8, 2016, 3:48 a.m.)


Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.


Bugs: MESOS-5781
https://issues.apache.org/jira/browse/MESOS-5781


Repository: mesos


Description
---

- Useful for high framework clusters which carry
  many suppressed frameworks that are considered
  during allocation.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49616/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49616: Add suppression benchmark.

[Jacob Janco]

> On July 6, 2016, 11:19 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 3587
> > 
> >
> > We actually don't need this count and it's misleading: it's not the 
> > count of offers. It's the count of frameworks that are receiving offers in 
> > this allocation round.
> > 
> > To get the offer count we can use `offers.size()`.

Agreed, removing and using offers.size().


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
---


On July 8, 2016, 3:48 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated July 8, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/
---

(Updated July 8, 2016, 3:11 a.m.)


Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.


Changes
---

Fix loop condition.


Bugs: MESOS-5780
https://issues.apache.org/jira/browse/MESOS-5780


Repository: mesos


Description
---

- This benchmark measures latency to stability of
  the allocator following disconnection and
  reconnection of all frameworks.
- In this scenario, frameworks are offered resources
  and suppressed in batches.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49617/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49780/#review141239
---


Ship it!




Ship It!

- Vinod Kone


On July 8, 2016, 2:12 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49780/
> ---
> 
> (Updated July 8, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, zhou xing, Jay Guo, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were waiting on `__recover()` to be invoked which does
> _not_ mean that the function has completed. This can lead to
> some flakiness i.e. a `503 xx` when the `post()` happens before
> the agent has finished recovery e.g., due to a context switch.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49780/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=1000)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49780/#review141237
---


Ship it!




Ship It!

- haosdent huang


On July 8, 2016, 2:12 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49780/
> ---
> 
> (Updated July 8, 2016, 2:12 a.m.)
> 
> 
> Review request for mesos, zhou xing, Jay Guo, haosdent huang, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We were waiting on `__recover()` to be invoked which does
> _not_ mean that the function has completed. This can lead to
> some flakiness i.e. a `503 xx` when the `post()` happens before
> the agent has finished recovery e.g., due to a context switch.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 
> 
> Diff: https://reviews.apache.org/r/49780/diff/
> 
> 
> Testing
> ---
> 
> make check (gtest_repeat=1000)
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 49780: Added a `Clock::settle()` to ensure agent has finished recovery.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49780/
---

Review request for mesos, zhou xing, Jay Guo, haosdent huang, and Vinod Kone.


Repository: mesos


Description
---

We were waiting on `__recover()` to be invoked which does
_not_ mean that the function has completed. This can lead to
some flakiness i.e. a `503 xx` when the `post()` happens before
the agent has finished recovery e.g., due to a context switch.


Diffs
-

  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49780/diff/


Testing
---

make check (gtest_repeat=1000)


Thanks,

Anand Mazumdar

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/
---

(Updated July 8, 2016, 2:07 a.m.)


Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.


Changes
---

Get rid of offerCount


Bugs: MESOS-5780
https://issues.apache.org/jira/browse/MESOS-5780


Repository: mesos


Description
---

- This benchmark measures latency to stability of
  the allocator following disconnection and
  reconnection of all frameworks.
- In this scenario, frameworks are offered resources
  and suppressed in batches.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49617/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49773: Moved veth related functions to a separate file.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49773/#review141236
---


Ship it!




Ship It!

- Qian Zhang


On July 8, 2016, 6:35 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49773/
> ---
> 
> (Updated July 8, 2016, 6:35 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of the effort to allow linking with a lower version of
> libnl. veth related functions were introduced in libnl 3.2.24.
> However, most of the popular Linux distributions use 3.2.21.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
>   src/linux/routing/link/link.hpp a4c92dc22cb23d9886ba0e74980c95ab0abf5daf 
>   src/linux/routing/link/link.cpp 3803d6f5d1f766da5de6af42333b5df52a3c1fba 
>   src/linux/routing/link/veth.hpp PRE-CREATION 
>   src/linux/routing/link/veth.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
>   src/tests/containerizer/routing_tests.cpp 
> f3298742dd4944d9d356b2edd20dc9c07c11ea9b 
> 
> Diff: https://reviews.apache.org/r/49773/diff/
> 
> 
> Testing
> ---
> 
> make check on fedora 23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 48593: Refactor Ranges Subtraction.

[Yanyan Hu]

> On July 6, 2016, 8:41 a.m., Guangya Liu wrote:
> > Another comment is that you may want to add a benchmark test case for this 
> > smiliar as 
> > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3299
> 
> Yanyan Hu wrote:
> Hi, Guangya, thanks a lot for your comments. Will revise the patch per 
> your suggestion.
> 
> Joseph Wu wrote:
> @Yanyan, have you published a revised patch?  Most of the issues you've 
> marked as fixed are not actually fixed.

Hi, Joseph, sorry forgot to publish it...


- Yanyan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review140967
---


On July 8, 2016, 1:42 a.m., Yanyan Hu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> ---
> 
> (Updated July 8, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-5425
> https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>

Re: Review Request 48593: Refactor Ranges Subtraction.

[Yanyan Hu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/
---

(Updated July 8, 2016, 1:42 a.m.)


Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van 
Remoortere.


Changes
---

Fix issues mentioned by GuangYa.


Bugs: MESOS-5425
https://issues.apache.org/jira/browse/MESOS-5425


Repository: mesos


Description
---

This patch reimplement Ranges subtraction using
IntervalSet data type: Ranges values will be
converted to IntervalSet values for subtraction
and the result will be converted back to Ranges
after subtraction is done. This change is for
fixing jira MESOS-5425.


Diffs (updated)
-

  src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
  src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 

Diff: https://reviews.apache.org/r/48593/diff/


Testing
---

make check


Thanks,

Yanyan Hu

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3711-3725
> > 
> >
> > 1. We should recover resources after the whole batch is finished and 
> > not after each `activateFramework` is called, as this is often the case in 
> > realistic scenarios.
> > 2. If we don't `settle()` then vector is actually not thread-safe so I 
> > think we need to settle here.
> > 
> > How about this for the entire loop?
> > 
> > ```
> >   for (unsigned batchStart = 0;
> >batchStart < frameworkCount;
> >batchStart += batchSize) {
> > unsigned batchEnd = min(batchStart + batchSize, frameworkCount);
> >   
> > // Activate all frameworks in this batch to trigger allocations.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->activateFramework(frameworks[i].id());
> > }
> > 
> > // Suppress offers in this batch after all activations. This is
> > // requires another message round trip between schedulers and the
> > // master following the activation.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->suppressOffers(frameworks[k].id());
> > }
> > 
> > // Make sure all resources are offered. This avoids data races in
> > // the offers vector.
> > Clock::settle();
> > 
> > foreach (auto offer, offers) {
> >   allocator->recoverResources(
> >   offer.frameworkId, 
> >   offer.slaveId,
> >   offer.resources, 
> >   None());
> > }
> > 
> > offers.clear();
> >   }
> > ```
> 
> Jacob Janco wrote:
> added a termination condition  for (unsigned i = batchStart; i < batchEnd 
> && i < frameworkCount; i++) {
> 
> to account for all frameworkCount cases. 
> 
> Also, I recover offers there because only framework 1 of the batch will 
> get an offer, so we will get 1005 offers for the whole of a test run with 
> 1000 agents the 5 being the 5 batches of activate/suppress. What do you think?
> 
> Jacob Janco wrote:
> Actually strike that wasn't thinking, I'll report offers.size() at the 
> end! agree with this completely!

This seems irrelevant to the test, I'll remove that metric entirely.


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review140887
---


On July 8, 2016, 1:22 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> ---
> 
> (Updated July 8, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
> https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3711-3725
> > 
> >
> > 1. We should recover resources after the whole batch is finished and 
> > not after each `activateFramework` is called, as this is often the case in 
> > realistic scenarios.
> > 2. If we don't `settle()` then vector is actually not thread-safe so I 
> > think we need to settle here.
> > 
> > How about this for the entire loop?
> > 
> > ```
> >   for (unsigned batchStart = 0;
> >batchStart < frameworkCount;
> >batchStart += batchSize) {
> > unsigned batchEnd = min(batchStart + batchSize, frameworkCount);
> >   
> > // Activate all frameworks in this batch to trigger allocations.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->activateFramework(frameworks[i].id());
> > }
> > 
> > // Suppress offers in this batch after all activations. This is
> > // requires another message round trip between schedulers and the
> > // master following the activation.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->suppressOffers(frameworks[k].id());
> > }
> > 
> > // Make sure all resources are offered. This avoids data races in
> > // the offers vector.
> > Clock::settle();
> > 
> > foreach (auto offer, offers) {
> >   allocator->recoverResources(
> >   offer.frameworkId, 
> >   offer.slaveId,
> >   offer.resources, 
> >   None());
> > }
> > 
> > offers.clear();
> >   }
> > ```
> 
> Jacob Janco wrote:
> added a termination condition  for (unsigned i = batchStart; i < batchEnd 
> && i < frameworkCount; i++) {
> 
> to account for all frameworkCount cases. 
> 
> Also, I recover offers there because only framework 1 of the batch will 
> get an offer, so we will get 1005 offers for the whole of a test run with 
> 1000 agents the 5 being the 5 batches of activate/suppress. What do you think?

Actually strike that wasn't thinking, I'll report offers.size() at the end! 
agree with this completely!


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review140887
---


On July 8, 2016, 1:22 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> ---
> 
> (Updated July 8, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
> https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered resources
>   and suppressed in batches.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49617/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49694: Filter out fully used agents before allocate resources.

[Guangya Liu]

> On 七月 6, 2016, 9:17 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1220-1228
> > 
> >
> > I think the intention of this filtering was that the allocation loop 
> > needs to ignore agents that are not whitelisted or that are not activated, 
> > because otherwise it would send offers for them.
> > 
> > If the agent doesn't have free resources, that's the intention of 
> > checking `!allocatable(resources)` when we're trying to offer resources 
> > below. Technically, you should be checking the same here.
> > 
> > I'm confused by this patch since you showed that it doesn't help 
> > performance and this isn't necessary. Why did you send it?
> 
> Guangya Liu wrote:
> Hi Ben, I did more test with 4000, 8000, 12000 fully used agent and 2000 
> non-fully used agent, the test result showed that there are indeed some 
> performnace improvement with the number of fully used agent increase.
> 
> 1) 6000 agents (4000 fully used + 2000 non-fully used)
> 
> Before fix:
> Using 6000 agents and 200 frameworks with 4000 agents fully used
> round 0 allocate took 3.224707secs to make 200 offers
> round 1 allocate took 3.205996secs to make 200 offers
> round 2 allocate took 3.203761secs to make 200 offers
> round 3 allocate took 3.520678secs to make 200 offers
> round 4 allocate took 3.599001secs to make 200 offers
> round 5 allocate took 3.437631secs to make 200 offers
> round 6 allocate took 3.197855secs to make 200 offers
> round 7 allocate took 3.210213secs to make 200 offers
> round 8 allocate took 3.482421secs to make 200 offers
> round 9 allocate took 3.495999secs to make 200 offers
> round 10 allocate took 3.270022secs to make 200 offers
> round 11 allocate took 3.303073secs to make 200 offers
> round 12 allocate took 3.574657secs to make 200 offers
> round 13 allocate took 3.20638secs to make 200 offers
> round 14 allocate took 3.644309secs to make 200 offers
> round 15 allocate took 3.22866secs to make 200 offers
> round 16 allocate took 3.234343secs to make 200 offers
> round 17 allocate took 3.457045secs to make 200 offers
> round 18 allocate took 3.30394secs to make 200 offers
> round 19 allocate took 3.323927secs to make 200 offers
> round 20 allocate took 3.477471secs to make 200 offers
> round 21 allocate took 3.494607secs to make 200 offers
> round 22 allocate took 3.330647secs to make 200 offers
> 
> 
> After Fix:
> [ RUN  ] HierarchicalAllocator_BENCHMARK_Test.FilterOutFullyUsedAgent
> Using 6000 agents and 200 frameworks with 4000 agents fully used
> round 0 allocate took 3.101395secs to make 200 offers
> round 1 allocate took 3.076541secs to make 200 offers
> round 2 allocate took 3.054527secs to make 200 offers
> round 3 allocate took 3.089352secs to make 200 offers
> round 4 allocate took 3.670608secs to make 200 offers
> round 5 allocate took 3.343736secs to make 200 offers
> round 6 allocate took 3.268496secs to make 200 offers
> round 7 allocate took 3.313199secs to make 200 offers
> round 8 allocate took 3.269126secs to make 200 offers
> round 9 allocate took 3.219127secs to make 200 offers
> round 10 allocate took 3.259214secs to make 200 offers
> round 11 allocate took 3.825867secs to make 200 offers
> round 12 allocate took 3.907938secs to make 200 offers
> round 13 allocate took 3.380813secs to make 200 offers
> round 14 allocate took 3.116237secs to make 200 offers
> round 15 allocate took 3.140145secs to make 200 offers
> round 16 allocate took 3.059795secs to make 200 offers
> round 17 allocate took 3.164924secs to make 200 offers
> round 18 allocate took 3.424397secs to make 200 offers
> round 19 allocate took 3.12893secs to make 200 offers
> round 20 allocate took 3.101884secs to make 200 offers
> 
> 2) 1 agents (8000 fully used + 2000 non-fully used)
> 
> Before Fix:
> Using 1 agents and 200 frameworks with 8000 agents fully used
> round 0 allocate took 3.372285secs to make 200 offers
> round 1 allocate took 3.411058secs to make 200 offers
> round 2 allocate took 3.3929secs to make 200 offers
> round 3 allocate took 3.412163secs to make 200 offers
> round 4 allocate took 3.434624secs to make 200 offers
> round 5 allocate took 3.774675secs to make 200 offers
> round 6 allocate took 3.570071secs to make 200 offers
> round 7 allocate took 3.400986secs to make 200 offers
> round 8 allocate took 3.438448secs to make 200 offers
> round 9 allocate took 3.407503secs to make 200 offers
> round 10 allocate took 3.463708secs to make 200 offers
> round 11 allocate took 3.990451secs to make 200 offers
> round 12 allocate took 4.181017secs to make 200 offers
> 

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/
---

(Updated July 8, 2016, 1:22 a.m.)


Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.


Changes
---

Fixed a few typos and spacing.


Bugs: MESOS-5780
https://issues.apache.org/jira/browse/MESOS-5780


Repository: mesos


Description
---

- This benchmark measures latency to stability of
  the allocator following disconnection and
  reconnection of all frameworks.
- In this scenario, frameworks are offered resources
  and suppressed in batches.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49617/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 3629
> > 
> >
> > Looks like our test doesn't use `offerCount` at all?
> > 
> > If we keep `offerCount` we can log how many total offers are generated 
> > at the end of the test. It's not an essential metric but I guess it would 
> > be nice to confirm.

Yes this is why I kept it here, I was using it while debugging. I'll add it as 
a metric at the end.


> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 3704
> > 
> >
> > Use `std::lround`?
> > 
> > This math here would be equivalent but it would be nice if we don't 
> > have to explain it. :)

So lround rounds down I want to do a std::ceil without having to cast the 
double. For instance 103 frameworks, I want batches of 21 rather than 20. Also 
for the case of frameworkCount=1 lround will give me batch size 0 and I get an 
infinite loop.


> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 3708
> > 
> >
> > Single space around `+=`.
> > 
> > More importantly, will this exclude the frameworks numbered after the 
> > last "full-sized" batch? i.e., framework 5-8 if frameworkCount == 9?
> > 
> > I suggest we restructure the loop as described below.

I overlooked this, but we will want:

for (unsigned i = batchStart; i < batchEnd && i < frameworkCount; i++) with the 
above comment for the ceiling. so in the case of 103 frameworks I hit 84 with a 
batchend of 105 and I'll terminate both inner loops at i < 103.


> On July 6, 2016, 6:24 p.m., Jiang Yan Xu wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 3711-3725
> > 
> >
> > 1. We should recover resources after the whole batch is finished and 
> > not after each `activateFramework` is called, as this is often the case in 
> > realistic scenarios.
> > 2. If we don't `settle()` then vector is actually not thread-safe so I 
> > think we need to settle here.
> > 
> > How about this for the entire loop?
> > 
> > ```
> >   for (unsigned batchStart = 0;
> >batchStart < frameworkCount;
> >batchStart += batchSize) {
> > unsigned batchEnd = min(batchStart + batchSize, frameworkCount);
> >   
> > // Activate all frameworks in this batch to trigger allocations.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->activateFramework(frameworks[i].id());
> > }
> > 
> > // Suppress offers in this batch after all activations. This is
> > // requires another message round trip between schedulers and the
> > // master following the activation.
> > for (unsigned i = batchStart; i < batchEnd; i++) {
> >   allocator->suppressOffers(frameworks[k].id());
> > }
> > 
> > // Make sure all resources are offered. This avoids data races in
> > // the offers vector.
> > Clock::settle();
> > 
> > foreach (auto offer, offers) {
> >   allocator->recoverResources(
> >   offer.frameworkId, 
> >   offer.slaveId,
> >   offer.resources, 
> >   None());
> > }
> > 
> > offers.clear();
> >   }
> > ```

added a termination condition  for (unsigned i = batchStart; i < batchEnd && i 
< frameworkCount; i++) {

to account for all frameworkCount cases. 

Also, I recover offers there because only framework 1 of the batch will get an 
offer, so we will get 1005 offers for the whole of a test run with 1000 agents 
the 5 being the 5 batches of activate/suppress. What do you think?


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/#review140887
---


On July 8, 2016, 1:06 a.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49617/
> ---
> 
> (Updated July 8, 2016, 1:06 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5780
> https://issues.apache.org/jira/browse/MESOS-5780
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - This benchmark measures latency to stability of
>   the allocator following disconnection and
>   reconnection of all frameworks.
> - In this scenario, frameworks are offered 

Re: Review Request 49617: Add benchmark for failover of many frameworks.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49617/
---

(Updated July 8, 2016, 1:06 a.m.)


Review request for mesos, Joris Van Remoortere and Jiang Yan Xu.


Bugs: MESOS-5780
https://issues.apache.org/jira/browse/MESOS-5780


Repository: mesos


Description
---

- This benchmark measures latency to stability of
  the allocator following disconnection and
  reconnection of all frameworks.
- In this scenario, frameworks are offered resources
  and suppressed in batches.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49617/diff/


Testing
---

make check


Thanks,

Jacob Janco

Re: Review Request 49773: Moved veth related functions to a separate file.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49773/#review141228
---


Ship it!




Ship It!

- Avinash sridharan


On July 7, 2016, 10:35 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49773/
> ---
> 
> (Updated July 7, 2016, 10:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of the effort to allow linking with a lower version of
> libnl. veth related functions were introduced in libnl 3.2.24.
> However, most of the popular Linux distributions use 3.2.21.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
>   src/linux/routing/link/link.hpp a4c92dc22cb23d9886ba0e74980c95ab0abf5daf 
>   src/linux/routing/link/link.cpp 3803d6f5d1f766da5de6af42333b5df52a3c1fba 
>   src/linux/routing/link/veth.hpp PRE-CREATION 
>   src/linux/routing/link/veth.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
>   src/tests/containerizer/routing_tests.cpp 
> f3298742dd4944d9d356b2edd20dc9c07c11ea9b 
> 
> Diff: https://reviews.apache.org/r/49773/diff/
> 
> 
> Testing
> ---
> 
> make check on fedora 23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 49773: Moved veth related functions to a separate file.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49773/#review141225
---



Patch looks great!

Reviews applied: [49773]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 10:35 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49773/
> ---
> 
> (Updated July 7, 2016, 10:35 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is part of the effort to allow linking with a lower version of
> libnl. veth related functions were introduced in libnl 3.2.24.
> However, most of the popular Linux distributions use 3.2.21.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
>   src/linux/routing/link/link.hpp a4c92dc22cb23d9886ba0e74980c95ab0abf5daf 
>   src/linux/routing/link/link.cpp 3803d6f5d1f766da5de6af42333b5df52a3c1fba 
>   src/linux/routing/link/veth.hpp PRE-CREATION 
>   src/linux/routing/link/veth.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
> 79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
>   src/tests/containerizer/routing_tests.cpp 
> f3298742dd4944d9d356b2edd20dc9c07c11ea9b 
> 
> Diff: https://reviews.apache.org/r/49773/diff/
> 
> 
> Testing
> ---
> 
> make check on fedora 23
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49520/
---

(Updated July 7, 2016, 11:45 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5752
https://issues.apache.org/jira/browse/MESOS-5752


Repository: mesos


Description
---

In GarbageCollectorIntegrationTest.BusyMountPoint there is
a race between the task creating a file and the test looking for it
which sometimes leads to assertion failure on the existence of the
file.


Diffs
-

  src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 

Diff: https://reviews.apache.org/r/49520/diff/


Testing (updated)
---

make check on mac os and linux


Thanks,

Megha Sharma

Re: Review Request 49245: Implement READ_FILE for agent operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 7, 2016, 11:42 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp 86803fe5c6524ada01956840e90404ab176ff8fb 
  src/slave/slave.hpp a8952f00086c8feb486895eb6a41cc2d27432da0 
  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49244: Implement READ_FILE for master operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49244/
---

(Updated 七月 7, 2016, 11:41 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for master operator API.


Diffs (updated)
-

  src/master/http.cpp 8b7e91718c04767b504fbc58965a30d2306b2ecd 
  src/master/master.hpp 845f2f6103b58e114dc5d50e3fcf70607c92a469 
  src/tests/api_tests.cpp 4cb70720ec6df86ad113170fb664de1bfbd809aa 

Diff: https://reviews.apache.org/r/49244/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/
---

(Updated 七月 7, 2016, 11:41 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

This method helps to readFiles based on offset, length
and path, which can be used for implementing master/agent's
READ_FILE operator v1 API.


Diffs (updated)
-

  src/files/files.hpp c36ecfb729d70aa0fb194fc8e285a8fb2e297ef2 
  src/files/files.cpp c8991c4ffcddc2c196d96cdfec104cd7a87aac34 

Diff: https://reviews.apache.org/r/49243/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/
---

(Updated 七月 7, 2016, 11:40 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Updated the type of offset and length of Call::ReadFile
for v1 operator API.


Diffs (updated)
-

  include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 
  include/mesos/master/master.proto d82b2456fb78c385dd9fa92606ab72aa1ef5a729 
  include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc 
  include/mesos/v1/master/master.proto 711a664724d433af51bfb3ba73462e1842e06a87 

Diff: https://reviews.apache.org/r/49679/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/
---

(Updated July 7, 2016, 11:41 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Removed dependency on committed review.


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Updated the type of offset and length of Call::ReadFile
for v1 operator API.


Diffs
-

  include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 
  include/mesos/master/master.proto d82b2456fb78c385dd9fa92606ab72aa1ef5a729 
  include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc 
  include/mesos/v1/master/master.proto 711a664724d433af51bfb3ba73462e1842e06a87 

Diff: https://reviews.apache.org/r/49679/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49242: Add ReadFile protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49242/
---

(Updated 七月 7, 2016, 11:41 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

code rebase


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Add ReadFile message in the Response message of master.proto
, v1/master.proto, agent.proto, v1/agent.proto.


Diffs (updated)
-

  include/mesos/agent/agent.proto ef07b1f0668dca9dcebc898cfc6caf5680b24016 
  include/mesos/master/master.proto d82b2456fb78c385dd9fa92606ab72aa1ef5a729 
  include/mesos/v1/agent/agent.proto 8f845081d504cd045677a65f7dea7429472c5bbc 
  include/mesos/v1/master/master.proto 711a664724d433af51bfb3ba73462e1842e06a87 

Diff: https://reviews.apache.org/r/49242/diff/


Testing
---

make
make check


Thanks,

zhou xing

Review Request 49773: Moved veth related functions to a separate file.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49773/
---

Review request for mesos, Avinash sridharan and Qian Zhang.


Repository: mesos


Description
---

This is part of the effort to allow linking with a lower version of
libnl. veth related functions were introduced in libnl 3.2.24.
However, most of the popular Linux distributions use 3.2.21.


Diffs
-

  src/Makefile.am 28dd15166937ed672f81be5a598df149b8ed4302 
  src/linux/routing/link/link.hpp a4c92dc22cb23d9886ba0e74980c95ab0abf5daf 
  src/linux/routing/link/link.cpp 3803d6f5d1f766da5de6af42333b5df52a3c1fba 
  src/linux/routing/link/veth.hpp PRE-CREATION 
  src/linux/routing/link/veth.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 
79ee960aa70f8bd39f9bf639cc54f6395ff21ad5 
  src/tests/containerizer/routing_tests.cpp 
f3298742dd4944d9d356b2edd20dc9c07c11ea9b 

Diff: https://reviews.apache.org/r/49773/diff/


Testing
---

make check on fedora 23


Thanks,

Jie Yu

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49520/#review141219
---



Patch looks great!

Reviews applied: [49520]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 9:20 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49520/
> ---
> 
> (Updated July 7, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5752
> https://issues.apache.org/jira/browse/MESOS-5752
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In GarbageCollectorIntegrationTest.BusyMountPoint there is
> a race between the task creating a file and the test looking for it
> which sometimes leads to assertion failure on the existence of the
> file.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 
> 
> Diff: https://reviews.apache.org/r/49520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 49520: Fixed the flaky BusyMountPoint test.

[Megha Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49520/
---

(Updated July 7, 2016, 9:20 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5752
https://issues.apache.org/jira/browse/MESOS-5752


Repository: mesos


Description (updated)
---

In GarbageCollectorIntegrationTest.BusyMountPoint there is
a race between the task creating a file and the test looking for it
which sometimes leads to assertion failure on the existence of the
file.


Diffs (updated)
-

  src/tests/gc_tests.cpp d6335dc711f0697a0728a912e713cf1ed783c146 

Diff: https://reviews.apache.org/r/49520/diff/


Testing
---


Thanks,

Megha Sharma

Re: Review Request 49219: Added runtime isolator interface to run appc containers.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49219/#review141210
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 82)


with Appc image default 'exec'.


- Gilbert Song


On June 29, 2016, 11 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49219/
> ---
> 
> (Updated June 29, 2016, 11 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added runtime isolator interface to run appc containers.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9c80a613818302ad3b417d582e9a91a59a6f666d 
>   src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41 
>   src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49219/diff/
> 
> 
> Testing
> ---
> 
> Make Check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49232: Added appcManifest to ImageInfo and ProvisionInfo.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49232/#review141211
---




src/slave/containerizer/mesos/containerizer.cpp (line 306)


This relates to the isolator dependency. Please move it right above 
`docker/runtime`.



src/slave/containerizer/mesos/provisioner/provisioner.hpp (line 24)


One newline below.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 335)


Why do you add this logic? It seems incorrect to me. Please remove it.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 337)


add two more space at the beginning.



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 404)


Please use None() for appc case here.

Fix the indentation please.



src/slave/containerizer/mesos/provisioner/store.hpp (line 25)


One newline below.


- Gilbert Song


On July 5, 2016, 11:32 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49232/
> ---
> 
> (Updated July 5, 2016, 11:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added appcManifest to ImageInfo and ProvisionInfo.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f 
>   src/slave/containerizer/mesos/provisioner/appc/store.cpp 
> aaa0efe63e587b9e604082b52a3cb8c11545fbb9 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 48a05059969e068a0ee0d38b61be9e7104e3188d 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 6825742546a87c8148097e6e13a94592e3b6754e 
>   src/slave/containerizer/mesos/provisioner/store.hpp 
> 1d477ef13ddd24fd8badae0decaa4a2271ecc746 
> 
> Diff: https://reviews.apache.org/r/49232/diff/
> 
> 
> Testing
> ---
> 
> Make Check.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49768: Updated configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141218
---



Patch looks great!

Reviews applied: [49768]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 48593: Refactor Ranges Subtraction.

[Joseph Wu]

> On July 6, 2016, 1:41 a.m., Guangya Liu wrote:
> > Another comment is that you may want to add a benchmark test case for this 
> > smiliar as 
> > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3299
> 
> Yanyan Hu wrote:
> Hi, Guangya, thanks a lot for your comments. Will revise the patch per 
> your suggestion.

@Yanyan, have you published a revised patch?  Most of the issues you've marked 
as fixed are not actually fixed.


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review140967
---


On July 6, 2016, 3:18 a.m., Yanyan Hu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> ---
> 
> (Updated July 6, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-5425
> https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>

Re: Review Request 41618: Edited defer documentation in libprocess.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41618/#review141215
---



Although I think these changes are still a good idea, I'm going to close this 
review for the time being, until I have time to come back to it in earnest.

- Greg Mann


On Dec. 22, 2015, midnight, Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41618/
> ---
> 
> (Updated Dec. 22, 2015, midnight)
> 
> 
> Review request for mesos, Benjamin Hindman and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Edited defer documentation in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/41618/diff/
> 
> 
> Testing
> ---
> 
> Viewed on github: 
> https://github.com/mesosphere/mesos/tree/defer_doc_update/3rdparty/libprocess
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent volume tests.

[Greg Mann]

> On May 3, 2016, 10:32 p.m., Michael Park wrote:
> > src/tests/persistent_volume_tests.cpp, line 68
> > 
> >
> > Perhaps we should consider pulling this out to `src/tests/mesos.hpp`.

Good call! I'll move this constant into mesos.hpp.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review131557
---


On Jan. 5, 2016, 2:49 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated Jan. 5, 2016, 2:49 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `DEFAULT_ROLE` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46038: Added recommended production config to the docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46038/#review141213
---



I think this patch would be much more helpful if we add some information along 
the lines of Guangya's suggestion, with an explanation of why a particular 
value is suggested for each flag. I think it's worth putting a good amount of 
thought into the suggestions/explanations we give, so I'm going to close this 
RR for the time being, until I have time to finish this properly.

- Greg Mann


On April 11, 2016, 10:57 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46038/
> ---
> 
> (Updated April 11, 2016, 10:57 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Provided information in the operational guide on what
> configuration options are advisable for production
> environments.
> 
> 
> Diffs
> -
> 
>   docs/operational-guide.md 5ae7ede3f500380a78364d5c3da2c4cea75e04c5 
> 
> Diff: https://reviews.apache.org/r/46038/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos website container:
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 49768: Updated configuration.md.

[Vinod Kone]

> On July 7, 2016, 7:17 p.m., Benjamin Mahler wrote:
> > docs/configuration.md, lines 1571-1578
> > 
> >
> > This doesn't match the latest version in flags.cpp, how did you 
> > generate the update?
> > 
> > 
> > https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99

see my comment below.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141201
---


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141206
---


Ship it!




I'll commit this as is and do another commit/review for the missed updates.

- Vinod Kone


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49768: Updated configuration.md.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/#review141201
---




docs/configuration.md (lines 1508 - 1515)


This doesn't match the latest version in flags.cpp, how did you generate 
the update?


https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99


- Benjamin Mahler


On July 7, 2016, 6:17 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49768/
> ---
> 
> (Updated July 7, 2016, 6:17 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49768/diff/
> 
> 
> Testing
> ---
> 
> Preview at 
> https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/#review141197
---




docs/configuration.md (lines 1516 - 1523)


This doesn't look like a complete sync of the flags, for example this one 
doesn't reflect what is in slave/flags.cpp:


https://github.com/apache/mesos/blob/d2c153f013a446174bbcafc793cf38d56bb5a477/src/slave/flags.cpp#L90-L99

How did you generate the update? I'd recommend running `--help` on both the 
master and slave binaries and updating based on that. We will add tooling in 
the future so that you could do this via a script.


- Benjamin Mahler


On July 7, 2016, 9:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49587/
> ---
> 
> (Updated July 7, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5758
> https://issues.apache.org/jira/browse/MESOS-5758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synced up flags in both master and agent to configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49587/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> https://github.com/gyliu513/mesos/blob/master/docs/configuration.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

[Anand Mazumdar]

> On July 6, 2016, 8:17 p.m., Anand Mazumdar wrote:
> > src/files/files.cpp, lines 360-362
> > 
> >
> > Do you need the `defer` here anymore?

I would fix this while committing.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49445/#review141066
---


On July 7, 2016, 3:29 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49445/
> ---
> 
> (Updated July 7, 2016, 3:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5487
> https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated FilesProcess to support List_Files Call in Operator API v1.
> 
> 
> Diffs
> -
> 
>   src/files/files.hpp 06a91a53b62ba930afaf116b9b6e90cab9ecd515 
>   src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 
>   src/tests/files_tests.cpp a30e452536f395c6e6286e75cb267fcc213bac44 
> 
> Diff: https://reviews.apache.org/r/49445/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49768: Updated configuration.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/
---

(Updated July 7, 2016, 6:17 p.m.)


Review request for mesos, Jay Guo and Vinod Kone.


Repository: mesos


Description
---

Updated configuration.md.


Diffs (updated)
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49768/diff/


Testing (updated)
---

Preview at 
https://github.com/haosdent/mesos/blob/sync_conf/docs/configuration.md


Thanks,

haosdent huang

Review Request 49768: Updated configuration.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49768/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Updated configuration.md.


Diffs
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49768/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49448: Added testcases for LIST_FILES call.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/
---

(Updated July 7, 2016, 5:35 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5514
https://issues.apache.org/jira/browse/MESOS-5514


Repository: mesos


Description
---

Added testcases for LIST_FILES call.


Diffs (updated)
-

  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49448/diff/


Testing
---

On Ubuntu 16.04:
sudo 
GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
 make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49696: Used alias for the namespace 'process::http'.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49696/
---

(Updated July 7, 2016, 5:30 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, zhou xing, haosdent huang, 
and Vinod Kone.


Bugs: MESOS-5487
https://issues.apache.org/jira/browse/MESOS-5487


Repository: mesos


Description
---

Used alias for the namespace 'process::http'.


Diffs (updated)
-

  src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 

Diff: https://reviews.apache.org/r/49696/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49760/#review141183
---




src/slave/http.cpp (lines 1425 - 1428)


We don't have `subscribe` defined for agent API yet, so this comment could 
be confusing.

What about:

```
  // NOTE: This function must be blocking instead of returning a
  // `Future`, to make sure information about different
  // components are collected atomically.
```

If we plan to introduce event stream on agent API, then ignore this issue 
please.


- Zhitao Li


On July 7, 2016, 3 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49760/
> ---
> 
> (Updated July 7, 2016, 3 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
> 
> Diff: https://reviews.apache.org/r/49760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49758: Implemented 'GetExecutors' call in v1 agent API.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49758/#review141181
---


Ship it!





src/slave/http.cpp (line 1104)


nit: capture `[this, contentType]`


- Zhitao Li


On July 7, 2016, 2:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49758/
> ---
> 
> (Updated July 7, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetExecutors' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
>   src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 
> 
> Diff: https://reviews.apache.org/r/49758/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49757/#review141180
---




src/slave/http.cpp (line 1032)


nit: capture `[this, contentType]`


- Zhitao Li


On July 7, 2016, 2:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49757/
> ---
> 
> (Updated July 7, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetFrameworks' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
>   src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 
> 
> Diff: https://reviews.apache.org/r/49757/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49760/#review141179
---



Patch looks great!

Reviews applied: [49757, 49758, 49759, 49760]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 3 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49760/
> ---
> 
> (Updated July 7, 2016, 3 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
> 
> Diff: https://reviews.apache.org/r/49760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49448: Added testcases for LIST_FILES call.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/
---

(Updated July 7, 2016, 4:07 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5514
https://issues.apache.org/jira/browse/MESOS-5514


Repository: mesos


Description
---

Added testcases for LIST_FILES call.


Diffs (updated)
-

  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49448/diff/


Testing
---

On Ubuntu 16.04:
sudo 
GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
 make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review141162
---




include/mesos/mesos.proto (line 1746)


`s/INVALID/UNKNOWN/`

The canonical name we add to proto enums to support upgrades seems to be 
`UNKNOWN`.



include/mesos/v1/mesos.proto (line 1740)


Proto enums should always start with an `UNKNOWN = 0` field to in order to 
support updates.


- Benjamin Bannier


On May 19, 2016, 7:06 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> ---
> 
> (Updated May 19, 2016, 7:06 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
> https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 887ffe9c5f04e25539a4c6b3d52ce5299c65e8d3 
>   include/mesos/v1/mesos.proto 9e59aed20965d50ee10989ff6b75db742cf2b83b 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 49761: Fixed typo in contributors list.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49761/#review141172
---


Ship it!




Ship It!

- Till Toenshoff


On July 7, 2016, 3:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49761/
> ---
> 
> (Updated July 7, 2016, 3:54 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed typo in contributors list.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml c203d2a888db0cb904ff10b5e77e462794d475ab 
> 
> Diff: https://reviews.apache.org/r/49761/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 49761: Fixed typo in contributors list.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49761/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Fixed typo in contributors list.


Diffs
-

  docs/contributors.yaml c203d2a888db0cb904ff10b5e77e462794d475ab 

Diff: https://reviews.apache.org/r/49761/diff/


Testing
---


Thanks,

Benjamin Bannier

Re: Review Request 49571: Added a benchmark test for allocations.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
---

(Updated July 7, 2016, 3:45 p.m.)


Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771


Repository: mesos


Description
---

This parameterized test has the following configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.


Diffs (updated)
-

  src/tests/hierarchical_allocator_tests.cpp 
0498cd5e54b0e4b87a767585a77699653aa52179 

Diff: https://reviews.apache.org/r/49571/diff/


Testing (updated)
---

All tests passed. Following results show that the support of shared resources 
has a small impact on runtime performance in allocations between HEAD and this 
patch. Also, there is no visible impact in performance when shared resources 
are added in the tests.

Based on HEAD, with all regular resources (no shared resources in HEAD 
supported):
round 0 allocate took 3.074583secs to make 200 offers
round 50 allocate took 3.124076secs to make 200 offers
round 100 allocate took 3.136869secs to make 200 offers
round 150 allocate took 3.081407secs to make 200 offers
round 199 allocate took 3.087184secs to make 200 offers

With the patch (and no shared resources):
round 0 allocate took 3.294563secs to make 200 offers
round 50 allocate took 3.299935secs to make 200 offers
round 100 allocate took 3.289989secs to make 200 offers
round 150 allocate took 3.295874secs to make 200 offers
round 199 allocate took 3.290305secs to make 200 offers

With the patch (and shared resources on all agents):
round 0 allocate took 3.298118secs to make 200 offers
round 50 allocate took 3.303362secs to make 200 offers
round 100 allocate took 3.299803secs to make 200 offers
round 150 allocate took 3.309727secs to make 200 offers
round 199 allocate took 3.306269secs to make 200 offers

With the patch (and shared resources on alternate agents):
round 0 allocate took 3.292819secs to make 200 offers
round 50 allocate took 3.305901secs to make 200 offers
round 100 allocate took 3.297403secs to make 200 offers
round 150 allocate took 3.30592secs to make 200 offers
round 199 allocate took 3.302744secs to make 200 offers


Thanks,

Anindya Sinha

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45961/
---

(Updated July 7, 2016, 3:44 p.m.)


Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael Park, 
and Jiang Yan Xu.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

o Each shared resource is accouted via its share count. This count is
  updated based on the resource operations (such as add and subtract)
  in various scenarios such as task launch and terminate at multiple
  modules such as master, allocator, sorter, etc.
o Only allow DESTROY if there are no running or pending tasks using
  the volume. However, if the volume is in a pending offer to one or
  more frameworks, resind that offer before processing the DESTROY.


Diffs (updated)
-

  src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
  src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d 
  src/master/allocator/mesos/hierarchical.cpp 
c1e00039606164599e25ff5f76245e4d35ec3112 
  src/master/allocator/sorter/drf/sorter.hpp 
e29feebd70277c79f7c3f6fb233e7a36501cf220 
  src/master/allocator/sorter/drf/sorter.cpp 
7df4dd641b21ea0705368861bf4679fed1ef078d 
  src/master/http.cpp bff1fd53462bfec19e4a025c49a00e2855faf4f3 
  src/master/master.hpp 60efd22280c62801b080365986fe9773737ca563 
  src/master/master.cpp 79e3d78ba45060bc2f2532fdc3d105d1cc888d0f 
  src/master/validation.hpp 43d876b00511d4ef652c2685d4950c994b5eef31 
  src/master/validation.cpp 50ba372d1301d16d1738a3e4f4882b51f9ce06cd 
  src/tests/master_validation_tests.cpp 
9eb82a569f7c48caa96d4d54a93b199ccac74385 
  src/tests/sorter_tests.cpp 0a921347586808863e615ca3dcc23fae92b629f5 
  src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 

Diff: https://reviews.apache.org/r/45961/diff/


Testing
---

Tests successful.


Thanks,

Anindya Sinha

Re: Review Request 49760: Implemented 'GetState' call in v1 agent API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49760/#review141168
---


Fix it, then Ship it!




No tests?


src/slave/http.cpp (lines 1425 - 1428)


this comment doesn't make sense because we don't have subscribe in agent 
API yet. kill this.


- Vinod Kone


On July 7, 2016, 3 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49760/
> ---
> 
> (Updated July 7, 2016, 3 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetState' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
> 
> Diff: https://reviews.apache.org/r/49760/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49759: Implemented 'GetTasks' call in v1 agent API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49759/#review141167
---


Fix it, then Ship it!




No tests?


include/mesos/agent/agent.proto (lines 202 - 203)


// Tasks that are pending in the agent's queue before an executor is 
launched.



include/mesos/agent/agent.proto (line 206)


// Tasks that are enqueued for a launched executor that has not yet 
registered.



src/slave/http.cpp (line 1266)


s/executorMap/executors/


- Vinod Kone


On July 7, 2016, 3 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49759/
> ---
> 
> (Updated July 7, 2016, 3 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetTasks' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
>   src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 
> 
> Diff: https://reviews.apache.org/r/49759/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49758: Implemented 'GetExecutors' call in v1 agent API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49758/#review141165
---


Ship it!




No tests?

- Vinod Kone


On July 7, 2016, 2:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49758/
> ---
> 
> (Updated July 7, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetExecutors' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
>   src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 
> 
> Diff: https://reviews.apache.org/r/49758/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49445: Updated FilesProcess to support List_Files Call in Operator API v1.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49445/
---

(Updated July 7, 2016, 3:29 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5487
https://issues.apache.org/jira/browse/MESOS-5487


Repository: mesos


Description
---

Updated FilesProcess to support List_Files Call in Operator API v1.


Diffs (updated)
-

  src/files/files.hpp 06a91a53b62ba930afaf116b9b6e90cab9ecd515 
  src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 
  src/tests/files_tests.cpp a30e452536f395c6e6286e75cb267fcc213bac44 

Diff: https://reviews.apache.org/r/49445/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 47753: Enabled building libprocess without building 3rdparty first.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47753/
---

(Updated July 7, 2016, 11:28 a.m.)


Review request for mesos, Joris Van Remoortere and Till Toenshoff.


Bugs: MESOS-5445
https://issues.apache.org/jira/browse/MESOS-5445


Repository: mesos


Description
---

Doing a `make` inside libprocess would now automatically build bundled
dependencies.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am 05499a8ff97d53e2d6a115f6ec19512e3e32f021 

Diff: https://reviews.apache.org/r/47753/diff/


Testing
---

`make clean` in 3rdparty/ followed by `make` in libprocess succeeds with this 
patch.


Thanks,

Kapil Arya

Re: Review Request 49448: Added testcases for LIST_FILES call.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/#review141164
---



Patch looks great!

Reviews applied: [49301, 49443, 49444, 49445, 49696, 49529, 49446, 49447, 
49550, 49551, 49448]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 1:42 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49448/
> ---
> 
> (Updated July 7, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5514
> https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added testcases for LIST_FILES call.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 
> 
> Diff: https://reviews.apache.org/r/49448/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> sudo 
> GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
>  make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49757/#review141163
---


Ship it!




No tests?

- Vinod Kone


On July 7, 2016, 2:59 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49757/
> ---
> 
> (Updated July 7, 2016, 2:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented 'GetFrameworks' call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
>   src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 
> 
> Diff: https://reviews.apache.org/r/49757/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49447/#review141159
---


Ship it!




Ship It!

- Anand Mazumdar


On July 7, 2016, 1:54 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49447/
> ---
> 
> (Updated July 7, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5514
> https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented LIST_FILES Call in v1 agent API.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
>   include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
>   src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
>   src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
> 
> Diff: https://reviews.apache.org/r/49447/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 49448: Added testcases for LIST_FILES call.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/#review141158
---


Fix it, then Ship it!




Can you run the newly introduced tests with `gtest_repeat=100` to ensure they 
don't show any flakiness.


src/tests/api_tests.cpp (line 2276)


hmm, this is flaky!

The future `__recover` would be completed as soon as `::__recover()` 
is invoked but not before it has _completed_. Hence, if the `post()` happens 
before the recovery is complete. This test would fail with a `503`.

You need this after the `AWAIT_*`
```cpp
// Wait for recovery to be complete.
  Clock::pause();
  Clock::settle();
```

Ditto for the other agent test.


- Anand Mazumdar


On July 7, 2016, 1:42 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49448/
> ---
> 
> (Updated July 7, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5514
> https://issues.apache.org/jira/browse/MESOS-5514
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added testcases for LIST_FILES call.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 
> 
> Diff: https://reviews.apache.org/r/49448/diff/
> 
> 
> Testing
> ---
> 
> On Ubuntu 16.04:
> sudo 
> GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
>  make -j4 check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 49760: Implemented 'GetState' call in v1 agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49760/
---

Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Repository: mesos


Description
---

Implemented 'GetState' call in v1 agent API.


Diffs
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 

Diff: https://reviews.apache.org/r/49760/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49696: Used alias for the namespace 'process::http'.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49696/#review141157
---


Fix it, then Ship it!




Include everything you need from the `process` namespace i.e. other than the 
namespace alias change, this change should be a no-op for other parts of the 
code in this file.


src/files/files.cpp (lines 73 - 77)


Move this above L64



src/files/files.cpp (line 94)


Why didn't you have a `using process::Future` declaration too?


- Anand Mazumdar


On July 7, 2016, 7:15 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49696/
> ---
> 
> (Updated July 7, 2016, 7:15 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, zhou xing, haosdent huang, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-5487
> https://issues.apache.org/jira/browse/MESOS-5487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used alias for the namespace 'process::http'.
> 
> 
> Diffs
> -
> 
>   src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 
> 
> Diff: https://reviews.apache.org/r/49696/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Review Request 49759: Implemented 'GetTasks' call in v1 agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49759/
---

Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Repository: mesos


Description
---

Implemented 'GetTasks' call in v1 agent API.


Diffs
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
  src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 

Diff: https://reviews.apache.org/r/49759/diff/


Testing
---


Thanks,

haosdent huang

Review Request 49757: Implemented 'GetFrameworks' call in v1 agent API.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49757/
---

Review request for mesos, Anand Mazumdar, Vinod Kone, and Zhitao Li.


Repository: mesos


Description
---

Implemented 'GetFrameworks' call in v1 agent API.


Diffs
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
  src/slave/validation.cpp b07e80a5e0b7d6cd383cf2d9914b8c83f740770d 

Diff: https://reviews.apache.org/r/49757/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49742: Fixed parameter names in test-upgrade.py.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49742/#review141156
---


Ship it!




Ship It!

- Vinod Kone


On July 7, 2016, 6:36 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49742/
> ---
> 
> (Updated July 7, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'MESOS_AUTHENTICATE_FRAMEWORKS' in env variable when starting
> master. Also changed 'mesos-agent.sh' back to 'mesos-slave.sh' since
> 'slave' is not renamed in 0.28.x.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 8655a8588e0cb93d90fdd862939f9bf11bd7a3a1 
> 
> Diff: https://reviews.apache.org/r/49742/diff/
> 
> 
> Testing
> ---
> 
> sudo ./support/test-upgrade.py --prev /path/to/mesos-0.28.x/build --next 
> /path/to/mesos-1.0.0/build on both OSX and Ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 49446: Implemented LIST_FILES Call in v1 master API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49446/
---

(Updated July 7, 2016, 1:55 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5487
https://issues.apache.org/jira/browse/MESOS-5487


Repository: mesos


Description
---

Implemented LIST_FILES Call in v1 master API.


Diffs (updated)
-

  include/mesos/master/master.proto 236a286d0e9f8fde81ba0380433bf132acd7bcd1 
  include/mesos/v1/master/master.proto 55eb2d8306fbeee68b269425851129b54d726412 
  src/master/http.cpp bff1fd53462bfec19e4a025c49a00e2855faf4f3 
  src/master/master.hpp 60efd22280c62801b080365986fe9773737ca563 

Diff: https://reviews.apache.org/r/49446/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 49447: Implemented LIST_FILES Call in v1 agent API.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49447/
---

(Updated July 7, 2016, 1:54 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5514
https://issues.apache.org/jira/browse/MESOS-5514


Repository: mesos


Description
---

Implemented LIST_FILES Call in v1 agent API.


Diffs (updated)
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 

Diff: https://reviews.apache.org/r/49447/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 49448: Added testcases for LIST_FILES call.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49448/
---

(Updated July 7, 2016, 1:42 p.m.)


Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and Vinod 
Kone.


Bugs: MESOS-5514
https://issues.apache.org/jira/browse/MESOS-5514


Repository: mesos


Description
---

Added testcases for LIST_FILES call.


Diffs (updated)
-

  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49448/diff/


Testing
---

On Ubuntu 16.04:
sudo 
GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*"
 make -j4 check


Thanks,

Abhishek Dasgupta

Re: Review Request 49245: Implement READ_FILE for agent operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49245/
---

(Updated 七月 7, 2016, 12:41 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

refined code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for agent operator API.


Diffs (updated)
-

  src/slave/http.cpp ef2d510b86e5d4f731c2ea6b7df8246a0be9d812 
  src/slave/slave.hpp 6a82c365baf463db298bfcc4771d9f6109b9f4bc 
  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49245/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49244: Implement READ_FILE for master operator API.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49244/
---

(Updated 七月 7, 2016, 12:29 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

refined the code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Implemented readFile method for master operator API.


Diffs (updated)
-

  src/master/http.cpp bff1fd53462bfec19e4a025c49a00e2855faf4f3 
  src/master/master.hpp 60efd22280c62801b080365986fe9773737ca563 
  src/tests/api_tests.cpp 7cf716dd7a5def8d648b1d8dbc2b9d5c158b00e9 

Diff: https://reviews.apache.org/r/49244/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49243: Create readFile method in FilesProcess.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49243/
---

(Updated 七月 7, 2016, 12:28 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

refined code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

This method helps to readFiles based on offset, length
and path, which can be used for implementing master/agent's
READ_FILE operator v1 API.


Diffs (updated)
-

  src/files/files.hpp 06a91a53b62ba930afaf116b9b6e90cab9ecd515 
  src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 

Diff: https://reviews.apache.org/r/49243/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49242: Add ReadFile protobuf message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49242/
---

(Updated 七月 7, 2016, 12:26 p.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

update message according to Anand's comments


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Add ReadFile message in the Response message of master.proto
, v1/master.proto, agent.proto, v1/agent.proto.


Diffs (updated)
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/master/master.proto 236a286d0e9f8fde81ba0380433bf132acd7bcd1 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  include/mesos/v1/master/master.proto 55eb2d8306fbeee68b269425851129b54d726412 

Diff: https://reviews.apache.org/r/49242/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49679: Updated v1 operator Call::ReadFile message.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49679/
---

(Updated 七月 7, 2016, 12:24 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

update message according to Anand's comments


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

Updated the type of offset and length of Call::ReadFile
for v1 operator API.


Diffs (updated)
-

  include/mesos/agent/agent.proto 538d12f71df1943f91bafb99650625aa910affaa 
  include/mesos/master/master.proto 236a286d0e9f8fde81ba0380433bf132acd7bcd1 
  include/mesos/v1/agent/agent.proto 48f15173fe62b9ce7f648f6b54d74ec62f797c55 
  include/mesos/v1/master/master.proto 55eb2d8306fbeee68b269425851129b54d726412 

Diff: https://reviews.apache.org/r/49679/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/#review141148
---



Patch looks great!

Reviews applied: [49587]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 9:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49587/
> ---
> 
> (Updated July 7, 2016, 9:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5758
> https://issues.apache.org/jira/browse/MESOS-5758
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Synced up flags in both master and agent to configuration.md.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 
> 
> Diff: https://reviews.apache.org/r/49587/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> https://github.com/gyliu513/mesos/blob/master/docs/configuration.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 49587: Synced up flags in both master and agent to configuration.md.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49587/
---

(Updated 七月 7, 2016, 9:29 a.m.)


Review request for mesos and Benjamin Mahler.


Summary (updated)
-

Synced up flags in both master and agent to configuration.md.


Bugs: MESOS-5758
https://issues.apache.org/jira/browse/MESOS-5758


Repository: mesos


Description (updated)
---

Synced up flags in both master and agent to configuration.md.


Diffs (updated)
-

  docs/configuration.md c7ec3c516882130a35d66c5e2390ade04046ac70 

Diff: https://reviews.apache.org/r/49587/diff/


Testing
---

make
make check

https://github.com/gyliu513/mesos/blob/master/docs/configuration.md


Thanks,

Guangya Liu

Re: Review Request 49616: Add suppression benchmark.

[Guangya Liu]

> On 七月 6, 2016, 11:19 p.m., Jiang Yan Xu wrote:
> >

@Jiang Yan, just FYI, I filed a JIRA here 
https://issues.apache.org/jira/browse/MESOS-5800 to trace the comments you 
mentioned here for other benchmark test.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49616/#review141095
---


On 七月 6, 2016, 11:21 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49616/
> ---
> 
> (Updated 七月 6, 2016, 11:21 p.m.)
> 
> 
> Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5781
> https://issues.apache.org/jira/browse/MESOS-5781
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> - Useful for high framework clusters which carry
>   many suppressed frameworks that are considered
>   during allocation.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 0498cd5e54b0e4b87a767585a77699653aa52179 
> 
> Diff: https://reviews.apache.org/r/49616/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 49742: Fixed parameter names in test-upgrade.py.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49742/#review141142
---



Patch looks great!

Reviews applied: [49742]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 7, 2016, 6:36 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49742/
> ---
> 
> (Updated July 7, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'MESOS_AUTHENTICATE_FRAMEWORKS' in env variable when starting
> master. Also changed 'mesos-agent.sh' back to 'mesos-slave.sh' since
> 'slave' is not renamed in 0.28.x.
> 
> 
> Diffs
> -
> 
>   support/test-upgrade.py 8655a8588e0cb93d90fdd862939f9bf11bd7a3a1 
> 
> Diff: https://reviews.apache.org/r/49742/diff/
> 
> 
> Testing
> ---
> 
> sudo ./support/test-upgrade.py --prev /path/to/mesos-0.28.x/build --next 
> /path/to/mesos-1.0.0/build on both OSX and Ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 49301: Added FilesError class.

[zhou xing]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49301/
---

(Updated July 7, 2016, 7:21 a.m.)


Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
---

rebased code


Bugs: mesos-5515
https://issues.apache.org/jira/browse/mesos-5515


Repository: mesos


Description
---

FilesError class represents the various errors that can be
returned by methods on the `Files` class via a `Try` that
has failed.


Diffs (updated)
-

  src/files/files.hpp 06a91a53b62ba930afaf116b9b6e90cab9ecd515 

Diff: https://reviews.apache.org/r/49301/diff/


Testing
---

make
make check


Thanks,

zhou xing

Re: Review Request 49696: Used alias for the namespace 'process::http'.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49696/
---

(Updated July 7, 2016, 7:15 a.m.)


Review request for mesos, Adam B, Anand Mazumdar, zhou xing, haosdent huang, 
and Vinod Kone.


Bugs: MESOS-5487
https://issues.apache.org/jira/browse/MESOS-5487


Repository: mesos


Description
---

Used alias for the namespace 'process::http'.


Diffs (updated)
-

  src/files/files.cpp 0368f67fc184dbd29945fcb9216439f0a5b713bd 

Diff: https://reviews.apache.org/r/49696/diff/


Testing
---


Thanks,

Abhishek Dasgupta

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49348/#review141133
---




src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 90)


kill this line



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 215 - 219)


So for the case of sh=0,value=0,argv=1,Exec=1, what about the value of 
`Exec[1]...` etc? Should not it be `./Exec[0] Exec[1] ... argv`



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 259)


It is not suggested to use reference here according to 
https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#capture-by-reference



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 265)


Seems you are losing the logic to handle logic in row 2 when there are 
arguments?



src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 287)


s/WorkingDirectory/workingDirectory


- Guangya Liu


On July 6, 2016, 6:32 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49348/
> ---
> 
> (Updated July 6, 2016, 6:32 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4778
> https://issues.apache.org/jira/browse/MESOS-4778
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added implementation to Appc Runtime Isolator.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49348/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Review Request 49742: Fixed parameter names in test-upgrade.py.

[Jay Guo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49742/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Added 'MESOS_AUTHENTICATE_FRAMEWORKS' in env variable when starting
master. Also changed 'mesos-agent.sh' back to 'mesos-slave.sh' since
'slave' is not renamed in 0.28.x.


Diffs
-

  support/test-upgrade.py 8655a8588e0cb93d90fdd862939f9bf11bd7a3a1 

Diff: https://reviews.apache.org/r/49742/diff/


Testing
---

sudo ./support/test-upgrade.py --prev /path/to/mesos-0.28.x/build --next 
/path/to/mesos-1.0.0/build on both OSX and Ubuntu 14.04


Thanks,

Jay Guo

Re: Review Request 48593: Refactor Ranges Subtraction.

[Yanyan Hu]

> On July 6, 2016, 8:41 a.m., Guangya Liu wrote:
> > Another comment is that you may want to add a benchmark test case for this 
> > smiliar as 
> > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3299

Hi, Guangya, thanks a lot for your comments. Will revise the patch per your 
suggestion.


- Yanyan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48593/#review140967
---


On July 6, 2016, 10:18 a.m., Yanyan Hu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48593/
> ---
> 
> (Updated July 6, 2016, 10:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-5425
> https://issues.apache.org/jira/browse/MESOS-5425
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch reimplement Ranges subtraction using
> IntervalSet data type: Ranges values will be
> converted to IntervalSet values for subtraction
> and the result will be converted back to Ranges
> after subtraction is done. This change is for
> fixing jira MESOS-5425.
> 
> 
> Diffs
> -
> 
>   src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b 
>   src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 
> 
> Diff: https://reviews.apache.org/r/48593/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yanyan Hu
> 
>