Re: Review Request 51505: Replace http::get with http::request in mesos project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/ --- (Updated Aug. 30, 2016, 5:36 a.m.) Review request for mesos. Changes ---

Re: Review Request 51505: Replace http::get with http::request in mesos project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/ --- (Updated Aug. 30, 2016, 5:28 a.m.) Review request for mesos. Summary

Re: Review Request 51495: Replace http::get with http::request in libprocess project.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51495/ --- (Updated Aug. 30, 2016, 5:27 a.m.) Review request for mesos. Summary

Re: Review Request 51096: Added the `mesos-cni-port-mapper` binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51096/ --- (Updated Aug. 30, 2016, 3:54 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51511: Added check in FileEncoder's destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review147258 --- Patch looks great! Reviews applied: [51509, 51511] Passed

Review Request 51511: Added check in FileEncoder's destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van

Re: Review Request 51509: Fixed potential FD double close in the libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51509/ --- (Updated Aug. 29, 2016, 5:51 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 51509: Fixed potential FD double close in the libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51509/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Joris Van

Re: Review Request 51508: Remove the useless http::get method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51508/#review147249 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Review Request 51508: Remove the useless http::get method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51508/ --- Review request for mesos. Bugs: MESOS-4440

Re: Review Request 51508: Remove the useless http::get method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51508/ --- (Updated Aug. 29, 2016, 11:41 p.m.) Review request for mesos. Bugs:

Re: Review Request 51505: [2]Replace http::get with http::request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/ --- (Updated Aug. 29, 2016, 11:39 p.m.) Review request for mesos. Summary

Re: Review Request 51495: [1]Replace http::get with http::request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51495/ --- (Updated Aug. 29, 2016, 11:39 p.m.) Review request for mesos. Summary

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/#review147241 --- Patch looks great! Reviews applied: [51323, 51343, 51358, 51359,

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 29, 2016, 9:59 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp, line 63 > > > > > > I would suggest to switch `msg` and `code`. > > Avinash sridharan wrote: >

Review Request 51505: Replace http::get with http::request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51505/ --- Review request for mesos. Bugs: MESOS-4440

Review Request 51495: Replace http::get with http::request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51495/ --- Review request for mesos. Bugs: MESOS-4440

Review Request 51493: Add the query parameter in createRequest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51493/ --- Review request for mesos. Bugs: MESOS-4440

Re: Review Request 51501: Exposed metrics in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/#review147223 --- Patch looks great! Reviews applied: [51501] Passed command:

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

> On Aug. 25, 2016, 5:58 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 538-543 > > > > > > Hum, I don't think legitimate case. ContainerState will only container > > top level

Re: Review Request 51402: Added nested container check in provisioner destroy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51402/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51421/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51421: Added provisioner appc unit test for recovering nested container.

> On Aug. 25, 2016, 5:58 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 538-543 > > > > > > Hum, I don't think legitimate case. ContainerState will only container > > top level

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote: > > I think we should also bring back this function: > > `const hashmap& total()`. > > Jiang Yan Xu wrote: > Why? The total is now fully hidden and we only need to reply on it within > DRFSorter for shared resources.

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

> On Aug. 29, 2016, 12:26 a.m., Anindya Sinha wrote: > > I think we should also bring back this function: > > `const hashmap& total()`. Why? The total is now fully hidden and we only need to reply on it within DRFSorter for shared resources. - Jiang Yan

Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51420/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51358/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51393: Added unit test for provisioner recursive listContainers().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51393/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51343: Refactored the redundant logic in provisioner recover().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51343/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 51503: Fixed appc provisioner tests to use absolute work directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51503/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Re: Review Request 51359: Added unit test for provisioner helper findContainerDir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51359/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51392: Supported provisioner listContainers() to be recursive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51392/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51323: Supported provisioner provision() and destroy() to be nested aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51323/ --- (Updated Aug. 29, 2016, 2:20 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 51497: Avoided blocking calls in `Docker::validateVersion`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51497/#review147201 --- Patch looks great! Reviews applied: [39939, 51497] Passed

Review Request 51501: Exposed metrics in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51501/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6080

Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/#review147160 --- Ship it! Will commit with the minor edit.

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/#review147166 --- Patch looks great! Reviews applied: [51095, 51096, 51097]

Re: Review Request 50868: Using `OfferedResources` for benchmark test of `SuppressOffers`.

> On Aug. 25, 2016, 3:56 p.m., Jiang Yan Xu wrote: > > I don't know. Making such distinction feels like splitting hairs to me. > > Yeah there are subtle differences between the two concepts but to me: > > > > - `offerCallback` may not be the best name what we could have come up with > > even

Re: Review Request 51497: Avoided blocking calls in `Docker::validateVersion`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51497/#review147156 --- src/docker/docker.hpp (line 223)

Review Request 51497: Avoided blocking calls in `Docker::validateVersion`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51497/ --- Review request for mesos and Zhitao Li. Repository: mesos Description

Re: Review Request 39939: Made docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/ --- (Updated Aug. 29, 2016, 5:04 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review147144 --- Fix it, then Ship it! Ship It! src/docker/docker.cpp (line

Re: Review Request 51097: Added a `PortMapper` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51097/ --- (Updated Aug. 29, 2016, 4 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51097: Added a `PortMapper` class.

> On Aug. 29, 2016, 1:59 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp, > > line 49 > > > > > > The indent should be 4 spaces, please see the

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/ --- (Updated Aug. 29, 2016, 9:52 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Aug. 29, 2016, 9:52 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51371: Fixed flakiness in MasterAuthorizationTest.SlaveDisconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51371/ --- (Updated Aug. 29, 2016, 9:51 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/ --- (Updated Aug. 29, 2016, 9:50 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50846: Added more assertions to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50846/ --- (Updated Aug. 29, 2016, 9:50 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Aug. 29, 2016, 9:48 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/ --- (Updated Aug. 29, 2016, 9:49 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

> On Aug. 23, 2016, 12:56 a.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 169 > > > > > > This test is huge. Can you split PARTITION_AWARE and > > non-PARTITION_AWARE into separate tests? > > Neil

Re: Review Request 51470: Add the 'resources' field back to DRFSorter::Total.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51470/#review147118 --- I think we should also bring back this function: `const

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On Aug. 25, 2016, 3:22 a.m., Jiang Yan Xu wrote: > > src/tests/sorter_tests.cpp, lines 773-779 > > > > > > Doesn't look like this block with `e` add much to the test coverage, > > remove it? I removed 'd' and

Re: Review Request 45964: Add unit tests for sharing of resources.

> On Aug. 25, 2016, 3:11 p.m., Jiang Yan Xu wrote: > > src/tests/mesos.hpp, line 754 > > > > > > The original comment was intended for the following three methods. Do > > you think we need to comment on each one?

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 29, 2016, 7:21 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45964: Add unit tests for sharing of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45964/ --- (Updated Aug. 29, 2016, 7:22 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51412: Add offeredResources to Allocator::updateAllocation() API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51412/ --- (Updated Aug. 29, 2016, 7:20 a.m.) Review request for mesos, Benjamin Mahler