Re: Review Request 54241: Updated IOSwitchboard to block IO until connected for DEBUG containers.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54241/#review157561 --- Bad patch! Reviews applied: [54241, 54229, 53974, 53939, 54148,

Re: Review Request 54196: Added API handler for LAUNCH_NESTED_CONTAINER_SESSION.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54196/ --- (Updated Dec. 1, 2016, 6:46 a.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 54193: Refactored `Slave::Http::launchNestedContainer()`.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54193/ --- (Updated Dec. 1, 2016, 6:45 a.m.) Review request for mesos and Anand Mazumdar.

Review Request 54245: Updated signatures of v1 agent API handlers.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54245/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Dec. 1, 2016, 6:39 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54238: Added `getContainerIOSwitchboardAddress` helper to containerizer paths.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54238/#review157555 --- Bad patch! Reviews applied: [54238, 54148, 54147, 54053] Failed

Re: Review Request 54242: Added a test for the `ATTACH_CONTAINER_INPUT` call on the Agent API.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54242/#review157553 --- Ship it! Ship It! - Vinod Kone On Dec. 1, 2016, 4:44 a.m.,

Re: Review Request 54243: Fixed the attach output container test to use the mock containerizer.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54243/#review157554 --- Ship it! Thanks for taking care of this. - Vinod Kone On

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/#review157552 --- Ship it! Ship It! - Vinod Kone On Dec. 1, 2016, 5:43 a.m.,

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Vinod Kone
> On Dec. 1, 2016, 3:22 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 2231 > > > > > > This is different from how we prolong the lifetime of `connection` in > > `attachContainerOutput`. can we make them

Re: Review Request 53690: Add namespaces/ipc documentation.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/#review157547 --- Patch looks great! Reviews applied: [53688, 53689, 53690]

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/ --- (Updated Dec. 1, 2016, 5:43 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 54115: Added an http::serve abstraction.

2016-11-30 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/#review157529 --- 3rdparty/libprocess/src/http.cpp (lines 1558 - 1566)

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/ --- (Updated Dec. 1, 2016, 5:34 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
> On Dec. 1, 2016, 3:22 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 2231 > > > > > > This is different from how we prolong the lifetime of `connection` in > > `attachContainerOutput`. can we make them

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Vinod Kone
> On Dec. 1, 2016, 3:22 a.m., Vinod Kone wrote: > > src/slave/http.cpp, lines 2194-2195 > > > > > > why do this here instead of inside the lambda? > > Anand Mazumdar wrote: > C++11 does not support moving

Review Request 54242: Added a test for the `ATTACH_CONTAINER_INPUT` call on the Agent API.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54242/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6472

Review Request 54243: Fixed the attach output container test to use the mock containerizer.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54243/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 54229: Enabled the IO switchboard server by default for tests.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54229/ --- (Updated Dec. 1, 2016, 4:13 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54241: Updated IOSwitchboard to block IO until connected for DEBUG containers.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54241/ --- (Updated Dec. 1, 2016, 4:13 a.m.) Review request for mesos and Jie Yu. Bugs:

Review Request 54241: Updated IOSwitchboard to block IO until connected for DEBUG containers.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54241/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6639

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
> On Dec. 1, 2016, 3:22 a.m., Vinod Kone wrote: > > can you add a simple test for this change as discussed. comprehensive tests > > can come later. yep, on it :-) > On Dec. 1, 2016, 3:22 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 2231 > >

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/ --- (Updated Dec. 1, 2016, 3:59 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 54229: Enabled the IO switchboard server by default for tests.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54229/#review157541 --- Bad patch! Reviews applied: [54229, 53974, 53939, 54148, 54147,

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157540 --- Fix it, then Ship it! src/common/http.hpp (line 53)

Re: Review Request 54220: Made the agent's `api/v1` handler handle request streaming.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54220/#review157538 --- Ship it! Ship It! - Vinod Kone On Dec. 1, 2016, 3:13 a.m.,

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/#review157518 --- can you add a simple test for this change as discussed.

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Dec. 1, 2016, 3:21 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54220: Made the agent's `api/v1` handler handle request streaming.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54220/ --- (Updated Dec. 1, 2016, 3:13 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54197: Introduced Resource.AllocationInfo.

2016-11-30 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54197/ --- (Updated Dec. 1, 2016, 2:47 a.m.) Review request for mesos, Guangya Liu and

Re: Review Request 54198: Added Resource.Allocation in Offer.

2016-11-30 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54198/ --- (Updated Dec. 1, 2016, 2:47 a.m.) Review request for mesos, Guangya Liu and

Review Request 54069: Changed master to validate roles instead of just role.

2016-11-30 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54069/ --- Review request for mesos. Repository: mesos Description --- Master

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review157535 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 54167: Removed cyclic header dependency in libprocess.

2016-11-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54167/#review157534 --- Ship it! Ship It! - Benjamin Mahler On Nov. 29, 2016, 3:59

Re: Review Request 54115: Added an http::serve abstraction.

2016-11-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/#review157533 --- Ship it! Modulo comments. - Benjamin Mahler On Nov. 28,

Re: Review Request 54115: Added an http::serve abstraction.

2016-11-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/#review157532 --- 3rdparty/libprocess/src/http.cpp (lines 1623 - 1629)

Re: Review Request 54238: Added `getContainerIOSwitchboardAddress` helper to containerizer paths.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54238/#review157527 --- Ship it! Ship It! - Jie Yu On Dec. 1, 2016, 1:45 a.m.,

Re: Review Request 54115: Added an http::serve abstraction.

2016-11-30 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/#review157525 --- 3rdparty/libprocess/src/http.cpp (line 1757)

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- (Updated Dec. 1, 2016, 1:45 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 54238: Added `getContainerIOSwitchboardAddress` helper to containerizer paths.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54238/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6467

Re: Review Request 54199: Minor style fix.

2016-11-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54199/#review157522 --- Ship it! Ship It! - Guangya Liu On εδΈ€ζœˆ 30, 2016, 9:56 a.m.,

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- (Updated Dec. 1, 2016, 1:32 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Dec. 1, 2016, 1:31 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54198: Added Resource.Allocation in Offer.

2016-11-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54198/#review157520 --- Fix it, then Ship it! Ship It! include/mesos/mesos.proto

Re: Review Request 54197: Introduced Resource.AllocationInfo.

2016-11-30 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54197/#review157519 --- Fix it, then Ship it! There is a typo in `Description`

Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54148/ --- (Updated Dec. 1, 2016, 12:54 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/ --- (Updated Dec. 1, 2016, 12:55 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Dec. 1, 2016, 12:53 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54220: Made the agent's `api/v1` handler handle request streaming.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54220/#review157511 --- src/slave/http.cpp (line 340)

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/#review157515 --- src/tests/containerizer/io_switchboard_tests.cpp (line 58)

Re: Review Request 54193: Refactored `Slave::Http::launcNestedContainer()`.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54193/#review157513 --- Ship it! Ship It! - Anand Mazumdar On Nov. 30, 2016, 3:53

Re: Review Request 53690: Add namespaces/ipc documentation.

2016-11-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/ --- (Updated Dec. 1, 2016, 12:25 a.m.) Review request for mesos, Avinash Gautam

Re: Review Request 53688: Implement a namespace/ipc isolator.

2016-11-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/ --- (Updated Dec. 1, 2016, 12:24 a.m.) Review request for mesos, Avinash Gautam

Re: Review Request 53689: Use a common fixture for the PID namespace test.

2016-11-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/ --- (Updated Dec. 1, 2016, 12:25 a.m.) Review request for mesos, Avinash Gautam

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
> On Dec. 1, 2016, 12:14 a.m., Vinod Kone wrote: > > not looking at subsequent reviews, it's not clear to me why the > > serialize/deserialize functions of streaming types are same as > > non-streaming types. i would've imagined the streaming types to use > > RecordIO format. maybe add a

Re: Review Request 54229: Enabled the IO switchboard server by default for tests.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54229/#review157512 --- Ship it! Ship It! - Jie Yu On Nov. 30, 2016, 10:26 p.m.,

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/#review157498 --- src/slave/containerizer/mesos/io/switchboard.cpp (line 509)

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157508 --- not looking at subsequent reviews, it's not clear to me why the

Re: Review Request 54219: Added validation for the attach container input call on the agent.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54219/#review157509 --- Ship it! Ship It! - Vinod Kone On Nov. 30, 2016, 7:18 p.m.,

Re: Review Request 53939: Added implementation for containerizer 'attach()' call.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53939/#review157493 --- Fix it, then Ship it!

Re: Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54226/#review157497 --- Patch looks great! Reviews applied: [54226] Passed command:

Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers.

2016-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50736/ --- (Updated Nov. 30, 2016, 11:16 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

2016-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51065/ --- (Updated Nov. 30, 2016, 11:16 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

2016-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50737/ --- (Updated Nov. 30, 2016, 11:14 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53803: Added a new libprocess HTTP test.

2016-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/ --- (Updated Nov. 30, 2016, 11:14 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.

2016-11-30 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53802/ --- (Updated Nov. 30, 2016, 11:12 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54148: Updated the io switchboard to launch an external io switchboard server.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54148/#review157474 --- Fix it, then Ship it!

Re: Review Request 52544: Introduced `int_fd` class.

2016-11-30 Thread Daniel Pravat
> On Nov. 19, 2016, 3:28 a.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/filedescriptor.hpp, lines 381-384 > > > > > > Do we actually need this? I think the `int` on the rhs should implicit >

Re: Review Request 54061: Augmented FrameworkInfo to support multiple roles.

2016-11-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54061/#review157485 --- Ship it! We should include some warnings that this isn't

Review Request 54229: Enabled the IO switchboard server by default for tests.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54229/ --- Review request for mesos. Repository: mesos Description --- Enabled the

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Nov. 30, 2016, 10:26 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- (Updated Nov. 30, 2016, 10:26 p.m.) Review request for mesos, Benjamin

Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

2016-11-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6602

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

2016-11-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review157484 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (line

Re: Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/ --- (Updated Nov. 30, 2016, 10:09 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- (Updated Nov. 30, 2016, 10:08 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54074: Added isolator nested aware user doc.

2016-11-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54074/#review157479 --- Patch looks great! Reviews applied: [54013, 54073, 54074]

Re: Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/#review157476 --- src/common/http.hpp (lines 66 - 75)

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/#review157461 --- Fix it, then Ship it!

Re: Review Request 53974: Added support to handle ATTACH_CONTAINER_OUPUT in the io switchbaord.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53974/ --- (Updated Nov. 30, 2016, 9:36 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 54147: Added a server side component for the IOSwitchboard.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54147/ --- (Updated Nov. 30, 2016, 9:35 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54217: Introduced streaming content types.

2016-11-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54217/#review157472 --- Ship it! Ship It! - Vinod Kone On Nov. 30, 2016, 7:17 p.m.,

Re: Review Request 54223: Adjusted agent `usedResources` accounting at the master.

2016-11-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54223/#review157470 --- Ship it! Ship It! - Benjamin Mahler On Nov. 30, 2016, 7:21

Re: Review Request 54178: Added a fixed-capacity hashmap to stout.

2016-11-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54178/ --- (Updated Nov. 30, 2016, 9:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 54183: Improved management of unreachable and completed tasks in master.

2016-11-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54183/ --- (Updated Nov. 30, 2016, 8:58 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52695: Harden libprocess

2016-11-30 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 30, 2016, 8:52 p.m.) Review request for mesos, James Peach,

Re: Review Request 52645: Harden Mesos

2016-11-30 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/ --- (Updated Nov. 30, 2016, 8:51 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-30 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 30, 2016, 8:50 p.m.) Review request for mesos, James Peach,

Re: Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

2016-11-30 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54226/#review157462 --- Ship it! Ship It! - Kevin Klues On Nov. 30, 2016, 8:31

Re: Review Request 54053: Updated 'io::redirect()' to take an optional vector of callback hooks.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54053/#review157460 --- Ship it! Ship It! - Jie Yu On Nov. 28, 2016, 9:18 p.m.,

Review Request 54226: Exposed IOSwitchboard to MesosContainerizer.

2016-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54226/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6651

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2016-11-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review157458 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 54211: Fixed overlay backend symlink error message.

2016-11-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54211/#review157457 --- Ship it! Ship It! - Zhitao Li On Nov. 30, 2016, 6:54 p.m.,

Review Request 54223: Adjusted agent `usedResources` accounting at the master.

2016-11-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54223/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54221: Added the v1 `ATTACH_CONTAINER_INPUT` call handler on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54221/ --- Review request for mesos, Kevin Klues and Vinod Kone. Bugs: MESOS-6472

Review Request 54220: Made the agent's `api/v1` handler handle request streaming.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54220/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6472

Review Request 54219: Added validation for the attach container input call on the agent.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54219/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6472

Review Request 54218: Made `serialize()`/`deserialize()` handle streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54218/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6472

Review Request 54217: Introduced streaming content types.

2016-11-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54217/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6472

Re: Review Request 54073: Added linux launcher nested container support doc.

2016-11-30 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54073/ --- (Updated Nov. 30, 2016, 11:11 a.m.) Review request for mesos, Benjamin Mahler,

  1   2   >