Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

> On Jan. 13, 2017, 4:52 a.m., Vinod Kone wrote: > > Thanks for the fix! > > > > Would you mind updating the `StatusUpdateCallFailedValidation` test in > > executor_http_api_tests.cpp to include this case? > > Vinod Kone wrote: > Also if you can create a ticket for this, and set target ver

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

> On Jan. 13, 2017, 4:52 a.m., Vinod Kone wrote: > > Thanks for the fix! > > > > Would you mind updating the `StatusUpdateCallFailedValidation` test in > > executor_http_api_tests.cpp to include this case? Also if you can create a ticket for this, and set target versions to 1.0, 1.1 and 1.2 w

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161484 --- Thanks for the fix! Would you mind updating the `StatusUpdateCall

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161483 --- Patch looks great! Reviews applied: [55480] Passed command: expo

Re: Review Request 54877: Windows: Stout: Removed dependency on Shell API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54877/#review161479 --- Ship it! Sounds good. I'll tweak the error message wording a b

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/ --- (Updated Jan. 13, 2017, 1:38 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 54407: Refactored Master::removeFramework to use Master::deactivate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54407/ --- (Updated Jan. 13, 2017, 1:38 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 55238: Use os::spawn in the CNI isolator.

> On Jan. 11, 2017, 10:11 a.m., Jiang Yan Xu wrote: > > I feel if we keep `os::system()` in the codebase at all, this is one of the > > few places it could actually be used... we could eliminate it so we can say > > there's no references to `os::systems()` left today but it's a bit harsh to >

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/#review161470 --- Ship it! Ship It! - Michael Park On Jan. 12, 2017, 3:40 p.m.

Re: Review Request 55161: Fixed typo in `stout/os/windows/write.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55161/#review161469 --- Ship it! Ship It! - Joseph Wu On Jan. 3, 2017, 8:40 p.m., Al

Re: Review Request 54793: Prevented task launches that reuse unreachable task IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54793/ --- (Updated Jan. 13, 2017, 12:42 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55449: Validate executor IDs in master validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55449/#review161467 --- src/tests/master_validation_tests.cpp (line 1751)

Re: Review Request 54408: Replaced `Master::Framework::active` with a new `state` enum value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/ --- (Updated Jan. 13, 2017, 12:08 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161463 --- Ship it! Nice catch! - Joseph Wu On Jan. 12, 2017, 3:52 p.m.

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161464 --- Ship it! Ship It! - haosdent huang On Jan. 12, 2017, 11:52 p

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/ --- (Updated Jan. 12, 2017, 11:52 p.m.) Review request for mesos and Anand Mazumdar

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/#review161460 --- Ship it! Ship It! - Andrew Schwartzmeyer On Jan. 12, 2017, 1

Re: Review Request 55480: Fix segfault when the executor ID is not a valid v4 UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/ --- (Updated Jan. 12, 2017, 11:41 p.m.) Review request for mesos and Anand Mazumdar

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/ --- (Updated Jan. 12, 2017, 3:40 p.m.) Review request for mesos, Alexander Rojas, D

Re: Review Request 55480: Fix segfault when executor ID is not a valid UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/#review161455 --- Will create a JIRA for this as soon as it's back online. - Aaron

Review Request 55480: Fix segfault when executor ID is not a valid UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55480/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description --

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/#review161454 --- Bad patch! Reviews applied: [55435, 55029, 55028, 55026, 55025, 5

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

> On Jan. 11, 2017, 7 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/jsonify.hpp, lines 75-78 > > > > > > Shouldn't we call `_configthreadlocale(_DISABLE_PER_THREAD_LOCALE);` > > here to recover the origi

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/ --- (Updated Jan. 12, 2017, 3:14 p.m.) Review request for mesos, Alexander Rojas, D

Re: Review Request 54232: Shutdown tasks of completed frameworks on agent re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/ --- (Updated Jan. 12, 2017, 10:55 p.m.) Review request for mesos and Vinod Kone.

Review Request 55476: Changed TASK_UNREACHABLE to be a non-terminal state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55476/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619 https://issues.ap

reviews@mesos.apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55475/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619 https://issues.ap

Review Request 55473: Marked a member function `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55473/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619 https://issues.ap

Review Request 55474: Renamed `taskTerminated` for Slave/Framework to `recoverResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55474/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619 https://issues.ap

Review Request 55472: Moved `Slave` definitions out-of-line to master.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55472/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6619 https://issues.ap

Re: Review Request 55239: Stop using os::system to extract fetcher archives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55239/ --- (Updated Jan. 12, 2017, 9:47 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 55446: Added common validation for IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55446/#review161430 --- Ship it! Ship It! - James Peach On Jan. 12, 2017, 9:46 a.m.,

Re: Review Request 55446: Added common validation for IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55446/#review161426 --- src/common/validation.hpp (line 18)

Re: Review Request 55449: Validate executor IDs in master validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55449/#review161428 --- Ship it! Ship It! - James Peach On Jan. 12, 2017, 9:47 a.m.,

Re: Review Request 55240: Stop using os::system to copy local files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55240/#review161412 --- Ship it! - Jiang Yan Xu On Jan. 11, 2017, 4:27 p.m., James Pe

Re: Review Request 55239: Stop using os::system to extract fetcher archives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55239/#review161409 --- Fix it, then Ship it! src/launcher/fetcher.cpp (line 51)

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review161408 --- Bad patch! Reviews applied: [52534, 51027] Failed command: pytho

Re: Review Request 55238: Use os::spawn in the CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55238/#review161407 --- Ship it! Ship It! - Jiang Yan Xu On Jan. 11, 2017, 4:26 p.m.

Re: Review Request 55238: Use os::spawn in the CNI isolator.

> On Jan. 11, 2017, 2:11 a.m., Jiang Yan Xu wrote: > > I feel if we keep `os::system()` in the codebase at all, this is one of the > > few places it could actually be used... we could eliminate it so we can say > > there's no references to `os::systems()` left today but it's a bit harsh to > >

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161401 --- Bad patch! Reviews applied: [55464, 55463] Failed command: pytho

Re: Review Request 52534: Dispatch filter expiration twice.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/ --- (Updated Jan. 12, 2017, 6:56 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/ --- (Updated Jan. 12, 2017, 6:55 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/#review161397 --- Bad patch! Reviews applied: [55271, 55381] Failed command: pytho

Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/#review161392 --- Bad patch! Reviews applied: [55445, 54898, 54649] Failed command

Re: Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161391 --- src/tests/api_tests.cpp

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55271/ --- (Updated Jan. 12, 2017, 4:32 p.m.) Review request for mesos, Benjamin Mahler, J

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/ --- (Updated Jan. 12, 2017, 4:32 p.m.) Review request for mesos, Benjamin Mahler, J

Review Request 55464: Made the Agent API able to handle containers nested at arbitrary levels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Alexander

Re: Review Request 55463: Fixed typos in `mesos/containerizer.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55463/#review161389 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 12, 2017, 3:

Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/ --- (Updated Jan. 12, 2017, 11 p.m.) Review request for mesos, Benjamin Mahler and

Review Request 55463: Fixed typos in `mesos/containerizer.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55463/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos Descripti

Re: Review Request 55462: WIP: Validate resource reservation against allocated role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55462/#review161388 --- Bad patch! Reviews applied: [55462, 55461] Failed command: pytho

Review Request 55461: Made resource reservation validation multi-role aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55461/ --- Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. Repository

Review Request 55462: WIP: Validate resource reservation against allocated role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55462/ --- Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu. Repository

Re: Review Request 55459: Added task check validation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/#review161383 --- Bad patch! Reviews applied: [55459, 55458, 55457, 55456, 55455, 5

Review Request 55459: Added task check validation test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55459/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Bugs:

Review Request 55458: Added validation for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55458/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Bugs:

Review Request 55457: Added protobufs for a general check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55457/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Bugs:

Review Request 55456: Fixed include order in "launcher/executor.cpp".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55456/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Repos

Review Request 55455: Moved `HealthChecker` into "checks" folder and namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55455/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Repos

Review Request 55454: Ensured zero health check timeout means infinite timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55454/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Bugs:

Review Request 55453: Updated comments in `HealthCheck` protobuf for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55453/ --- Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. Repos

Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/#review161372 --- Bad patch! Reviews applied: [55445, 54898, 54649] Failed command

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review161371 --- src/tests/master_validation_tests.cpp (line 2559)

Re: Review Request 55381: Added test for framework upgrading to multi-role capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55381/#review161367 --- Fix it, then Ship it! Ship It! src/tests/master_validation_te

Re: Review Request 55447: Added sanity checks on IDs and roles before creating directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55447/#review161368 --- Bad patch! Reviews applied: [55447, 55448, 55449, 55446] Failed

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

> On Jan. 12, 2017, 1:50 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [55435, 55029, 55028, 55026, 55025, 55024, 55023, 55022] > > > > Failed command: python support/apply-reviews.py -n -r 55022 > > > > Error: > > Traceback (most recent call last): > > File "support/a

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/#review161365 --- 3rdparty/stout/include/stout/jsonify.hpp (lines 66 - 72)

Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/ --- (Updated Jan. 12, 2017, 5:54 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 55435: Windows: Fixed the locale guard in jsonify.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55435/#review161363 --- Bad patch! Reviews applied: [55435, 55029, 55028, 55026, 55025, 5

Re: Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/#review161362 --- Ship it! It would be great to add sth in `Testing Done` section

Re: Review Request 54926: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54926/#review161361 --- Can you please abandon this? Seems duplicate with https://reviews

Review Request 55447: Added sanity checks on IDs and roles before creating directories.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55447/ --- Review request for mesos, Benjamin Mahler and James Peach. Bugs: MESOS-6866

Review Request 55448: Implemented TODOs to use common ID validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55448/ --- Review request for mesos, Benjamin Mahler and James Peach. Repository: mesos

Review Request 55449: Validate executor IDs in master validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55449/ --- Review request for mesos, James Peach and Joseph Wu. Repository: mesos Descri

Review Request 55446: Added common validation for IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55446/ --- Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu. Bugs: ME

Re: Review Request 54926: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54926/#review161360 --- Ship it! Ship It! - Guangya Liu On 十二月 21, 2016, 3:06 a.m.,

Re: Review Request 55253: Added 'roles' section in the response of `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55253/ --- (Updated Jan. 12, 2017, 5:13 p.m.) Review request for mesos, Anand Mazumdar, Be

Re: Review Request 54649: Fixed minor argument style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54649/ --- (Updated Jan. 12, 2017, 5:04 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 54649: Fixed minor argument style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54649/ --- (Updated Jan. 12, 2017, 4:57 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 54898: Added a CHECK in updateFrameworkInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54898/ --- (Updated Jan. 12, 2017, 4:57 p.m.) Review request for mesos, Benjamin Mahler, G

Review Request 55445: Augmented a fault_tolerance_test to cover update of role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55445/ --- Review request for mesos. Repository: mesos Description --- In currently