Re: Review Request 56757: Added the SecretGenerator module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56757/#review168099 --- include/mesos/authentication/secret_generator.hpp Lines 29-32 (pa

Review Request 57364: Fixed flaky test FaultToleranceTest.FrameworkReregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57364/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7029 https://issues.a

Re: Review Request 57166: Updated role validation for hierarchical roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57166/#review168096 --- Fix it, then Ship it! src/common/roles.cpp Line 71 (original),

Re: Review Request 57059: Updated default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57059/#review168095 --- Patch looks great! Reviews applied: [57058, 57059] Passed comman

Review Request 57360: Replace `.get().` in favor of `->` in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57360/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

> On March 7, 2017, 6:38 a.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4292-4293 (patched) > > > > > > Are you planning to test the agent endpoint as well? I modified existing test to includ

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/ --- (Updated March 7, 2017, 11:35 a.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 56733: Mount all supported subsystems in the containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56733/#review168084 --- Patch looks great! Reviews applied: [56730, 56731, 56732, 56733]

Review Request 57358: Fixed potential for circular dependencies in Future continuations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57358/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Michael Park. Bugs: MESO

Re: Review Request 56805: Simplified interface for setting weights in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/#review168076 --- Ship it! Ship It! - Adam B On Feb. 28, 2017, 12:24 p.m., Nei

Re: Review Request 56805: Simplified interface for setting weights in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/#review168075 --- Ship it! Ship It! - Michael Park On Feb. 28, 2017, 12:24 p.m

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

> On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 519-541 (patched) > > > > > > Ditto here. N/A - Michael ---

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

> On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote: > > Looks good, wonder if we can just loop over the master and agent pids and > > use the same code to check the contents since they should be the same? Yep. Thanks for the suggestion! > On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote:

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/ --- (Updated March 6, 2017, 5:33 p.m.) Review request for mesos and Benjamin Mahler

Review Request 57354: Added `initializer_list` constructors for `JSON::(Object|Array)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57354/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 57059: Updated default executor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57059/ --- (Updated March 7, 2017, 1:17 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 57058: Updated default executor tests to exclusively use v1 protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57058/ --- (Updated March 7, 2017, 1:15 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

> On March 2, 2017, 1:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 1830-1840 (original), 1818-1835 (patched) > > > > > > This results in a behavior change: if tasks are killed during > > unschedul

Re: Review Request 57165: Minor cleanup for quota validation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57165/#review168068 --- Ship it! Ship It! - Michael Park On March 1, 2017, 10:23 a.m

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 4:07 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/#review168065 --- Almost there! Thanks Jan, code is looking great. 3rdparty/libpro

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review168040 --- 3rdparty/libprocess/include/process/jwt.hpp Lines 13-14 (patched)

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review167750 --- src/slave/slave.hpp Lines 340 (patched)

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 3, 2017, 7:48 a.m., Greg Mann wrote: > > src/authentication/executor/jwt_secret_generator.hpp > > Lines 40 (patched) > > > > > > Use `override` instead of `virtual` here? > > Jan Schlicht wrote: > Do w

Re: Review Request 57269: Added a test to ensure allocation roles are exposed in master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168058 --- Looks good, just a few minor things and we can get this committed.

Re: Review Request 57186: Added unit test for persistent volume using default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57186/ --- (Updated March 6, 2017, 2:25 p.m.) Review request for mesos, Anand Mazumdar, Av

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/#review168056 --- Fix it, then Ship it! Looks good, wonder if we can just loop ov

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review168055 --- Patch looks great! Reviews applied: [54449] Passed command: expo

Re: Review Request 57335: Migrated `MultiRoleSchedulerUpgrade` from `MasterTest` to `UpgradeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57335/#review168054 --- Ship it! Ship It! - Benjamin Mahler On March 6, 2017, 1:19 p

Re: Review Request 57164: Cleaned up header includes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57164/#review168053 --- Ship it! Ship It! - Michael Park On Feb. 28, 2017, 12:18 p.m

Re: Review Request 57163: Cleaned up sorter test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57163/#review168052 --- Ship it! Ship It! - Michael Park On Feb. 28, 2017, 12:17 p.m

Re: Review Request 57162: Minor cleanup for slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57162/#review168051 --- Ship it! Ship It! - Michael Park On Feb. 28, 2017, 12:14 p.m

Review Request 57156: Minor cleanup for slave tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57156/ --- Review request for mesos. Repository: mesos Description --- Minor cleanu

Re: Review Request 55323: Used process::loop for framework scheduler heartbeater.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55323/#review168049 --- Ship it! Ship It! - Vinod Kone On Jan. 8, 2017, 7:50 a.m., B

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

> On Jan. 31, 2017, 11:45 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you commit this @haosdent? > > haosdent huang wrote: > Sure, let me commit. ping! - Vinod --- This is an automatically generated e-mail

Re: Review Request 56666: Added a HMAC SHA256 generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review168036 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/ssl/

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review168031 --- Fix it, then Ship it! New function names look good. src/maste

Re: Review Request 56733: Mount all supported subsystems in the containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56733/ --- (Updated March 6, 2017, 7:34 p.m.) Review request for mesos, Mesos Reviewbot an

Re: Review Request 56730: Kill stray tasks when tearing down test cgroups.

> On March 3, 2017, 12:40 a.m., Jiang Yan Xu wrote: > > Did you run into issues without this patch? cgroups::destroy() *should* > > kill all tasks in it. On my reading of `cgroups::destroy`, processes would only be killed when destroying the `freezer` cgroup, since that is the only one with th

Re: Review Request 57186: Added unit test for persistent volume using default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57186/#review168028 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp Lin

Re: Review Request 57329: Renamed `activeRoles` to `roles` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57329/#review168027 --- Ship it! Ship It! - Benjamin Mahler On March 6, 2017, 11:45

Re: Review Request 57185: Support 'v1::createCallAccept()' helper with multi operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57185/#review168026 --- Ship it! Ship It! - Vinod Kone On March 1, 2017, 8:15 a.m.,

Re: Review Request 57184: Fixed bugs in tests/mesos.hpp helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57184/#review168024 --- Ship it! Ship It! - Vinod Kone On March 1, 2017, 8:15 a.m.,

Re: Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57330/#review168023 --- Ship it! Ship It! - Benjamin Mahler On March 6, 2017, 11:36

Re: Review Request 57331: Used `at` rather than `operator[]` in a few instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57331/#review168022 --- Ship it! Ship It! - Benjamin Mahler On March 6, 2017, 10:57

Re: Review Request 56813: Updated master handlers to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- (Updated March 6, 2017, 7:11 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 54449: Check quotas are enabled in the XFS disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/ --- (Updated March 6, 2017, 7:10 p.m.) Review request for mesos, Jie Yu and Jiang Y

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168017 --- Patch looks great! Reviews applied: [56623, 56617, 56618, 56901,

Re: Review Request 57166: Updated role validation for hierarchical roles.

> On March 2, 2017, 1:21 a.m., Qian Zhang wrote: > > src/common/roles.cpp > > Line 71 (original), 71 (patched) > > > > > > Why can't role start with a slash? According to the design doc, it > > seems the role like `/

Re: Review Request 55901: Added support for command health checks to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55901/ --- (Updated March 6, 2017, 4:23 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/#review167995 --- Patch looks great! Reviews applied: [57319, 57329, 57330, 57331,

Review Request 57340: Remove adjustment code within Resources::apply.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7048 https://issu

Re: Review Request 56754: Implemented a JWT secret generator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/ --- (Updated March 6, 2017, 3:57 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 56753: Implemented the JWT authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56753/ --- (Updated March 6, 2017, 3:55 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 56667: Added support for JSON Web Tokens.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/ --- (Updated March 6, 2017, 3:53 p.m.) Review request for mesos, Alexander Rojas an

Re: Review Request 56754: Implemented a JWT secret generator.

> On March 3, 2017, 8:48 a.m., Greg Mann wrote: > > src/authentication/executor/jwt_secret_generator.hpp > > Lines 40 (patched) > > > > > > Use `override` instead of `virtual` here? Do we use that for destructors as

Re: Review Request 56753: Implemented the JWT authenticator.

> On March 1, 2017, 8:41 a.m., Greg Mann wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp > > Lines 186-189 (patched) > > > > > > `override` keyword implies `virtual`, so the `virtual` here can be >

Re: Review Request 56753: Implemented the JWT authenticator.

> On March 1, 2017, 8:41 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp > > Lines 2067-2068 (patched) > > > > > > Ditto as above - can we consolidate to one line? > > Greg Mann wrote: >

Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57112/#review167974 --- Patch looks great! Reviews applied: [57319, 57329, 57330, 57331,

Re: Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/ --- (Updated March 6, 2017, 5:19 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57335: Migrated `MultiRoleSchedulerUpgrade` from `MasterTest` to `UpgradeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57335/ --- (Updated March 6, 2017, 5:19 a.m.) Review request for mesos and Benjamin Mahler

Review Request 57336: Updated `MultiRoleSchedulerUpgrade` to test framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 57335: Migrated `MultiRoleSchedulerUpgrade` from `MasterTest` to `UpgradeTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57335/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57112/ --- (Updated March 6, 2017, 4:01 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57112/ --- (Updated March 6, 2017, 3:59 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- (Updated March 6, 2017, 3:52 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57329: Renamed `activeRoles` to `roles` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57329/ --- (Updated March 6, 2017, 3:45 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 3:37 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57330/ --- (Updated March 6, 2017, 3:36 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Lines 1785-1786 (original), 1789-1793 (patched) > > > > > > It looks like we should have pulled out this rename to into a separate

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

> On March 5, 2017, 12:37 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 401-412 (patched) > > > > > > Since this is effectively `stopTrackingAllocationToRole`, should we be > > CHECKing the invari

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- (Updated March 6, 2017, 2:57 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57331: Used `at` rather than `operator[]` in a few instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57331/ --- (Updated March 6, 2017, 2:57 a.m.) Review request for mesos and Benjamin Mahler

Review Request 57331: Used `at` in a few instances.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57331/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57330/ --- (Updated March 6, 2017, 2:56 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57330/ --- (Updated March 6, 2017, 2:55 a.m.) Review request for mesos and Benjamin Mahler

Review Request 57329: Renamed `activeRoles` to `roles` in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57329/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 57330: Renamed `source` to `newInfo` for `Framework::updateFrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57330/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -