Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179215 --- src/master/http.cpp Line 3840 (original), 3845 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179212 --- Fix it, then Ship it! src/common/http.hpp Lines 218 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 12:47 a.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On June 28, 2017, 11:31 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 3545-3547 (patched) > > > > > > We want to assert that both of these tasks are there. Should do > > > > ``` > >

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 29, 2017, 12:39 a.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179195 --- src/common/http.hpp Lines 165 (patched)

Review Request 60525: Fixed the default filter used by the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60525/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and V

Review Request 60524: Stout: Made the `Duration` operators handle int overflows explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60524/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and V

Review Request 60520: Remove posix/subprocess.hpp dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60520/ --- Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan Xu

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review179197 --- Bad patch! Reviews applied: [60511, 56722, 60471, 56721, 59705, 5

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179192 --- Bad patch! Reviews applied: [60107] Failed command: python suppo

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179189 --- Bad patch! Reviews applied: [60370, 60369] Failed command: pytho

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 28, 2017, 10:05 p.m.) Review request for mesos, Anand Mazumdar, A

Re: Review Request 60496: WIP: Add socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review179187 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179184 --- src/common/http.hpp Lines 40-42 (patched)

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179185 --- Bad patch! Reviews applied: [58394] Failed command: python suppo

Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review179182 --- Bad patch! Reviews applied: [60511, 56722, 60471, 56721, 59705, 5

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60008/ --- (Updated June 28, 2017, 9:44 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 60508: Fixed Attributes comparison.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/#review179181 --- Bad patch! Reviews applied: [60508] Failed command: python suppo

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 28, 2017, 9:38 p.m.) Review request for mesos, Anand Mazumdar, Al

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179178 --- Bad patch! Reviews applied: [60500] Failed command: python suppo

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

> On June 28, 2017, 7:05 p.m., Greg Mann wrote: > > src/common/http.hpp > > Lines 205-218 (patched) > > > > > > It doesn't look like this class is used at all in this patch, can we > > remove it? I am creating Auth

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60008/#review179176 --- Bad patch! Reviews applied: [60008] Failed command: python suppo

Re: Review Request 60497: Update mesos-execute capabilities options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60497/#review179175 --- Bad patch! Reviews applied: [60497, 60414, 60413, 60412, 60411, 6

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 8:52 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > > ng-repeat="(ro

Re: Review Request 60496: WIP: Add socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/#review179151 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179132 --- Could you change the commit title to something like "Added filteri

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/ --- (Updated June 28, 2017, 6:55 p.m.) Review request for mesos, Jason Lai, Joseph

Review Request 60511: Added MockMetadataManager and test concurrent prune and pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-4945 http

Review Request 60508: Fixed Attributes comparison.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60508/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Bugs: MESOS-1216

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/#review179124 --- Ship it! Ship It! - haosdent huang On June 26, 2017, 5:54 p.

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > > ng-repeat="(ro

Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709 ht

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

> On June 26, 2017, 2:15 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/dispatch.hpp > > Lines 68 (patched) > > > > > > Why don't you use `Option<>`? Fixed. > On June 26, 2017, 2:15 p.m.,

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60008/ --- (Updated June 28, 2017, 2:56 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59937/#review179100 --- docs/configuration.md Lines 1900 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > > ng-repeat="(ro

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 12:37 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 184 (patched) > > > > > > Is `|| 0` necessary here? > > Andrei Budnik wrote: > I think yes, because we might

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/ --- (Updated June 28, 2017, 12:29 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

> On June 27, 2017, 5:58 p.m., haosdent huang wrote: > > src/slave/http.cpp > > Lines 1334-1344 (patched) > > > > > > Should we follow this pattern? > > > > > > ``` > > writer->field( > >

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/ --- (Updated June 28, 2017, 12:08 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/#review179082 --- Ship it! Ship It! - Alexander Rukletsov On June 27, 2017, 8:

Review Request 60497: Update mesos-execute capabilities options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60497/ --- Review request for mesos and Jie Yu. Bugs: MESOS-7671 https://issues.apache

Review Request 60496: WIP: Add socket checking to the network ports isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60496/ --- Review request for mesos. Bugs: MESOS-7675 https://issues.apache.org/jira/b

Review Request 60493: Remove diagnostic socket IPv4 assumptions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60493/ --- Review request for mesos. Bugs: MESOS-7675 https://issues.apache.org/jira/b

Review Request 60494: Expose LinuxLauncher cgroups helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60494/ --- Review request for mesos. Bugs: MESOS-7675 https://issues.apache.org/jira/b

Review Request 60491: Capture the inode when scanning for sockets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60491/ --- Review request for mesos. Bugs: MESOS-7675 https://issues.apache.org/jira/b