eply, visit:
https://reviews.apache.org/r/40131/#review106154
-------
On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically g
---
Thanks,
Alex Clemmer
hat correct?
> >
> > (At least, I don't think the command exists in other Windows shells,
> > like PowerShell.)
>
> Alex Clemmer wrote:
> That's mostly correct, yes: we do not assume the user has PowerShell
> right now, and we do assume the shell
hat correct?
> >
> > (At least, I don't think the command exists in other Windows shells,
> > like PowerShell.)
>
> Alex Clemmer wrote:
> That's mostly correct, yes: we do not assume the user has PowerShell
> right now, and we do assume the shell
4db01decf351c33c9a1
support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7
support/post-reviews.py 170be83aa6dca6e8175292169d78e8f7915f7e6e
Diff: https://reviews.apache.org/r/40340/diff/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
/libprocess/3rdparty/stout/include/stout/os/windows/process.hpp
e8238383c3c5feb688b10e37e544556ba9d43107
Diff: https://reviews.apache.org/r/40102/diff/
Testing
---
Thanks,
Alex Clemmer
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39888/diff/
Testing
---
Thanks,
Alex Clemmer
Diff: https://reviews.apache.org/r/39852/diff/
Testing
---
Thanks,
Alex Clemmer
on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39850/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
/os_tests.cpp
8791cfe628563b25ac86a8170966d458c3a9c0c8
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
buntu
Thanks,
Alex Clemmer
hanks,
Alex Clemmer
://reviews.apache.org/r/39802/diff/
Testing
---
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
hanks,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/40131/#review106154
-------
On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatic
,
Alex Clemmer
---
Thanks,
Alex Clemmer
altogether.
Diffs
-
support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3
support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d
Diff: https://reviews.apache.org/r/40195/diff/
Testing
---
Branches tested manually.
Thanks,
Alex Clemmer
Remoortere, and Joseph Wu.
Repository: mesos
Description
---
Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`.
Diffs
-
bootstrap.bat PRE-CREATION
Diff: https://reviews.apache.org/r/40131/diff/
Testing
---
Thanks,
Alex Clemmer
/windows/process.hpp
e8238383c3c5feb688b10e37e544556ba9d43107
Diff: https://reviews.apache.org/r/40102/diff/
Testing
---
Thanks,
Alex Clemmer
e name,
> > correct?
>
> Joseph Wu wrote:
> Windows doesn't have a temp-directory function. Are you suggesting
> calling `mktemp` and then using the file's name as the argument to `mkdir`?
>
> Joris Van Remoortere wrote:
> Indeed. It seems like tha
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
for my simple
approach.
I think you are right that we should retry if there is a name collision though,
so based on my read, I suggest that I make that change.
Does this seem reasonable to you?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3
> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote:
> > configure.ac, lines 612-621
> > <https://reviews.apache.org/r/39634/diff/2/?file=1112829#file1112829line612>
> >
> > If it's not too much trouble, it would be great to see this logic added
> >
Remoortere, and Joseph Wu.
Repository: mesos
Description
---
Windows: Added support for `files/files.hpp`.
Diffs
-
src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
Diff: https://reviews.apache.org/r/39889/diff/
Testing
---
Thanks,
Alex Clemmer
/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
s to its own tests file so that we can run it on
Windows too? `os_test.cpp` has is too big and full of unimplemented stuff to
add Windows support right now.
- Alex Clemmer
On Oct. 23, 2015, 7:49 a.m., Benjamin Bannier wrote:
>
> --
719/#comment163000>
It looks like it might make sense to add this to `src/CMakeLists.txt` also?
- Alex Clemmer
On Nov. 2, 2015, 6:52 p.m., Timothy Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
g/r/39634/#comment162999>
If it's not too much trouble, it would be great to see this logic added
also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines
of code.
- Alex Clemmer
On Oct. 30, 2015, 5:05 a.m., David For
230/#comment162998>
Sorry I'm super late to the party. Does it make sense to add these to the
CMake build system as well?
- Alex Clemmer
On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatica
/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
tps://reviews.apache.org/r/39851/#comment162948>
Ah. VisualStudio tricked me into believing this was ok! It claimed this
built correctly, but now when I `make clean` it doesn't. I'll have to revisit
tomorrow, as it's 3:30 AM.
- Alex Clemmer
On Nov. 2, 2015, 11:06 a.m
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
://reviews.apache.org/r/39851/diff/
Testing
---
Thanks,
Alex Clemmer
/
Testing
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
/3rdparty/stout/include/stout/windows.hpp
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
tps://reviews.apache.org/r/39805/#comment162892>
Oh, interesting, I thought that the lineup here was identical to that of
`git diff`. I guess not.
- Alex Clemmer
On Nov. 1, 2015, 1:22 a.m., Alex Clemmer wrote:
>
> ---
/os_tests.cpp
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff
Diff: https://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
Remoortere, and Joseph Wu.
Repository: mesos
Description
---
Made `path_tests.cpp` standalone.
Diffs
-
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
ad9ce324eaf940f68d04c6db7ba37d05efb1216a
Diff: https://reviews.apache.org/r/39834/diff/
Testing
---
Thanks,
Alex
1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/39803/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
://reviews.apache.org/r/39805/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
,
Alex Clemmer
,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
` project in VS on Windows 10.
Thanks,
Alex Clemmer
check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
buntu
Thanks,
Alex Clemmer
hanks,
Alex Clemmer
hanks,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
Thanks,
Alex Clemmer
and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
e26df59d9b837e1f4a4b92577f0a3de4b9076cb4
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
edf17d5ad8efbc988e909bfb8ffa5a015ecdc89d
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
/rmdir.hpp (line 138)
<https://reviews.apache.org/r/39584/#comment162433>
note that actually `::rmdir` here will deal appropriately with Unix-style
paths, so there's no real need to normalize them.
- Alex Clemmer
On Oct. 27, 2015, 8:23 a.m., Alex Cl
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review104054
---
On Oct. 27, 2015, 8:23 a.m., Ale
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
;re not using snake case. Have I missed something
important?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103815
-------
On Oct. 27, 2015, 8:14 a.m., Alex Clemmer wrote:
>
&
> On Oct. 23, 2015, 6:45 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 34
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line34>
> >
> > `strlen()` might be better
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
b6afe0e76366d0bc68d37097ced83a1e14828d84
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp
3e6f2aafd0f541f512025dfa683ab4178701f7c4
Diff: https://reviews.apache.org/r/39559/diff/
Testing
---
Thanks,
Alex
eviews.apache.org/r/39559/#review103815
---
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To re
:
https://reviews.apache.org/r/39559/#review103815
-------
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-
---
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015
on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
7a8819541506f57f70a9b577dc97a76fc26ebaa8
Diff: https://reviews.apache.org/r/39539/diff/
Testing
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
; code.
Yes, I admit it's a super nitpicky thing to do.
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39019/#review101663
---------
` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
---
`make check` from CMake on OS X 10.10.
`make check` from Autotools on OS X 10.10.
Ran `check` project in VS on Windows 10.
PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH
into my Ubuntu box to test this from Ubuntu
Thanks,
Alex Clemmer
views.apache.org/r/39540/#review103800
---
On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
>
autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
https://reviews.apache.org/r/39583/#review103746
-------
On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
>
> ---
> This is an automatically generated e-m
,
Alex Clemmer
on OS X 10.10.
Ran `check` project in VS on Windows 10.
Thanks,
Alex Clemmer
> On Oct. 22, 2015, 6:33 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp,
> > line 31
> > <https://reviews.apache.org/r/39559/diff/1/?file=1103501#file1103501line31>
> >
> > Just so I catch it be
he answer is yes.
Also, you might be leery of committing this without tests. That's ok! We
need this to pull the FS tests out of `os_tests.cpp` though. The last function
we will need to port to get those tests functional on Windows is `rmdir`, and
I'm almost done.
- Alex Clemme
an't commit this stuff with
tests" is "yes, I agree, but I have to write this before we can open up the
tests!" :)
- Alex Clemmer
On Oct. 22, 2015, 6:23 p.m., Alex Clemmer wrote:
>
> ---
> This is an automat
901 - 1000 of 1316 matches
Mail list logo
