Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

`. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644 Diff: https://reviews.apache.org/r/43323/diff/ Testing --- make, make check, and sudo ./build/mesos-tests.sh Thanks, Avinash sridharan

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

coding guidelines, should we make the `using` clause more explicit ? - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43323/#review118532 ---------

Re: Review Request 43323: Added unit-test for checking `NetCls` classid in `state.json.

`. Diffs (updated) - src/tests/containerizer/isolator_tests.cpp 84fe4fb61ac032e68d2ab22e85f6b41481c04644 Diff: https://reviews.apache.org/r/43323/diff/ Testing --- make, make check, and sudo ./build/mesos-tests.sh Thanks, Avinash sridharan

Review Request 43483: Added logs for better debugging of allocation of `net_cls` handles.

/43483/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 43483: Added logs for better debugging of allocation of `net_cls` handles.

b22b9f6e9ba77d044c91203b76e0a7237315eb34 src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp 2fc79973524d3776d39d378f22ac694030347c73 Diff: https://reviews.apache.org/r/43483/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029 Diff: https://reviews.apache.org/r/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

ted e-mail. To reply, visit: https://reviews.apache.org/r/42588/#review117641 ------- On Feb. 4, 2016, 5:39 p.m., Avinash sridharan wrote: > > --- > This is an automatically gener

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42947/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

--- make and make check. Thanks, Avinash sridharan

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

://reviews.apache.org/r/42982/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 43258: Modified agent to get container status from containerizer.

1f4c8368feb0ce19963577582ce745acfb21aa9f Diff: https://reviews.apache.org/r/43258/diff/ Testing --- make and make check Thanks, Avinash sridharan

Review Request 43344: Added flag `--cgroups_net_cls_primary_handle`.

the rendering of configuration.md on locally generated docker-site. Thanks, Avinash sridharan

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

84fe4fb61ac032e68d2ab22e85f6b41481c04644 Diff: https://reviews.apache.org/r/42782/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

3f8d07cad363c62e31adc1a756ebc7ff94b76db3 src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp fd674090d4b7f22b98571b693d71493d71b8e05e Diff: https://reviews.apache.org/r/42947/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Review Request 43322: Exposed `ContainerStatus` in `state.json`.

`ContainerStatus` in `state.json`. Diffs - src/common/http.cpp a56c3f1fdc1beec0bf842eba826279e82d4648ec Diff: https://reviews.apache.org/r/43322/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

/containerizer/mesos/containerizer.cpp 1e362d2756690368fde46a3a516c258d9ead2154 Diff: https://reviews.apache.org/r/42983/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42810: Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.

0501dfa27ed610666226953591a902eac4c295f8 Diff: https://reviews.apache.org/r/42810/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

) https://reviews.apache.org/r/39056/ Diffs (updated) - src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2 Diff: https://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash

Review Request 42873: Enhanced the NetClsIsolatorTest filter.

e112270b68d402bb9b01445af552500fb3929e52 Diff: https://reviews.apache.org/r/42873/diff/ Testing --- Thanks, Avinash sridharan

Re: Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

was using (boxcutter/centos66) vagrant image to test this patch. (boxcutter/centos66) is where this test was failing. Thanks, Avinash sridharan

Review Request 42872: Relaxed the subsystem check for net_cls.

03a488e0025da2f0a835cdc39379c901a83b78b0 Diff: https://reviews.apache.org/r/42872/diff/ Testing --- make and make check on Debian 8 Thanks, Avinash sridharan

Review Request 42878: Fixed the NetClsIsolatorTest to correctly learn the net_cls hierarchy.

image to test this patch. (boxcutter/centos66) is where this test was failing. Thanks, Avinash sridharan

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

> On Jan. 19, 2016, 10:37 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 253 > > <https://reviews.apache.org/r/40731/diff/6/?file=1199338#file1199338line253> > > > > Could we check for 0.2 CPU here? > > Avinash sridharan wro

Re: Review Request 40731: Added a fixture to test the floating point precision during CPU resource allocation.

://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

/containerizer/mesos/isolators/cgroups/net_cls.cpp 0798de747627ccc45b01a2668e16693757dc69a8 Diff: https://reviews.apache.org/r/42587/diff/ Testing (updated) --- make Thanks, Avinash sridharan

Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

/ Testing (updated) --- make and make check Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42587/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

ly generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117243 ------- On Feb. 2, 2016, 6:32 p.m., Avinash sridharan wrote: > > --- > This is an auto

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

--- make and make check Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

``` Removed usage(). Will introduce isUsed with the unit-test patch. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117230 ---

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029 Diff: https://reviews.apache.org/r/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

ate patch and make this dependent on the new patch. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117275 -------

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

ed e-mail. To reply, visit: https://reviews.apache.org/r/42618/#review117243 --- On Jan. 31, 2016, 8:06 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

to --cgroup_net_cls_primary_handle and made sure the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Review Request 42982: Defined a virtual `status` method for Containerizer.

Thanks, Avinash sridharan

Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

4b504dbb58823ce7675f1d2048dcc7a27c05663d Diff: https://reviews.apache.org/r/42983/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

://reviews.apache.org/r/42781/diff/ Testing --- Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

: https://reviews.apache.org/r/42782/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42947/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42586/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42587/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42618/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

8d101df957fd36adac388310eddba2db1f98c029 Diff: https://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

, Avinash sridharan

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42586/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_major_handles flag to the slave.

and checking that the slave takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

: https://reviews.apache.org/r/42782/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42947/diff/ Testing (updated) --- make and make check. Thanks, Avinash sridharan

Review Request 42947: Implemented the `status` method in `CgroupNetClsIsolatorProcess`.

/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42947/diff/ Testing --- Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42587/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

ks for catching this. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117171 --- On Jan. 31, 2016, 5

Re: Review Request 42586: Defined the NetClsHandleMgr class.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42586/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42618/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleManager class.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42586/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/#review117588 ------- On Feb. 3, 2016, 6:46 a.m., Avinash sridharan wrote: > > -

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42587/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

/43096/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42618: Modified the `cgroup/net_cls` isolator to use the `NetClsHandleMgr`.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42618/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

24a23325cc255d0d7b7af7ed096b6d3012ad75c7 Diff: https://reviews.apache.org/r/42781/diff/ Testing --- Tested the flag by launching a mesos agent and checking that the slave takes the `--cgroups_net_cls_major_handles` flag. Thanks, Avinash sridharan

Re: Review Request 43107: Passed agent flag --cgroup_net_cls_primary_handle to net_cls isolator.

the slave correctly detects these invalid handles. Launched a slave with valid handle to make sure that the slave launches correctly. Thanks, Avinash sridharan

Re: Review Request 42781: Added the --cgroups_net_cls_primary_handle flag to the slave.

cgroup if that flag is not set? Made the flag optional. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42781/#review117668 --------

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

: https://reviews.apache.org/r/42782/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing --- make and make check Thanks, Avinash sridharan

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

sphere actually > understands it... So looks like you are pushing something no one is actually > going to use. > > Avinash sridharan wrote: > The egress_fq_codel that you are pointing too (I am assuming this is the > jira you are refferring to https://issues.apache.org/jira/browse

Re: Review Request 42810: Added the CgroupInfo protobuf.

applied to a container. Diffs - include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 Diff: https://reviews.apache.org/r/42810/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42832: Added a status method to the Isolator interface.

/42832/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 40731: Added a fixture to test the floating point precision for CPU resource allocation.

://reviews.apache.org/r/40731/diff/ Testing --- Ran make check after adding Mandeep's test case to the GTEST framework. Thanks, Avinash sridharan

Re: Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

://reviews.apache.org/r/42780/diff/ Testing (updated) --- make and make check Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleMgr class.

, structs, global functions, etc.) should be spaced apart by two empty lines." So from that perspective this makes sense. - Avinash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/

Re: Review Request 42586: Defined the NetClsHandleMgr class.

b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42586/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42586: Defined the NetClsHandleManager class.

s://reviews.apache.org/r/42586/diff/6/?file=1227492#file1227492line65> > > > > Why do we need this? > > Avinash sridharan wrote: > Was using this data structure to pass on the usage of handles for a given > major handle. It was useful in unit-testing, but thought

Re: Review Request 42586: Defined the NetClsHandleManager class.

, Avinash sridharan

Re: Review Request 42587: Implemented the `NetClsHandleManager` class.

/mesos/isolators/cgroups/net_cls.hpp b4bc52114389d1c1efce2830f4292bd89bb0de7c src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e Diff: https://reviews.apache.org/r/42587/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 42588: Added unit-test for `NetClsHandleManager`.

/r/42588/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Re: Review Request 43096: Added helper function in cgroup for supporting net_cls subsystem.

mail. To reply, visit: https://reviews.apache.org/r/43096/#review117539 ----------- On Feb. 3, 2016, 7:17 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e

Re: Review Request 42782: Added a unit-test to test net_cls major handles set from command line.

8d101df957fd36adac388310eddba2db1f98c029 Diff: https://reviews.apache.org/r/42782/diff/ Testing --- make and make check. Thanks, Avinash sridharan

Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a Diff: https://reviews.apache.org/r/43915/diff/ Testing --- make and make check Thanks, Avinash sridharan

Review Request 43913: Modified `NetClsHandleManager` to take a range of secondary handles.

--- Modified `NetClsHandleManager` to take a range of secondary handles. Diffs - src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp acd61e615951e18dd51a2ce1e746ba733e9159ae Diff: https://reviews.apache.org/r/43913/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 43913: Modified `NetClsHandleManager` to take a range of secondary handles.

acd61e615951e18dd51a2ce1e746ba733e9159ae Diff: https://reviews.apache.org/r/43913/diff/ Testing --- make Thanks, Avinash sridharan

Re: Review Request 43915: Introduced the `--cgroups_net_cls_secondary_handles` flag in the agent.

f05cd55a9e080f44566ec7dcef22f11950496d6f src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a Diff: https://reviews.apache.org/r/43915/diff/ Testing --- make and make check Thanks, Avinash sridharan

Review Request 43914: Modified the `NetClsHandleManager` methods to work with ranges.

f05cd55a9e080f44566ec7dcef22f11950496d6f Diff: https://reviews.apache.org/r/43914/diff/ Testing --- make and make check. Also ran sudo make check for the "NetClsIsolatoTest" Thanks, Avinash sridharan

Re: Review Request 43914: Modified the `NetClsHandleManager` methods to work with ranges.

for the "NetClsIsolatoTest" Thanks, Avinash sridharan

Review Request 43916: Modified testcase to test `--cgroups_net_cls_secondary_handles` flag.

/ Testing --- make check and sudo make check (for NetClsIsolator) Thanks, Avinash sridharan

<    1   2   3   4   5   6   7   8   9   >